V48 (impl-only): Fix auxillaries data + VCS card tests after GitHub fixes

Safely refresh connection without requiring manager.getConnection; update
regeneration diagnostic copy assertions for the single shared GitHub App.

Author: geraldarthurdavis

uapi/app/api/auxillaries/data/route.ts

@@ -47,9 +47,16 @@ const getAuxillaryData = buildGetAuxillaryDataRoute({
     });
 
     // Prefer post-validation connection row (may include regeneration diagnostics).
-    const refreshedConnection = valid
-      ? (await manager.getConnection(userId, 'github').catch(() => null)) || connection
-      : (await manager.getConnection(userId, 'github').catch(() => null)) || connection;
+    // getConnection is optional on lightweight managers in tests — never throw.
+    let refreshedConnection = connection;
+    try {
+      if (manager && typeof manager.getConnection === 'function') {
+        refreshedConnection =
+          (await manager.getConnection(userId, 'github')) || connection;
+      }
+    } catch {
+      refreshedConnection = connection;
+    }
 
     return {
       repositoryConnectionStatus: buildStoredConnectionStatus(

uapi/tests/vcsConnectionCard.test.tsx

@@ -55,7 +55,10 @@ describe("VCSConnectionCard — regeneration-failure diagnostic (V48-Gate3-F34)"
       screen.getByText(/Failed to generate installation token: 404 Not Found/i),
     ).toBeInTheDocument();
     expect(
-      screen.getByText(/Try Disconnect below, then reconnect/i),
+      screen.getByText(/bitcode-github-auxiliary/i),
+    ).toBeInTheDocument();
+    expect(
+      screen.getByText(/Try Disconnect, then Install GitHub App again/i),
     ).toBeInTheDocument();
   });
 
@@ -76,7 +79,7 @@ describe("VCSConnectionCard — regeneration-failure diagnostic (V48-Gate3-F34)"
       screen.getByText(/GitHub App credentials are not configured/i),
     ).toBeInTheDocument();
     expect(
-      screen.queryByText(/Try Disconnect below, then reconnect/i),
+      screen.queryByText(/Try Disconnect, then Install GitHub App again/i),
     ).not.toBeInTheDocument();
   });