V48 Gate 3: PromptPart/Prompt sanity-check — fix prompts index export mismatch + verify synthesis prompt build-up

geraldarthurdavis · claude · geraldarthurdavis · commit 83b3130d8174 · 2026-06-25T15:07:11.000-07:00
Chunk F (sanity-check all PromptPart + Prompt implementations for instruction correctness given the full registry build-up + formatting correctness):

- prompts/src/index.{ts,d.ts}: the four PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSET_PACK_* re-exports were spelled ASSETPACK (no underscore), naming members that do not exist — a latent TS2724 surfaced whenever a package imports the prompts index. Corrected to the real ASSET_PACK names (the six AssetPack comprehension/clone tools already import them directly under the correct name; no consumer used the wrong spelling).

- asset-packs-synthesis-pipeline.ts: extracted buildSynthesisPromptLayers — the six layered system PromptParts (pipeline identity -&gt; source-safety -&gt; phase lens-role -&gt; agent catalog -&gt; agent rules -&gt; step shape) as a pure, exported, ordered factory the measure step applies via setSpecificExecution.

- New asset-packs-synthesis-pipeline.test.ts proves the registry build-up + hierarchical formatting: every layer registers under a valid ExecutionPrompt path and the real hierarchicalFormatter renders each layer's instruction content into the system prompt, lens-correctly (deposit demand-alignment vs read need-fit). 3/3 green.

Co-Authored-By: Claude Fable 5 &lt;noreply@anthropic.com&gt;
diff --git a/packages/pipelines/asset-pack/src/__tests__/asset-packs-synthesis-pipeline.test.ts b/packages/pipelines/asset-pack/src/__tests__/asset-packs-synthesis-pipeline.test.ts
@@ -0,0 +1,80 @@
+import { ExecutionPrompt } from '@bitcode/execution-generics/prompts/ExecutionPrompt';
+import { hierarchicalFormatter } from '@bitcode/prompts/formatters';
+import type { PromptPart } from '@bitcode/prompts/parts/PromptPart';
+
+import { buildSynthesisPromptLayers } from '../asset-packs-synthesis-pipeline';
+import { measurementCatalogForLens, type AssetPacksSynthesisLens } from '../asset-packs-synthesis';
+
+// Satisfy the ExecutionPrompt root requirements exactly as AgentExecution does
+// at runtime (generic_system + specific_execution set to a blank PromptPart).
+const BLANK = ' ' as PromptPart;
+
+/**
+ * Gate 3 chunk F — sanity-check that the synthesis PromptParts compose
+ * correctly through the real registry build-up: each layer registers under a
+ * valid ExecutionPrompt path and the hierarchical formatter renders every
+ * layer's instruction content into the system prompt, lens-correctly.
+ */
+describe('AssetPacksSynthesis formal prompt build-up (Gate 3 chunk F)', () => {
+  function render(lens: AssetPacksSynthesisLens): string {
+    const prompt = new ExecutionPrompt();
+    prompt.set('generic_system', BLANK);
+    prompt.set('specific_execution', BLANK);
+    const catalog = measurementCatalogForLens(lens);
+    for (const { path, part } of buildSynthesisPromptLayers(
+      lens,
+      catalog,
+      ['capability-slice', 'implementation-pattern'],
+      4,
+    )) {
+      prompt.setSpecificExecution(path, part);
+    }
+    return prompt.format(hierarchicalFormatter);
+  }
+
+  it('registers six hierarchical layers under valid execution-prompt paths', () => {
+    const layers = buildSynthesisPromptLayers(
+      'deposit',
+      measurementCatalogForLens('deposit'),
+      ['capability-slice'],
+      4,
+    );
+    expect(layers.map((layer) => layer.path)).toEqual([
+      'pipeline:asset-packs-synthesis:identity',
+      'pipeline:asset-packs-synthesis:source-safety',
+      'phase:deposit:role',
+      'agent:measure:catalog',
+      'agent:measure:rules',
+      'step:candidate:shape',
+    ]);
+    // Every part is non-empty and accepted by the ExecutionPrompt path hierarchy.
+    const prompt = new ExecutionPrompt();
+    for (const { path, part } of layers) {
+      expect(part.trim().length).toBeGreaterThan(0);
+      expect(() => prompt.setSpecificExecution(path, part)).not.toThrow();
+    }
+  });
+
+  it('composes every deposit layer into the formatted system prompt', () => {
+    const rendered = render('deposit');
+    expect(rendered).toContain('single Bitcode synthesis and measurement pipeline'); // identity
+    expect(rendered).toContain('Source-safety law'); // source-safety
+    expect(rendered).toContain('Lens: deposit'); // phase lens-role
+    expect(rendered).toContain('source-coverage'); // agent catalog
+    expect(rendered).toContain('demand-alignment');
+    expect(rendered).toContain('DISTINCT candidates'); // agent rules
+    expect(rendered).toContain('"options"'); // step candidate-shape contract
+    expect(rendered).toContain('capability-slice'); // allowed kinds threaded into rules
+  });
+
+  it('carries the lens through the phase role and measurement catalog', () => {
+    const deposit = render('deposit');
+    const read = render('read');
+    expect(deposit).toContain('Lens: deposit');
+    expect(read).toContain('Lens: read');
+    // Read catalog adds the Need-relative measurement; deposit uses demand-alignment.
+    expect(read).toContain('need-fit');
+    expect(deposit).not.toContain('need-fit');
+    expect(deposit).toContain('demand-alignment');
+  });
+});
diff --git a/packages/pipelines/asset-pack/src/asset-packs-synthesis-pipeline.ts b/packages/pipelines/asset-pack/src/asset-packs-synthesis-pipeline.ts
@@ -103,6 +103,37 @@ function buildShapePart(catalog: AssetPackMeasurementSpec[], maxCandidates: numb
   );
 }
 
+export interface SynthesisPromptLayer {
+  /** setSpecificExecution path under the agent's ExecutionPrompt. */
+  path: string;
+  part: PromptPart;
+}
+
+/**
+ * The layered synthesis system prompt, in hierarchical order:
+ *   pipeline identity → pipeline source-safety → phase lens-role →
+ *   agent measurement-catalog → agent rules → step candidate-shape.
+ * Registered on the AgentExecution.prompt via setSpecificExecution and composed
+ * upwards by buildHierarchicalPrompt / hierarchicalFormatter. Pure + exported so
+ * the registry build-up and formatting correctness are unit-tested (Gate 3
+ * chunk F: PromptPart/Prompt sanity-check).
+ */
+export function buildSynthesisPromptLayers(
+  lens: AssetPacksSynthesisLens,
+  catalog: AssetPackMeasurementSpec[],
+  candidateKinds: string[],
+  maxCandidates: number,
+): SynthesisPromptLayer[] {
+  return [
+    { path: 'pipeline:asset-packs-synthesis:identity', part: PIPELINE_IDENTITY },
+    { path: 'pipeline:asset-packs-synthesis:source-safety', part: PIPELINE_SOURCE_SAFETY },
+    { path: `phase:${lens}:role`, part: LENS_ROLE[lens] },
+    { path: 'agent:measure:catalog', part: buildCatalogPart(catalog) },
+    { path: 'agent:measure:rules', part: buildRulesPart(candidateKinds, maxCandidates) },
+    { path: 'step:candidate:shape', part: buildShapePart(catalog, maxCandidates) },
+  ];
+}
+
 // ---- Formal source-inventory Tool ------------------------------------------
 
 type InventoryToolArgs = {
@@ -228,19 +259,19 @@ export async function synthesizeAssetPackCandidatesFormal(
       }
     } catch {}
 
-    // Layered system prompt parts on the AgentExecution.prompt (compose upwards).
+    // Layered system prompt parts on the AgentExecution.prompt — composed
+    // upwards by buildHierarchicalPrompt. Built by the pure, tested factory.
     try {
       const p = (agentExec as any).prompt;
       if (p?.setSpecificExecution) {
-        p.setSpecificExecution('pipeline:asset-packs-synthesis:identity', PIPELINE_IDENTITY);
-        p.setSpecificExecution('pipeline:asset-packs-synthesis:source-safety', PIPELINE_SOURCE_SAFETY);
-        p.setSpecificExecution(`phase:${request.lens}:role`, LENS_ROLE[request.lens]);
-        p.setSpecificExecution('agent:measure:catalog', buildCatalogPart(catalog));
-        p.setSpecificExecution(
-          'agent:measure:rules',
-          buildRulesPart(request.candidateKinds, request.maxCandidates),
-        );
-        p.setSpecificExecution('step:candidate:shape', buildShapePart(catalog, request.maxCandidates));
+        for (const layer of buildSynthesisPromptLayers(
+          request.lens,
+          catalog,
+          request.candidateKinds,
+          request.maxCandidates,
+        )) {
+          p.setSpecificExecution(layer.path, layer.part);
+        }
       }
     } catch {}
 
diff --git a/packages/prompts/src/index.d.ts b/packages/prompts/src/index.d.ts
@@ -88,10 +88,10 @@ export { PROMPTPART_SPECIFIC_AGENT_APPLYFILE_REFINE_OPTIMIZATION } from './raw_p
 export { PROMPTPART_SPECIFIC_AGENT_APPLYFILE_REFINE_ASSESSMENT } from './raw_promptparts/specific/promptpart_specific_agent_applyfile_refine_assessment';
 export { PROMPTPART_SPECIFIC_AGENT_APPLYFILE_RETRY_STRATEGY } from './raw_promptparts/specific/promptpart_specific_agent_applyfile_retry_strategy';
 export { PROMPTPART_SPECIFIC_AGENT_APPLYFILE_RETRY_ERRORHANDLING } from './raw_promptparts/specific/promptpart_specific_agent_applyfile_retry_errorhandling';
-export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSETPACK_METADATA_PIPELINE } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_metadata_pipeline';
-export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSETPACK_METADATA_PHASE_SETUP } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_metadata_phase_setup';
-export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSETPACK_PURPOSE_ADDENDUM } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_purpose_addendum';
-export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSETPACK_CAPABILITIES_ADDENDUM } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_capabilities_addendum';
+export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSET_PACK_METADATA_PIPELINE } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_metadata_pipeline';
+export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSET_PACK_METADATA_PHASE_SETUP } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_metadata_phase_setup';
+export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSET_PACK_PURPOSE_ADDENDUM } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_purpose_addendum';
+export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSET_PACK_CAPABILITIES_ADDENDUM } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_capabilities_addendum';
 export { PROMPTPART_SPECIFIC_AGENT_ASSETPACKPIPELINE_CLONEVCSREPOSITORY_SYSTEM_IDENTITY } from './raw_promptparts/specific/promptpart_specific_agent_assetpackpipeline_clonevcsrepository_system_identity';
 export { PROMPTPART_SPECIFIC_AGENT_ASSETPACKPIPELINE_CLONEVCSREPOSITORY_SYSTEM_PURPOSE } from './raw_promptparts/specific/promptpart_specific_agent_assetpackpipeline_clonevcsrepository_system_purpose';
 export { PROMPTPART_SPECIFIC_AGENT_ASSETPACKPIPELINE_CLONEVCSREPOSITORY_SYSTEM_CONSTRAINTS } from './raw_promptparts/specific/promptpart_specific_agent_assetpackpipeline_clonevcsrepository_system_constraints';
diff --git a/packages/prompts/src/index.ts b/packages/prompts/src/index.ts
@@ -147,10 +147,10 @@ export { PROMPTPART_SPECIFIC_AGENT_APPLYFILE_RETRY_STRATEGY } from './raw_prompt
 export { PROMPTPART_SPECIFIC_AGENT_APPLYFILE_RETRY_ERRORHANDLING } from './raw_promptparts/specific/promptpart_specific_agent_applyfile_retry_errorhandling';
 
 // AssetPack Tool PromptParts (Repository Setup additions)
-export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSETPACK_METADATA_PIPELINE } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_metadata_pipeline';
-export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSETPACK_METADATA_PHASE_SETUP } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_metadata_phase_setup';
-export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSETPACK_PURPOSE_ADDENDUM } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_purpose_addendum';
-export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSETPACK_CAPABILITIES_ADDENDUM } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_capabilities_addendum';
+export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSET_PACK_METADATA_PIPELINE } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_metadata_pipeline';
+export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSET_PACK_METADATA_PHASE_SETUP } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_metadata_phase_setup';
+export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSET_PACK_PURPOSE_ADDENDUM } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_purpose_addendum';
+export { PROMPTPART_SPECIFIC_TOOL_REPOSITORYSETUP_ASSET_PACK_CAPABILITIES_ADDENDUM } from './raw_promptparts/specific/promptpart_specific_tool_repositorysetup_assetpack_capabilities_addendum';
 
 // AssetPack Agent PromptParts (Clone VCS Repository)
 export { PROMPTPART_SPECIFIC_AGENT_ASSETPACKPIPELINE_CLONEVCSREPOSITORY_SYSTEM_IDENTITY } from './raw_promptparts/specific/promptpart_specific_agent_assetpackpipeline_clonevcsrepository_system_identity';
