wip v28

Author: geraldarthurdavis

BITCODE_V28_QA.md

@@ -829,6 +829,10 @@ Deposit path:
 13. In Network, capture the `/api/executions/history` request and response. Expected status is `201`.
 14. Run `v28_qa_terminal_02_activity_after_write` and confirm an `executions_recent` row with `type='agentic-execution:asset-pack'`, `context_summary.source='terminal-deposit-read-workbench'`, `context_summary.workbench='deposit'`, and a non-empty `output_summary.deposit`.
 15. Rerun `v28_qa_terminal_04_deposit_repository_alignment`; recent Deposit activity must reference the connected repository and must not reference `frontier/*`.
+16. Before `Submit deposit to Bitcode`, run `v28_qa_terminal_05_wallet_signer_gate`. For the current Leather staging path, `terminal_deposit_signer_gate_state` should be `wallet_signer_pending_signed_proof_accepted_for_v28_staging` or `wallet_signer_verified`.
+17. Click `Submit deposit to Bitcode`. The browser wallet should open a Bitcoin message-signing prompt for a `Bitcode deposit authorization` message before the API request is sent.
+18. Approve the signature. The request body must include a wallet authorization proof, and the UI should report a successful deposit submission rather than the staged-settlement error.
+19. If `/api/deposits` returns `Bitcode can draft transaction-bearing activity...`, rerun query 05 and paste the row with the Network response; this is a V28 signer-gate blocker.
 
 Read path:
 

packages/protocol/src/bitcode-demo.js

@@ -2189,6 +2189,29 @@ function buildAddressingSurface(input, selectedInventoryEntries = [], extracted
   };
 }
 
+/**
+ * @param {unknown} value
+ * @returns {null | Record<string, unknown>}
+ */
+function normalizeWalletAuthorizationProof(value) {
+  if (!value || typeof value !== 'object' || Array.isArray(value)) return null;
+  const record = /** @type {Record<string, unknown>} */ (value);
+  const signature = typeof record.signature === 'string' && record.signature.trim() ? record.signature.trim() : null;
+  const message = typeof record.message === 'string' && record.message.trim() ? record.message.trim() : null;
+  if (!signature || !message) return null;
+  return {
+    kind: typeof record.kind === 'string' ? record.kind : 'bitcode_deposit_authorization',
+    proofKind: typeof record.proofKind === 'string' ? record.proofKind : 'bitcoin_message_signature',
+    provider: typeof record.provider === 'string' ? record.provider : null,
+    providerLabel: typeof record.providerLabel === 'string' ? record.providerLabel : null,
+    signerAddress: typeof record.signerAddress === 'string' ? record.signerAddress : null,
+    signedAt: typeof record.signedAt === 'string' ? record.signedAt : null,
+    messageHash: stableHashObject(message),
+    signatureHash: stableHashObject(signature),
+    signatureCaptured: true
+  };
+}
+
 /**
  * @param {any} input
  * @param {any} assetId
@@ -2199,6 +2222,7 @@ function buildAddressingSurface(input, selectedInventoryEntries = [], extracted
  * @returns {any}
  */
 function buildSigningSurface(input, assetId, contentRoot, addressingSurface, artifactSelectionSurface, githubAppAuthSurface) {
+  const walletAuthorizationProof = normalizeWalletAuthorizationProof(input.walletAuthorizationProof);
   const signerAddress = input.signerAddress || input.authSession?.defaultSignerAddress || `did:key:${toSlug(input.author)}`;
   const signingAlgorithm = input.signingAlgorithm || input.authSession?.signingAlgorithm || 'ed25519';
   const keySource = input.keySource || input.authSession?.keySource || 'manual-upload-key';
@@ -2220,9 +2244,15 @@ function buildSigningSurface(input, assetId, contentRoot, addressingSurface, art
     keySource,
     statementKind: signedStatement.statementKind,
     payloadHash: stableHashObject(signedStatement),
-    signatureChecksPass: input.signatureChecksPass !== false,
+    signatureChecksPass: input.signatureChecksPass !== false && (!walletAuthorizationProof || walletAuthorizationProof.signatureCaptured === true),
     signedPayloadHashMatchesContentRoot: input.signedPayloadHashMatchesContentRoot !== false,
-    attestationHash: stableHashObject({ signerAddress, signingAlgorithm, payloadHash: stableHashObject(signedStatement) }),
+    attestationHash: stableHashObject({
+      signerAddress,
+      signingAlgorithm,
+      payloadHash: stableHashObject(signedStatement),
+      walletAuthorizationProof
+    }),
+    walletAuthorizationProof,
     signedAddressingRoot: addressingSurface.addressingRoot,
     signedSelectionRoot: artifactSelectionSurface.selectedInventoryRoot,
     signedGitHubAppAuthRoot: githubAppAuthSurface.authPayloadHash

supabase/queries/v28_qa_terminal_05_wallet_signer_gate.sql

@@ -0,0 +1,94 @@
+-- Saved query name: v28_qa_terminal_05_wallet_signer_gate
+-- Purpose: run before "Submit deposit to Bitcode" when the Terminal Deposit
+-- button reports wallet signing/settlement readiness. V28 staging accepts a
+-- provider-backed pending Bitcoin message signature as live signer readiness,
+-- while unsigned provider-session posture remains blocked.
+
+WITH recent_wallet_users AS (
+  SELECT
+    u.id AS user_id,
+    u.email,
+    u.raw_app_meta_data ->> 'provider' AS auth_provider,
+    u.raw_user_meta_data ->> 'sub' AS bitcoin_subject,
+    u.created_at AS auth_created_at,
+    u.last_sign_in_at
+  FROM auth.users u
+  WHERE
+    u.raw_app_meta_data ->> 'provider' = 'custom:bitcode-bitcoin'
+    OR u.raw_user_meta_data ->> 'sub' LIKE 'bitcoin:%'
+  ORDER BY u.created_at DESC
+  LIMIT 10
+),
+profile_wallets AS (
+  SELECT
+    p.id AS user_id,
+    p.settings #>> '{bitcodeProfile,walletBinding,provider}' AS profile_wallet_provider,
+    p.settings #>> '{bitcodeProfile,walletBinding,status}' AS profile_wallet_status,
+    p.settings #>> '{bitcodeProfile,walletBinding,network}' AS profile_wallet_network,
+    p.settings #>> '{bitcodeProfile,walletBinding,address}' AS profile_wallet_address,
+    p.settings #>> '{bitcodeProfile,walletBinding,authAddress}' AS profile_auth_address,
+    p.settings #>> '{bitcodeProfile,walletBinding,paymentAddress}' AS profile_payment_address,
+    p.updated_at AS profile_updated_at
+  FROM public.user_profiles p
+),
+wallet_connections AS (
+  SELECT DISTINCT ON (c.user_id)
+    c.user_id,
+    c.provider,
+    c.is_active,
+    coalesce(c.connection_data ->> 'verification_state', c.connection_data ->> 'status') AS verification_state,
+    coalesce(c.connection_data ->> 'proof_kind', c.connection_data ->> 'proofKind') AS proof_kind,
+    coalesce(c.connection_data ->> 'address', c.connection_data ->> 'wallet_address') AS connection_address,
+    c.connection_data ->> 'network' AS connection_network,
+    coalesce(c.connection_data ->> 'authAddress', c.connection_data ->> 'auth_address') AS connection_auth_address,
+    coalesce(c.connection_data ->> 'paymentAddress', c.connection_data ->> 'payment_address') AS connection_payment_address,
+    coalesce(c.connection_data ->> 'addressType', c.connection_data ->> 'address_type') AS address_type,
+    nullif(trim(coalesce(c.connection_data ->> 'message', '')), '') IS NOT NULL AS has_wallet_message,
+    nullif(trim(coalesce(c.connection_data ->> 'signature', '')), '') IS NOT NULL AS has_wallet_signature,
+    c.updated_at AS wallet_connection_updated_at
+  FROM public.user_connections c
+  WHERE c.provider IN ('bitcoin-wallet', 'unisat', 'leather', 'okx-bitcoin', 'xverse', 'manual-bitcoin')
+  ORDER BY c.user_id, c.is_active DESC, c.updated_at DESC NULLS LAST
+)
+SELECT
+  u.user_id,
+  u.email,
+  u.auth_provider,
+  u.bitcoin_subject,
+  w.provider AS wallet_provider,
+  w.is_active AS wallet_active,
+  w.verification_state,
+  w.proof_kind,
+  w.connection_network,
+  w.connection_address,
+  w.connection_auth_address,
+  w.connection_payment_address,
+  w.address_type,
+  w.has_wallet_message,
+  w.has_wallet_signature,
+  p.profile_wallet_status,
+  p.profile_wallet_network,
+  p.profile_wallet_address,
+  p.profile_auth_address,
+  p.profile_payment_address,
+  CASE
+    WHEN w.user_id IS NULL THEN 'blocker:missing_wallet_connection'
+    WHEN w.is_active IS DISTINCT FROM true THEN 'blocker:wallet_connection_inactive'
+    WHEN w.verification_state = 'verified' THEN 'wallet_signer_verified'
+    WHEN w.verification_state = 'pending'
+      AND w.proof_kind = 'bitcoin_message_signature'
+      AND w.has_wallet_message
+      AND w.has_wallet_signature
+      THEN 'wallet_signer_pending_signed_proof_accepted_for_v28_staging'
+    WHEN w.verification_state = 'pending'
+      THEN 'blocker:wallet_pending_without_signed_bitcoin_message_proof'
+    ELSE 'blocker:wallet_connection_not_settlement_ready'
+  END AS terminal_deposit_signer_gate_state,
+  u.auth_created_at,
+  u.last_sign_in_at,
+  p.profile_updated_at,
+  w.wallet_connection_updated_at
+FROM recent_wallet_users u
+LEFT JOIN profile_wallets p ON p.user_id = u.user_id
+LEFT JOIN wallet_connections w ON w.user_id = u.user_id
+ORDER BY u.auth_created_at DESC;

uapi/app/api/wallet/_shared.ts

@@ -16,6 +16,11 @@ export type BitcodeWalletConnectionStatus = {
     connectionAddress?: string | null;
     matchesBindingAddress?: boolean;
     connectedAt?: string | null;
+    network?: string | null;
+    proofKind?: string | null;
+    paymentAddress?: string | null;
+    authAddress?: string | null;
+    addressType?: string | null;
     mock_mode?: boolean;
   } | null;
 };
@@ -59,6 +64,23 @@ function readConnectionAddress(connectionData: UnknownRecord | null): string | n
   );
 }
 
+function readConnectionProofKind(connectionData: UnknownRecord | null): string | null {
+  return (
+    normalizeString(connectionData?.proof_kind) ||
+    normalizeString(connectionData?.proofKind) ||
+    normalizeString(connectionData?.wallet_proof_kind) ||
+    null
+  );
+}
+
+function hasSignedBitcoinWalletProof(connectionData: UnknownRecord | null): boolean {
+  return Boolean(
+    readConnectionProofKind(connectionData) === 'bitcoin_message_signature' &&
+      normalizeString(connectionData?.message) &&
+      normalizeString(connectionData?.signature),
+  );
+}
+
 function readConnectionVerificationState(
   connectionData: UnknownRecord | null,
 ): BitcodeWalletConnectionVerificationState {
@@ -130,21 +152,34 @@ export async function readBitcodeWalletConnectionStatus(input: {
 
   const connectionData = asRecord(data?.connection_data);
   const connectionAddress = readConnectionAddress(connectionData);
+  const proofKind = readConnectionProofKind(connectionData);
   const liveVerificationState = readConnectionVerificationState(connectionData);
   const matchesBindingAddress =
     !connectionAddress || !walletBinding.address ? true : connectionAddress === walletBinding.address;
+  const hasLiveSignedProviderProof =
+    liveVerificationState === 'pending' && hasSignedBitcoinWalletProof(connectionData);
+  const valid = Boolean(
+    data &&
+      matchesBindingAddress &&
+      (liveVerificationState === 'verified' || hasLiveSignedProviderProof),
+  );
 
   return {
     connected: Boolean(data),
     provider,
-    valid: Boolean(data && liveVerificationState === 'verified' && matchesBindingAddress),
+    valid,
     address: walletBinding.address,
     verificationState: liveVerificationState ?? verificationState,
     metadata: {
       source: 'wallet_provider_connection',
       connectionAddress,
       matchesBindingAddress,
       connectedAt: normalizeString(data?.updated_at),
+      network: normalizeString(connectionData?.network),
+      proofKind,
+      paymentAddress: normalizeString(connectionData?.payment_address) ?? normalizeString(connectionData?.paymentAddress),
+      authAddress: normalizeString(connectionData?.auth_address) ?? normalizeString(connectionData?.authAddress),
+      addressType: normalizeString(connectionData?.address_type) ?? normalizeString(connectionData?.addressType),
     },
   };
 }