V48 (implementation-only): Drop deposit agent roster synonym aliases

Register exactly one key per deposit SDIVF agent (parity roster): Discovery
comprehend-codebase / search-depository / inherent-regurgitation only; Setup
clone without the asset-pack-clone dual key; Validation only ready-to-finish.
Remove tools map and tests that pinned synonym aliases.

Author: geraldarthurdavis

packages/asset-packs-pipelines/domain/src/__tests__/deposit-setup-discovery-agents.test.ts

@@ -332,13 +332,11 @@ describe('discovery conditional runtime registry roster', () => {
     };
   }
 
-  it('deposit mode registers the three Discovery agents (native keys + stable aliases), not the read roster', () => {
+  it('deposit mode registers exactly three Discovery agents (no synonym aliases), not the read roster', () => {
     const registry = recordingRegistry();
     registerDiscoveryAgents(registry, 'deposit');
     expect([...registry.registrations.keys()].sort()).toEqual([
-      'discovery:codebase-comprehension',
       'discovery:comprehend-codebase',
-      'discovery:depository-search',
       'discovery:inherent-regurgitation',
       'discovery:search-depository',
     ]);

packages/asset-packs-pipelines/domain/src/__tests__/validation-agents.test.ts

@@ -6,7 +6,6 @@ jest.mock('@bitcode/generic-llms', () => require('./support/generic-llms-mock').
 
 import { Execution } from '@bitcode/execution-generics';
 import { AssetPackValidationReadyToFinishAgent } from '../agents/validation-agents';
-import runDepositValidationAgent from '../agents/validation/deposit-validation-agent';
 import { registerValidationAgentsForType } from '../phases/validation';
 import { setBoundaryLLMOutput, resetBoundaryLLMOutput } from './support/generic-llms-mock';
 
@@ -85,30 +84,26 @@ describe('registerValidationAgentsForType (mode-conditional Validation registry)
     };
   }
 
-  it('deposit mode registers the deposit-quality validator plus the envelope-unwrapping ReadyToFinish gate', async () => {
+  it('deposit mode registers exactly one ready-to-finish Validation agent (no quality alias)', async () => {
     const { registrations, registry } = captureRegistry();
 
     registerValidationAgentsForType('read-satisfaction-asset-pack', registry, 'deposit');
 
     expect([...registrations.keys()].sort()).toEqual([
-      'validation:asset-pack-ready-to-finish-agent',
-      'validation:deposit-quality',
+      'validation:ready-to-finish-asset-packs-synthesis-deposit-pipeline',
     ]);
 
-    // The gate is the wrapper that unwraps the PTRR envelope (validation-agents.ts),
-    // NOT the orphaned readyToFinishWithShortCircuit module that reads typed fields
-    // straight off the envelope.
-    expect(registrations.get('validation:asset-pack-ready-to-finish-agent')).toBe(
-      AssetPackValidationReadyToFinishAgent,
+    const loader = registrations.get(
+      'validation:ready-to-finish-asset-packs-synthesis-deposit-pipeline',
     );
-
-    // The deposit-quality key lazily resolves to the deposit validation runner.
-    const loader = registrations.get('validation:deposit-quality');
     const resolved = await loader();
-    expect(resolved).toBe(runDepositValidationAgent);
+    const readyToFinish = (
+      await import('../agents/validation/deposit-ready-to-finish-agent')
+    ).default;
+    expect(resolved).toBe(readyToFinish);
   });
 
-  it('read mode (no deposit) registers the canonical validator roster and no deposit-quality agent', () => {
+  it('read mode (no deposit) registers the canonical validator roster and no deposit Validation keys', () => {
     const { registrations, registry } = captureRegistry();
 
     registerValidationAgentsForType('read-satisfaction-asset-pack', registry);
@@ -120,6 +115,9 @@ describe('registerValidationAgentsForType (mode-conditional Validation registry)
       'validation:validate-last-iterations-validation-phase',
     ]);
     expect(registrations.has('validation:deposit-quality')).toBe(false);
+    expect(
+      registrations.has('validation:ready-to-finish-asset-packs-synthesis-deposit-pipeline'),
+    ).toBe(false);
     expect(registrations.get('validation:asset-pack-ready-to-finish-agent')).toBe(
       AssetPackValidationReadyToFinishAgent,
     );

packages/asset-packs-pipelines/domain/src/phases/deposit-phases.ts

@@ -18,16 +18,12 @@ type ImplementationOutput = AssetPackOutput;
 type ValidationOutput = AssetPackOutput;
 
 function registerDepositSetupAgents(agentRegistry: any): void {
+  // One roster key per Setup agent (matches depositSetupPhase executors).
   agentRegistry.registerAgent(
     'setup:clone-vcs-repository',
     () =>
       import('../agents/setup/asset-pack-clone-vcs-repository-agent').then((m) => m.default),
   );
-  agentRegistry.registerAgent(
-    'setup:asset-pack-clone-vcs-repository-agent',
-    () =>
-      import('../agents/setup/asset-pack-clone-vcs-repository-agent').then((m) => m.default),
-  );
   agentRegistry.registerAgent(
     'setup:initialize-lsp',
     () => import('../agents/setup/asset-pack-initialize-lsp-agent').then((m) => m.default),
@@ -114,22 +110,12 @@ export const depositValidationPhase: PhaseDelegator<
   ValidationOutput
 > = (async (input: any, execution: any) => {
   try {
+    // One Validation key only — no deposit-quality / read ready-to-finish aliases.
     (execution as any).agents?.registerAgent?.(
       'validation:ready-to-finish-asset-packs-synthesis-deposit-pipeline',
       () =>
         import('../agents/validation/deposit-ready-to-finish-agent').then((m) => m.default),
     );
-    // Compat alias for older roster tests
-    (execution as any).agents?.registerAgent?.(
-      'validation:deposit-quality',
-      () =>
-        import('../agents/validation/deposit-ready-to-finish-agent').then((m) => m.default),
-    );
-    (execution as any).agents?.registerAgent?.(
-      'validation:asset-pack-ready-to-finish-agent',
-      () =>
-        import('../agents/validation/deposit-ready-to-finish-agent').then((m) => m.default),
-    );
   } catch {}
   return await createAgentExecutor(
     'validation:ready-to-finish-asset-packs-synthesis-deposit-pipeline',

packages/asset-packs-pipelines/domain/src/phases/discovery.ts

@@ -46,18 +46,17 @@ export function registerDiscoveryAgents(
   mode?: SynthesizeAssetPacksMode,
 ): void {
   if (mode === 'deposit') {
-    // Deposit-native keys + stable aliases (no lens vocabulary).
-    const codebase = () =>
-      import('../agents/discovery/deposit-codebase-comprehension-agent').then((m) => m.default);
-    const depository = () =>
-      import('../agents/discovery/deposit-depository-search-agent').then((m) => m.default);
-    const regurgitation = () =>
-      import('../agents/discovery/deposit-inherent-regurgitation-agent').then((m) => m.default);
-    agentRegistry.registerAgent('discovery:codebase-comprehension', codebase);
-    agentRegistry.registerAgent('discovery:comprehend-codebase', codebase);
-    agentRegistry.registerAgent('discovery:depository-search', depository);
-    agentRegistry.registerAgent('discovery:search-depository', depository);
-    agentRegistry.registerAgent('discovery:inherent-regurgitation', regurgitation);
+    // Exactly three deposit Discovery keys (parity matrix / depositDiscoveryPhase).
+    // No synonym aliases — one roster key per agent.
+    agentRegistry.registerAgent('discovery:comprehend-codebase', () =>
+      import('../agents/discovery/deposit-codebase-comprehension-agent').then((m) => m.default),
+    );
+    agentRegistry.registerAgent('discovery:search-depository', () =>
+      import('../agents/discovery/deposit-depository-search-agent').then((m) => m.default),
+    );
+    agentRegistry.registerAgent('discovery:inherent-regurgitation', () =>
+      import('../agents/discovery/deposit-inherent-regurgitation-agent').then((m) => m.default),
+    );
     return;
   }
   registerCanonicalDiscoveryAgents(agentRegistry);

packages/asset-packs-pipelines/domain/src/phases/validation.ts

@@ -1,16 +1,12 @@
 import { createPhaseRunner, PhaseConfig } from '@bitcode/pipelines-generics';
-import {
-  registerValidationAgentsForType as registerAgents,
-  AssetPackValidationReadyToFinishAgent,
-} from '../agents/validation-agents';
+import { registerValidationAgentsForType as registerAgents } from '../agents/validation-agents';
 import { AssetPackWrittenAssetType } from '../types/AssetPackWrittenAssetType';
 import type { SynthesizeAssetPacksMode } from '../synthesize-asset-packs';
 
 /**
- * Validation phase configuration placeholder.
- * The actual execution composition for validation lives in phases/index.ts
- * where three validators run in parallel followed by the AssetPack
- * ReadyToFinish agent that gates the canonical Finish phase.
+ * Validation phase configuration placeholder (read-path phase runner).
+ * Deposit Validation is registered/executed only via deposit-phases
+ * (`validation:ready-to-finish-asset-packs-synthesis-deposit-pipeline`).
  */
 const validationPhaseConfig: PhaseConfig = {
   phaseName: 'validation',
@@ -33,14 +29,12 @@ export function registerValidationAgentsForType(
   mode?: SynthesizeAssetPacksMode,
 ): void {
   if (mode === 'deposit') {
-    // Deposit lens: a single quality validator over the synthesized AssetPacks,
-    // then the canonical ReadyToFinish gate (it reads validation/implementation:issues).
-    agentRegistry.registerAgent('validation:deposit-quality', () =>
-      import('../agents/validation/deposit-validation-agent').then(m => m.default),
-    );
+    // Deposit Validation is a single ready-to-finish gate (A/B/C). Prefer the
+    // deposit-phases roster key; this path stays for mode-conditional callers.
     agentRegistry.registerAgent(
-      'validation:asset-pack-ready-to-finish-agent',
-      AssetPackValidationReadyToFinishAgent,
+      'validation:ready-to-finish-asset-packs-synthesis-deposit-pipeline',
+      () =>
+        import('../agents/validation/deposit-ready-to-finish-agent').then((m) => m.default),
     );
     return;
   }

packages/asset-packs-pipelines/domain/src/tools/index.ts

@@ -172,6 +172,7 @@ export function getAssetPackPipelineToolsForAgent(agentName: string): Tool[] {
     'asset-pack-plan-implementation-agent': [lexicalDepositorySearchTool],
     'asset-pack-digest-codebase-agent': [],
     'asset-pack-research-web-agent': [],
+    // Deposit Discovery roster keys (one entry each; factory names only if tools resolve by agent class).
     'DepositCodebaseComprehensionAgent': optionalTools(
       lspSemanticAnalysisEngine,
       lspCodeIntelligenceEngine,
@@ -182,20 +183,16 @@ export function getAssetPackPipelineToolsForAgent(agentName: string): Tool[] {
       lspCodeIntelligenceEngine,
       lspWorkspaceNavigationEngine,
     ),
-    'discovery:codebase-comprehension': optionalTools(
-      lspSemanticAnalysisEngine,
-      lspCodeIntelligenceEngine,
-      lspWorkspaceNavigationEngine,
-    ),
     'DepositDepositorySearchAgent': [depositDepositoryAssetPackSearchTool, lexicalDepositorySearchTool],
     'discovery:search-depository': [depositDepositoryAssetPackSearchTool, lexicalDepositorySearchTool],
-    'discovery:depository-search': [depositDepositoryAssetPackSearchTool, lexicalDepositorySearchTool],
+    'discovery:inherent-regurgitation': [],
+    'DepositInherentRegurgitationAgent': [],
 
-    // Implementation Phase
+    // Implementation Phase (roster key + factory name when tools bind by either)
     'ReadFitsFindingSynthesisAssetPackSynthesisAgent': [],
     'implementation:ReadFitsFindingSynthesisAssetPackSynthesisAgent': [],
     'implementation:deposit-asset-pack-synthesis': [],
-    'deposit-asset-pack-synthesis': [],
+    'DepositAssetPackSynthesisAgent': [],
 
     // Validation Phase
     'asset-pack-validate-last-iterations-validation-phase-agent': optionalTools(lspSemanticAnalysisEngine),
@@ -204,7 +201,7 @@ export function getAssetPackPipelineToolsForAgent(agentName: string): Tool[] {
     'asset-pack-validation-ready-to-finish-agent': [],
     'asset-pack-ready-to-finish-agent': [],
     'validation:ready-to-finish-asset-packs-synthesis-deposit-pipeline': [],
-    'validation:deposit-quality': [],
+    'validation:asset-pack-ready-to-finish-agent': [],
 
     // Internal Read-measurement computer-use option
     'read-measurement:computer-use-evidence-agent': getComputerUseReadMeasurementTools(),