V30 Gate 5: Stabilize journal reconciliation cards

Allow Terminal reconciliation cards to render historical or partial journal snapshots that predate object-storage fact projection while preserving the new object-storage section for current reports.

Proof: pnpm --dir uapi exec jest --runTestsByPath tests/api/readReviewRoute.test.ts tests/api/pipelineHarnessRoute.test.ts tests/terminalPipelineHarnessClient.test.ts tests/terminalDepositReadWorkbench.test.ts tests/terminalTransactionQuery.test.ts tests/terminalTransactionReadModel.test.ts tests/terminalWalletBtcOperation.test.ts tests/terminalJournalReconciliation.test.ts tests/terminalOrganizationAuthority.test.ts tests/protocolCommercialBoundary.test.ts tests/terminalTransactionDetailCards.test.tsx tests/terminalTransactionDetailSnapshot.test.ts tests/terminalUxBrowserProof.test.tsx tests/pipelineExecutionLogHeader.test.tsx --runInBand; pnpm -C uapi exec jest --coverage; pnpm --dir uapi exec tsc --noEmit --pretty false

Author: geraldarthurdavis

uapi/app/terminal/TerminalTransactionJournalReconciliationCard.tsx

@@ -16,7 +16,7 @@ interface TerminalTransactionJournalReconciliationCardProps {
   reconciliation: TerminalJournalReconciliationSnapshot;
 }
 
-function factRows(facts: TerminalJournalReconciliationFact[]) {
+function factRows(facts: readonly TerminalJournalReconciliationFact[] = []) {
   return facts.map((fact) => ({
     label: fact.label,
     value: `${fact.value} · ${fact.state}${fact.blocksContradictoryProjection ? ' · blocks contradictory projection' : ''}`,
@@ -30,7 +30,7 @@ function FactSection({
 }: {
   title: string;
   summary: string;
-  facts: TerminalJournalReconciliationFact[];
+  facts?: readonly TerminalJournalReconciliationFact[];
 }) {
   return (
     <section className="border-t border-white/8 pt-4">