V48: Never emit settleDelivery from synthesis

Asset-pack synthesis postprocess/Finish never surface
settle_delivery, settleDelivery, settlePassThrough, or
settle shippable PR — even if settle keys exist on the EE.
Settlement remains settle-asset-pack-pipeline exclusive.

Author: geraldarthurdavis

packages/api/src/routes/asset-pack-pipeline.ts

@@ -1041,31 +1041,12 @@ export const POST = traceRoute('/executions', async (request: NextRequest) => {
             (execution as any).get?.('implementation', 'assetPackSynthesisArtifacts') ||
             writtenAssets ||
             undefined;
-          // Buyer-repo PR: settle Simple shippable only (or settlePassThrough
-          // after settle on same EE). Synthesis Finish must not invent settleDelivery.
-          const settleShippable =
-            (execution as any).get?.('settle-asset-pack-pipeline', 'shippable') ||
-            undefined;
-          const settlePassThrough =
-            (execution as any).get?.('finish/asset_pack_completion', 'settlePassThrough') ||
-            undefined;
-          const settleDelivery =
-            settleShippable?.prUrl
-              ? {
-                  pullRequest: {
-                    url: settleShippable.prUrl,
-                    title: settleShippable.optionTitle || undefined,
-                  },
-                  summary:
-                    (execution as any).get?.('finish/asset_pack_completion', 'summary') ||
-                    undefined,
-                }
-              : settlePassThrough?.pullRequest?.url
-                ? settlePassThrough
-                : undefined;
+          // Synthesis completion path: never project settleDelivery / settle PR.
+          // Buyer-repo settle surfaces come only from settle-asset-pack-pipeline runs.
           const deliveryMechanism =
             (execution as any).get?.('finish/asset_pack_completion', 'deliveryMechanism') ||
             undefined;
+          const settleDelivery = undefined;
           const read =
             (execution as any).get?.('finish/asset_pack_completion', 'read') ||
             (execution as any).get?.('pipeline', 'expressedRead') ||

packages/asset-packs-pipelines/domain/src/__tests__/finish-completion.test.ts

@@ -1,9 +1,8 @@
 // @ts-nocheck
 /**
  * Finish AssetPack completion evidence (product SDIVF Finish phase).
- * Buyer-repo PR URL is only present when settle Simple already stored a
- * shippable on the shared execution — Finish itself does not open PRs and
- * does not author settleDelivery (settlement-exclusive surface).
+ * Synthesis Finish never opens PRs and never surfaces settleDelivery /
+ * settlePassThrough — even if settle keys exist on a shared EE.
  */
 import { Execution } from '@bitcode/execution-generics';
 import AssetPackCompletionAgent from '../agents/finish/asset-pack-completion-agent';
@@ -32,8 +31,9 @@ describe('finish AssetPack completion evidence', () => {
       branch: 'main',
       commit: '272b5b1586b28363b57676603a1990bb10df319c',
     });
-    expect(result.settlePassThrough).toBeUndefined();
+    expect((result as any).settlePassThrough).toBeUndefined();
     expect((result as any).settleDelivery).toBeUndefined();
+    expect(result.deliveryMechanism?.pullRequest).toBeNull();
     expect(result.summary).toContain('octocat/Spoon-Knife');
     expect(result.deliveryMechanism?.readiness).toMatchObject({
       status: 'pending-user-review',
@@ -42,7 +42,7 @@ describe('finish AssetPack completion evidence', () => {
     expect(result.assetPackSynthesisArtifacts?.summary).toContain('octocat/Spoon-Knife');
   });
 
-  it('passes through settle shippable PR only as settlePassThrough when settle already ran', async () => {
+  it('ignores settle shippable on the EE — synthesis never emits settle surfaces', async () => {
     const exec = new Execution('pipeline:asset-pack');
     exec.store('pipeline', 'expressedRead', 'Need: type-safe plain object check');
     exec.store('harness', 'sourceRevision', {
@@ -56,9 +56,8 @@ describe('finish AssetPack completion evidence', () => {
     });
 
     const result = await AssetPackCompletionAgent({}, exec);
-    expect(result.settlePassThrough?.pullRequest).toMatchObject({
-      url: 'https://github.com/octocat/Spoon-Knife/pull/123',
-    });
+    expect((result as any).settlePassThrough).toBeUndefined();
     expect((result as any).settleDelivery).toBeUndefined();
+    expect(result.deliveryMechanism?.pullRequest).toBeNull();
   });
 });

packages/asset-packs-pipelines/domain/src/__tests__/postprocess.test.ts

@@ -42,11 +42,13 @@ describe('normalizeAssetPackOutput', () => {
     expect(typeof normalized.summary).toBe('string');
     expect(normalized.summary.length).toBeGreaterThan(0);
 
+    // Settle shippable on EE must not project into synthesis normalize.
     exec.store('settle-asset-pack-pipeline', 'shippable', {
       prUrl: 'https://github.com/acme/repo/pull/123',
     });
-    const withSettle = normalizeAssetPackOutput(output, exec);
-    expect(withSettle.shippable.prUrl).toContain('/pull/123');
+    const withSettleKeysPresent = normalizeAssetPackOutput(output, exec);
+    expect(withSettleKeysPresent.shippable?.prUrl).toBeUndefined();
+    expect(withSettleKeysPresent.deliveryMechanism?.prUrl).toBeUndefined();
   });
 
   it('builds asset-pack semantic mirrors into the postprocessed result', () => {
@@ -169,7 +171,7 @@ describe('normalizeAssetPackOutput', () => {
     expect(result.assetPackSynthesisArtifacts?.proofEvidence).toEqual(['sibling-implementation-read']);
   });
 
-  it('surfaces settleDelivery only when settle Simple shippable exists on the EE', () => {
+  it('never emits settle_delivery / settleDelivery even when settle shippable exists on EE', () => {
     const exec = new Execution('pipeline:asset-pack');
     exec.store('execution', 'id', 'exec-2');
     exec.store('settle-asset-pack-pipeline', 'shippable', {
@@ -179,21 +181,21 @@ describe('normalizeAssetPackOutput', () => {
 
     const result = buildAssetPackPostprocessedResult(exec, {
       success: true,
-      summary: 'Settled delivery complete.',
+      summary: 'Synthesis complete.',
       writtenAsset: {
         title: 'Read satisfaction summary',
       },
       semanticKind: 'asset-pack-written-asset',
     } as any);
 
     expect(result.title).toBe('Read satisfaction summary');
-    expect(result.kind).toBe('settle_delivery');
-    expect(result.settleDelivery?.pullRequest).toMatchObject({
-      url: 'https://github.com/acme/repo/pull/26',
-    });
+    expect(result.kind).toBe('asset_pack_synthesis');
+    expect(result.kind).not.toBe('settle_delivery' as any);
+    expect(result.settleDelivery).toBeUndefined();
+    expect(result.shippable).toBeUndefined();
   });
 
-  it('does not invent settleDelivery from synthesis deliveryMechanism alone', () => {
+  it('strips PR fields from deliveryMechanism on synthesis postprocess', () => {
     const exec = new Execution('pipeline:asset-pack');
     exec.store('execution', 'id', 'exec-2b');
 
@@ -210,8 +212,8 @@ describe('normalizeAssetPackOutput', () => {
 
     expect(result.kind).toBe('asset_pack_synthesis');
     expect(result.settleDelivery).toBeUndefined();
-    // deliveryMechanism may still carry readiness-shaped data from the input
-    expect(result.deliveryMechanism?.prUrl).toBe('https://github.com/acme/repo/pull/26');
+    expect(result.deliveryMechanism?.prUrl).toBeUndefined();
+    expect((result.deliveryMechanism as any)?.pullRequest).toBeUndefined();
   });
 
   it('derives and stores source-safe preview evidence from an accepted Need and Finding Fits result', () => {

packages/asset-packs-pipelines/domain/src/agents/finish/asset-pack-completion-agent.ts

@@ -52,30 +52,16 @@ const DeliveryMechanismSchema = z.object({
     .optional(),
 });
 
-/**
- * Settle pass-through only — present when settle Simple already stored a
- * shippable on this EE. Synthesis Finish must not author this as a fake PR bag.
- */
-const SettlePassThroughSchema = z.object({
-  pullRequest: ShippableSchema.nullable().optional(),
-  fileChanges: FileChangesSchema.nullable().optional(),
-  summary: z.string().nullable().optional(),
-});
-
 export const AssetPackCompletionOutputSchema = z.object({
   /**
    * Synthesis completion summary (markdown). Primary Finish evidence for SDIVF.
-   * Not settleDelivery — settlement is settle-asset-pack-pipeline exclusive.
+   * Settlement (settleDelivery / buyer PR) is exclusive to settle-asset-pack-pipeline
+   * and is never authored or passed through by synthesis Finish.
    */
   summary: z.string().optional(),
   assetPackSynthesisArtifacts: AssetPackSynthesisArtifactsSchema.optional(),
   writtenAssets: WrittenAssetsSchema.optional(),
   deliveryMechanism: DeliveryMechanismSchema.optional(),
-  /**
-   * Only when settle Simple already ran on this execution (cross-pipeline
-   * handoff). Omitted on pure deposit/read synthesis Finish.
-   */
-  settlePassThrough: SettlePassThroughSchema.optional(),
   read: z.string().optional(),
   writtenAssetType: z.string().optional(),
   processingStats: z.object({
@@ -125,7 +111,7 @@ const AssetPackCompletionAgent = factoryAgentWithSingleStep<any, AssetPackComple
       (execution as any).prompt?.setSpecificExecution(
         'specific_execution:output:shape',
         (
-          'Output JSON with keys: summary, assetPackSynthesisArtifacts{fileChanges,summary,proofEvidence?,reviewNotes?}, writtenAssets{fileChanges,summary}, deliveryMechanism{summary,readiness}, processingStats{…}, repoSnapshot{org,repo,branch,commit}. Optional settlePassThrough only if settle Simple already stored a shippable PR on this execution. SDIVF Finish closes synthesis evidence; buyer-repo PR shipping is settle-asset-pack-pipeline only.'
+          'Output JSON with keys: summary, assetPackSynthesisArtifacts{fileChanges,summary,proofEvidence?,reviewNotes?}, writtenAssets{fileChanges,summary}, deliveryMechanism{summary,readiness}, processingStats{…}, repoSnapshot{org,repo,branch,commit}. Never settleDelivery / settlePassThrough / buyer-repo PR — those are settle-asset-pack-pipeline only. SDIVF Finish closes synthesis evidence only.'
         ) as unknown as PromptPart
       );
     } catch {}
@@ -225,25 +211,9 @@ const AssetPackCompletionAgent = factoryAgentWithSingleStep<any, AssetPackComple
     }
     const summary = lines.join('\n');
 
-    // PR shipping is settle-only. Pass through only when settle Simple already
-    // stored a shippable on this EE — never author settleDelivery on synthesis Finish.
-    let settlePassThrough: AssetPackCompletionOutput['settlePassThrough'] | undefined;
+    // Settlement / buyer-repo PR is never part of synthesis Finish — even if
+    // settle keys exist on a shared EE. That surface is settle-asset-pack-pipeline only.
     const dtype = resolveWrittenAssetTypeFromExecution(execution);
-    try {
-      const settleShippable =
-        findStoredExecutionValue(execution, 'settle-asset-pack-pipeline', 'shippable') || null;
-      if (settleShippable?.prUrl) {
-        settlePassThrough = {
-          pullRequest: {
-            url: settleShippable.prUrl,
-            title: settleShippable.optionTitle || read || 'AssetPack delivery',
-            number: undefined,
-          },
-          fileChanges: undefined,
-          summary,
-        };
-      }
-    } catch {}
 
     const writtenAssets = {
       fileChanges: undefined,
@@ -264,9 +234,9 @@ const AssetPackCompletionAgent = factoryAgentWithSingleStep<any, AssetPackComple
         : {
             ...writtenAssets,
           };
-    // Delivery readiness for review surfaces — not a buyer-repo PR unless settle ran.
+    // Review readiness only — never pullRequest / settleDelivery.
     const deliveryMechanism = {
-      pullRequest: settlePassThrough?.pullRequest ?? null,
+      pullRequest: null,
       summary,
       readiness: deliveryReadiness,
     };
@@ -276,7 +246,6 @@ const AssetPackCompletionAgent = factoryAgentWithSingleStep<any, AssetPackComple
       assetPackSynthesisArtifacts,
       writtenAssets,
       deliveryMechanism,
-      ...(settlePassThrough ? { settlePassThrough } : {}),
       read: read || undefined,
       writtenAssetType: dtype || undefined,
       processingStats,
@@ -286,7 +255,6 @@ const AssetPackCompletionAgent = factoryAgentWithSingleStep<any, AssetPackComple
     const output: AssetPackCompletionOutput = validated;
 
     try {
-      // Synthesis evidence only — do not store settleDelivery from Finish.
       (execution as any).store?.('finish/asset_pack_completion', 'summary', summary as any);
       (execution as any).store?.('finish/asset_pack_completion', 'assetPackSynthesisArtifacts', assetPackSynthesisArtifacts as any);
       (execution as any).store?.('finish/asset_pack_completion', 'writtenAssets', writtenAssets as any);
@@ -295,13 +263,6 @@ const AssetPackCompletionAgent = factoryAgentWithSingleStep<any, AssetPackComple
       (execution as any).store?.('finish/asset_pack_completion', 'writtenAssetType', dtype || undefined);
       (execution as any).store?.('finish/asset_pack_completion', 'processingStats', processingStats as any);
       (execution as any).store?.('finish/asset_pack_completion', 'repoSnapshot', repoSnapshot as any);
-      if (settlePassThrough) {
-        (execution as any).store?.(
-          'finish/asset_pack_completion',
-          'settlePassThrough',
-          settlePassThrough as any,
-        );
-      }
     } catch {}
 
     return output;

packages/asset-packs-pipelines/domain/src/postprocess.ts

@@ -57,25 +57,9 @@ export function normalizeAssetPackOutput(output: AssetPackOutput, execution: Exe
     (execution as any).findUp?.('depository/search', 'result') ||
     (execution as any).get?.('depository/search', 'result');
 
-  // PR URLs come from settle Simple (ship-asset-pack-patch-pr), not from the
-  // Deposit/Read SDIVF Finish phase. Only surface a PR when settle already
-  // recorded a shippable (or the result object was produced by settle).
-  // Never invent a PR from finish/* store keys alone.
-  const settleShippable = findStoredExecutionValue(
-    execution,
-    'settle-asset-pack-pipeline',
-    'shippable',
-  ) as { prUrl?: string } | null;
-  const prUrl =
-    settleShippable?.prUrl ||
-    enhanced.writtenAsset?.prUrl ||
-    deliveryMechanism?.prUrl ||
-    enhanced.shippable?.prUrl ||
-    null;
-  if (prUrl) {
-    enhanced.deliveryMechanism = { ...(deliveryMechanism || {}), prUrl } as any;
-    enhanced.shippable = { ...(enhanced.shippable || enhanced.deliveryMechanism || {}), prUrl } as any;
-  }
+  // Asset-pack *synthesis* postprocess never projects settle/PR shippables.
+  // Buyer-repo PR / settleDelivery live exclusively on settle-asset-pack-pipeline.
+  // Do not read settle-asset-pack-pipeline.shippable or invent prUrl here.
 
   // 2) Backfill artifacts from execution if missing
   const filesModified = enhanced.artifacts?.filesModified?.length
@@ -88,11 +72,10 @@ export function normalizeAssetPackOutput(output: AssetPackOutput, execution: Exe
     } as any;
   }
 
-  // 3) Ensure a human-readable summary exists
+  // 3) Ensure a human-readable summary exists (no settle/PR narrative).
   if (!enhanced.summary || !enhanced.summary.trim()) {
     const parts: string[] = [];
     parts.push(enhanced.success ? 'AssetPack synthesis artifacts completed.' : 'AssetPack synthesis artifacts finished with issues.');
-    if (prUrl) parts.push(`PR: ${prUrl}`);
     if (filesModified?.length) parts.push(`Files modified: ${filesModified.length}`);
     enhanced.summary = parts.join(' ');
   }
@@ -117,7 +100,8 @@ export function normalizeAssetPackOutput(output: AssetPackOutput, execution: Exe
   if (depositorySearch) {
     (enhanced as any).depositorySearch = depositorySearch;
   }
-  const sourceSafePreview = ensureAssetPackSourceSafePreview(execution, enhanced, prUrl);
+  // No settle PR target in synthesis postprocess.
+  const sourceSafePreview = ensureAssetPackSourceSafePreview(execution, enhanced, null);
   if (sourceSafePreview) {
     const assetPackDisclosureReview = ensureAssetPackDisclosureReview(execution, sourceSafePreview);
     const assetPackPreviewBoundary = ensureAssetPackPreviewBoundary(
@@ -308,59 +292,39 @@ export function buildAssetPackPostprocessedResult(
     ensureReadingOperationalTelemetryRepairReadback(execution, normalized);
   const readingInterfaceProductParity = ensureReadingInterfaceProductParity(execution, normalized);
   const readingLocalStagingRehearsal = ensureReadingLocalStagingRehearsal(execution, normalized);
-  const shippable = normalized.shippable || normalized.deliveryMechanism;
-  // settleDelivery is settle-pipeline exclusive. Only surface when settle Simple
-  // already recorded a shippable on this EE (cross-pipeline handoff), never invent
-  // a settle-shaped bag from synthesis finish or deliveryMechanism alone.
-  const settleShippable =
-    findStoredExecutionValue(execution, 'settle-asset-pack-pipeline', 'shippable') as
-      | { prUrl?: string; optionTitle?: string }
-      | null;
-  const settleDeliveryFromSettleOnly =
-    settleShippable?.prUrl
-      ? {
-          pullRequest: {
-            url: settleShippable.prUrl,
-            title: settleShippable.optionTitle || finalSummary || 'AssetPack delivery',
-          },
-          summary: finalSummary || normalized.summary || null,
-        }
-      : (normalized as any).settleDelivery?.pullRequest?.url
-        ? (normalized as any).settleDelivery
-        : null;
 
+  // Synthesis postprocess never emits settle_delivery / settleDelivery / settle
+  // shippables — even if settle keys exist on a shared EE. Settlement is a
+  // different pipeline (ExecutionPipelineSimpleSettleAssetPack).
   const productPipeline = resolveSynthesisProductPipeline(execution);
   const selectionEnvelope =
     findStoredExecutionValue(execution, 'finish', 'selectionEnvelope') ||
     (normalized as any).selectionEnvelope ||
     null;
-  const kind = resolveSynthesisPostprocessKind(productPipeline, !!settleDeliveryFromSettleOnly);
+  const kind = resolveSynthesisPostprocessKind(productPipeline);
 
   return {
     executionId,
     kind,
     semanticKind: 'asset-pack-written-asset',
     title:
       normalized.writtenAsset?.title ||
-      normalized.shippable?.title ||
-      normalized.deliveryMechanism?.title ||
       finalSummary ||
       normalized.summary ||
       (kind === 'deposit_options' || kind === 'read_options'
         ? 'AssetPack options'
         : 'Written Asset'),
     repository,
     summary: finalSummary,
-    shippable: settleDeliveryFromSettleOnly
-      ? shippable
-      : kind === 'deposit_options' || kind === 'read_options'
-        ? undefined
-        : shippable,
-    // Only attach when settle actually produced a PR — never synthesis-authored.
-    ...(settleDeliveryFromSettleOnly
-      ? { settleDelivery: settleDeliveryFromSettleOnly as any }
-      : {}),
-    deliveryMechanism: normalized.deliveryMechanism || (settleDeliveryFromSettleOnly ? shippable : undefined),
+    // No shippable / settleDelivery on synthesis results.
+    deliveryMechanism: normalized.deliveryMechanism
+      ? {
+          // Strip any PR projection that may have leaked onto deliveryMechanism.
+          ...normalized.deliveryMechanism,
+          prUrl: undefined,
+          pullRequest: undefined,
+        }
+      : undefined,
     ...(selectionEnvelope ? { selectionEnvelope } : {}),
     ...((normalized as any).options || (normalized as any).depositOptions
       ? {
@@ -790,16 +754,12 @@ function resolveSynthesisProductPipeline(execution: Execution): string {
 }
 
 /**
- * Postprocess kind for synthesis product runs.
- * - deposit_options / read_options: selection envelopes for UI
- * - asset_pack_synthesis: generic synthesis completion evidence
- * - settle_delivery: only when settle Simple already produced a shippable PR
+ * Postprocess kind for synthesis product runs only.
+ * Never settle_delivery — that kind is exclusive to settle-asset-pack-pipeline.
  */
 function resolveSynthesisPostprocessKind(
   productPipeline: string,
-  hasSettleDelivery: boolean,
 ): AssetPackPostprocessed['kind'] {
-  if (hasSettleDelivery) return 'settle_delivery';
   if (
     productPipeline.includes('deposit') ||
     productPipeline === 'deposit'