Skip to content

Commit 6497c53

Browse files
V48 Gate 3 (implementation-only): allow the spec/impl category parenthetical in the gate-PR title check
The title-validation regex required the colon immediately after the gate number, rejecting the now-canonical `(specification-only|implementation-only| specification-implementation)` parenthetical every gate-3 commit/PR title uses.
1 parent 346656c commit 6497c53

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/bitcode-gate-quality.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,9 @@ jobs:
4949
if [[ "$PR_BASE_REF" == version/* && "$PR_HEAD_REF" =~ ^v([0-9]+)/gate-([0-9]+)- ]]; then
5050
expected_version="V${BASH_REMATCH[1]}"
5151
expected_gate="${BASH_REMATCH[2]}"
52-
if [[ ! "$PR_TITLE" =~ ^${expected_version}[[:space:]]+Gate[[:space:]]+${expected_gate}:[[:space:]].+ ]]; then
53-
echo "Gate pull request titles must begin with: ${expected_version} Gate ${expected_gate}:"
52+
title_re="^${expected_version}[[:space:]]+Gate[[:space:]]+${expected_gate}([[:space:]]\((specification-only|implementation-only|specification-implementation)\))?:[[:space:]].+"
53+
if [[ ! "$PR_TITLE" =~ $title_re ]]; then
54+
echo "Gate pull request titles must begin with: ${expected_version} Gate ${expected_gate}: or ${expected_version} Gate ${expected_gate} (specification-only|implementation-only|specification-implementation):"
5455
echo "Observed: ${PR_TITLE}"
5556
exit 1
5657
fi

0 commit comments

Comments
 (0)