V48 Gate 3 (specification-implementation): surface reconnect-required state on deposit branch/commit selects (V48-Gate3-F32)

Live QA: with a repository already selected, Branch and Commit stayed on
"Select branch.../Select commit..." forever — no loading spinner, no error,
and clicking didn't even open the dropdowns.

Root cause: the branch/commit fetch effects in DepositSourceSelection.tsx
gate on connectionStatus.valid (a live re-check of the GitHub session), not
just .connected. A GitHub App installation token expires roughly hourly, so
connected:true/valid:false is a normal, recurring state — the repository
list still populates (it doesn't need .valid), but Branch/Commit silently
stay empty, and disabled={branches.length === 0} makes the selects inert
with nothing telling the depositor why.

The legacy TerminalRepositoryContextPanel this component replaced had
dedicated "reconnect required" messaging + a Reconnect CTA for exactly this
state; it was dropped in the deposit-native rewrite. Restored it: an amber
banner explaining Branch/Commit are empty until the live session
reconnects, a Reconnect GitHub button (reusing TerminalOpenAuxillariesButton
directly — its own logic has no terminal-workspace coupling), and matching
inline hints under each select.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: geraldarthurdavis

BITCODE_V48_QA.md

@@ -520,6 +520,12 @@ Track 3-4 scripts (BTD ledger, settlement, pack journaling) get added when those
 - Cause: `POST /api/deposit/synthesize-options` (V48-Gate3-F26-B) dispatches the run then returns `{status:'dispatched'}` immediately, with the actual multi-agent synthesis (`runSynthesis()`) continuing as a bare `void runSynthesis()` promise after the response completes. Vercel Functions (including Fluid Compute) do not guarantee an instance stays alive to finish work started before the response but not awaited by it — the platform is free to freeze/recycle the instance once the response is flushed, unless the continuation is registered via `waitUntil()`. This is the same failure class `execution-orphan-sweep.ts`'s own header comment already names as the reason its sweep exists ("dev-server restarts (and crashed serverless boxes) kill in-process pipelines … leaving them running forever" — QA runs `7f023f23` and the 2026-07-03 pre-restart orphans): that sweep detects and relabels the resulting stuck-`running` rows as `interrupted`, but nothing previously stopped the box from being killed mid-run in the first place. The same bare-`void` pattern was also on the orphan sweep's own fire-and-forget call at dispatch time.
 - Repair: added `@vercel/functions` and wrapped both fire-and-forget continuations in `waitUntil()` — the `runSynthesis()` background run and the `sweepOrphanedExecutions()` call in `uapi/app/api/deposit/synthesize-options/route.ts`. This keeps the Function instance alive until the promise settles, so a dispatched run either completes or fails and finalizes its row through the normal `finalizeExecutionRow`/error-banner path, instead of being silently killed mid-flight. Checked the only sibling background-dispatch route (`/api/pipeline-harness/asset-pack`) and confirmed it does NOT have this defect: its continuation runs inside an open `ReadableStream` (SSE), whose lifetime keeps the Function instance alive by construction — no `waitUntil` needed there. Verified: `tsc --noEmit` 0; `depositSynthesizeOptionsRoute.test.ts` 6/6 green.
 
+### V48-Gate3-F32 — Branch/Commit selects on `/deposits` silently stuck on a stale GitHub connection, no explanation (FIXED)
+
+- Severity: high (reported live, 2026-07-08: "branch and commit selects seem broken … not loading lists+defaults nor is clicking opening dropdowns" — with a repository already selected).
+- Cause: `DepositSourceSelection.tsx` (the deposit-native replacement for the legacy `TerminalRepositoryContextPanel`/`TerminalSupplySelectionPanel`) fetches the repository list gated only on `connectionStatus.connected`, but gates the Branch and Commit fetch effects on BOTH `connectionStatus.connected` AND `connectionStatus.valid` (same asymmetry as the legacy panel). `valid` comes from `validateStoredConnection`, which re-checks the live GitHub session/token — a GitHub App installation token expires ~hourly and is regenerated lazily, so `connected:true, valid:false` is a normal, recurring state, not an edge case. In that state a repository is still selectable (stored inventory doesn't need `valid`), but Branch/Commit silently stay at `[]` forever: `disabled={... || branches.length === 0}` (and the same for commits) keeps the selects inert with no loading spinner and no error text — the legacy panel this replaced had dedicated "reconnect required" messaging + a Reconnect CTA for exactly this state (`connectionStatus?.connected && !connectionStatus.valid`, `TerminalRepositoryContextPanel.tsx`), but that messaging was dropped when `DepositSourceSelection` replaced it — the refactor's docblock even says it "carries no terminal-UI dependency," which is what left this state unhandled.
+- Repair: added a `connectionNeedsReconnect` derived flag to `DepositSourceSelection.tsx`; when true, an amber banner (mirroring the legacy panel's messaging) explains that Branch/Commit stay empty until the live session reconnects, with a "Reconnect GitHub" button (`TerminalOpenAuxillariesButton`, opens Auxillaries → Externals — reused directly since its own logic has no terminal-workspace coupling, only its file location is under `app/terminal/`). The Branch/Commit helper hints below each select also swap to "Reconnect required to load branches/commits" instead of the normal "default is selected when available" copy in this state. `TerminalOpenAuxillariesButton.tsx` was missing an explicit `React` import (never directly rendered by a test before — ts-jest's classic JSX transform needs it in scope); added it. Verified: `tsc --noEmit` 0; new `depositSourceSelection.test.tsx` coverage (valid connection → no banner; invalid → banner + Reconnect button + both hint texts) 5/5 green; full uapi jest suite 639/640 green (1 pre-existing skip).
+
 ## Track 1 — Identity / Authentication / Auxillaries — COMPLETE 2026-06-12 (email deferred by decision; F2/F9 and legacy eradication queued for gates)
 
 - [x] Sign up / sign in via Connect Wallet (nav CTA → SignUpWindow → wallet signature on testnet4 → `custom:bitcode-bitcoin` session → `/tps/supabase/callback`) — verified 2026-06-12 after F5 fix; lands on `/packs`. Re-verified from fully nuked state (purged user + cleared site data): created 19:29:21 → session 19:29:25 → binding auto-written 19:29:29 by the bridge on `/packs` mount with no Auxillaries visit; UI consistent across nav, Wallet, and Profile panes.

uapi/app/deposits/DepositSourceSelection.tsx

@@ -19,6 +19,7 @@ import { VCSRepositorySelector } from "@/components/base/bitcode/vcs/VCSReposito
 import { SearchableSelect } from "@/components/base/bitcode/forms/SearchableSelect";
 import BitcodeInlineExplainer from "@/components/base/bitcode/execution/BitcodeInlineExplainer";
 import { DEPOSIT_SECTION_EXPLAINERS } from "@/app/deposits/deposit-explainers";
+import TerminalOpenAuxillariesButton from "@/app/terminal/TerminalOpenAuxillariesButton";
 import {
   buildTerminalRepositoryAnchorDraft,
   type TerminalActivityRecordDraft,
@@ -131,6 +132,14 @@ export default function DepositSourceSelection({
     () => deriveSelectedCommit(commits, requestedCommit),
     [commits, requestedCommit],
   );
+  // Repositories list from stored inventory regardless of token validity
+  // (below), but branches/commits require a LIVE, valid session — a stale
+  // installation token (they expire ~hourly) leaves this true while a
+  // repository is still selectable, which otherwise reads as "broken":
+  // Branch/Commit silently stay empty and disabled with no explanation.
+  const connectionNeedsReconnect = Boolean(
+    connectionStatus?.connected && !connectionStatus.valid,
+  );
 
   // Connection posture.
   useEffect(() => {
@@ -500,6 +509,22 @@ export default function DepositSourceSelection({
         </div>
       </div>
 
+      {connectionNeedsReconnect ? (
+        <div className="mt-3 flex flex-wrap items-center justify-between gap-3 border border-amber-300/24 bg-amber-400/10 px-3 py-2.5 text-sm text-amber-100">
+          <span className="flex items-center gap-2">
+            <RefreshCw className="h-4 w-4 shrink-0" />
+            Saved {getProviderLabel(provider)} attachment found, but the live session
+            needs to reconnect — Branch and Commit stay empty (and non-interactive)
+            until then; the Repository list above is read from stored inventory only.
+          </span>
+          <TerminalOpenAuxillariesButton
+            step="externals"
+            label={`Reconnect ${getProviderLabel(provider)}`}
+            className="shrink-0 border border-amber-300/24 bg-amber-400/12 px-3 py-1.5 text-xs font-semibold uppercase tracking-[0.14em] text-amber-50 transition hover:border-amber-300/42 hover:bg-amber-400/18"
+          />
+        </div>
+      ) : null}
+
       <div className="mt-3 grid gap-3 tablet:grid-cols-2 desktop:grid-cols-[minmax(0,180px)_minmax(0,1.4fr)_minmax(0,1fr)_minmax(0,1fr)]">
         <div>
           <span className="flex items-center gap-2 text-[0.62rem] uppercase tracking-[0.18em] text-neutral-500">
@@ -616,7 +641,9 @@ export default function DepositSourceSelection({
           <p className="mt-1.5 text-[0.6rem] uppercase tracking-[0.16em] text-neutral-500">
             {isLoadingBranches
               ? "Loading branches…"
-              : "Default branch is selected when available"}
+              : connectionNeedsReconnect
+                ? "Reconnect required to load branches"
+                : "Default branch is selected when available"}
           </p>
         </div>
 
@@ -657,7 +684,9 @@ export default function DepositSourceSelection({
           <p className="mt-1.5 text-[0.6rem] uppercase tracking-[0.16em] text-neutral-500">
             {isLoadingCommits
               ? "Loading commits…"
-              : "Latest branch commit is selected when available"}
+              : connectionNeedsReconnect
+                ? "Reconnect required to load commits"
+                : "Latest branch commit is selected when available"}
           </p>
         </div>
       </div>

uapi/app/terminal/TerminalOpenAuxillariesButton.tsx

@@ -1,5 +1,6 @@
 'use client';
 
+import React from 'react';
 import { openAuxillaries } from '@/app/auxillaries/components/AuxillariesProvider';
 import {
   getAuxillaryOpenActionLabel,

uapi/tests/depositSourceSelection.test.tsx

@@ -11,14 +11,15 @@ jest.mock("next/navigation", () => ({
   useSearchParams: () => new URLSearchParams(""),
 }));
 
-function mockVcsFetch() {
+function mockVcsFetch(options: { connectionValid?: boolean } = {}) {
+  const connectionValid = options.connectionValid ?? true;
   global.fetch = jest.fn((input: unknown) => {
     const url = String(input);
     if (url.includes("/connection")) {
       return Promise.resolve({
         ok: true,
         status: 200,
-        json: async () => ({ connected: true, valid: true }),
+        json: async () => ({ connected: true, valid: connectionValid }),
       });
     }
     if (url.includes("/repositories")) {
@@ -128,3 +129,42 @@ describe("DepositSourceSelection — V48-Gate3-F17 repository anchoring", () =>
     expect(lastHref).not.toContain("sourceCommit=");
   });
 });
+
+describe("DepositSourceSelection — stale connection surfaces a reconnect notice (repro: branch/commit silently stuck empty)", () => {
+  afterEach(() => {
+    jest.restoreAllMocks();
+    mockReplace.mockReset();
+  });
+
+  it("shows no reconnect notice when the connection is connected and valid", async () => {
+    mockVcsFetch({ connectionValid: true });
+    render(
+      <DepositSourceSelection
+        routePath="/"
+        buildRouteHref={(params) => `/deposits?${params?.toString() ?? ""}`}
+      />,
+    );
+
+    await screen.findByLabelText("Repository provider");
+    expect(
+      screen.queryByText(/needs to reconnect/i),
+    ).not.toBeInTheDocument();
+  });
+
+  it("surfaces a reconnect notice (and why Branch/Commit stay empty) when connected but not valid", async () => {
+    mockVcsFetch({ connectionValid: false });
+    render(
+      <DepositSourceSelection
+        routePath="/"
+        buildRouteHref={(params) => `/deposits?${params?.toString() ?? ""}`}
+      />,
+    );
+
+    await screen.findByText(/needs to reconnect/i);
+    expect(
+      screen.getByRole("button", { name: /Reconnect GitHub/i }),
+    ).toBeInTheDocument();
+    expect(screen.getByText(/Reconnect required to load branches/i)).toBeInTheDocument();
+    expect(screen.getByText(/Reconnect required to load commits/i)).toBeInTheDocument();
+  });
+});