V48 (impl-only): SDIVF phase-delegator names

Rename deposit/read phase modules to full SDIVF ancestry.

Author: geraldarthurdavis

.docs/ASSET_PACKS.md

@@ -252,7 +252,7 @@ Finish:
   )
 ```
 
-Implementation lives in `packages/asset-packs-pipelines/syntheses/domain/src/phases/deposit-phases.ts`.
+Implementation lives in `packages/asset-packs-pipelines/syntheses/domain/src/phases/execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators.ts`.
 
 ---
 
@@ -692,7 +692,7 @@ ship AssetPack patch PR → journal PackActivity. Package:
 
 | Concern | Location |
 |---------|----------|
-| Deposit phase roster | `packages/asset-packs-pipelines/syntheses/domain/src/phases/deposit-phases.ts` |
+| Deposit phase roster | `packages/asset-packs-pipelines/syntheses/domain/src/phases/execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators.ts` |
 | Discovery registration | `…/phases/discovery.ts` |
 | Absolutes catalog | `packages/generic-asset-packs/synthesis/src/measurement-catalogs.ts` |
 | Measured patch type | `packages/generic-asset-packs/synthesis/` |
@@ -723,4 +723,4 @@ ship AssetPack patch PR → journal PackActivity. Package:
 
 ---
 
-*Document owner: product + pipeline maintainers. Prefer updating this file when deposit agent roster keys, absolute catalog kinds, or Finish schemas change — keep it aligned with `deposit-phases.ts` and `ASSET_PACK_ABSOLUTES_CATALOG`.*
+*Document owner: product + pipeline maintainers. Prefer updating this file when deposit agent roster keys, absolute catalog kinds, or Finish schemas change — keep it aligned with `execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators.ts` and `ASSET_PACK_ABSOLUTES_CATALOG`.*

packages/asset-packs-pipelines/syntheses/deposit/package.json

@@ -22,7 +22,7 @@
     "./depositor-earning-supply-intelligence-types": "./src/depositor-earning-supply-intelligence-types.ts",
     "./depositor-earning-supply-intelligence": "./src/depositor-earning-supply-intelligence.ts",
     "./ensure-deposit-checkout-source-files": "./src/ensure-deposit-checkout-source-files.ts",
-    "./phases/deposit-phases": "./src/phases/deposit-phases.ts",
+    "./phases/execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators": "./src/phases/execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators.ts",
     "./agents/finish/deposit-store-artifacts-agent": "./src/agents/finish/deposit-store-artifacts-agent.ts",
     "./agents/implementation/deposit-asset-pack-synthesis-schema": "./src/agents/implementation/deposit-asset-pack-synthesis-schema.ts",
     "./agents/implementation/deposit-asset-pack-synthesis-prompts": "./src/agents/implementation/deposit-asset-pack-synthesis-prompts.ts",

packages/asset-packs-pipelines/syntheses/deposit/src/__tests__/deposit-setup-discovery-agents.test.ts

@@ -26,7 +26,7 @@ import runDepositCodebaseComprehensionAgent from '../agents/discovery/deposit-co
 import runDepositDepositorySearchAgent from '../agents/discovery/deposit-depository-search-agent';
 import runDepositInherentRegurgitationAgent from '../agents/discovery/deposit-inherent-regurgitation-agent';
 import runDepositAssetPackSynthesisAgent from '../agents/implementation/deposit-asset-pack-synthesis-agent';
-import { depositSetupPhase } from '../phases/deposit-phases';
+import { executionPipelineSDIVFSynthesizeDepositAssetPacksSetupPhase } from '../phases/execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators';
 import { registerDiscoveryAgents } from '../phases/discovery';
 import {
   setBoundaryLLMOutput,
@@ -309,7 +309,7 @@ describe('deposit Setup native sequence (clone → parallel bootstrap → danger
       return originalRegister(name, agent);
     };
 
-    await depositSetupPhase(DEPOSIT_INPUT as any, exec);
+    await executionPipelineSDIVFSynthesizeDepositAssetPacksSetupPhase(DEPOSIT_INPUT as any, exec);
 
     expect(invoked[0]).toBe('setup:clone-vcs-repository');
     expect(invoked[invoked.length - 1]).toBe('setup:danger-wall');

packages/asset-packs-pipelines/syntheses/deposit/src/index.ts

@@ -26,7 +26,7 @@ import {
   normalizeAssetPackOutput,
   buildAssetPackPostprocessedResult,
 } from '@bitcode/asset-packs-pipelines-syntheses-domain';
-import { depositPhases } from './phases/deposit-phases';
+import { executionPipelineSDIVFSynthesizeDepositAssetPacksPhaseDelegators } from './phases/execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators';
 import {
   EXECUTION_PIPELINE_SDIVF_SYNTHESIZE_DEPOSITS_ASSET_PACKS_PROMPT,
   EXECUTION_PHASE_SDIVF_SYNTHESIZE_DEPOSITS_SETUP_PROMPT,
@@ -45,11 +45,11 @@ export function factoryExecutionPipelineSDIVFSynthesizeDepositAssetPacks(
   const maxIterations = 1;
   const sdivf = factoryExecutionPipelineSDIVFFromExecutors(pipelineName, {
     preprocess: factoryPreprocessDepositOnly() as any,
-    setup: depositPhases.setup as any,
-    discovery: depositPhases.discovery as any,
-    implementation: depositPhases.implementation as any,
-    validation: depositPhases.validation as any,
-    finish: depositPhases.finish as any,
+    setup: executionPipelineSDIVFSynthesizeDepositAssetPacksPhaseDelegators.setup as any,
+    discovery: executionPipelineSDIVFSynthesizeDepositAssetPacksPhaseDelegators.discovery as any,
+    implementation: executionPipelineSDIVFSynthesizeDepositAssetPacksPhaseDelegators.implementation as any,
+    validation: executionPipelineSDIVFSynthesizeDepositAssetPacksPhaseDelegators.validation as any,
+    finish: executionPipelineSDIVFSynthesizeDepositAssetPacksPhaseDelegators.finish as any,
     maxIterations,
     pipelinePromptSpecific: EXECUTION_PIPELINE_SDIVF_SYNTHESIZE_DEPOSITS_ASSET_PACKS_PROMPT,
     phasePromptSpecific: {
@@ -83,4 +83,4 @@ export * from './deposit-asset-pack-option-policy';
 export * from './deposit-asset-pack-option-admission';
 export * from './deposit-option-real-synthesis';
 export * from './depositor-earning-supply-intelligence';
-export * from './phases/deposit-phases';
+export * from './phases/execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators';

…ses/deposit/src/phases/deposit-phases.ts …-deposit-asset-packs-phase-delegators.tspackages/asset-packs-pipelines/syntheses/deposit/src/phases/deposit-phases.ts renamed to packages/asset-packs-pipelines/syntheses/deposit/src/phases/execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators.ts packages/asset-packs-pipelines/syntheses/deposit/src/phases/deposit-phases.ts renamed to packages/asset-packs-pipelines/syntheses/deposit/src/phases/execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators.ts

@@ -1,5 +1,10 @@
 /**
- * Deposit-only SDIVF phase rosters for ExecutionPipelineSDIVFSynthesizeDepositAssetPacks.
+ * ExecutionPipelineSDIVFSynthesizeDepositAssetPacks — SDIVF ExecutionPhase delegators.
+ *
+ * Hierarchy: Execution → Pipeline → SDIVF → SynthesizeDepositAssetPacks → ExecutionPhase*.
+ * Phases are exclusively SDIVF concepts (Setup / Discovery / Implementation / Validation / Finish).
+ * This module is product-specific *delegators* for those SDIVF phases — not a separate
+ * "deposit phase" system.
  *
  * Setup: clone alone → parallel {LSP, MCP, obfuscations} → danger wall alone.
  * Discovery: parallel {comprehend-codebase, inherent-regurgitation}
@@ -25,8 +30,8 @@ type DiscoveryOutput = AssetPackInput;
 type ImplementationOutput = AssetPackOutput;
 type ValidationOutput = AssetPackOutput;
 
-function registerDepositSetupAgents(agentRegistry: any): void {
-  // One roster key per Setup agent (matches depositSetupPhase executors).
+function registerExecutionPipelineSDIVFSynthesizeDepositAssetPacksSetupAgents(agentRegistry: any): void {
+  // One roster key per Setup agent (matches executionPipelineSDIVFSynthesizeDepositAssetPacksSetupPhase executors).
   agentRegistry.registerAgent(
     'setup:clone-vcs-repository',
     () =>
@@ -51,12 +56,12 @@ function registerDepositSetupAgents(agentRegistry: any): void {
   );
 }
 
-export const depositSetupPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<AssetPackInput, SetupOutput> = (async (
+export const executionPipelineSDIVFSynthesizeDepositAssetPacksSetupPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<AssetPackInput, SetupOutput> = (async (
   input: AssetPackInput,
   execution: any,
 ) => {
   try {
-    registerDepositSetupAgents((execution as any).agents);
+    registerExecutionPipelineSDIVFSynthesizeDepositAssetPacksSetupAgents((execution as any).agents);
   } catch {}
 
   // Progressive deposit QA: BITCODE_DEBUG_SETUP_SERIAL=1 runs wave-1 agents
@@ -136,7 +141,7 @@ export const depositSetupPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<As
   }
 }) as unknown as ExecutionPipelineSDIVFExecutionPhaseDelegator<AssetPackInput, SetupOutput>;
 
-export const depositDiscoveryPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<SetupOutput, DiscoveryOutput> = (async (
+export const executionPipelineSDIVFSynthesizeDepositAssetPacksDiscoveryPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<SetupOutput, DiscoveryOutput> = (async (
   input: AssetPackInput,
   execution: any,
 ) => {
@@ -147,6 +152,62 @@ export const depositDiscoveryPhase: ExecutionPipelineSDIVFExecutionPhaseDelegato
     registerDiscoveryAgents((execution as any).agents, 'deposit');
   } catch {}
 
+  // Progressive Discovery QA: when BITCODE_DEBUG_STOP_AGENT_FILTER targets a
+  // later wave-1/wave-2 agent, passthrough earlier agents so each stop does not
+  // re-burn full multi-tool codebase PTRR (already Accepted 1.D-Agent).
+  const stopFilter = String(
+    process.env.BITCODE_DEBUG_STOP_AGENT_FILTER || '',
+  ).toLowerCase();
+  const targetsCodebase =
+    !stopFilter ||
+    stopFilter.includes('codebasecomprehension') ||
+    stopFilter.includes('comprehend-codebase');
+  const targetsRegurgitation =
+    stopFilter.includes('inherentregurgitation') ||
+    stopFilter.includes('inherent-regurgitation') ||
+    stopFilter.includes('regurgitation');
+  const targetsSearch =
+    stopFilter.includes('depository') ||
+    stopFilter.includes('search-depository') ||
+    stopFilter.includes('searchforrelevants');
+
+  if (stopFilter && !targetsCodebase) {
+    (execution as any).agents?.registerAgent?.(
+      DISCOVERY_COMPREHEND_CODEBASE,
+      async (passthroughInput: any, exec: any) => {
+        storeCrossPhaseArtifact(exec, 'discovery', 'codebaseComprehension', {
+          schema: 'bitcode.debug.fast-discovery.codebase',
+          summary:
+            'Fast Discovery: DepositCodebaseComprehension skipped (agent Accepted).',
+          capabilities: [],
+          knowledgeAreas: [],
+          notableModules: [],
+        });
+        storeCrossPhaseArtifact(exec, 'discovery', 'codebaseAnalysis', {
+          schema: 'bitcode.debug.fast-discovery.codebase-analysis',
+          skipped: true,
+        });
+        return passthroughInput;
+      },
+    );
+  }
+  if (stopFilter && targetsSearch && !targetsRegurgitation) {
+    (execution as any).agents?.registerAgent?.(
+      DISCOVERY_INHERENT_REGURGITATION,
+      async (passthroughInput: any, exec: any) => {
+        storeCrossPhaseArtifact(exec, 'discovery', 'inherentRegurgitation', {
+          schema: 'bitcode.debug.fast-discovery.regurgitation',
+          summary:
+            'Fast Discovery: InherentRegurgitation skipped for depository-search progressive QA.',
+          relevantKnowledge: [],
+          patterns: [],
+          references: [],
+        });
+        return passthroughInput;
+      },
+    );
+  }
+
   // Wave 1 parallel → wave 2 depository relevants search (uses comprehension).
   // Progressive Discovery QA: BITCODE_DEBUG_DISCOVERY_SERIAL=1 (or SETUP_SERIAL)
   // runs wave-1 agents sequentially so agent-filter hard-stops do not race the
@@ -176,7 +237,7 @@ export const depositDiscoveryPhase: ExecutionPipelineSDIVFExecutionPhaseDelegato
   return await exec(input, execution);
 }) as unknown as ExecutionPipelineSDIVFExecutionPhaseDelegator<SetupOutput, DiscoveryOutput>;
 
-export const depositImplementationPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<
+export const executionPipelineSDIVFSynthesizeDepositAssetPacksImplementationPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<
   DiscoveryOutput,
   ImplementationOutput
 > = (async (input: any, execution: any) => {
@@ -190,7 +251,7 @@ export const depositImplementationPhase: ExecutionPipelineSDIVFExecutionPhaseDel
 }) as unknown as ExecutionPipelineSDIVFExecutionPhaseDelegator<DiscoveryOutput, ImplementationOutput>;
 
 /** Single Validation agent: prior phases + pack quality + obfuscations. */
-export const depositValidationPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<
+export const executionPipelineSDIVFSynthesizeDepositAssetPacksValidationPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<
   ImplementationOutput,
   ValidationOutput
 > = (async (input: any, execution: any) => {
@@ -208,7 +269,7 @@ export const depositValidationPhase: ExecutionPipelineSDIVFExecutionPhaseDelegat
 }) as unknown as ExecutionPipelineSDIVFExecutionPhaseDelegator<ImplementationOutput, ValidationOutput>;
 
 /** Finish: store-artifacts → ledgerize → finish-synthesize-deposit-run. */
-export const depositFinishPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<ValidationOutput, AssetPackOutput> = (async (
+export const executionPipelineSDIVFSynthesizeDepositAssetPacksFinishPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<ValidationOutput, AssetPackOutput> = (async (
   input: any,
   execution: any,
 ) => {
@@ -236,10 +297,10 @@ export const depositFinishPhase: ExecutionPipelineSDIVFExecutionPhaseDelegator<V
   return await exec(input, execution);
 }) as unknown as ExecutionPipelineSDIVFExecutionPhaseDelegator<ValidationOutput, AssetPackOutput>;
 
-export const depositPhases = {
-  setup: depositSetupPhase,
-  discovery: depositDiscoveryPhase,
-  implementation: depositImplementationPhase,
-  validation: depositValidationPhase,
-  finish: depositFinishPhase,
+export const executionPipelineSDIVFSynthesizeDepositAssetPacksPhaseDelegators = {
+  setup: executionPipelineSDIVFSynthesizeDepositAssetPacksSetupPhase,
+  discovery: executionPipelineSDIVFSynthesizeDepositAssetPacksDiscoveryPhase,
+  implementation: executionPipelineSDIVFSynthesizeDepositAssetPacksImplementationPhase,
+  validation: executionPipelineSDIVFSynthesizeDepositAssetPacksValidationPhase,
+  finish: executionPipelineSDIVFSynthesizeDepositAssetPacksFinishPhase,
 };

packages/asset-packs-pipelines/syntheses/domain/src/__tests__/synthesize-asset-packs-phase-rosters.test.ts

@@ -3,8 +3,8 @@
  * Deposit / read SDIVF phase rosters (V48).
  *
  * Separate product pipelines (no unified lensed roster):
- *   - depositPhases from phases/deposit-phases
- *   - readPhases from phases/read-phases
+ *   - executionPipelineSDIVFSynthesizeDepositAssetPacksPhaseDelegators from phases/execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators
+ *   - executionPipelineSDIVFSynthesizeReadAssetPacksPhaseDelegators from phases/execution-pipeline-sdivf-synthesize-read-asset-packs-phase-delegators
  *
  * These tests pin:
  *  1. per-phase agent ROSTER each product registers (keys + modules), and
@@ -25,17 +25,17 @@ import { registerImplementationAgents } from '../phases/implementation';
 import { registerValidationAgentsForType } from '../phases/validation';
 import { registerFinishAgentsForType } from '../phases/finish';
 import {
-  depositDiscoveryPhase,
-  depositImplementationPhase,
-  depositValidationPhase,
-  depositFinishPhase,
-} from '../../../deposit/src/phases/deposit-phases';
+  executionPipelineSDIVFSynthesizeDepositAssetPacksDiscoveryPhase,
+  executionPipelineSDIVFSynthesizeDepositAssetPacksImplementationPhase,
+  executionPipelineSDIVFSynthesizeDepositAssetPacksValidationPhase,
+  executionPipelineSDIVFSynthesizeDepositAssetPacksFinishPhase,
+} from '../../../deposit/src/phases/execution-pipeline-sdivf-synthesize-deposit-asset-packs-phase-delegators';
 import {
-  readDiscoveryPhase,
-  readImplementationPhase,
-  readValidationPhase,
-  readFinishPhase,
-} from '../../../read/src/phases/read-phases';
+  executionPipelineSDIVFSynthesizeReadAssetPacksDiscoveryPhase,
+  executionPipelineSDIVFSynthesizeReadAssetPacksImplementationPhase,
+  executionPipelineSDIVFSynthesizeReadAssetPacksValidationPhase,
+  executionPipelineSDIVFSynthesizeReadAssetPacksFinishPhase,
+} from '../../../read/src/phases/execution-pipeline-sdivf-synthesize-read-asset-packs-phase-delegators';
 
 import depositCodebaseComprehensionAgent from '../../../deposit/src/agents/discovery/deposit-codebase-comprehension-agent';
 import depositDepositorySearchAgent from '../../../deposit/src/agents/discovery/deposit-depository-search-agent';
@@ -268,7 +268,7 @@ describe('product phase delegators execute the roster (execution-tree walk)', ()
     const { calls, root } = harness(DEPOSIT_DISCOVERY_KEYS);
     const phaseExec = root.child('seq-2');
 
-    await depositDiscoveryPhase({ seed: true }, phaseExec);
+    await executionPipelineSDIVFSynthesizeDepositAssetPacksDiscoveryPhase({ seed: true }, phaseExec);
 
     expect(calls).toHaveLength(3);
     // Wave 1 (either order) then wave 2 search last.
@@ -281,7 +281,7 @@ describe('product phase delegators execute the roster (execution-tree walk)', ()
   it('read discovery: parallel(comprehend, regurgitation) then read-need-fits search', async () => {
     const { calls, root } = harness(READ_DISCOVERY_KEYS);
 
-    await readDiscoveryPhase({ seed: true }, root.child('seq-2'));
+    await executionPipelineSDIVFSynthesizeReadAssetPacksDiscoveryPhase({ seed: true }, root.child('seq-2'));
 
     expect(calls).toHaveLength(3);
     expect(new Set(calls.slice(0, 2))).toEqual(
@@ -292,39 +292,39 @@ describe('product phase delegators execute the roster (execution-tree walk)', ()
 
   it('deposit implementation resolves deposit-asset-pack-synthesis', async () => {
     const { calls, root } = harness([DEPOSIT_IMPLEMENTATION_KEY]);
-    const output = await depositImplementationPhase({ seed: true }, root.child('seq-2'));
+    const output = await executionPipelineSDIVFSynthesizeDepositAssetPacksImplementationPhase({ seed: true }, root.child('seq-2'));
     expect(calls).toEqual([DEPOSIT_IMPLEMENTATION_KEY]);
     expect(output[`ran:${DEPOSIT_IMPLEMENTATION_KEY}`]).toBe(true);
   });
 
   it('read implementation resolves read-asset-pack-synthesis', async () => {
     const { calls, root } = harness([READ_IMPLEMENTATION_KEY]);
-    const output = await readImplementationPhase({ seed: true }, root.child('seq-2'));
+    const output = await executionPipelineSDIVFSynthesizeReadAssetPacksImplementationPhase({ seed: true }, root.child('seq-2'));
     expect(calls).toEqual([READ_IMPLEMENTATION_KEY]);
     expect(output[`ran:${READ_IMPLEMENTATION_KEY}`]).toBe(true);
   });
 
   it('deposit validation runs the single ready-to-finish deposit gate', async () => {
     const { calls, root } = harness([DEPOSIT_VALIDATION_KEY]);
-    await depositValidationPhase({ seed: true }, root.child('seq-2'));
+    await executionPipelineSDIVFSynthesizeDepositAssetPacksValidationPhase({ seed: true }, root.child('seq-2'));
     expect(calls).toEqual([DEPOSIT_VALIDATION_KEY]);
   });
 
   it('read validation runs the single ready-to-finish read gate', async () => {
     const { calls, root } = harness([READ_VALIDATION_KEY]);
-    await readValidationPhase({ seed: true }, root.child('seq-2'));
+    await executionPipelineSDIVFSynthesizeReadAssetPacksValidationPhase({ seed: true }, root.child('seq-2'));
     expect(calls).toEqual([READ_VALIDATION_KEY]);
   });
 
   it('deposit finish runs store → ledgerize → finish-synthesize-deposit-run', async () => {
     const { calls, root } = harness(DEPOSIT_FINISH_KEYS);
-    await depositFinishPhase({ seed: true }, root.child('seq-3'));
+    await executionPipelineSDIVFSynthesizeDepositAssetPacksFinishPhase({ seed: true }, root.child('seq-3'));
     expect(calls).toEqual(DEPOSIT_FINISH_KEYS);
   });
 
   it('read finish runs store → ledgerize → finish-synthesize-read-run', async () => {
     const { calls, root } = harness(READ_FINISH_KEYS);
-    await readFinishPhase({ seed: true }, root.child('seq-3'));
+    await executionPipelineSDIVFSynthesizeReadAssetPacksFinishPhase({ seed: true }, root.child('seq-3'));
     expect(calls).toEqual(READ_FINISH_KEYS);
   });
 });

packages/asset-packs-pipelines/syntheses/domain/src/index.ts

@@ -44,7 +44,7 @@ export * from './embedding-config';
 export * from './resolve-source-checkout-catalog';
 
 // Phase builders shared by both products (setup/discovery helpers).
-// Product rosters (depositPhases / readPhases) live on the product packages —
+// Product rosters (executionPipelineSDIVFSynthesizeDepositAssetPacksPhaseDelegators / executionPipelineSDIVFSynthesizeReadAssetPacksPhaseDelegators) live on the product packages —
 // do not re-export them here (package cycle).
 export * from './phases/setup';
 export * from './phases/discovery';