V29 Gate 5: Guard AssetPack disclosure rights

Define package-owned AssetPackDisclosureReview, leakage checks, and source-safe preview persistence for postprocess and sandbox harness evidence.

Render disclosure review in Terminal, extend BTD access boundary coverage, document Gate 5 parity, and enforce version/gate-prefixed PR titles in gate CI.

Author: geraldarthurdavis

.github/pull_request_template.md

@@ -0,0 +1,11 @@
+## Title
+
+Use the version and gate prefix for gate PRs: `V29 Gate N: Concise Topical Title`.
+Use the version and promotion prefix for version promotion PRs: `V29: Promote Canon`.
+
+## Closure
+
+- Gate:
+- Acceptance criteria closed:
+- Tests/checks run:
+- Accepted boundaries:

.github/workflows/bitcode-gate-quality.yml

@@ -38,6 +38,23 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
 
+      - name: Validate gate pull request title
+        if: github.event_name == 'pull_request'
+        env:
+          PR_BASE_REF: ${{ github.base_ref }}
+          PR_HEAD_REF: ${{ github.head_ref }}
+          PR_TITLE: ${{ github.event.pull_request.title }}
+        run: |
+          if [[ "$PR_BASE_REF" == version/* && "$PR_HEAD_REF" =~ ^v([0-9]+)/gate-([0-9]+)- ]]; then
+            expected_version="V${BASH_REMATCH[1]}"
+            expected_gate="${BASH_REMATCH[2]}"
+            if [[ ! "$PR_TITLE" =~ ^${expected_version}[[:space:]]+Gate[[:space:]]+${expected_gate}:[[:space:]].+ ]]; then
+              echo "Gate pull request titles must begin with: ${expected_version} Gate ${expected_gate}:"
+              echo "Observed: ${PR_TITLE}"
+              exit 1
+            fi
+          fi
+
       - name: Validate draft canon posture
         run: |
           test "$(cat BITCODE_SPEC.txt)" = "V28"
@@ -49,6 +66,7 @@ jobs:
           node scripts/check-v29-gate2-terminal-transaction-read-models.mjs --skip-branch-check
           node scripts/check-v29-gate3-wallet-signer-btc-operations.mjs --skip-branch-check
           node scripts/check-v29-gate4-reading-pipeline-observability.mjs --skip-branch-check
+          node scripts/check-v29-gate5-assetpack-disclosure-rights.mjs --skip-branch-check
 
       - name: Validate source casing and imports
         run: |
@@ -65,8 +83,10 @@ jobs:
         run: |
           pnpm --filter @bitcode/btd test
           pnpm --filter @bitcode/btd test -- --runTestsByPath __tests__/btc-fee-operation.test.ts
+          pnpm --filter @bitcode/btd test -- --runTestsByPath __tests__/btd.test.ts
           pnpm --filter @bitcode/pipeline-asset-pack exec jest --config jest.config.cjs --passWithNoTests --forceExit
           pnpm --filter @bitcode/pipeline-asset-pack exec jest --config jest.config.cjs --runTestsByPath src/__tests__/reading-pipeline-observability.test.ts src/__tests__/reading-pipeline-contract.test.ts --runInBand
+          pnpm --filter @bitcode/pipeline-asset-pack exec jest --config jest.config.cjs --runTestsByPath src/__tests__/asset-pack-disclosure.test.ts src/__tests__/postprocess.test.ts src/__tests__/read-need.test.ts --runInBand
           pnpm --filter @bitcode/pipeline-hosts exec jest --config jest.config.cjs --passWithNoTests --forceExit
 
       - name: Test staged Reading route and Terminal harness contracts

AGENTS.md

@@ -5,6 +5,7 @@
 - Do not consider any legacy code. All legacy code is located under `_legacy/`.
 - Highest caliber software engineering crafstmanship (maintainibility, abstractions, architectures, naming, patterns, comments, documentation, structures, algorithmic and data flow designs, UI/UX, etc.), correctness (specification and implementation precision, reliability, completeness, boundaried, scoped, encapsulated, etc.), and auditable (totalistic proofs systems from static code, build time, runtime, etc. etc. as is Bitcode, tests from unit, integration, E2E, linting and building, etc.).
 - Do not push work directly to `main`. Create a version base branch for each draft target, such as `version/v28`, then create scoped gate branches from that version branch. Gate branches must be prefixed with the gate number, such as `v28/gate-3-read-fit-workflow` or `v28/gate-8-promotion-proof`. Pull-request each closed gate back into the version branch. Pull-request the version branch into `main` only when all gates are closed and the version is formally promoted as canon. The default branch is protected by the `Bitcode Core Contributions` ruleset and requires pull requests plus verified signatures.
+- Gate pull request titles must begin with the uppercase version and gate prefix, followed by a concise topical title, for example `V29 Gate 5: AssetPack Disclosure Rights And Preview Depth`. Version-promotion pull requests must begin with the uppercase version and name canonical promotion.
 - Once implementation starts on a gate branch, do not stop at partial progress unless blocked by missing external input or explicit user pause. A gate branch is ready to stop only when the gate's acceptance criteria are implemented, specified, tested, documented, committed, pushed, and pull-requested for closure into the version branch.
 - Treat gate and promotion workflow health as part of gate closure. Gate pull requests into version branches must be green through the maintained gate-quality checks, and repository-wide canon-quality checks must remain greenable during draft work. Version pull requests into `main` must pass the version promotion workflow, which performs promotion-grade validations and commits the standalone `BITCODE_SPEC.txt` pointer change only after those validations pass.
 - Keep CI greenable rather than ceremonial. Required application CI uses root pnpm workspace installation and maintained uapi lint/typecheck/build/Jest coverage. Heavy legacy scans such as full DB/browser E2E, Storybook build, super-linter, and advanced CodeQL are opt-in by repository variables until their backing catalogs and service assumptions are maintained for required branch protection.

BITCODE_SPEC_V29.md

@@ -301,6 +301,27 @@ Failure to observe prompt, raw-output, parsed-output, or tool telemetry in a run
 - Current validating commands and parity basis: synthesis tests, source-leakage tests, route tests, PR delivery mocks/live checks, and V29 gate checks.
 - Current accepted boundaries: full mainnet value delivery remains approval-gated.
 
+#### V29 AssetPack disclosure rights canon
+
+AssetPack disclosure is a first-class review object, not an incidental UI summary.
+The preview before payment may show Need measurements, Finding Fits measurements, candidate ids, roots, score band, fee quote, range projection, access policy hash, and delivery target.
+It must not show protected source content, the full patch, source-bearing manifest entries, or licensed read payload before the paid unlock is proven.
+
+The disclosure review contract carries:
+
+- `AssetPackSourceSafePreview`, which remains the source-safe preview envelope;
+- `AssetPackDisclosureReview`, which binds preview id, AssetPack id, read-right state, source visibility, reader action, policy fields, range projection, roots, and protected-source leakage findings;
+- owner-read, licensed-read, denied, and pending-settlement distinctions from BTD access primitives;
+- paid unlock state from settlement readback;
+- leakage review that fails closed when patch markers, source-code markers, or forbidden source-bearing fields appear in preview metadata.
+
+Terminal must render disclosure review as an ordinary Reading stage surface.
+Collapsed view shows visibility, reader action, policy root, review root, visible/withheld counts, leakage state, and source unlock state.
+Expanded views may show the review metadata and roots, but they still may not reveal protected source before settlement.
+
+Gate pull request titles are part of the same operator-quality posture.
+Gate PRs into version branches must begin with the uppercase version and gate prefix, for example `V29 Gate 5: AssetPack Disclosure Rights And Preview Depth`, so gate history stays auditable from GitHub alone.
+
 ### Identity, authorization, and sensitive flow
 
 - Current canonical objects and emitted artifacts: wallet identity, signer session, GitHub connection, organization role, read-license, access-policy decision, permission proof.

BITCODE_SPEC_V29_DELTA.md

@@ -126,6 +126,16 @@ Closure acceptance:
 
 Gate 5 owns AssetPack range detail, owner-read/licensed-read/denied-state flows, source-safe preview, disclosure policy review, paid unlock state, and protected-source leakage tests.
 
+Closure acceptance:
+
+- `@bitcode/pipeline-asset-pack` exposes `AssetPackDisclosureReview` as the first-class review object between source-safe preview and paid source unlock.
+- The disclosure review binds preview id, AssetPack id, BTD read-right state, source visibility, reader action, policy fields, range projection, proof roots, fee quote root, and protected-source leakage review.
+- Protected source leakage detection fails closed for source-bearing field names, patch markers, and source-code markers inside pre-settlement preview metadata.
+- AssetPack postprocessing and the Vercel Sandbox harness store `assetPackDisclosureReview`, `asset-pack/preview.disclosureReview`, and `asset-pack/preview.disclosureReviewRoot` alongside source-safe preview evidence.
+- BTD tests cover owner-read, licensed-read, and denied-state boundaries so paid unlock cannot blur ownership, license, and denial semantics.
+- Terminal renders disclosure review as part of the source-safe preview surface with visibility, reader action, policy root, review root, visible/withheld counts, leakage state, and source unlock state before raw evidence.
+- Gate-quality CI enforces focused disclosure tests and gate PR titles beginning with the uppercase version and gate prefix, such as `V29 Gate 5: AssetPack Disclosure Rights And Preview Depth`.
+
 ### Gate 6: Settlement Reconciliation And Repair
 
 Gate 6 owns ledger/database/metaphysical separation, journal diffing, reconciliation repair actions, proof-root surfacing, settlement conservation drift handling, and delivery recovery.

BITCODE_SPEC_V29_NOTES.md

@@ -134,6 +134,23 @@ Accepted Gate 4 posture:
 - Terminal's live harness stream shows pipeline, phase id, PTRR agent, PTRR step, ThricifiedGeneration, prompt, tool, output schema, raw output posture, and parsed typed output posture through the shared execution log components.
 - Gate 4 does not implement disclosure-depth unlock, settlement repair, organization authority, or full browser proof; later gates own those slices.
 
+## Gate 5 working notes
+
+Gate 5 makes AssetPack disclosure a package-owned contract instead of a Terminal-only summary.
+The Reading pipeline may synthesize the AssetPack and compute its measurements before payment, but protected source remains withheld until the BTD read-right state and settlement unlock prove that the reader owns or is licensed to read the AssetPack source.
+
+Accepted Gate 5 posture:
+
+- `AssetPackSourceSafePreview` remains the pre-payment preview envelope.
+- `AssetPackDisclosureReview` binds source visibility, reader action, policy roots, range projection, fee quote root, and protected-source leakage review to that preview.
+- Source visibility has distinct `withheld_before_settlement`, `available_after_settlement`, and `denied` states.
+- Reader action has distinct `pay_to_unlock`, `read_as_owner`, `read_as_licensee`, and `blocked` states.
+- Leakage review scans preview metadata for source-bearing field names, patch markers, and source-code markers and fails closed before the preview is shown.
+- Postprocessing and the sandbox harness store disclosure review evidence next to source-safe preview evidence so database/ledger readback can explain paid unlock state without exposing protected source.
+- Terminal renders disclosure review as the ordinary Reading preview surface and keeps expandable raw metadata behind the same source-safe boundary.
+- Gate pull request titles must carry the uppercase version and gate prefix so gate closure can be audited from GitHub history.
+- Gate 5 does not implement reconciliation repair, organization authority, full settlement UI depth, or browser proof; later V29 gates own those slices.
+
 ## Later-version boundaries
 
 - V30 remains reserved for Protocol/BTD hardening that is not necessary to close Terminal transaction depth.

BITCODE_SPEC_V29_PARITY_MATRIX.md

@@ -52,7 +52,7 @@ No `_legacy/` source is active source truth.
 | Terminal transaction read models | Gate 2 | `uapi/app/terminal/terminal-transaction-read-model.ts`, `uapi/app/terminal/terminal-transaction-query.ts`, `TerminalTransactionWorkspace.tsx`, `TerminalTransactionDetailSurface.tsx`, UAPI tests, Gate 2 checker | drafted | Terminal transaction state is URL-addressable, recoverable, typed, low-detail by default, and expandable without raw JSON as the ordinary operator contract. |
 | Wallet signer/BTC operations | Gate 3 | `packages/btd/src/btc-fee-operation.ts`, BTC fee route, Terminal Wallet/BTC detail section, BTD and UAPI tests, Gate 3 checker | drafted | Signer session, PSBT, broadcast/finality/reorg/replacement/failure states are ordinary Terminal states. |
 | Reading pipeline observability | Gate 4 | `packages/pipelines/asset-pack/src/reading-pipeline-observability.ts`, `packages/pipeline-hosts/src/asset-pack-harness.ts`, Terminal stream components, Gate 4 checker | drafted | Pipeline/phase/PTRR/ThricifiedGeneration/tool/prompt/raw-output/parsed-output telemetry is contract-projected, complete, and readable. |
-| AssetPack disclosure rights | Gate 5 | BTD access primitives, AssetPack preview UI, disclosure policy tests | pending | Source-safe preview and paid unlock are proven without source leakage. |
+| AssetPack disclosure rights | Gate 5 | `asset-pack-disclosure.ts`, AssetPack postprocess, sandbox harness, BTD access tests, Terminal disclosure review UI, Gate 5 checker | drafted | Source-safe preview and paid unlock are proven without protected-source leakage. |
 | Settlement reconciliation repair | Gate 6 | BTD journal/reconciliation, Supabase readback, Terminal repair UI | pending | Ledger, database, and metaphysical state drift is visible and repairable. |
 | Organization permission authority | Gate 7 | access policy, org holdings, MCP/ChatGPT gates, Terminal permission UI | pending | Registry-derived roles, holdings, and read-license authority govern actions. |
 | Commercial formalization | Gate 8 | packages/protocol, package tests, import scans, docs | pending | Demonstration-origin commercial internals are package-native and no runtime demo imports remain. |
@@ -70,7 +70,8 @@ No `_legacy/` source is active source truth.
 | Gate 2 read model | `pnpm run check:v29-gate2` proves typed route-owned Terminal transaction reading | drafted |
 | Gate 3 wallet/BTC operation | `pnpm run check:v29-gate3` proves quote lifecycle, signer recovery, blocked readiness, API posture, and Terminal Wallet/BTC detail | drafted |
 | Gate 4 Reading observability | `pnpm run check:v29-gate4` proves contract-aware Reading stream telemetry and Terminal rendering | drafted |
-| Product implementation gates | Gates 3-9 close remaining Terminal transaction depth with tests and docs | pending |
+| Gate 5 AssetPack disclosure | `pnpm run check:v29-gate5` proves source-safe disclosure review, leakage detection, Terminal preview rendering, and PR title enforcement | drafted |
+| Product implementation gates | Gates 6-9 close remaining Terminal transaction depth with tests and docs | pending |
 | Promotion gate | Gate 10 closes generated proof and promotion automation | pending |
 
 ## Gate 1 Parity
@@ -163,3 +164,28 @@ Gate 3 is complete when package primitives model BTC quotes, signer recovery, op
 ## Gate 4 completion condition
 
 Gate 4 is complete when Reading pipeline observability is package-owned, stream events are contract-projected in the sandbox harness, Terminal renders the projection through shared execution components, focused package and UAPI tests pass, `check:v29-gate4` passes, CI invokes the checker and tests, docs name the implemented source surfaces, and the gate branch is committed and pushed for review into `version/v29`.
+
+## Gate 5 Parity
+
+| Requirement | Source evidence | Current V29 judgment |
+| --- | --- | --- |
+| AssetPack disclosure review is package-owned | `asset-pack-disclosure.ts`, package exports, disclosure tests | drafted |
+| Source visibility separates pending, paid, owner, licensee, and denied states | `buildAssetPackDisclosureReview`, BTD access tests | drafted |
+| Protected source leakage fails closed before preview display | `reviewAssetPackProtectedSourceLeakage`, `assertAssetPackDisclosureSourceSafe`, disclosure tests | drafted |
+| Postprocessing persists disclosure review and review root | `postprocess.ts`, postprocess tests | drafted |
+| Sandbox harness stores and exports disclosure review evidence | `packages/pipeline-hosts/src/asset-pack-harness.ts`, harness tests | drafted |
+| Terminal preview surface renders disclosure policy before raw evidence | `TerminalDepositReadWorkbench.tsx`, Terminal harness client tests | drafted |
+| Gate PR title enforcement is automated | `.github/workflows/bitcode-gate-quality.yml`, PR template, AGENTS/README instructions | drafted |
+| Gate 5 checker is wired to package scripts and CI | `scripts/check-v29-gate5-assetpack-disclosure-rights.mjs`, `package.json`, gate workflow | drafted |
+
+## Gate 5 accepted boundaries
+
+- Gate 5 does not reveal protected AssetPack source before settlement.
+- Gate 5 does not perform settlement reconciliation repair; Gate 6 owns ledger/database drift and repair.
+- Gate 5 does not implement organization authority beyond read-right state distinctions; Gate 7 owns registry-derived roles and holdings.
+- Gate 5 does not add browser proof or full UX polish; Gate 9 owns that surface.
+- Gate 5 does not add versioned API routes or source identifiers.
+
+## Gate 5 completion condition
+
+Gate 5 is complete when AssetPack disclosure review is package-owned, postprocess and sandbox harness evidence include source-safe disclosure review roots, protected-source leakage tests fail closed, Terminal renders the disclosure review through the Reading preview surface, gate PR title enforcement is active, focused package and UAPI tests pass, `check:v29-gate5` passes, CI invokes the checker and tests, docs name the implemented source surfaces, and the gate branch is committed and pushed for review into `version/v29`.

README.md

@@ -51,6 +51,8 @@ Use a version branch and gate-numbered branches:
    implemented, specified, tested, documented, committed, pushed, and ready for
    closure review.
 5. Open pull requests from gate branches into the version branch as gates close.
+   Title gate PRs with the uppercase version and gate prefix plus a topical
+   title, for example `V29 Gate 5: AssetPack Disclosure Rights And Preview Depth`.
 6. Open the version branch back into `main` only after all gates close and the
    version is formally promoted as canon.
 

package.json

@@ -48,6 +48,7 @@
     "check:v29-gate2": "node scripts/check-v29-gate2-terminal-transaction-read-models.mjs",
     "check:v29-gate3": "node scripts/check-v29-gate3-wallet-signer-btc-operations.mjs",
     "check:v29-gate4": "node scripts/check-v29-gate4-reading-pipeline-observability.mjs",
+    "check:v29-gate5": "node scripts/check-v29-gate5-assetpack-disclosure-rights.mjs",
     "check:spec-quality": "node scripts/run-bitcode-spec-quality.mjs --mode basic",
     "check:spec-quality:title": "node scripts/run-bitcode-spec-quality.mjs --mode strict-from-title",
     "check:spec-quality:v24": "node scripts/run-bitcode-spec-quality.mjs --mode strict-version --version V24",