Skip to content

Commit 0567ef0

Browse files
V48 (impl-only): Ease metric chip gap and stop value cutoff
Restore modest label-value spacing and drop truncate so stage values like CONNECT SOURCE render in full.
1 parent e388de0 commit 0567ef0

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

apps/uapi/components/bitcode/routes/ProductChipSkeletonRow/ProductChipSkeletonRow.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ const DEFAULT_SPECS: ProductChipSkeletonSpec[] = [
3131
export const PRODUCT_METRIC_CHIP_ROW_CLASS =
3232
'flex h-7 w-full max-w-full flex-nowrap items-center gap-1.5 overflow-x-auto overflow-y-hidden [scrollbar-width:none] [&::-webkit-scrollbar]:hidden';
3333

34-
/** Tight label↔value pair; chip-to-chip spacing lives on the row. */
34+
/** Label↔value pair; modest gap (not UA dd margin / space-between). */
3535
export const PRODUCT_METRIC_CHIP_SHELL_CLASS =
36-
'flex h-7 min-w-0 shrink-0 items-center gap-0.5 border border-white/10 bg-white/[0.045] px-2';
36+
'flex h-7 min-w-0 shrink-0 items-center gap-1.5 border border-white/10 bg-white/[0.045] px-2';
3737

3838
type ProductChipSkeletonRowProps = {
3939
/** Number of chip placeholders (defaults to specs length). */

apps/uapi/components/bitcode/routes/ProductRouteShell/ProductRouteShell.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -186,10 +186,10 @@ function ProductRouteMetricChips({
186186
}) {
187187
const reduceMotion = shouldReduceMetricMotion(useReducedMotion());
188188

189-
// Content-sized value; UA stylesheet gives `dd` a large margin-inline-start
190-
// which looked like space-between — always reset dt/dd margins.
189+
// Content-sized value (no truncate — e.g. CONNECT SOURCE must fully show).
190+
// UA stylesheet gives `dd` a large margin-inline-start — always reset.
191191
const valueClass =
192-
"inline-block max-w-[6.5rem] truncate text-left text-[0.7rem] font-semibold leading-none tabular-nums text-white";
192+
"inline-block whitespace-nowrap text-left text-[0.7rem] font-semibold leading-none tabular-nums text-white";
193193

194194
const chips = metrics.map((metric) => {
195195
const valueSlot = !ready ? (
@@ -214,7 +214,7 @@ function ProductRouteMetricChips({
214214
const chipBody = (
215215
<>
216216
<dt className="m-0 leading-none text-neutral-500">{metric.label}</dt>
217-
<dd className="m-0 flex min-w-0 shrink-0 items-center p-0">
217+
<dd className="m-0 flex shrink-0 items-center p-0">
218218
{valueSlot}
219219
</dd>
220220
</>

0 commit comments

Comments
 (0)