Skip to content

Remove node_modules from watcher exclusions #88

@kerwanp

Description

@kerwanp

Problem

There is a regression since watcher has been moved to the assembler as node_modules are fully ignored impacting the developer experience when working in a mono-repository setup.

In a Yarn mono-repository, workspaces are symlinked inside node_modules, allowing other workspaces to depend on them by using classic module resolving. By watching node_modules it would notify hot-hook about changes done inside a package of the mono-repository and perform reload if it is part of the dependency tree.

It was also useful in classic repositories as installing new packages would also trigger a reload (it now requires a manual restart/reload) or when manually editing files in node_modules for debugging.

Solution

node_modules should not be ignored and in fact should notify hot-hook about changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions