-
Notifications
You must be signed in to change notification settings - Fork 32
fix: include URL in api list --json output #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1a1b011
fix: include URL in api list --json output
shazron 9ef0ca1
fix: populate x-openwhisk.url in api list --json output
shazron 5432232
test: add coverage for operation without x-openwhisk in api list --json
shazron b293ebb
Merge branch 'master' into fix/api-list-json-url
shazron d720068
Potential fix for pull request finding
shazron 1a89276
Update src/commands/runtime/api/list.js
shazron 354b348
Update src/commands/runtime/api/list.js
shazron 9262b84
test: add coverage for --json flag with empty apis result
Copilot c564b4f
fix: clean up duplicate declarations in --json branch of api list
Copilot aa2b8a3
Update src/commands/runtime/api/list.js
shazron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code has multiple critical bugs: (1) The early return
returnis placed inside theif (!api || !api.value)block but the closing brace is wrong — the return is actually outside the if, so execution falls through and tries to accessapi.value.apidocwhen api is falsy. (2) There is a strayObject.keys(apidoc.paths || {}).forEachblock that referencesapidocbefore it is declared, causing a ReferenceError. (3) The closingreturnafterthis.logJSON('', {})is missing, so on empty apis the code will crash. The entire block needs to be rewritten correctly.