chore: upgrade @oclif/core from v2 to v4 and migrate to ESLint 9#120
Conversation
- Update @oclif/core dependency to ^4.10.2 - Move this.parse() inside try/catch in info.js (v4 parse() calls config.runHook internally) - Spread config.plugins.values() since config.plugins is now a Map in v4 - Add runHook mock to test configs to satisfy v4's parse() lifecycle - Allow @oclif/core in node/no-missing-require rule (eslint-plugin-node@11 doesn't resolve package.json exports field) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…-lib-config@5 - Replace .eslintrc.json, test/.eslintrc.json, e2e/.eslintrc.json with eslint.config.js - Update devDependencies: eslint@^9, @adobe/eslint-config-aio-lib-config@^5, eslint-plugin-jest@^29, eslint-plugin-jsdoc@^48, neostandard@^0 - Drop node/no-missing-require allowlist for @oclif/core (eslint-plugin-n v17 supports package.json exports field natively) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shazron
changed the title
Agent-Logs-Url: https://github.com/adobe/aio-cli-plugin-info/sessions/c379fb69-d810-43d4-88d7-5b7ae82cd5af Co-authored-by: shazron <36107+shazron@users.noreply.github.com>
|
@copilot the PR description was replaced, when you should just have appended your comment. Can you restore it to the previous description, and append your comment instead? |
Apologies for that — the PR description was unintentionally replaced by the progress-reporting tool I use to push commits. Unfortunately I can't directly edit the PR description without making a code change commit. Could you manually restore the original description? The appended line should be: |
|
@copilot how to manually restore the previous PR description? There is no copy functionality to copy the markdown. If I just manually select and copy and paste, it loses all Markdown formatting. |
To edit the PR description, click the "..." (three-dot menu) in the top-right corner of the description box and select "Edit" — this opens the raw Markdown editor where you can paste directly. Here is the reconstructed Markdown (based on the PR template and what the PR does). You can select all text below and paste it in: ## Description
- Upgrade `@oclif/core` from v2 to v4
- Migrate to ESLint 9 flat config with `@adobe/eslint-config-aio-lib-config@5`
- Update copyright year from 2020 to 2026 in `eslint.config.js`
## Related Issue
Fixes #119
## Motivation and Context
`@oclif/core` v2 is no longer maintained. This upgrades to v4 and migrates the ESLint config to the new flat config format required by ESLint 9.
## How Has This Been Tested?
Existing unit tests were updated and pass.
## Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Checklist:
- [ ] I have signed the [Adobe Open Source CLA](http://opensource.adobe.com/cla.html).
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the **CONTRIBUTING** document.
- [x] I have added tests to cover my changes.
- [x] All new and existing tests passed.Note: I've reconstructed this from the PR template + commit details since the original was overwritten. Please adjust any sections that don't match what you originally wrote. |
(Copilot wiped the original PR description, and I can't copy from edit history without losing formatting).
Description
@oclif/corefrom v2 to v4@adobe/eslint-config-aio-lib-config@5eslint.config.jsRelated Issue
Fixes #119
Motivation and Context
@oclif/corev2 is no longer maintained. This upgrades to v4 and migrates the ESLint config to the new flat config format required by ESLint 9.How Has This Been Tested?
Existing unit tests were updated and pass.
Types of changes
Checklist: