Skip to content

Default runner image labels appear to be stale #373

@woodruffw

Description

@woodruffw

Describe the bug

Observe here:

export const DEFAULT_RUNNER_LABELS = [

The DEFAULT_RUNNER_LABELS list includes several labels for runners that are no longer available (such as macos-13) and lacks labels for runners that are currently available (such as windows-11-arm).

#183 and #325 appear to be a prior instance of this.

To Reproduce

Write runs-on: windows-11-arm and observe an incorrect warning via the LSP about an unknown runner.

Expected behavior

No warning. More ideally, the set of runners would be sourced from a living, machine-readable source (like a REST API) rather than being manually curated in this repository.

Package/Area

  • Expressions
  • Workflow Parser
  • Language Service
  • Language Server

Package Version

v0.3.58

(Note however that I'm submitting this purely from a code review, I only observed it secondarily by trying the LSP.)

Additional context

I think it'd be really great if there was an official API or other machine-readable source for a list of official GitHub-hosted runners, similarly to how GitHub provides org/enterprise/etc. specific runner-listing APIs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions