Skip to content

chore(flutter): generate CocoaPods files for restaurant_finder macOS client#1589

Open
jacobsimionato wants to merge 2 commits into
a2ui-project:mainfrom
jacobsimionato:fix_format
Open

chore(flutter): generate CocoaPods files for restaurant_finder macOS client#1589
jacobsimionato wants to merge 2 commits into
a2ui-project:mainfrom
jacobsimionato:fix_format

Conversation

@jacobsimionato

Copy link
Copy Markdown
Collaborator

Description

This PR checks in the auto-generated CocoaPods files (Podfile and related .xcconfig configurations) for the restaurant_finder Flutter application's macOS build target.

Rationale

When running scripts/fix_format.sh, the script executes flutter pub get in the Flutter/Dart workspace. On macOS (darwin), this automatically bootstraps and generates the standard CocoaPods configuration files (Podfile, Flutter-Debug.xcconfig, Flutter-Release.xcconfig) for the restaurant_finder/app macOS target. Checking these generated files into the repository ensures that developers building the macOS target have a pre-configured CocoaPods environment and that formatting/getting dependencies remains consistent and clean across all environments.

Description of Changes

  • samples/client/flutter/restaurant_finder/app/macos/Podfile: Added the standard CocoaPods platform setup and runner targets for the macOS application.
  • samples/client/flutter/restaurant_finder/app/macos/Flutter/Flutter-Debug.xcconfig: Appended the target support configuration file include for Pods in Debug mode.
  • samples/client/flutter/restaurant_finder/app/macos/Flutter/Flutter-Release.xcconfig: Appended the target support configuration file include for Pods in Release mode.

Testing/Running Instructions

To test or verify these changes locally on a macOS machine:

  1. Ensure Flutter is installed and configured.
  2. In the repository root, run the formatter/workspace update script:
    ./scripts/fix_format.sh
  3. Verify that the files remain consistent and generated.
  4. (Optional) Run/build the macOS client to verify compiling succeeds:
    cd samples/client/flutter/restaurant_finder/app
    flutter build macos

Pre-launch Checklist

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds CocoaPods configuration for the macOS target of the Flutter restaurant finder sample app, introducing a new Podfile and updating the debug and release xcconfig files. The reviewer recommends running pod install and committing the resulting Podfile.lock to ensure consistent dependency versions across development and CI environments.

@@ -0,0 +1,42 @@
platform :osx, '10.15'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since you are checking in the Podfile for the macOS target, it is highly recommended to also run pod install and commit the resulting Podfile.lock file. Tracking Podfile.lock ensures that all developers and CI environments build with the exact same dependency versions, preventing 'works on my machine' issues and unexpected build failures due to upstream updates.

@github-project-automation github-project-automation Bot moved this from Todo to Done in A2UI Jun 9, 2026
@jacobsimionato jacobsimionato reopened this Jun 9, 2026
@jacobsimionato jacobsimionato requested a review from polina-c June 9, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant