From bdd9d509b1e1afe66094469927a278c6ab8eeedf Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Sun, 31 May 2026 20:39:37 +0000
Subject: [PATCH] Refactor: Use localized strings for foreground service
 notification

Replaces hardcoded, technical terminology (like "Kill") and internal
identifiers (like `CHANNEL_ID`) with localized string resources in the
foreground service notification to improve the user-facing experience.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
---
 .Jules/palette.md                                      |  4 ++++
 .../main/java/com/samsung/android/scan3d/serv/Cam.kt   | 10 +++++-----
 app/src/main/res/values/strings.xml                    |  7 +++++++
 3 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/.Jules/palette.md b/.Jules/palette.md
index 8e61b09..ec551b8 100644
--- a/.Jules/palette.md
+++ b/.Jules/palette.md
@@ -146,3 +146,7 @@
 ## 2026-05-20 - Mouse Hover States for Custom Selectors
 **Learning:** Custom drawable selectors (like `ic_shutter.xml`) on Android often define `state_pressed` and `state_focused` but omit `state_hovered`. This strips visual feedback for users navigating with pointer devices (mice, trackpads) on environments like Chromebooks or Samsung DeX, degrading the user experience compared to native components.
 **Action:** Always include `android:state_hovered="true"` alongside focus and pressed states in custom interactive background selectors to ensure universal visual feedback across all input methods.
+
+## 2026-05-30 - User-Facing Notification Terminology
+**Learning:** Using raw technical identifiers (like `CHANNEL_ID`) as the visible name or description for a `NotificationChannel`, or using hardcoded/aggressive terms (like "Kill" or "Click") in notification actions and text degrades the user experience. These elements are directly exposed to users in system settings and the notification shade.
+**Action:** Never use raw technical identifiers or hardcoded, aggressive terminology in user-facing system notifications or foreground service controls. Always utilize standard mobile UX phrasing (e.g., "Stop", "Tap") and ensure all notification text (titles, descriptions, actions, channel names) is extracted to localized string resources.
diff --git a/app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt b/app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt
index 902764a..bc035cf 100644
--- a/app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt
+++ b/app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt
@@ -45,10 +45,10 @@ class Cam : Service() {
             "start" -> {
                 val channel = NotificationChannel(
                     CHANNEL_ID,
-                    CHANNEL_ID,
+                    getString(R.string.notification_channel_name),
                     NotificationManager.IMPORTANCE_DEFAULT
                 )
-                channel.description = "RemoteCam run"
+                channel.description = getString(R.string.notification_channel_desc)
                 val notificationManager = getSystemService(NotificationManager::class.java)
                 notificationManager.createNotificationChannel(channel)
 
@@ -72,9 +72,9 @@ class Cam : Service() {
 
                 val builder =
                     NotificationCompat.Builder(this, CHANNEL_ID)
-                        .setContentTitle("RemoteCam (active)")
-                        .setContentText("Click to open").setOngoing(true)
-                        .setSmallIcon(R.drawable.ic_linked_camera).addAction(R.drawable.ic_close, "Kill",pendingIntentKill)
+                        .setContentTitle(getString(R.string.notification_title))
+                        .setContentText(getString(R.string.notification_content)).setOngoing(true)
+                        .setSmallIcon(R.drawable.ic_linked_camera).addAction(R.drawable.ic_close, getString(R.string.notification_action_stop),pendingIntentKill)
                         .setContentIntent(pendingIntent)
 
 
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index b34ffb5..682caab 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -69,4 +69,11 @@
     <string name="frame_time_format">%1$d ms</string>
     <string name="bitrate_format">%1$d kB/sec</string>
     <string name="quality_format">%1$d%%</string>
+
+    <!-- Foreground Service Notification Strings -->
+    <string name="notification_channel_name">Camera Service</string>
+    <string name="notification_channel_desc">Active remote camera stream</string>
+    <string name="notification_title">RemoteCam (active)</string>
+    <string name="notification_content">Tap to open</string>
+    <string name="notification_action_stop">Stop</string>
 </resources>