Skip to content

ExtremesSimplifier broken #19

Description

@plepe

I just noticed, the ExtremesSimplifier seems broken. I had a SIMPLIFY_SIZE way larger than the datasize size. The count of values that the interpolate-function received was correct (the datasize size), but one point (i guess the median point) got multiplied (9 times of 33 points total), whereas other points were missing. As I currently don't want to simplify, I just changed to another SIMPLIFY_METHOD which works fine for me.

I guess it would be easier to add all points to a list, sort it and then copy the resulting lowest and highest numbers, like so:

#include
list<Pixel*> dataset_ordered;
list<Pixel*>::iterator dataset_it;

for(int i=0; i<dataset_size; i++)
dataset_ordered.push_back(dataset+i);

dataset_ordered.sort(cmp_function);

Maybe I need it anyway, than I would fix it myself, but I just wanted others to know that there's a problem.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions