Skip to content

[Bug]: Explosive Trap initial blast missing directCoefficient (TBC 10% RAP) #51

Description

@Xerrion

Problem

Data/SpellData_Hunter.lua Explosive Trap (spellID 13813 and ranks) is encoded as a hybrid spell with directCoefficient = 0.00 and dotCoefficient = 0.10. The DoT-side scaling is correct, but the initial blast on trigger should also scale at 10% ranged attack power per the TBC empirical table.

Empirical TBC value

WoWWiki Attack_power_coefficient archive (Hunter > Survival section):

  • Explosive Trap initial blast: 10% RAP (one-time, applied to the direct damage on trigger)
  • Explosive Trap DoT: 10% RAP total over the DoT duration (already correctly stored as 0.10)

The two coefficients are independent and BOTH apply to a single Explosive Trap proc.

Expected fix

Set directCoefficient = 0.10 on the Explosive Trap entries in Data/SpellData_Hunter.lua. The DoT coefficient stays at 0.10. With RAP=2000 this adds 200 damage to the initial blast on top of base.

Discovery context

Found during the AoE coefficient audit for #46 but deliberately excluded from that PR per scope discipline (Explosive Trap is a Hunter trap correction, not an AoE penalty correction in the same vein as the Mage/Druid/Warlock spells).

Acceptance criteria

  • Explosive Trap entry sets directCoefficient = 0.10.
  • A regression test in tests/ pins both directCoefficient and dotCoefficient and asserts Pipeline.Calculate produces the expected combined initial+DoT damage.
  • Source citation comment added.
  • luacheck . clean, busted --verbose passes.

Source

  • WoWWiki Attack_power_coefficient archive (Hunter > Survival table)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions