Skip to content

self.EventList.secondary does not consider all balance changes #4

@zgrguric

Description

@zgrguric

Consider transaction A357FD7C8F0BBE7120E62FD603ACBE98819BC623D5D12BD81AC68564393A7792
from perspective of rhub8VRN55s94qWKDv6jmDy1pUykJzF3wq

self.EventList.secondary displays in this case only first RippleState change (also affects intermediate mutation out)

I propose to summarize all RippleState changes to one, then counterparty must be left NULL (or even better array of r.... counterparties), since multiple accounts participates in that specific balance change assuming all blance changes are of same currency (please confirm this).

Second option is (I do not endorse this): To add full list of balance changes to self.EventList.secondaries, this will create array and remove secondary key which is breaking change - also this can be extracted from balance changes which is already available.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions