Follow-up to #250, which made bundled sounds resolve correctly inside a PyInstaller .app. The sound fix itself is complete; these are packaging items that don't block #250 but should be addressed before any macOS distribution/notarization.
1. bundle_identifier and icon are placeholders
In clients/desktop/PlayPalace.spec, the BUNDLE step has bundle_identifier=None and icon=None. Functionally fine for local builds, but a real reverse-DNS bundle identifier (e.g. com.xgdevgroup.playpalace) and an app icon are needed before notarization/distribution.
2. upx=True may break macOS codesigning
The spec enables UPX compression. UPX has historically corrupted/invalidated macOS binaries and breaks codesigning. Recommend upx=False for Mac builds (or confirm it's intentional and works on the target setup).
3. Build must be run from clients/desktop
datas=[('sounds', 'sounds')] uses a relative source path, so pyinstaller PlayPalace.spec only bundles the sounds when invoked from clients/desktop. Worth a note in build docs (or a comment in the spec) so the sounds folder isn't silently omitted from a build run elsewhere.
Follow-up to #250, which made bundled sounds resolve correctly inside a PyInstaller
.app. The sound fix itself is complete; these are packaging items that don't block #250 but should be addressed before any macOS distribution/notarization.1.
bundle_identifierandiconare placeholdersIn
clients/desktop/PlayPalace.spec, theBUNDLEstep hasbundle_identifier=Noneandicon=None. Functionally fine for local builds, but a real reverse-DNS bundle identifier (e.g.com.xgdevgroup.playpalace) and an app icon are needed before notarization/distribution.2.
upx=Truemay break macOS codesigningThe spec enables UPX compression. UPX has historically corrupted/invalidated macOS binaries and breaks codesigning. Recommend
upx=Falsefor Mac builds (or confirm it's intentional and works on the target setup).3. Build must be run from
clients/desktopdatas=[('sounds', 'sounds')]uses a relative source path, sopyinstaller PlayPalace.speconly bundles the sounds when invoked fromclients/desktop. Worth a note in build docs (or a comment in the spec) so the sounds folder isn't silently omitted from a build run elsewhere.