Fix CPA public navigation and deployment docs#139
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request focuses on improving project documentation, configuration flexibility, and the local development experience. Key changes include a comprehensive reorganization of the README and environment variable examples, the introduction of a configurable CPA_PUBLIC_URL to handle cross-domain navigation, and the addition of a Vite development proxy for the frontend. Additionally, the default Redis queue batch size has been increased to 10,000. A security review identified a potential XSS vulnerability in the URL pattern matching logic used for the 'Back to CPA' link, which should be restricted to safe protocols.
berry-shake
added a commit
to berry-shake/cpa-usage-keeper
that referenced
this pull request
May 23, 2026
Merge 9 upstream commits including: - feat: support public CPA back link URL (Willxup#139) - fix: restrict CPA public URL schemes - fix: proxy api requests in frontend dev server - feat: increase redis queue batch default - docs/chore updates Conflicts resolved: - internal/api/router_test.go: kept fork's TestStatusReturnsForkVersionAndUpdateCheckFlag alongside upstream's CPA public URL tests - web/vite.config.js: took upstream's env-driven proxy target with serve-only guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation