Add a new GroupedBenchmark that runs a series of benchmarks.#133
Merged
kmiller68 merged 4 commits intoAug 14, 2025
Merged
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
camillobruni
approved these changes
Aug 14, 2025
| assert(benchmarks.length); | ||
| for (const benchmark of benchmarks) { | ||
| // FIXME: Tags don't work for grouped tests anyway but if they did then this would be weird and probably wrong. | ||
| assert(benchmark.plan.tags.indexOf("Default") === -1, `Grouped benchmark sub-benchmarks shouldn't have the "Default" tag`, benchmark.tags); |
Contributor
There was a problem hiding this comment.
assert(benchmark.hasAnyTag("default"), ... would be a bit shorter
Use this for all the SunSpider tests. WIP Only note is that `subScores` re-computes everything every time because it's called before the benchmark runs.
kmiller68
force-pushed
the
add-grouped-benchmark-for-sunspider
branch
from
1239b20 to
7b54891
Compare
Contributor
Author
|
@iainireland Thoughts? |
Contributor
|
This seems like a reasonably clean way of accomplishing our goal. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this for all the SunSpider tests.
Grouped benchmarks just run each sub-benchmark in order then report those back. The score is the geomean of each sub-benchmarks analogous score e.g. the geomean of each sub-benchmark's First or Average scores. All the relevant prefetching is just forwarded to the sub-benchmarks
Only note is that
subScoresre-computes everything every time because it's called before the benchmark runs. Also, tags don't seem to work for the sub benchmarks. This didn't seem important enough to fix right now but we should maybe consider in the future.