From 86faaa51398a59bbb43aea2bcf2b8602476a2ece Mon Sep 17 00:00:00 2001 From: VirtualMachinist Date: Wed, 23 Sep 2026 21:32:31 -0400 Subject: [PATCH] fix: G1c drop onFailedToStart, detect failed start via running flag Quickshell 0.3.0 Process has no onFailedToStart property; assigning it refused to load the widget (non-existent property). Removed. A missing geode binary never emits exited: the run stays running=false with pid null. rerun() now checks the flag after running=true and folds Model.statusFromRun(127, "", "") so a set vault path shows the missing-binary reason. onExited stays the only exit fold: refresh(code, collector.text). No exitCode property is read. --- BarWidget.qml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/BarWidget.qml b/BarWidget.qml index ace3448..a30592e 100644 --- a/BarWidget.qml +++ b/BarWidget.qml @@ -41,6 +41,14 @@ Item { } geodeRun.command = Model.listArgs(vaultPath); geodeRun.running = true; + // A missing `geode` binary never emits `exited`: the run stays + // running=false (pid null). That is the failed-to-start shape on + // Quickshell 0.3.0. 127 is + // the not-found code; Model turns it into the missing-binary + // reason instead of leaving the empty-vault status up. + if (!geodeRun.running) { + status = Model.statusFromRun(127, "", ""); + } } onVaultPathChanged: rerun() @@ -60,18 +68,11 @@ Item { } // The single fold point: exit code + the collector text. Exit 0 - // with JSON keeps ok:true. + // with JSON keeps ok:true. Missing-binary runs never reach here + // (no `exited` fires); rerun() catches those via the running flag. onExited: function (code) { root.refresh(code, collector.text); } - - // A missing `geode` binary is QProcess.FailedToStart: no `exited` - // fires, so a set vault path would stay on the empty-vault status. - // 127 is the not-found code; Model turns it into the - // missing-binary reason. - onFailedToStart: { - root.status = Model.statusFromRun(127, "", ""); - } } Row {