[bug] flaky test in src/tool-invoker.test.ts

[jahands]

Executor version

1.6.7

How do you run Executor?

Self-host (Cloudflare)

Operating system

macOS (Apple Silicon)

Integration involved

No response

What happened

My CI runs all your tests and deploys, and I noticed a flaky test. Maybe this test should use fake timers to prevent flakiness? Or at least add retries?

What you expected

Your tests to work on my machine! That's reasonable and not a completely obnoxious thing, right? 😅

Steps to reproduce

Run CI a bunch of times on either a fast machine or slow one, not sure which.

Here's some ai slop of what Fable 5.1 thinks is the solution (not sure if useful at all): jahands#1

(hopefully I still get points for filling out this template all by myself?? 🙂)

Diagnostics / logs

@executor-js/execution:test: ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
@executor-js/execution:test: 
@executor-js/execution:test:  FAIL  src/tool-invoker.test.ts > tool discovery > describes a return type that accepts the sandbox invocation result
@executor-js/execution:test: Error: Test timed out in 5000ms.
@executor-js/execution:test: If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
@executor-js/execution:test:  ❯ src/tool-invoker.test.ts:908:6
@executor-js/local:test:  ✓ src/db/legacy-bigint-boot.test.ts (3 tests) 247ms
@executor-js/host-selfhost:test: stdout | src/admin/admin-users.node.test.ts > the owner sees who uses the instance; a plain member cannot look
@executor-js/host-selfhost:test: [13:08:45.566] INFO (#50) http.span.5=187ms: Sent HTTP response {
@executor-js/host-selfhost:test:   'http.method': 'GET',
@executor-js/host-selfhost:test:   'http.url': '/api/integrations',
@executor-js/host-selfhost:test:   'http.status': 200
@executor-js/host-selfhost:test: }
@executor-js/host-selfhost:test: 
@executor-js/execution:test:     906|   );
@executor-js/execution:test:     907|
@executor-js/execution:test:     908|   it.effect("describes a return type that accepts the sandbox invocati…
@executor-js/execution:test:        |      ^
@executor-js/execution:test:     909|     Effect.gen(function* () {
@executor-js/execution:test:     910|       const executor = yield* makeSearchExecutor();
@executor-js/execution:test: 
@executor-js/execution:test: ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯
@executor-js/execution:test: 
@executor-js/execution:test: 
@executor-js/execution:test:  Test Files  1 failed | 4 passed (5)
@executor-js/execution:test:       Tests  1 failed | 70 passed (71)
@executor-js/execution:test:    Start at  13:08:04
@executor-js/execution:test:    Duration  41.27s (transform 10.59s, setup 0ms, import 56.88s, tests 27.64s, environment 22ms)
@executor-js/execution:test: 
@executor-js/host-selfhost:test: stdout | src/admin/admin-users.node.test.ts > the owner sees who uses the instance; a plain member cannot look
@executor-js/host-selfhost:test: [13:08:45.715] INFO (#60) http.span.6=142ms: Sent HTTP response {
@executor-js/host-selfhost:test:   'http.method': 'GET',
@executor-js/host-selfhost:test:   'http.url': '/api/integrations',
@executor-js/host-selfhost:test:   'http.status': 200
@executor-js/host-selfhost:test: }

Before you submit

• I searched the open issues for a duplicate.
• I removed all keys, tokens, and credentials from this report.