Skip to content

Commit 73cbba9

Browse files
authored
Disable product telemetry in every workflow (#1709)
The first pass only covered the workflows that looked like they ran product code and missed preview, deploy, pkg-pr-new and publish-executor-package, which also invoke the CLI. Blacksmith runners kept reporting to the production PostHog project after the fix merged. Apply the opt-out at the top level of every workflow instead of guessing. The variables are inert where the product is not executed.
1 parent 442b3f0 commit 73cbba9

5 files changed

Lines changed: 50 additions & 0 deletions

File tree

‎.github/workflows/deploy.yml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,16 @@ concurrency:
99
group: deploy-production
1010
cancel-in-progress: false
1111

12+
# CI is not a user — see the note in ci.yml. Applied to every workflow rather
13+
# than the ones that look like they run product code: the first pass guessed,
14+
# missed preview/deploy/pkg-pr-new, and kept leaking. These vars are inert
15+
# where the product is not executed, so the blanket application is the cheap
16+
# structural answer.
17+
env:
18+
DO_NOT_TRACK: "1"
19+
EXECUTOR_DISABLE_ANALYTICS: "1"
20+
EXECUTOR_DISABLE_INTEGRATIONS_FETCH: "1"
21+
1222
jobs:
1323
migrate:
1424
name: Migrate database

‎.github/workflows/pkg-pr-new.yml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,16 @@ concurrency:
1010
group: pkg-pr-new-${{ github.event.pull_request.number }}
1111
cancel-in-progress: true
1212

13+
# CI is not a user — see the note in ci.yml. Applied to every workflow rather
14+
# than the ones that look like they run product code: the first pass guessed,
15+
# missed preview/deploy/pkg-pr-new, and kept leaking. These vars are inert
16+
# where the product is not executed, so the blanket application is the cheap
17+
# structural answer.
18+
env:
19+
DO_NOT_TRACK: "1"
20+
EXECUTOR_DISABLE_ANALYTICS: "1"
21+
EXECUTOR_DISABLE_INTEGRATIONS_FETCH: "1"
22+
1323
jobs:
1424
# Per-platform matrix: build the executor binary, tar it, upload to R2.
1525
# The wrapper npm package is built later by the `publish` job which just

‎.github/workflows/preview-sweep.yml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,16 @@ permissions:
1616
contents: read
1717
pull-requests: read
1818

19+
# CI is not a user — see the note in ci.yml. Applied to every workflow rather
20+
# than the ones that look like they run product code: the first pass guessed,
21+
# missed preview/deploy/pkg-pr-new, and kept leaking. These vars are inert
22+
# where the product is not executed, so the blanket application is the cheap
23+
# structural answer.
24+
env:
25+
DO_NOT_TRACK: "1"
26+
EXECUTOR_DISABLE_ANALYTICS: "1"
27+
EXECUTOR_DISABLE_INTEGRATIONS_FETCH: "1"
28+
1929
jobs:
2030
sweep:
2131
name: Destroy previews for closed PRs

‎.github/workflows/preview.yml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,16 @@ concurrency:
2323
group: preview-${{ github.event.pull_request.number }}
2424
cancel-in-progress: ${{ github.event.action != 'closed' }}
2525

26+
# CI is not a user — see the note in ci.yml. Applied to every workflow rather
27+
# than the ones that look like they run product code: the first pass guessed,
28+
# missed preview/deploy/pkg-pr-new, and kept leaking. These vars are inert
29+
# where the product is not executed, so the blanket application is the cheap
30+
# structural answer.
31+
env:
32+
DO_NOT_TRACK: "1"
33+
EXECUTOR_DISABLE_ANALYTICS: "1"
34+
EXECUTOR_DISABLE_INTEGRATIONS_FETCH: "1"
35+
2636
jobs:
2737
deploy:
2838
name: Deploy preview

‎.github/workflows/publish-executor-package.yml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,16 @@ concurrency:
2121
group: publish-executor-package-${{ github.ref }}
2222
cancel-in-progress: false
2323

24+
# CI is not a user — see the note in ci.yml. Applied to every workflow rather
25+
# than the ones that look like they run product code: the first pass guessed,
26+
# missed preview/deploy/pkg-pr-new, and kept leaking. These vars are inert
27+
# where the product is not executed, so the blanket application is the cheap
28+
# structural answer.
29+
env:
30+
DO_NOT_TRACK: "1"
31+
EXECUTOR_DISABLE_ANALYTICS: "1"
32+
EXECUTOR_DISABLE_INTEGRATIONS_FETCH: "1"
33+
2434
jobs:
2535
publish:
2636
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)