fix embedded web ui release smoke

Author: RhysSullivan

.changeset/green-bobcats-shop.md

@@ -0,0 +1,5 @@
+---
+"executor": patch
+---
+
+Fix compiled web serving so embedded UI assets are bundled into release binaries, and extend the bootstrap smoke test to verify the root web page and docs routes respond successfully.

.changeset/pre.json

@@ -26,6 +26,7 @@
     "@executor/ui": "1.4.0-beta.0"
   },
   "changesets": [
+    "green-bobcats-shop",
     "kind-cycles-hang",
     "ripe-yaks-sniff",
     "tiny-melons-jump"

apps/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "executor",
-  "version": "1.4.0-beta.4",
+  "version": "1.4.0-beta.5",
   "private": true,
   "type": "module",
   "bin": {

apps/cli/src/build.ts

@@ -121,6 +121,8 @@ const createEmbeddedWebUISource = async () => {
 // Build platform binaries
 // ---------------------------------------------------------------------------
 
+const EMBEDDED_WEB_UI_STUB = `const files: Record<string, string> | null = null;\n\nexport default files;\n`;
+
 const buildBinaries = async (targets: Target[]) => {
   const meta = await readMetadata();
   const binaries: Record<string, string> = {};
@@ -143,7 +145,7 @@ const buildBinaries = async (targets: Target[]) => {
     console.log(`Building ${name}...`);
 
     await Bun.build({
-      entrypoints: [join(cliRoot, "src/main.ts"), embeddedWebUIPath],
+      entrypoints: [join(cliRoot, "src/main.ts")],
       minify: true,
       compile: {
         target: bunTarget(target) as any,
@@ -183,7 +185,7 @@ const buildBinaries = async (targets: Target[]) => {
 
     return binaries;
   } finally {
-    await rm(embeddedWebUIPath, { force: true });
+    await writeFile(embeddedWebUIPath, EMBEDDED_WEB_UI_STUB);
   }
 };
 

apps/cli/src/embedded-web-ui.gen.d.ts

@@ -1,2 +1,2 @@
-declare const files: Record<string, string>;
+declare const files: Record<string, string> | null;
 export default files;

apps/cli/src/embedded-web-ui.gen.ts

@@ -0,0 +1,3 @@
+const files: Record<string, string> | null = null;
+
+export default files;

apps/cli/src/main.ts

@@ -40,10 +40,7 @@ const DEFAULT_PORT = 8788;
 const DEFAULT_BASE_URL = `http://localhost:${DEFAULT_PORT}`;
 
 // Embedded web UI — baked into compiled binaries via `with { type: "file" }`
-const embeddedWebUI: Record<string, string> | null =
-  await import("./embedded-web-ui.gen")
-    .then((m) => m.default as Record<string, string>)
-    .catch(() => null);
+import embeddedWebUI from "./embedded-web-ui.gen";
 
 // ---------------------------------------------------------------------------
 // Helpers

bun.lock

@@ -161,15 +161,75 @@ describe("release bootstrap smoke", () => {
         const installedBinaryStat = await readFile(installedBinaryPath);
         expect(installedBinaryStat.byteLength).toBeGreaterThan(0);
 
-        const secondRun = await runCommand(
+        const probeServer = createServer((_, response) => {
+          response.statusCode = 204;
+          response.end();
+        });
+        const webPort = await listen(probeServer);
+        await closeServer(probeServer);
+
+        const webProcess = spawn(
           process.execPath,
-          [join(installedPackageDir, "bin", "executor"), "--help"],
-          installedPackageDir,
+          [join(installedPackageDir, "bin", "executor"), "web", "--port", String(webPort)],
+          {
+            cwd: installedPackageDir,
+            stdio: ["ignore", "pipe", "pipe"],
+          },
         );
-        const secondCombinedOutput = `${secondRun.stdout}\n${secondRun.stderr}`;
 
-        expect(secondRun.exitCode, secondCombinedOutput).toBe(0);
-        expect(secondCombinedOutput).not.toContain("downloading release asset");
+        let webStdout = "";
+        let webStderr = "";
+        webProcess.stdout.setEncoding("utf8");
+        webProcess.stdout.on("data", (chunk) => {
+          webStdout += chunk;
+        });
+        webProcess.stderr.setEncoding("utf8");
+        webProcess.stderr.on("data", (chunk) => {
+          webStderr += chunk;
+        });
+
+        try {
+          const deadline = Date.now() + 30_000;
+          let rootResponse: Response | null = null;
+          while (Date.now() < deadline) {
+            await new Promise((resolveDelay) => setTimeout(resolveDelay, 250));
+            try {
+              rootResponse = await fetch(`http://127.0.0.1:${webPort}/`);
+              if (rootResponse.ok) {
+                break;
+              }
+            } catch {
+              // keep polling until the server is ready
+            }
+          }
+
+          expect(rootResponse, `${webStdout}\n${webStderr}`).not.toBeNull();
+          expect(rootResponse!.status, `${webStdout}\n${webStderr}`).toBe(200);
+          const rootHtml = await rootResponse!.text();
+          expect(rootHtml.toLowerCase()).toContain("<html");
+
+          const docsResponse = await fetch(`http://127.0.0.1:${webPort}/docs`);
+          expect(docsResponse.status, `${webStdout}\n${webStderr}`).toBe(200);
+
+          const secondRun = await runCommand(
+            process.execPath,
+            [join(installedPackageDir, "bin", "executor"), "--help"],
+            installedPackageDir,
+          );
+          const secondCombinedOutput = `${secondRun.stdout}\n${secondRun.stderr}`;
+
+          expect(secondRun.exitCode, secondCombinedOutput).toBe(0);
+          expect(secondCombinedOutput).not.toContain("downloading release asset");
+        } finally {
+          webProcess.kill("SIGTERM");
+          await Promise.race([
+            new Promise((resolveClose) => webProcess.once("close", () => resolveClose(undefined))),
+            new Promise((resolveClose) => setTimeout(resolveClose, 5_000)),
+          ]);
+          if (webProcess.exitCode === null) {
+            webProcess.kill("SIGKILL");
+          }
+        }
       } finally {
         await closeServer(server);
         await rm(tempRoot, { recursive: true, force: true });