Stale mapping: extras-to-your-tour.summary has no matching section

[deanleigh]

The Tailored Tour PDF workflow reports:

WARN: source 'extras-to-your-tour.summary' not found in transform.json (orphaned source)

This one is genuine, unlike the $sourceFile warning alongside it, which was a validation bug and is fixed.

A mapping points at a section part that is not in the workflow's transform.json. Either the mapping is stale and should go, or the section was lost and should come back.

Surfaced by the list-workflows MCP tool (#130), which reports validation warnings in its output. It has presumably been in the startup log for a while without anyone reading it.

Worth knowing before fixing

The Extras section is one of the two extraction problems noted during the Tailored Travel migration: the price caveat ("Price based on twin share…") extracts correctly but lands at the end of the Extras body rather than in the summary slot.

A mapping targeting extras-to-your-tour.summary suggests someone intended the summary to be filled and it never was. So this may not be a stale mapping to delete — it may be the mapping that was supposed to solve exactly that problem, pointing at a section part the transform does not produce.

Worth understanding which before removing anything.

Done when

• Established whether the section part should exist or the mapping should go
• Whichever it is, done, and the workflow validates clean
• If the price caveat was the intent, noted whether this fixes it or is separate

Refs #130.

[deanleigh]

Diagnosed, not fixed. Parking it — rule finessing is not a priority right now — but recording the cause so nobody has to work it out again.

The mapping is not stale. Keep it.

The issue asked whether the mapping should go or the section should come back. It is the second: extras-to-your-tour.summary was always correct, and the transform is not producing the part it points at.

Note both extras mappings share a sourceKey (e4aecc5d…) and a blockKey — same section, same destination block, two parts feeding two fields. .content → richTextContent resolves; .summary → featurePropertyFeatureSummary does not.

Cause: two rules match the same element, and order decides

The price caveat extracts cleanly. From sample-extraction.json:

"Price based on twin share. Minimum numbers required. Normal booking conditions apply."
  fontSize: 8
  fontName: ADABKN+HelveticaNeue-Medium
  color:    #16549D

Both rules in the Main Content - Section group match it:

Rule	Font size	Font name	Colour	Matches
Section Content	8–10	contains HelveticaNeue	#16549D	yes
Section Summary	7–9	contains HelveticaNeue-Medium	#16549D	yes

fontNameContains is a substring test (PdfPagePropertiesService.cs:672), so "HelveticaNeue" also matches "ADABKN+HelveticaNeue-Medium". Content is listed first, wins, and the caveat lands at the end of the Extras body — the symptom noted during the migration.

So the Summary rule is the more specific of the two and loses anyway, because specificity does not beat order.

Confirming case: preamble-itinerary-p2 does get a Summary. Its Disclaimer rule sits in a group with no competing content rule, so nothing shadows it. Same mechanism, no collision.

This also answers the third checkbox: the price caveat landing in the wrong slot is not a separate bug. It is this one.

Options when it comes back up

1. Reorder Summary above Content in the group. No code, editable in the rules editor. Fragile — it works by position, and the next reorder breaks it.
2. Tighten the Content rule so the two stop overlapping (fontNameEquals, or a font-name condition that excludes -Medium). Config-only, fixes the cause. Preferred.
3. Make specificity win over order in the matcher. Code change affecting every workflow and every existing rule set — too big for this, and it would move behaviour under workflows that currently rely on ordering.

Option 2 is the one to take, with 1 alongside it if wanted.

Note for whoever picks this up

The rules live in the workflow folder as data, not in code. Both copies would want the same edit:

src/TailoredTravel.Web/updoc/workflows/tailoredTourPdf/source/source.json   (mirror, gitignored)
src/UpDoc.TestSite/updoc/workflows/tailoredTourPdf/source/source.json       (committed)

Worth considering separately whether two rules matching one element should warn at validation time. It is silent today, and it took reading the extraction metadata to see it.