From f3aa41696190cbc873833eaf4f614266e6389be6 Mon Sep 17 00:00:00 2001 From: minnykim06 Date: Mon, 9 Nov 2026 15:12:27 -0800 Subject: [PATCH 1/2] Fix null check crash when dining locations have no coordinates Some dining locations from the API have no lat/lon. populateDistances now skips them instead of crashing on a null check. Co-Authored-By: Claude Opus 5.5 --- lib/core/providers/dining.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/core/providers/dining.dart b/lib/core/providers/dining.dart index e0e9864e9..297e2768e 100644 --- a/lib/core/providers/dining.dart +++ b/lib/core/providers/dining.dart @@ -109,7 +109,9 @@ class DiningDataProvider extends ChangeNotifier { final bool hasLongitude = _coordinates?.lon != null; if (hasCoordinates && hasLatitude && hasLongitude) { for (DiningModel model in _diningModels.values.toList()) { - if (model.coordinates != null) { + // Some locations from the API have no lat/lon; skip them instead of crashing. + final bool modelHasLocation = model.coordinates?.lat != null && model.coordinates?.lon != null; + if (modelHasLocation) { var distance = calculateDistance( _coordinates!.lat!, _coordinates!.lon!, From 4d88b5f3bb167932a834a1a028f2406792c5286d Mon Sep 17 00:00:00 2001 From: minnykim06 Date: Mon, 9 Nov 2026 15:12:27 -0800 Subject: [PATCH 2/2] MA-732: Parking card - remove unnecessary nesting Replace the Neighborhoods / Parking Structures drill-down with a single flat, alphabetical list of every structure and lot, each with an on/off switch. Switches use the existing toggleLot selection logic and the max-lots limit. Loading, error and empty states are kept. Remove the now-unused nested views, their routes and titles, and the provider helpers only they used. Add widget tests for the new view. Co-Authored-By: Claude Opus 5.5 --- lib/app_constants.dart | 6 - lib/app_router.dart | 25 --- lib/core/providers/parking.dart | 26 --- lib/ui/parking/manage_parking_view.dart | 141 +++++++++++----- lib/ui/parking/neighborhood_lot_view.dart | 103 ------------ lib/ui/parking/neighborhoods_view.dart | 60 ------- lib/ui/parking/parking_structure_view.dart | 110 ------------- test/ui/parking/manage_parking_view_test.dart | 151 ++++++++++++++++++ 8 files changed, 248 insertions(+), 374 deletions(-) delete mode 100644 lib/ui/parking/neighborhood_lot_view.dart delete mode 100644 lib/ui/parking/neighborhoods_view.dart delete mode 100644 lib/ui/parking/parking_structure_view.dart create mode 100644 test/ui/parking/manage_parking_view_test.dart diff --git a/lib/app_constants.dart b/lib/app_constants.dart index aa5b41fd8..7c376efc0 100644 --- a/lib/app_constants.dart +++ b/lib/app_constants.dart @@ -29,10 +29,7 @@ class RoutePaths { // static const String DINING_NUTRITION_VIEW = 'dining/dining_nutrition_view'; static const String PARKING = "parking/parking_view"; static const String SPOT_TYPES_VIEW = "parking/spot_types_view"; - static const String PARKING_STRUCTURE_VIEW = "parking/parking_structure_view"; static const String PARKING_LOTS_VIEW = "parking/parking_lots_view"; - static const String NEIGHBORHOODS_VIEW = "parking/neighborhoods_view"; - static const String NEIGHBORHOODS_LOTS_VIEW = "parking/neighborhoods_lot_view"; static const String AVAILABILITY_DETAILED_VIEW = "availability/detailed_view"; static const String TGPT_CITATION_WEB = 'ai_assistant/citation_web'; } @@ -57,10 +54,7 @@ class RouteTitles { 'shuttle/manage_shuttle_view': 'MANAGE SHUTTLE STOPS', 'shuttle/add_shuttle_stops_view': 'ADD SHUTTLE STOPS', 'parking/manage_parking_view': 'MANAGE LOTS', - 'parking/neighborhoods_lot_view': 'MANAGE LOTS', - 'parking/neighborhoods_view': 'MANAGE LOTS', 'parking/parking_lots_view': 'MANAGE LOTS', - 'parking/parking_structure_view': 'MANAGE LOTS', 'parking/spot_types_view': 'MANAGE SPOTS', 'dining/view_all_dining_options': 'DINING', 'dining/option_detail_view': 'DINING', diff --git a/lib/app_router.dart b/lib/app_router.dart index 45cf92062..8e849cc71 100644 --- a/lib/app_router.dart +++ b/lib/app_router.dart @@ -25,9 +25,6 @@ import 'package:campus_mobile_experimental/ui/notifications/notifications_filter import 'package:campus_mobile_experimental/ui/onboarding/onboarding_slides.dart'; import 'package:campus_mobile_experimental/ui/onboarding/onboarding_login.dart'; import 'package:campus_mobile_experimental/ui/parking/manage_parking_view.dart'; -import 'package:campus_mobile_experimental/ui/parking/neighborhood_lot_view.dart'; -import 'package:campus_mobile_experimental/ui/parking/neighborhoods_view.dart'; -import 'package:campus_mobile_experimental/ui/parking/parking_structure_view.dart'; import 'package:campus_mobile_experimental/ui/parking/spot_types_view.dart'; import 'package:campus_mobile_experimental/ui/profile/cards.dart'; import 'package:campus_mobile_experimental/ui/profile/profile.dart'; @@ -204,28 +201,6 @@ class Router { return ClassList(); }, ); - case RoutePaths.PARKING_STRUCTURE_VIEW: - return MaterialPageRoute( - builder: (context) { - Provider.of(context).changeTitle(settings.name, done: true); - return ParkingStructureView(); - }, - ); - case RoutePaths.NEIGHBORHOODS_VIEW: - return MaterialPageRoute( - builder: (context) { - Provider.of(context).changeTitle(settings.name, done: true); - return NeighborhoodsView(); - }, - ); - case RoutePaths.NEIGHBORHOODS_LOTS_VIEW: - List data = settings.arguments as List; - return MaterialPageRoute( - builder: (context) { - Provider.of(context).changeTitle(settings.name, done: true); - return NeighborhoodLotsView(data); - }, - ); default: return MaterialPageRoute( builder: (context) { diff --git a/lib/core/providers/parking.dart b/lib/core/providers/parking.dart index 531e8b12f..9f5373dab 100644 --- a/lib/core/providers/parking.dart +++ b/lib/core/providers/parking.dart @@ -206,32 +206,6 @@ class ParkingDataProvider extends ChangeNotifier { return totalAndOpenSpots; } - Map> getParkingMap() { - Map> parkingMap = {}; - List neighborhoodsToSort = []; - for (ParkingModel model in _parkingService.data!) { - neighborhoodsToSort.add(model.neighborhood); - } - neighborhoodsToSort.sort(); - for (String neighborhood in neighborhoodsToSort) { - List val = []; - parkingMap[neighborhood] = val; - } - - for (ParkingModel model in _parkingService.data!) { - parkingMap[model.neighborhood]!.add(model.locationName); - } - return parkingMap; - } - - List getStructures() { - List structureMap = []; - for (ParkingModel model in _parkingService.data!) { - if (model.isStructure) structureMap.add(model.locationName); - } - return structureMap; - } - List getLots() { List lotMap = []; for (ParkingModel model in _parkingService.data!) { diff --git a/lib/ui/parking/manage_parking_view.dart b/lib/ui/parking/manage_parking_view.dart index 7d23843e3..a3c66e536 100644 --- a/lib/ui/parking/manage_parking_view.dart +++ b/lib/ui/parking/manage_parking_view.dart @@ -1,60 +1,113 @@ import 'package:campus_mobile_experimental/app_constants.dart'; -import 'package:campus_mobile_experimental/ui/common/container_view.dart'; import 'package:campus_mobile_experimental/app_styles.dart'; +import 'package:campus_mobile_experimental/core/models/parking.dart'; +import 'package:campus_mobile_experimental/core/providers/parking.dart'; +import 'package:campus_mobile_experimental/ui/common/alert_dialog_widget.dart'; +import 'package:campus_mobile_experimental/ui/common/container_view.dart'; +import 'package:flutter/cupertino.dart'; import 'package:flutter/material.dart'; +import 'package:provider/provider.dart'; -class ManageParkingView extends StatefulWidget { - @override - _ManageParkingViewState createState() => _ManageParkingViewState(); -} - -class _ManageParkingViewState extends State { +/// Flat list of every parking structure and lot, each with an on/off switch +/// that controls whether it appears on the parking card. +class ManageParkingView extends StatelessWidget { @override - Widget build(BuildContext context) { - return ContainerView(child: buildLocationsList(context)); - } + Widget build(BuildContext context) => ContainerView(child: buildLocationsList(context)); Widget buildLocationsList(BuildContext context) { - const List parkingType = ["Neighborhoods", "Parking Structures"]; - - List listTiles = []; - for (int i = 0; i < parkingType.length; i++) { - listTiles.add( - ListTile( - title: Text(parkingType[i], style: Theme.of(context).textTheme.bodyMedium), - trailing: Icon(Icons.arrow_forward_ios, color: dotsSelectedColorLight, size: 18.0), - onTap: () { - if (i == 0) { - Navigator.pushNamed(context, RoutePaths.NEIGHBORHOODS_VIEW); - } else if (i == 1) { - Navigator.pushNamed(context, RoutePaths.PARKING_STRUCTURE_VIEW); - } - }, - ), - ); + final parkingDataProvider = Provider.of(context); + + if (parkingDataProvider.isLoading == true) { + return Center(child: CircularProgressIndicator(color: Theme.of(context).colorScheme.secondary)); + } + + if (parkingDataProvider.error != null) { + return _statusMessage(context, 'Unable to load parking locations. Please try again later.'); + } + + // Sort by name so each location is easy to find in one list. + final List locations = List.from(parkingDataProvider.parkingModels) + ..sort((a, b) => a.locationName.toLowerCase().compareTo(b.locationName.toLowerCase())); + + if (locations.isEmpty) { + return _statusMessage(context, 'No parking locations available.'); } + final Map viewState = parkingDataProvider.parkingViewState; + final int selectedLots = viewState.values.where((selected) => selected).length; + + final List listTiles = [ + for (ParkingModel location in locations) + _locationTile( + context, + parkingDataProvider, + location.locationName, + viewState[location.locationName] ?? false, + selectedLots, + ), + ]; + return Padding( padding: const EdgeInsets.symmetric(horizontal: 8.0), child: ListView( - shrinkWrap: true, - children: [ - for (int i = 0; i < listTiles.length; i++) ...[ - listTiles[i], - if (i != listTiles.length - 1) - Padding( - padding: const EdgeInsets.symmetric(horizontal: 16.0), - child: Divider( - color: Theme.of(context).brightness == Brightness.dark - ? listTileDividerColorDark - : listTileDividerColorLight, - thickness: 0.5, - height: 0, - ), - ), - ], - ], + physics: const BouncingScrollPhysics(), + children: ListTile.divideTiles( + tiles: listTiles, + context: context, + color: Theme.of(context).brightness == Brightness.dark ? listTileDividerColorDark : listTileDividerColorLight, + ).toList(), + ), + ); + } + + Widget _locationTile( + BuildContext context, + ParkingDataProvider parkingDataProvider, + String locationName, + bool isSelected, + int selectedLots, + ) { + void toggle() { + if (!isSelected && selectedLots >= ParkingDataProvider.MAX_SELECTED_LOTS) { + showDialog( + context: context, + builder: (context) => AlertDialogWidget( + type: MessageTypeConstants.ERROR, + icon: Icons.block_flipped, + title: ParkingConstants.LOT_MAX_TITLE, + description: ParkingConstants.LOT_MAX_DESC, + onClose: () => Navigator.of(context).pop(), + ), + ); + return; + } + parkingDataProvider.toggleLot(locationName, selectedLots); + } + + // MergeSemantics lets screen readers announce the name and switch state together. + return MergeSemantics( + child: ListTile( + key: Key(locationName), + contentPadding: const EdgeInsets.symmetric(horizontal: 16.0), + title: Text(locationName, style: Theme.of(context).textTheme.bodyMedium), + onTap: toggle, + trailing: Transform.scale( + scale: 0.9, + child: CupertinoSwitch( + value: isSelected, + activeTrackColor: toggleActiveColor, + inactiveTrackColor: Colors.grey.shade400, + onChanged: (_) => toggle(), + ), + ), ), ); } + + Widget _statusMessage(BuildContext context, String message) => Center( + child: Padding( + padding: const EdgeInsets.all(32.0), + child: Text(message, style: Theme.of(context).textTheme.bodyMedium, textAlign: TextAlign.center), + ), + ); } diff --git a/lib/ui/parking/neighborhood_lot_view.dart b/lib/ui/parking/neighborhood_lot_view.dart deleted file mode 100644 index 8b3129176..000000000 --- a/lib/ui/parking/neighborhood_lot_view.dart +++ /dev/null @@ -1,103 +0,0 @@ -import 'package:campus_mobile_experimental/core/providers/parking.dart'; -import 'package:campus_mobile_experimental/ui/common/container_view.dart'; -import 'package:campus_mobile_experimental/app_styles.dart'; -import 'package:flutter/cupertino.dart'; -import 'package:flutter/material.dart'; -import 'package:provider/provider.dart'; -import 'package:campus_mobile_experimental/app_constants.dart'; -import 'package:campus_mobile_experimental/ui/common/alert_dialog_widget.dart'; - -class NeighborhoodLotsView extends StatefulWidget { - final List args; - const NeighborhoodLotsView(this.args); - - @override - _NeighborhoodLotsViewState createState() => _NeighborhoodLotsViewState(); -} - -class _NeighborhoodLotsViewState extends State { - bool showedScaffold = false; - late ParkingDataProvider parkingDataProvider; - - @override - Widget build(BuildContext context) { - parkingDataProvider = Provider.of(context); - return ContainerView(child: buildLotsList(context)); - } - - Widget buildLotsList(BuildContext context) { - List arguments = widget.args; - - List list = []; - list.add( - ListTile( - title: Padding( - padding: const EdgeInsets.fromLTRB(8, 0, 0, 0), - child: Text( - "Parking Lots", - style: Theme.of(context).brightness == Brightness.dark ? textSubheaderDark : textSubheaderLight, - ), - ), - ), - ); - - var selectedLots = 0; - parkingDataProvider.parkingViewState.forEach((key, value) { - if (value == true) selectedLots++; - }); - - for (var lotName in arguments) { - bool lotState = parkingDataProvider.parkingViewState[lotName]!; - list.add( - ListTile( - title: Padding( - padding: const EdgeInsets.fromLTRB(8, 0, 0, 0), - child: Text(lotName, style: Theme.of(context).textTheme.bodyMedium), - ), - trailing: Transform.scale( - scale: 0.9, - child: CupertinoSwitch( - value: lotState, - activeTrackColor: toggleActiveColor, - inactiveTrackColor: Colors.grey.shade400, - onChanged: (bool newValue) { - if (selectedLots == 10 && !lotState && !showedScaffold) { - showDialog( - context: context, - builder: (context) { - return AlertDialogWidget( - type: MessageTypeConstants.ERROR, - icon: Icons.block_flipped, - title: ParkingConstants.LOT_MAX_TITLE, - description: ParkingConstants.LOT_MAX_DESC, - onClose: () { - Navigator.of(context).pop(); - }, - ); - }, - ); - showedScaffold = true; - } else { - parkingDataProvider.toggleLot(lotName, selectedLots); - } - }, - ), - ), - ), - ); - } - - return Padding( - padding: const EdgeInsets.symmetric(horizontal: 8.0), - child: ListView( - physics: BouncingScrollPhysics(), - shrinkWrap: true, - children: ListTile.divideTiles( - tiles: list, - context: context, - color: Theme.of(context).brightness == Brightness.dark ? listTileDividerColorDark : listTileDividerColorLight, - ).toList(), - ), - ); - } -} diff --git a/lib/ui/parking/neighborhoods_view.dart b/lib/ui/parking/neighborhoods_view.dart deleted file mode 100644 index 7c461d433..000000000 --- a/lib/ui/parking/neighborhoods_view.dart +++ /dev/null @@ -1,60 +0,0 @@ -import 'package:flutter/material.dart'; -import 'package:campus_mobile_experimental/ui/common/container_view.dart'; -import 'package:campus_mobile_experimental/app_constants.dart'; -import 'package:campus_mobile_experimental/core/providers/parking.dart'; -import 'package:provider/provider.dart'; -import 'package:campus_mobile_experimental/app_styles.dart'; - -class NeighborhoodsView extends StatefulWidget { - @override - _NeighborhoodsViewState createState() => _NeighborhoodsViewState(); -} - -class _NeighborhoodsViewState extends State { - @override - Widget build(BuildContext context) { - return ContainerView(child: buildNeighborhoodsList(context)); - } - - Widget buildNeighborhoodsList(BuildContext context) { - Map> neighborhoods = Provider.of(context).getParkingMap(); - - List listTiles = []; - - listTiles.add( - ListTile( - title: Text( - "Neighborhoods", - style: Theme.of(context).brightness == Brightness.dark ? textSubheaderDark : textSubheaderLight, - ), - ), - ); - - neighborhoods.forEach((key, value) { - if (key.isNotEmpty) { - listTiles.add( - ListTile( - title: Text(key, style: Theme.of(context).textTheme.bodyMedium), - trailing: Icon(Icons.arrow_forward_ios, color: dotsSelectedColorLight, size: 18.0), - onTap: () { - Navigator.pushNamed(context, RoutePaths.NEIGHBORHOODS_LOTS_VIEW, arguments: value); - }, - ), - ); - } - }); - - return Padding( - padding: const EdgeInsets.symmetric(horizontal: 8.0), - child: ListView( - shrinkWrap: true, - physics: const BouncingScrollPhysics(), - children: ListTile.divideTiles( - tiles: listTiles, - context: context, - color: Theme.of(context).brightness == Brightness.dark ? listTileDividerColorDark : listTileDividerColorLight, - ).toList(), - ), - ); - } -} diff --git a/lib/ui/parking/parking_structure_view.dart b/lib/ui/parking/parking_structure_view.dart deleted file mode 100644 index e2d9aecdd..000000000 --- a/lib/ui/parking/parking_structure_view.dart +++ /dev/null @@ -1,110 +0,0 @@ -import 'package:campus_mobile_experimental/core/providers/parking.dart'; -import 'package:campus_mobile_experimental/ui/common/container_view.dart'; -import 'package:campus_mobile_experimental/app_styles.dart'; -import 'package:flutter/cupertino.dart'; -import 'package:flutter/material.dart'; -import 'package:provider/provider.dart'; -import 'package:campus_mobile_experimental/app_constants.dart'; -import 'package:campus_mobile_experimental/ui/common/alert_dialog_widget.dart'; - -class ParkingStructureView extends StatefulWidget { - @override - _ParkingStructureViewState createState() => _ParkingStructureViewState(); -} - -class _ParkingStructureViewState extends State { - late ParkingDataProvider parkingDataProvider; - var showedScaffold = false; - - @override - Widget build(BuildContext context) { - parkingDataProvider = Provider.of(context); - return ContainerView(child: structureList(context)); - } - - Widget structureList(BuildContext context) { - List structures = Provider.of(context).getStructures(); - - List listTiles = []; - listTiles.add( - ListTile( - contentPadding: const EdgeInsets.symmetric(horizontal: 16.0), - title: Padding( - padding: const EdgeInsets.fromLTRB(0, 0, 0, 0), - child: Text( - "Parking Structures", - style: Theme.of(context).brightness == Brightness.dark ? textSubheaderDark : textSubheaderLight, - ), - ), - ), - ); - - var selectedLots = 0; - parkingDataProvider.parkingViewState.forEach((key, value) { - if (value == true) selectedLots++; - }); - - for (var structureName in structures) { - bool structureState = parkingDataProvider.parkingViewState[structureName]!; - listTiles.add( - ListTile( - contentPadding: const EdgeInsets.symmetric(horizontal: 16.0), - title: Padding( - padding: const EdgeInsets.fromLTRB(0, 0, 0, 0), - child: Text(structureName, style: Theme.of(context).textTheme.bodyMedium), - ), - trailing: Transform.scale( - scale: 0.9, - child: CupertinoSwitch( - value: structureState, - activeTrackColor: toggleActiveColor, - inactiveTrackColor: Colors.grey.shade400, - onChanged: (bool newValue) { - if (selectedLots == 10 && !structureState && !showedScaffold) { - showDialog( - context: context, - builder: (context) { - return AlertDialogWidget( - type: MessageTypeConstants.ERROR, - icon: Icons.block_flipped, - title: ParkingConstants.LOT_MAX_TITLE, - description: ParkingConstants.LOT_MAX_DESC, - onClose: () { - Navigator.of(context).pop(); - }, - ); - }, - ); - showedScaffold = true; - } else { - parkingDataProvider.toggleLot(structureName, selectedLots); - } - }, - ), - ), - ), - ); - } - - return ListView( - physics: BouncingScrollPhysics(), - shrinkWrap: true, - children: [ - for (int i = 0; i < listTiles.length; i++) ...[ - listTiles[i], - if (i != listTiles.length - 1) - Padding( - padding: const EdgeInsets.symmetric(horizontal: 16.0), - child: Divider( - color: Theme.of(context).brightness == Brightness.dark - ? listTileDividerColorDark - : listTileDividerColorLight, - thickness: 0.5, - height: 0, - ), - ), - ], - ], - ); - } -} diff --git a/test/ui/parking/manage_parking_view_test.dart b/test/ui/parking/manage_parking_view_test.dart new file mode 100644 index 000000000..1a02465c7 --- /dev/null +++ b/test/ui/parking/manage_parking_view_test.dart @@ -0,0 +1,151 @@ +import 'package:campus_mobile_experimental/core/models/parking.dart'; +import 'package:campus_mobile_experimental/core/providers/parking.dart'; +import 'package:campus_mobile_experimental/ui/common/alert_dialog_widget.dart'; +import 'package:campus_mobile_experimental/ui/navigator/top.dart'; +import 'package:campus_mobile_experimental/ui/parking/manage_parking_view.dart'; +import 'package:flutter/cupertino.dart'; +import 'package:flutter/material.dart'; +import 'package:flutter_test/flutter_test.dart'; +import 'package:provider/provider.dart'; + +void main() { + Future pumpView(WidgetTester tester, _ParkingDataProvider provider) async { + await tester.pumpWidget( + MultiProvider( + providers: [ + ChangeNotifierProvider.value(value: provider), + ChangeNotifierProvider.value(value: CustomAppBar()), + ], + child: MaterialApp(home: ManageParkingView()), + ), + ); + } + + testWidgets('shows every structure and lot once in a flat, sorted list', (tester) async { + final provider = _ParkingDataProvider( + [ + _model('Hopkins', neighborhood: 'Central', isStructure: true), + _model('Athena', neighborhood: 'East', isStructure: true), + _model('Lot P701', neighborhood: 'East', isStructure: false), + ], + {'Hopkins': true, 'Athena': false, 'Lot P701': false}, + ); + + await pumpView(tester, provider); + + // No neighborhood or "Parking Structures" group rows, and no drill-in arrows. + expect(find.text('Neighborhoods'), findsNothing); + expect(find.text('Parking Structures'), findsNothing); + expect(find.byIcon(Icons.arrow_forward_ios), findsNothing); + + expect(find.byType(CupertinoSwitch), findsNWidgets(3)); + for (final name in ['Athena', 'Hopkins', 'Lot P701']) { + expect(find.text(name), findsOneWidget); + } + final athenaY = tester.getTopLeft(find.text('Athena')).dy; + final hopkinsY = tester.getTopLeft(find.text('Hopkins')).dy; + final lotY = tester.getTopLeft(find.text('Lot P701')).dy; + expect(athenaY < hopkinsY && hopkinsY < lotY, isTrue); + + expect(_switch(tester, 'Hopkins').value, isTrue); + expect(_switch(tester, 'Athena').value, isFalse); + }); + + testWidgets('switches and rows toggle selection through the provider', (tester) async { + final provider = _ParkingDataProvider([_model('Hopkins'), _model('Athena')], {'Hopkins': true, 'Athena': false}); + + await pumpView(tester, provider); + + await tester.tap(_switchFinder('Athena')); + await tester.pump(); + expect(provider.toggleCalls, [('Athena', 1)]); + expect(_switch(tester, 'Athena').value, isTrue); + + await tester.tap(find.text('Hopkins')); + await tester.pump(); + expect(provider.toggleCalls.last, ('Hopkins', 2)); + expect(_switch(tester, 'Hopkins').value, isFalse); + }); + + testWidgets('blocks turning on a location past the max and shows the alert', (tester) async { + final names = List.generate( + ParkingDataProvider.MAX_SELECTED_LOTS + 1, + (i) => 'Lot ${i.toString().padLeft(2, '0')}', + ); + final provider = _ParkingDataProvider(names.map((n) => _model(n)).toList(), { + for (final n in names) n: n != names.last, + }); + + await pumpView(tester, provider); + await tester.scrollUntilVisible(find.text(names.last), 100); + + await tester.tap(_switchFinder(names.last)); + await tester.pumpAndSettle(); + expect(provider.toggleCalls, isEmpty); + expect(find.byType(AlertDialogWidget), findsOneWidget); + }); + + testWidgets('shows loading, error, and empty states', (tester) async { + final provider = _ParkingDataProvider([], {})..loading = true; + await pumpView(tester, provider); + expect(find.byType(CircularProgressIndicator), findsOneWidget); + + provider + ..loading = false + ..err = 'boom'; + provider.notifyListeners(); + await tester.pump(); + expect(find.text('Unable to load parking locations. Please try again later.'), findsOneWidget); + + provider.err = null; + provider.notifyListeners(); + await tester.pump(); + expect(find.text('No parking locations available.'), findsOneWidget); + }); +} + +Finder _switchFinder(String name) => find.descendant(of: find.byKey(Key(name)), matching: find.byType(CupertinoSwitch)); + +CupertinoSwitch _switch(WidgetTester tester, String name) => tester.widget(_switchFinder(name)); + +ParkingModel _model(String name, {String neighborhood = 'Central', bool isStructure = false}) => ParkingModel( + neighborhood: neighborhood, + isStructure: isStructure, + locationId: name, + locationName: name, + locationContext: '', + locationProvider: '', + availability: {}, +); + +class _ParkingDataProvider extends ChangeNotifier implements ParkingDataProvider { + _ParkingDataProvider(this.models, this.state); + + final List models; + final Map state; + final List<(String, int)> toggleCalls = []; + bool loading = false; + String? err; + + @override + get isLoading => loading; + + @override + get error => err; + + @override + List get parkingModels => models; + + @override + Map get parkingViewState => state; + + @override + void toggleLot(String location, int numSelected) { + toggleCalls.add((location, numSelected)); + state[location] = !state[location]!; + notifyListeners(); + } + + @override + dynamic noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation); +}