From eb30e8c442b40d4047e7d0f271d0b82861735971 Mon Sep 17 00:00:00 2001 From: CoGibby Date: Tue, 3 Nov 2026 14:31:49 -0800 Subject: [PATCH 1/2] Fix Classes card evaluation option for TSS data MA-769: normalize grade_option parsing (snake_case and camelCase), map known TSS grade-option codes case-insensitively, pass unrecognized values through instead of showing Other, and hide the evaluation row when no data is present. Adds unit tests for the mapping and parsing. --- lib/core/models/classes.dart | 2 +- lib/core/models/scheduled_class.dart | 18 +++++++-- lib/ui/classes/classes_card.dart | 2 +- lib/ui/classes/classes_list.dart | 2 +- test/core/models/scheduled_class_test.dart | 43 ++++++++++++++++++++++ 5 files changed, 61 insertions(+), 6 deletions(-) create mode 100644 test/core/models/scheduled_class_test.dart diff --git a/lib/core/models/classes.dart b/lib/core/models/classes.dart index 807b0230e..dacb3e2cf 100644 --- a/lib/core/models/classes.dart +++ b/lib/core/models/classes.dart @@ -56,7 +56,7 @@ class ClassData { courseCode: json["course_code"] == null ? null : json["course_code"], units: (json["units"] as num?)?.toDouble(), courseLevel: json["course_level"] == null ? null : json["course_level"], - gradeOption: json["grade_option"] == null ? null : json["grade_option"], + gradeOption: json["grade_option"] ?? json["gradeOption"], grade: json["grade"] == null ? null : json["grade"], courseTitle: json["course_title"] == null ? null : json["course_title"], enrollmentStatus: json["enrollment_status"] == null ? null : json["enrollment_status"], diff --git a/lib/core/models/scheduled_class.dart b/lib/core/models/scheduled_class.dart index cc154f02f..93d2f52ba 100644 --- a/lib/core/models/scheduled_class.dart +++ b/lib/core/models/scheduled_class.dart @@ -22,16 +22,28 @@ class ScheduledClass { return dayCodes.isEmpty ? days : dayCodes.join(', '); } - String get gradeOption { - switch (course.gradeOption) { + String? get gradeOption { + final raw = course.gradeOption?.trim(); + if (raw == null || raw.isEmpty) return null; + switch (raw.toUpperCase()) { case 'L': + case 'GR': + case 'GRD': + case 'LETTER': return 'Letter Grade'; case 'P': + case 'PN': + case 'PNP': + case 'PASS': return 'Pass/No Pass'; case 'S': + case 'SU': + case 'S/U': return 'Sat/Unsat'; default: - return 'Other'; + // Surface the raw value instead of a misleading "Other" when the + // TSS API adds new grade-option codes. + return raw; } } } diff --git a/lib/ui/classes/classes_card.dart b/lib/ui/classes/classes_card.dart index beeb8dacf..2431f850b 100644 --- a/lib/ui/classes/classes_card.dart +++ b/lib/ui/classes/classes_card.dart @@ -87,7 +87,7 @@ class ClassScheduleCard extends StatelessWidget { buildLocationRow(context, section.room?.trim().isNotEmpty == true ? section.room!.trim() : 'TBD'), SizedBox(height: 8), // Evaluation Option: - buildGradeEvaluationRow(context, scheduledClass.gradeOption), + if (scheduledClass.gradeOption != null) buildGradeEvaluationRow(context, scheduledClass.gradeOption!), // "Last updated: A few seconds ago Padding( padding: const EdgeInsets.only(left: 4.0, top: 24.0), diff --git a/lib/ui/classes/classes_list.dart b/lib/ui/classes/classes_list.dart index e52112fc7..24e057ef5 100644 --- a/lib/ui/classes/classes_list.dart +++ b/lib/ui/classes/classes_list.dart @@ -166,7 +166,7 @@ class ClassList extends StatelessWidget { // Classroom Location: _detailRow(Icons.location_on_outlined, 'Location: ${_formatLocation(scheduledClass)}', detailStyle), // Evaluation Option: - if (!isMidterm) + if (!isMidterm && scheduledClass.gradeOption != null) _detailRow(Icons.check_box_outlined, 'Evaluation: ${scheduledClass.gradeOption}', detailStyle), ], ), diff --git a/test/core/models/scheduled_class_test.dart b/test/core/models/scheduled_class_test.dart new file mode 100644 index 000000000..8acc571bd --- /dev/null +++ b/test/core/models/scheduled_class_test.dart @@ -0,0 +1,43 @@ +import 'package:campus_mobile_experimental/core/models/classes.dart'; +import 'package:campus_mobile_experimental/core/models/scheduled_class.dart'; +import 'package:flutter_test/flutter_test.dart'; + +ScheduledClass scheduledFromJson(Map courseJson) => + ScheduledClass(course: ClassData.fromJson(courseJson), section: SectionData()); + +void main() { + group('ScheduledClass.gradeOption', () { + test('maps the classic single-letter codes', () { + expect(scheduledFromJson({'grade_option': 'L'}).gradeOption, 'Letter Grade'); + expect(scheduledFromJson({'grade_option': 'P'}).gradeOption, 'Pass/No Pass'); + expect(scheduledFromJson({'grade_option': 'S'}).gradeOption, 'Sat/Unsat'); + }); + + test('maps known TSS vocabulary variants case-insensitively', () { + expect(scheduledFromJson({'grade_option': 'GRD'}).gradeOption, 'Letter Grade'); + expect(scheduledFromJson({'grade_option': 'pnp'}).gradeOption, 'Pass/No Pass'); + expect(scheduledFromJson({'grade_option': 'S/U'}).gradeOption, 'Sat/Unsat'); + }); + + test('passes unrecognized non-empty values through verbatim', () { + expect(scheduledFromJson({'grade_option': 'Z'}).gradeOption, 'Z'); + expect(scheduledFromJson({'grade_option': 'credit'}).gradeOption, 'credit'); + }); + + test('returns null when the value is missing, null, or blank', () { + expect(scheduledFromJson({}).gradeOption, isNull); + expect(scheduledFromJson({'grade_option': null}).gradeOption, isNull); + expect(scheduledFromJson({'grade_option': ' '}).gradeOption, isNull); + }); + }); + + group('ClassData.fromJson grade_option parsing', () { + test('reads snake_case payloads', () { + expect(ClassData.fromJson({'grade_option': 'L'}).gradeOption, 'L'); + }); + + test('falls back to camelCase payloads', () { + expect(ClassData.fromJson({'gradeOption': 'L'}).gradeOption, 'L'); + }); + }); +} From e4398104cecb3fa9572ce2fb44ee30f51e535619 Mon Sep 17 00:00:00 2001 From: CoGibby Date: Fri, 6 Nov 2026 13:14:05 -0800 Subject: [PATCH 2/2] Map MyAcademicHistory grade options case-insensitively (MA-741) --- lib/core/models/scheduled_class.dart | 25 +++++++++++----------- test/core/models/scheduled_class_test.dart | 21 ++++++++++++------ 2 files changed, 27 insertions(+), 19 deletions(-) diff --git a/lib/core/models/scheduled_class.dart b/lib/core/models/scheduled_class.dart index 93d2f52ba..5fd49ac41 100644 --- a/lib/core/models/scheduled_class.dart +++ b/lib/core/models/scheduled_class.dart @@ -25,20 +25,21 @@ class ScheduledClass { String? get gradeOption { final raw = course.gradeOption?.trim(); if (raw == null || raw.isEmpty) return null; - switch (raw.toUpperCase()) { - case 'L': - case 'GR': - case 'GRD': - case 'LETTER': + switch (raw.toLowerCase()) { + case 'l': + case 'letter grade': return 'Letter Grade'; - case 'P': - case 'PN': - case 'PNP': - case 'PASS': + case 'p': + case 'pn': + case 'pnp': + case 'pass/no pass': + case 'pass/not pass': return 'Pass/No Pass'; - case 'S': - case 'SU': - case 'S/U': + case 's': + case 'su': + case 's/u': + case 'sat/unsat': + case 'satisfactory/unsatisfactory': return 'Sat/Unsat'; default: // Surface the raw value instead of a misleading "Other" when the diff --git a/test/core/models/scheduled_class_test.dart b/test/core/models/scheduled_class_test.dart index 8acc571bd..978eadbba 100644 --- a/test/core/models/scheduled_class_test.dart +++ b/test/core/models/scheduled_class_test.dart @@ -7,16 +7,23 @@ ScheduledClass scheduledFromJson(Map courseJson) => void main() { group('ScheduledClass.gradeOption', () { - test('maps the classic single-letter codes', () { + test('maps the legacy single-letter codes', () { expect(scheduledFromJson({'grade_option': 'L'}).gradeOption, 'Letter Grade'); expect(scheduledFromJson({'grade_option': 'P'}).gradeOption, 'Pass/No Pass'); expect(scheduledFromJson({'grade_option': 'S'}).gradeOption, 'Sat/Unsat'); }); - test('maps known TSS vocabulary variants case-insensitively', () { - expect(scheduledFromJson({'grade_option': 'GRD'}).gradeOption, 'Letter Grade'); - expect(scheduledFromJson({'grade_option': 'pnp'}).gradeOption, 'Pass/No Pass'); - expect(scheduledFromJson({'grade_option': 'S/U'}).gradeOption, 'Sat/Unsat'); + test('maps real MyAcademicHistory Title Case values', () { + expect(scheduledFromJson({'grade_option': 'Letter Grade'}).gradeOption, 'Letter Grade'); + expect(scheduledFromJson({'grade_option': 'Pass/No Pass'}).gradeOption, 'Pass/No Pass'); + expect(scheduledFromJson({'grade_option': 'Sat/Unsat'}).gradeOption, 'Sat/Unsat'); + expect(scheduledFromJson({'grade_option': 'Satisfactory/Unsatisfactory'}).gradeOption, 'Sat/Unsat'); + }); + + test('maps grade-option spellings case-insensitively', () { + expect(scheduledFromJson({'grade_option': 'letter grade'}).gradeOption, 'Letter Grade'); + expect(scheduledFromJson({'grade_option': 'pass/not pass'}).gradeOption, 'Pass/No Pass'); + expect(scheduledFromJson({'grade_option': 's/u'}).gradeOption, 'Sat/Unsat'); }); test('passes unrecognized non-empty values through verbatim', () { @@ -33,11 +40,11 @@ void main() { group('ClassData.fromJson grade_option parsing', () { test('reads snake_case payloads', () { - expect(ClassData.fromJson({'grade_option': 'L'}).gradeOption, 'L'); + expect(ClassData.fromJson({'grade_option': 'Letter Grade'}).gradeOption, 'Letter Grade'); }); test('falls back to camelCase payloads', () { - expect(ClassData.fromJson({'gradeOption': 'L'}).gradeOption, 'L'); + expect(ClassData.fromJson({'gradeOption': 'Pass/No Pass'}).gradeOption, 'Pass/No Pass'); }); }); }