From 20fb8bf1b0159dce78ab6589a60eff4d49809133 Mon Sep 17 00:00:00 2001 From: TzuHsuan <96853116+TzuH-Hsu@users.noreply.github.com> Date: Mon, 7 Sep 2026 00:12:43 +0800 Subject: [PATCH] feat: retire the agent-ok and by-agent label mechanism MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Both labels were write-only: agent-ok had one producer (the issue labeler copying a form checkbox) and no consumer; by-agent had neither. Nothing gated, routed, or recorded on them, and provenance already lives in the Co-Authored-By trailer and the PR author account. - Drop both entries from labels.yml, the Agent eligibility checkbox from the three issue forms, and the agent-ok sync + isFormManaged clause from issue-labeler.yml (priority/area/type sync unchanged). This also removes the silent stripping of a hand-added agent-ok on issue edit. - AGENTS.md: start-work rule is explicit human assignment; provenance is the commit trailer. README, design principle 7, PROJECT_FIELDS, project-views (Agent queue view removed), bootstrap Ready description and view count updated to match. - Skills agent-workflow, pr-authoring, issue-writing, anti-patterns, code-review reworded; no reference to either label remains. - ADR-0007 records the decision and rejected alternatives; ADR-0003 left untouched as history. Retires agent-ok, by-agent — no successor. Closes #36 Co-Authored-By: Claude Fable 5.1 --- .github/ISSUE_TEMPLATE/bug_report.yml | 7 ---- .github/ISSUE_TEMPLATE/feature_request.yml | 7 ---- .github/ISSUE_TEMPLATE/task.yml | 7 ---- .github/PROJECT_FIELDS.md | 2 -- .github/labels.yml | 8 ----- .github/workflows/issue-labeler.yml | 14 ++------ AGENTS.md | 6 ++-- README.md | 2 +- docs/adr/ADR-0007-retire-agent-labels.md | 37 ++++++++++++++++++++ docs/adr/README.md | 1 + docs/setup/project-views.md | 15 +-------- docs/template/design-principles.md | 2 +- scripts/bootstrap.sh | 4 +-- skills/agent-workflow/SKILL.md | 39 +++++++++++----------- skills/anti-patterns/SKILL.md | 4 +-- skills/code-review/SKILL.md | 2 +- skills/issue-writing/SKILL.md | 16 +++------ skills/pr-authoring/SKILL.md | 9 +---- 18 files changed, 77 insertions(+), 105 deletions(-) create mode 100644 docs/adr/ADR-0007-retire-agent-labels.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index f76cad5..243ed90 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -66,10 +66,3 @@ body: placeholder: Paste output, logs, or attach files (optional) validations: required: false - - - type: checkboxes - id: agent_eligibility - attributes: - label: Agent eligibility - options: - - label: "AI agents may pick this up (adds agent-ok)" diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index 4edeec6..ce1e2a8 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -63,10 +63,3 @@ body: - label: "area:skills — Skills knowledge modules" - label: "area:ci — CI workflows and automation" - label: "area:governance — Labels, templates, metadata contract, process" - - - type: checkboxes - id: agent_eligibility - attributes: - label: Agent eligibility - options: - - label: "AI agents may pick this up (adds agent-ok)" diff --git a/.github/ISSUE_TEMPLATE/task.yml b/.github/ISSUE_TEMPLATE/task.yml index 4e788cb..784bbed 100644 --- a/.github/ISSUE_TEMPLATE/task.yml +++ b/.github/ISSUE_TEMPLATE/task.yml @@ -68,10 +68,3 @@ body: - label: "area:skills — Skills knowledge modules" - label: "area:ci — CI workflows and automation" - label: "area:governance — Labels, templates, metadata contract, process" - - - type: checkboxes - id: agent_eligibility - attributes: - label: Agent eligibility - options: - - label: "AI agents may pick this up (adds agent-ok)" diff --git a/.github/PROJECT_FIELDS.md b/.github/PROJECT_FIELDS.md index fe38ccf..924aff7 100644 --- a/.github/PROJECT_FIELDS.md +++ b/.github/PROJECT_FIELDS.md @@ -13,8 +13,6 @@ Every issue/PR attribute lives in **exactly one place**. Never dual-write the sa | Workflow status | **Project `Status` field** | `Backlog` / `Ready` / `In Progress` / `In Review` / `Blocked` / `Done` | | Target version | **Milestone** | `vX.Y.Z` releases, `gov-*` process phases; **no milestone = backlog** | | Effort | **Project `Effort` field** | `S` (≤ half a day) / `M` (≤ 2 days) / `L` (must be decomposed first) | -| Agent eligibility | `agent-ok` **label** | present = AI agents may self-serve when Status is `Ready` | -| Agent authorship | `by-agent` **label** | on PRs authored by an AI agent (audit trail) | | Dependencies | **Native issue relationships** | GitHub blocked-by / blocking | | Epic membership | **Native sub-issues** | parent issue with sub-issues; no `epic:*` labels | diff --git a/.github/labels.yml b/.github/labels.yml index fb6488b..0c28a63 100644 --- a/.github/labels.yml +++ b/.github/labels.yml @@ -86,14 +86,6 @@ labels: color: c5def5 description: Nice to have / polish - - name: agent-ok - color: 7057ff - description: AI agents may pick this up self-service when status is Ready - - - name: by-agent - color: bfd4f2 - description: Authored by an AI agent (audit trail) - - name: area:docs color: 1d76db description: Documentation and guides diff --git a/.github/workflows/issue-labeler.yml b/.github/workflows/issue-labeler.yml index ad9e559..6875883 100644 --- a/.github/workflows/issue-labeler.yml +++ b/.github/workflows/issue-labeler.yml @@ -1,6 +1,6 @@ name: Issue labeler -# Syncs priority:*, area:*, agent-ok and the four type:* SUBTYPE labels from +# Syncs priority:*, area:* and the four type:* SUBTYPE labels from # the issue form fields on open/edit. The issue body is untrusted input — it is # only ever read inside the actions/github-script JS sandbox # (context.payload.issue.body), never interpolated into a shell `run:` step. @@ -36,7 +36,7 @@ jobs: script: | // Parses the GitHub issue-form markdown body (###