From 203b0daf5c803cd1594d6fe866fd88e5ff95af9b Mon Sep 17 00:00:00 2001 From: Moussa Date: Fri, 18 Sep 2026 20:41:44 +0200 Subject: [PATCH 01/31] feat(mod): add offline target identity resolution and punishment request builder - add OfflineTargetIdentity record and PunishmentRequest builder - add active punishment in-memory set caches in PunishmentManager - enforce strict duration suffixes in DurationParser - replace deprecated string lookup in UserInfoCommand with UUID resolution --- .../commands/impl/UserInfoCommand.java | 15 +- .../moderator/punishments/DurationParser.java | 6 +- .../punishments/OfflineTargetIdentity.java | 12 + .../punishments/PunishmentManager.java | 278 +++++++++++++----- .../punishments/PunishmentRequest.java | 100 +++++++ .../entities/{ => powerful}/Illusioner.java | 0 .../entities/{ => powerful}/Watchling.java | 0 .../content/recipes/FishingArmorsRecipes.java | 22 ++ 8 files changed, 346 insertions(+), 87 deletions(-) create mode 100644 blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/OfflineTargetIdentity.java create mode 100644 blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentRequest.java rename blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/{ => powerful}/Illusioner.java (100%) rename blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/{ => powerful}/Watchling.java (100%) create mode 100644 blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/FishingArmorsRecipes.java diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/UserInfoCommand.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/UserInfoCommand.java index 6f3b66f1..076479f4 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/UserInfoCommand.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/UserInfoCommand.java @@ -2,6 +2,7 @@ import fr.moussax.bedrock.commands.CommandArgument; import fr.moussax.blightedMod.commands.ModerationCommand; +import fr.moussax.blightedMod.moderator.punishments.OfflineTargetIdentity; import fr.moussax.blightedMod.moderator.punishments.PunishmentData; import fr.moussax.blightedMod.moderator.punishments.PunishmentManager; import org.bukkit.Bukkit; @@ -30,19 +31,23 @@ protected boolean executeModeration(Player moderator, Command command, String la return false; } - OfflinePlayer target = Bukkit.getOfflinePlayer(arguments[0]); - if (!target.hasPlayedBefore() && !target.isOnline()) { - warn(moderator, "Unable to find player §4" + arguments[0]); + String targetNameInput = arguments[0]; + OfflineTargetIdentity targetIdentity = getPunishmentManager().resolvePlayerIdentity(targetNameInput); + Player onlinePlayer = Bukkit.getPlayerExact(targetNameInput); + + if (targetIdentity == null && onlinePlayer == null) { + warn(moderator, "Unable to find player §4" + targetNameInput); return false; } - String targetName = target.getName() != null ? target.getName() : arguments[0]; + OfflinePlayer target = onlinePlayer != null ? onlinePlayer : Bukkit.getOfflinePlayer(targetIdentity.uniqueId()); + String targetName = target.getName() != null ? target.getName() : (targetIdentity != null ? targetIdentity.name() : targetNameInput); boolean isOnline = target.isOnline(); String statusDot = isOnline ? "§a●" : "§c●"; Player targetPlayer = target.getPlayer(); List punishments = getPunishmentManager().getAllPunishments(targetName); - String ipAddress = targetPlayer != null ? PunishmentManager.getPlayerIp(targetPlayer) : resolveOfflineIp(punishments); + String ipAddress = targetPlayer != null ? PunishmentManager.getPlayerIp(targetPlayer) : (targetIdentity != null ? targetIdentity.ipAddress() : resolveOfflineIp(punishments)); long mutesCount = punishments.stream().filter(punishment -> punishment.type() == PunishmentData.PunishmentType.MUTE).count(); long bansCount = punishments.stream().filter(punishment -> punishment.type() == PunishmentData.PunishmentType.BAN || punishment.type() == PunishmentData.PunishmentType.IP_BAN).count(); diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/DurationParser.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/DurationParser.java index 966538fe..b3c1c5b1 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/DurationParser.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/DurationParser.java @@ -13,11 +13,7 @@ public static Long parseDurationSeconds(String input) { Matcher matcher = DURATION_PATTERN.matcher(input.toLowerCase()); if (!matcher.matches()) { - try { - return Long.parseLong(input); - } catch (NumberFormatException _) { - return null; - } + return null; } long value = Long.parseLong(matcher.group(1)); diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/OfflineTargetIdentity.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/OfflineTargetIdentity.java new file mode 100644 index 00000000..313e207f --- /dev/null +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/OfflineTargetIdentity.java @@ -0,0 +1,12 @@ +package fr.moussax.blightedMod.moderator.punishments; + +import java.util.UUID; + +/** + * Immutable identity record for resolving online and offline player target details. + * + * @param uniqueId player UUID + * @param name player name + * @param ipAddress player last known IP address + */ +public record OfflineTargetIdentity(UUID uniqueId, String name, String ipAddress) {} diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentManager.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentManager.java index b5db1752..ad63c4b4 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentManager.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentManager.java @@ -1,23 +1,67 @@ package fr.moussax.blightedMod.moderator.punishments; +import fr.moussax.bedrock.utils.debug.Log; +import org.bukkit.Bukkit; +import org.bukkit.command.CommandSender; import org.bukkit.entity.Player; +import org.jspecify.annotations.NonNull; +import org.jspecify.annotations.Nullable; import java.net.InetSocketAddress; import java.sql.*; -import java.util.ArrayList; -import java.util.List; -import java.util.UUID; +import java.util.*; +import java.util.concurrent.ConcurrentHashMap; public final class PunishmentManager { + public static final UUID CONSOLE_UUID = UUID.nameUUIDFromBytes("CONSOLE".getBytes(java.nio.charset.StandardCharsets.UTF_8)); + private final Connection connection; + private final Set activeMutedPlayers = ConcurrentHashMap.newKeySet(); + private final Set activeBannedPlayers = ConcurrentHashMap.newKeySet(); + private final Map playerIdentityCache = new ConcurrentHashMap<>(); - public PunishmentManager(Connection connection) { + public PunishmentManager(@NonNull Connection connection) { this.connection = connection; + initializeCache(); + } + + private void initializeCache() { + String query = """ + SELECT DISTINCT player_uuid, player_name, punishment_type, ip_address, expires_at + FROM punishments + WHERE is_active = 1 + """; + synchronized (connection) { + try (PreparedStatement statement = connection.prepareStatement(query); + ResultSet resultSet = statement.executeQuery()) { + long currentTime = System.currentTimeMillis(); + while (resultSet.next()) { + Long expiresAt = resultSet.getLong("expires_at"); + if (resultSet.wasNull()) expiresAt = null; + if (expiresAt != null && currentTime > expiresAt) continue; + + UUID playerUuid = UUID.fromString(resultSet.getString("player_uuid")); + String playerName = resultSet.getString("player_name"); + String ipAddress = resultSet.getString("ip_address"); + PunishmentData.PunishmentType type = PunishmentData.PunishmentType.valueOf(resultSet.getString("punishment_type")); + + if (type == PunishmentData.PunishmentType.MUTE) { + activeMutedPlayers.add(playerUuid); + } else if (type == PunishmentData.PunishmentType.BAN || type == PunishmentData.PunishmentType.IP_BAN) { + activeBannedPlayers.add(playerUuid); + } + + if (playerName != null && !playerName.isBlank()) { + playerIdentityCache.put(playerName.toLowerCase(Locale.ROOT), new OfflineTargetIdentity(playerUuid, playerName, ipAddress)); + } + } + } catch (SQLException exception) { + Log.error("PunishmentManager", "Failed to initialize active punishments cache: " + exception.getMessage()); + } + } } - public void addPunishment(UUID playerUuid, String playerName, PunishmentData.PunishmentType type, - String reason, UUID moderatorUuid, String moderatorName, - Long expiresAt, String ipAddress) { + public void addPunishment(@NonNull PunishmentRequest request) { String query = """ INSERT INTO punishments (player_uuid, player_name, punishment_type, reason, moderator_uuid, moderator_name, created_at, expires_at, ip_address) @@ -26,23 +70,41 @@ INSERT INTO punishments (player_uuid, player_name, punishment_type, reason, synchronized (connection) { try (PreparedStatement statement = connection.prepareStatement(query)) { - statement.setString(1, playerUuid.toString()); - statement.setString(2, playerName); - statement.setString(3, type.name()); - statement.setString(4, reason); - statement.setString(5, moderatorUuid.toString()); - statement.setString(6, moderatorName); + statement.setString(1, request.playerUuid().toString()); + statement.setString(2, request.playerName()); + statement.setString(3, request.type().name()); + statement.setString(4, request.reason()); + statement.setString(5, request.moderatorUuid().toString()); + statement.setString(6, request.moderatorName()); statement.setLong(7, System.currentTimeMillis()); - if (expiresAt != null) statement.setLong(8, expiresAt); - else statement.setNull(8, Types.INTEGER); - statement.setString(9, ipAddress); + if (request.expiresAt() != null) { + statement.setLong(8, request.expiresAt()); + } else { + statement.setNull(8, Types.INTEGER); + } + statement.setString(9, request.ipAddress()); statement.executeUpdate(); + + if (request.type() == PunishmentData.PunishmentType.MUTE) { + activeMutedPlayers.add(request.playerUuid()); + } else if (request.type() == PunishmentData.PunishmentType.BAN || request.type() == PunishmentData.PunishmentType.IP_BAN) { + activeBannedPlayers.add(request.playerUuid()); + } + + playerIdentityCache.put(request.playerName().toLowerCase(Locale.ROOT), + new OfflineTargetIdentity(request.playerUuid(), request.playerName(), request.ipAddress())); } catch (SQLException exception) { - throw new RuntimeException("Failed to add punishment", exception); + throw new RuntimeException("Failed to add " + request.type() + " punishment for player " + request.playerName(), exception); } } } + public void addPunishment(@NonNull UUID playerUuid, @NonNull String playerName, PunishmentData.@NonNull PunishmentType type, + @NonNull String reason, @NonNull UUID moderatorUuid, @NonNull String moderatorName, + @Nullable Long expiresAt, @Nullable String ipAddress) { + addPunishment(new PunishmentRequest(playerUuid, playerName, type, reason, moderatorUuid, moderatorName, expiresAt, ipAddress)); + } + public void removePunishment(UUID playerUuid, PunishmentData.PunishmentType type) { String query = """ UPDATE punishments SET is_active = 0 @@ -54,6 +116,12 @@ public void removePunishment(UUID playerUuid, PunishmentData.PunishmentType type statement.setString(1, playerUuid.toString()); statement.setString(2, type.name()); statement.executeUpdate(); + + if (type == PunishmentData.PunishmentType.MUTE) { + activeMutedPlayers.remove(playerUuid); + } else if (type == PunishmentData.PunishmentType.BAN) { + activeBannedPlayers.remove(playerUuid); + } } catch (SQLException exception) { throw new RuntimeException("Failed to remove punishment", exception); } @@ -116,6 +184,11 @@ public PunishmentData getActivePunishment(UUID playerUuid, PunishmentData.Punish if (punishment.isExpired()) { deactivatePunishment(punishment.id()); + if (type == PunishmentData.PunishmentType.MUTE) { + activeMutedPlayers.remove(playerUuid); + } else if (type == PunishmentData.PunishmentType.BAN) { + activeBannedPlayers.remove(playerUuid); + } return null; } return punishment; @@ -149,49 +222,63 @@ public PunishmentData getActiveIpBan(String ipAddress) { return punishment; } - /** - * Resolves the UUID of an actively banned player by name, using persisted punishment - * data instead of a live Mojang lookup. - * - *

Used to unban players who are offline — {@code requireTarget} only resolves - * online players, but a banned player is disconnected by the time {@code /unban} - * is run against them.

- * - * @param playerName the banned player's name - * @return the player's UUID, or {@code null} if no active ban matches - */ - public UUID resolveBannedUuidByName(String playerName) { + public OfflineTargetIdentity resolvePlayerIdentity(String playerName) { + Player onlinePlayer = Bukkit.getPlayerExact(playerName); + if (onlinePlayer != null) { + OfflineTargetIdentity identity = new OfflineTargetIdentity(onlinePlayer.getUniqueId(), onlinePlayer.getName(), getPlayerIp(onlinePlayer)); + playerIdentityCache.put(playerName.toLowerCase(Locale.ROOT), identity); + return identity; + } + + OfflineTargetIdentity cachedIdentity = playerIdentityCache.get(playerName.toLowerCase(Locale.ROOT)); + if (cachedIdentity != null) { + return cachedIdentity; + } + String query = """ - SELECT * FROM punishments - WHERE LOWER(player_name) = LOWER(?) AND punishment_type = 'BAN' AND is_active = 1 + SELECT player_uuid, player_name, ip_address FROM punishments + WHERE LOWER(player_name) = LOWER(?) ORDER BY created_at DESC LIMIT 1 """; - - PunishmentData punishment; synchronized (connection) { try (PreparedStatement statement = connection.prepareStatement(query)) { statement.setString(1, playerName); try (ResultSet resultSet = statement.executeQuery()) { - if (!resultSet.next()) return null; - punishment = mapResultSet(resultSet); + if (resultSet.next()) { + UUID uniqueId = UUID.fromString(resultSet.getString("player_uuid")); + String resolvedName = resultSet.getString("player_name"); + String ipAddress = resultSet.getString("ip_address"); + OfflineTargetIdentity identity = new OfflineTargetIdentity(uniqueId, resolvedName, ipAddress); + playerIdentityCache.put(playerName.toLowerCase(Locale.ROOT), identity); + return identity; + } } } catch (SQLException exception) { - throw new RuntimeException("Failed to resolve banned player", exception); + Log.error("PunishmentManager", "Failed to resolve player identity for " + playerName + ": " + exception.getMessage()); } } + return null; + } - if (punishment.isExpired()) { - deactivatePunishment(punishment.id()); - return null; - } - return punishment.playerUuid(); + public UUID resolveBannedUuidByName(String playerName) { + OfflineTargetIdentity identity = resolvePlayerIdentity(playerName); + if (identity == null) return null; + + PunishmentData ban = getActivePunishment(identity.uniqueId(), PunishmentData.PunishmentType.BAN); + return ban != null ? identity.uniqueId() : null; } public boolean isMuted(UUID playerUuid) { + if (!activeMutedPlayers.contains(playerUuid)) { + return false; + } return getActivePunishment(playerUuid, PunishmentData.PunishmentType.MUTE) != null; } public boolean isBanned(UUID playerUuid) { + if (!activeBannedPlayers.contains(playerUuid)) { + return false; + } return getActivePunishment(playerUuid, PunishmentData.PunishmentType.BAN) != null; } @@ -199,49 +286,86 @@ public boolean isIpBanned(String ipAddress) { return getActiveIpBan(ipAddress) != null; } - public static final UUID CONSOLE_UUID = UUID.nameUUIDFromBytes("CONSOLE".getBytes(java.nio.charset.StandardCharsets.UTF_8)); - - public static UUID getModeratorUuid(org.bukkit.command.CommandSender sender) { + public static UUID getModeratorUuid(CommandSender sender) { return sender instanceof Player player ? player.getUniqueId() : CONSOLE_UUID; } - public void addBan(Player target, org.bukkit.command.CommandSender moderator, String reason, Long expiresAt) { - addPunishment( - target.getUniqueId(), - target.getName(), - PunishmentData.PunishmentType.BAN, - reason, - getModeratorUuid(moderator), - moderator.getName(), - expiresAt, - getPlayerIp(target) - ); + public void addBan(OfflineTargetIdentity targetIdentity, CommandSender moderator, String reason, Long expiresAt) { + addPunishment(PunishmentRequest.builder() + .target(targetIdentity) + .type(PunishmentData.PunishmentType.BAN) + .moderator(moderator) + .reason(reason) + .expiresAt(expiresAt) + .build()); } - public void addMute(Player target, org.bukkit.command.CommandSender moderator, String reason, Long expiresAt) { - addPunishment( - target.getUniqueId(), - target.getName(), - PunishmentData.PunishmentType.MUTE, - reason, - getModeratorUuid(moderator), - moderator.getName(), - expiresAt, - getPlayerIp(target) - ); + public void addBan(Player target, CommandSender moderator, String reason, Long expiresAt) { + addPunishment(PunishmentRequest.builder() + .target(target) + .type(PunishmentData.PunishmentType.BAN) + .moderator(moderator) + .reason(reason) + .expiresAt(expiresAt) + .build()); } - public void addIpBan(Player target, org.bukkit.command.CommandSender moderator, String reason, Long expiresAt) { - addPunishment( - target.getUniqueId(), - target.getName(), - PunishmentData.PunishmentType.IP_BAN, - reason, - getModeratorUuid(moderator), - moderator.getName(), - expiresAt, - getPlayerIp(target) - ); + public void addMute(OfflineTargetIdentity targetIdentity, CommandSender moderator, String reason, Long expiresAt) { + addPunishment(PunishmentRequest.builder() + .target(targetIdentity) + .type(PunishmentData.PunishmentType.MUTE) + .moderator(moderator) + .reason(reason) + .expiresAt(expiresAt) + .build()); + } + + public void addMute(Player target, CommandSender moderator, String reason, Long expiresAt) { + addPunishment(PunishmentRequest.builder() + .target(target) + .type(PunishmentData.PunishmentType.MUTE) + .moderator(moderator) + .reason(reason) + .expiresAt(expiresAt) + .build()); + } + + public void addIpBan(OfflineTargetIdentity targetIdentity, CommandSender moderator, String reason, Long expiresAt) { + addPunishment(PunishmentRequest.builder() + .target(targetIdentity) + .type(PunishmentData.PunishmentType.IP_BAN) + .moderator(moderator) + .reason(reason) + .expiresAt(expiresAt) + .build()); + } + + public void addIpBan(Player target, CommandSender moderator, String reason, Long expiresAt) { + addPunishment(PunishmentRequest.builder() + .target(target) + .type(PunishmentData.PunishmentType.IP_BAN) + .moderator(moderator) + .reason(reason) + .expiresAt(expiresAt) + .build()); + } + + public void addKick(OfflineTargetIdentity targetIdentity, CommandSender moderator, String reason) { + addPunishment(PunishmentRequest.builder() + .target(targetIdentity) + .type(PunishmentData.PunishmentType.KICK) + .moderator(moderator) + .reason(reason) + .build()); + } + + public void addKick(Player target, CommandSender moderator, String reason) { + addPunishment(PunishmentRequest.builder() + .target(target) + .type(PunishmentData.PunishmentType.KICK) + .moderator(moderator) + .reason(reason) + .build()); } private PunishmentData mapResultSet(ResultSet resultSet) throws SQLException { diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentRequest.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentRequest.java new file mode 100644 index 00000000..394ff5d9 --- /dev/null +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentRequest.java @@ -0,0 +1,100 @@ +package fr.moussax.blightedMod.moderator.punishments; + +import org.bukkit.command.CommandSender; +import org.bukkit.entity.Player; +import org.jspecify.annotations.NonNull; +import org.jspecify.annotations.Nullable; + +import java.util.Objects; +import java.util.UUID; + +/** + * Domain request payload for issuing a player punishment. + * + * @param playerUuid unique identifier of the target player + * @param playerName name of the target player + * @param type type of sanction applied + * @param reason justification for the sanction + * @param moderatorUuid unique identifier of the issuer + * @param moderatorName name of the issuer + * @param expiresAt expiration timestamp in milliseconds, or {@code null} if permanent + * @param ipAddress associated IP address of the target, or {@code null} + */ +public record PunishmentRequest( + @NonNull UUID playerUuid, + @NonNull String playerName, + PunishmentData.@NonNull PunishmentType type, + @NonNull String reason, + @NonNull UUID moderatorUuid, + @NonNull String moderatorName, + @Nullable Long expiresAt, + @Nullable String ipAddress +) { + + public static Builder builder() { + return new Builder(); + } + + public static final class Builder { + private UUID playerUuid; + private String playerName; + private PunishmentData.PunishmentType type; + private String reason = "No reason specified"; + private UUID moderatorUuid = PunishmentManager.CONSOLE_UUID; + private String moderatorName = "CONSOLE"; + private Long expiresAt; + private String ipAddress; + + public Builder target(Player player) { + this.playerUuid = player.getUniqueId(); + this.playerName = player.getName(); + this.ipAddress = PunishmentManager.getPlayerIp(player); + return this; + } + + public Builder target(OfflineTargetIdentity identity) { + this.playerUuid = identity.uniqueId(); + this.playerName = identity.name(); + this.ipAddress = identity.ipAddress(); + return this; + } + + public Builder type(PunishmentData.PunishmentType type) { + this.type = type; + return this; + } + + public Builder reason(String reason) { + this.reason = reason != null && !reason.isBlank() ? reason : "No reason specified"; + return this; + } + + public Builder moderator(@Nullable CommandSender moderator) { + if (moderator != null) { + this.moderatorUuid = PunishmentManager.getModeratorUuid(moderator); + this.moderatorName = moderator.getName(); + } else { + this.moderatorUuid = PunishmentManager.CONSOLE_UUID; + this.moderatorName = "CONSOLE"; + } + return this; + } + + public Builder expiresAt(Long expiresAt) { + this.expiresAt = expiresAt; + return this; + } + + public Builder ipAddress(String ipAddress) { + this.ipAddress = ipAddress; + return this; + } + + public PunishmentRequest build() { + Objects.requireNonNull(playerUuid, "Target player UUID cannot be null"); + Objects.requireNonNull(playerName, "Target player name cannot be null"); + Objects.requireNonNull(type, "Punishment type cannot be null"); + return new PunishmentRequest(playerUuid, playerName, type, reason, moderatorUuid, moderatorName, expiresAt, ipAddress); + } + } +} diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/Illusioner.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Illusioner.java similarity index 100% rename from blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/Illusioner.java rename to blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Illusioner.java diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/Watchling.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Watchling.java similarity index 100% rename from blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/Watchling.java rename to blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Watchling.java diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/FishingArmorsRecipes.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/FishingArmorsRecipes.java new file mode 100644 index 00000000..885eaaff --- /dev/null +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/FishingArmorsRecipes.java @@ -0,0 +1,22 @@ +package fr.moussax.blightedSMP.content.recipes; + +import fr.moussax.blightedSMP.engine.items.recipes.crafting.BlightedRecipe; +import fr.moussax.blightedSMP.registry.RegistryModule; + +import java.util.function.Consumer; + +import static fr.moussax.blightedSMP.engine.items.recipes.crafting.registry.RecipeRegistry.shapedRecipe; + +public class AnglerArmorRecipe implements RegistryModule> { + + @Override + public void register(Consumer registry) { + + BlightedRecipe anglerHelmet = shapedRecipe("ANGLER_HELMET") + + + + + + } +} From 860ad737126eb0a0ff93668831527891a70712d2 Mon Sep 17 00:00:00 2001 From: Moussa Date: Fri, 18 Sep 2026 20:41:58 +0200 Subject: [PATCH 02/31] feat(mod): update sanction commands and interactive staff notifications - add offline player target support for ban and mute commands - send direct console feedback when sanctions are executed from console - format staff sanction broadcasts with interactive action components - track vanished status across moderator disconnect and reconnect sessions --- .../blightedMod/commands/impl/BanCommand.java | 110 +++++++----------- .../commands/impl/KickCommand.java | 16 +-- .../commands/impl/MuteCommand.java | 50 ++++---- .../moderator/BlightedModerator.java | 15 ++- .../moderator/ModerationManager.java | 44 ++++++- 5 files changed, 123 insertions(+), 112 deletions(-) diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/BanCommand.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/BanCommand.java index 913e0835..a3666473 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/BanCommand.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/BanCommand.java @@ -5,6 +5,8 @@ import fr.moussax.blightedMod.moderator.punishments.DurationParser; import fr.moussax.blightedMod.moderator.punishments.PunishmentArguments; import fr.moussax.blightedMod.moderator.punishments.PunishmentData; +import fr.moussax.blightedMod.moderator.punishments.OfflineTargetIdentity; +import org.bukkit.Bukkit; import org.bukkit.command.Command; import org.bukkit.command.CommandSender; import org.bukkit.entity.Player; @@ -33,24 +35,36 @@ protected boolean executeModeration(CommandSender moderator, Command command, St } private boolean handleBan(CommandSender moderator, String[] arguments) { + return executeBanOrIpBan(moderator, arguments, false); + } + + private boolean handleBanIp(CommandSender moderator, String[] arguments) { + return executeBanOrIpBan(moderator, arguments, true); + } + + private boolean executeBanOrIpBan(CommandSender moderator, String[] arguments, boolean isIpBan) { + String actionLabel = isIpBan ? "banip" : "ban"; if (arguments.length < 1) { - warn(moderator, "Usage: /ban [duration] [reason]"); + warn(moderator, "Usage: /" + actionLabel + " [duration] [reason]"); moderator.sendMessage("§7Duration format: 1d, 3w, 1m, 1y (omit for permanent)"); return false; } - Player target = requireTarget(moderator, arguments[0]); - if (target == null) { + String targetName = arguments[0]; + OfflineTargetIdentity targetIdentity = getPunishmentManager().resolvePlayerIdentity(targetName); + if (targetIdentity == null) { + warn(moderator, "Unable to find player §4" + targetName); return false; } - if (target.equals(moderator)) { - warn(moderator, "You cannot ban yourself."); + if (moderator instanceof Player executingPlayer && targetIdentity.uniqueId().equals(executingPlayer.getUniqueId())) { + warn(moderator, "You cannot " + (isIpBan ? "IP ban" : "ban") + " yourself."); return false; } - if (moderator instanceof Player && getModerationManager().isModerator(target)) { - warn(moderator, "You cannot ban another moderator."); + Player onlineTarget = Bukkit.getPlayerExact(targetName); + if (moderator instanceof Player && onlineTarget != null && getModerationManager().isModerator(onlineTarget)) { + warn(moderator, "You cannot " + (isIpBan ? "IP ban" : "ban") + " another moderator."); return false; } @@ -58,23 +72,26 @@ private boolean handleBan(CommandSender moderator, String[] arguments) { Long expiresAt = punishmentArguments.expiresAt(); String reason = punishmentArguments.reason(); - getPunishmentManager().addBan(target, moderator, reason, expiresAt); - - String durationText = expiresAt != null ? DurationParser.formatDuration(arguments[1]) : "Permanent"; - String banMessage = """ - §cYou are banned from this server! - - §7Reason: §f%s - §7Duration: §f%s + if (isIpBan) { + getPunishmentManager().addIpBan(targetIdentity, moderator, reason, expiresAt); + } else { + getPunishmentManager().addBan(targetIdentity, moderator, reason, expiresAt); + } - §7Appeal on our Discord if you believe this was a mistake.""".formatted(reason, durationText); + if (onlineTarget != null && onlineTarget.isOnline()) { + String durationText = expiresAt != null ? DurationParser.formatDuration(arguments[1]) : "Permanent"; + String header = isIpBan ? "§cYour IP address is banned from this server!" : "§cYou are banned from this server!"; + String banMessage = """ + %s - target.kickPlayer(banMessage); + §7Reason: §f%s + §7Duration: §f%s - String durationString = expiresAt != null ? " for §6" + durationText + "§e" : " permanently"; - String notification = " §d§lSTAFF! §9" + moderator.getName() + "§e banned §d" + target.getName() + "§e" + durationString + " for §c" + reason + "§e."; - getModerationManager().broadcastToModerators(notification); + §7Appeal on our Discord if you believe this was a mistake.""".formatted(header, reason, durationText); + onlineTarget.kickPlayer(banMessage); + } + getModerationManager().handleSanctionNotification(moderator, targetIdentity.name(), isIpBan ? "IP banned" : "banned"); return true; } @@ -93,54 +110,7 @@ private boolean handleUnban(CommandSender moderator, String[] arguments) { } getPunishmentManager().removePunishment(targetId, PunishmentData.PunishmentType.BAN); - - String notification = " §d§lSTAFF! §9" + moderator.getName() + "§e unbanned §d" + targetName + "§e."; - getModerationManager().broadcastToModerators(notification); - - return true; - } - - private boolean handleBanIp(CommandSender moderator, String[] arguments) { - if (arguments.length < 1) { - warn(moderator, "Usage: /banip [duration] [reason]"); - moderator.sendMessage("§7Duration format: 1d, 3w, 1m, 1y (omit for permanent)"); - return false; - } - - Player target = requireTarget(moderator, arguments[0]); - if (target == null) { - return false; - } - - if (target.equals(moderator)) { - warn(moderator, "You cannot IP ban yourself."); - return false; - } - - if (moderator instanceof Player && getModerationManager().isModerator(target)) { - warn(moderator, "You cannot IP ban another moderator."); - return false; - } - - PunishmentArguments punishmentArguments = PunishmentArguments.parse(arguments, 1); - Long expiresAt = punishmentArguments.expiresAt(); - String reason = punishmentArguments.reason(); - - getPunishmentManager().addIpBan(target, moderator, reason, expiresAt); - - String durationText = expiresAt != null ? DurationParser.formatDuration(arguments[1]) : "Permanent"; - String banMessage = """ - §cYour IP address is banned from this server! - - §7Reason: §f%s - §7Duration: §f%s - - §7Appeal on our Discord if you believe this was a mistake.""".formatted(reason, durationText); - - target.kickPlayer(banMessage); - - String notification = " §d§lSTAFF! §9" + moderator.getName() + "§e IP banned §d" + target.getName() + "§e for §c" + reason + "§e."; - getModerationManager().broadcastToModerators(notification); + getModerationManager().handleSanctionNotification(moderator, targetName, "unbanned"); return true; } @@ -172,9 +142,7 @@ private boolean handleUnbanIp(CommandSender moderator, String[] arguments) { } getPunishmentManager().removeIpPunishment(ipAddress); - - String notification = " §d§lSTAFF! §9" + moderator.getName() + "§e unbanned IP for §d" + targetName + "§e."; - getModerationManager().broadcastToModerators(notification); + getModerationManager().handleSanctionNotification(moderator, targetName, "unbanned IP"); return true; } diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/KickCommand.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/KickCommand.java index e22e5c6b..4502d648 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/KickCommand.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/KickCommand.java @@ -45,18 +45,7 @@ protected boolean executeModeration(CommandSender moderator, Command command, St String reason = arguments.length > 1 ? String.join(" ", Arrays.copyOfRange(arguments, 1, arguments.length)) : "No reason specified"; - String ipAddress = PunishmentManager.getPlayerIp(target); - - getPunishmentManager().addPunishment( - target.getUniqueId(), - target.getName(), - PunishmentData.PunishmentType.KICK, - reason, - PunishmentManager.getModeratorUuid(moderator), - moderator.getName(), - null, - ipAddress - ); + getPunishmentManager().addKick(target, moderator, reason); String kickMessage = """ §cYou are kicked from this server! @@ -66,8 +55,7 @@ protected boolean executeModeration(CommandSender moderator, Command command, St target.kickPlayer(kickMessage); - String notification = " §d§lSTAFF! §9" + moderator.getName() + "§e kicked §d" + target.getName() + "§e for §c" + reason + "§e."; - getModerationManager().broadcastToModerators(notification); + getModerationManager().handleSanctionNotification(moderator, target.getName(), "kicked"); return true; } diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/MuteCommand.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/MuteCommand.java index fb2ae10a..c9d63a5a 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/MuteCommand.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/MuteCommand.java @@ -3,8 +3,10 @@ import fr.moussax.bedrock.commands.CommandArgument; import fr.moussax.blightedMod.commands.ModerationCommand; import fr.moussax.blightedMod.moderator.punishments.DurationParser; +import fr.moussax.blightedMod.moderator.punishments.OfflineTargetIdentity; import fr.moussax.blightedMod.moderator.punishments.PunishmentArguments; import fr.moussax.blightedMod.moderator.punishments.PunishmentData; +import org.bukkit.Bukkit; import org.bukkit.command.Command; import org.bukkit.command.CommandSender; import org.bukkit.entity.Player; @@ -35,17 +37,20 @@ private boolean handleMute(CommandSender moderator, String[] arguments) { return false; } - Player target = requireTarget(moderator, arguments[0]); - if (target == null) { + String targetName = arguments[0]; + OfflineTargetIdentity targetIdentity = getPunishmentManager().resolvePlayerIdentity(targetName); + if (targetIdentity == null) { + warn(moderator, "Unable to find player §4" + targetName); return false; } - if (target.equals(moderator)) { + if (moderator instanceof Player executingPlayer && targetIdentity.uniqueId().equals(executingPlayer.getUniqueId())) { warn(moderator, "You cannot mute yourself."); return false; } - if (moderator instanceof Player && getModerationManager().isModerator(target)) { + Player onlineTarget = Bukkit.getPlayerExact(targetName); + if (moderator instanceof Player && onlineTarget != null && getModerationManager().isModerator(onlineTarget)) { warn(moderator, "You cannot mute another moderator."); return false; } @@ -54,16 +59,15 @@ private boolean handleMute(CommandSender moderator, String[] arguments) { Long expiresAt = punishmentArguments.expiresAt(); String reason = punishmentArguments.reason(); - getPunishmentManager().addMute(target, moderator, reason, expiresAt); + getPunishmentManager().addMute(targetIdentity, moderator, reason, expiresAt); - String durationText = expiresAt != null ? "for §6" + DurationParser.formatDuration(arguments[1]) + " " : ""; - String notification = " §d§lSTAFF! §9" + moderator.getName() + "§e muted §d" + target.getName() + " §e" + durationText + "§efor §c" + reason + "§e."; - - getModerationManager().broadcastToModerators(notification); - if (expiresAt != null) { - target.sendMessage(" §c⌚ §cYou are muted for §d" + arguments[1] + " §cfor §b" + reason + "§c."); - } else { - target.sendMessage(" §c⌚ §cYou are muted §cfor §b" + reason + "§c."); + getModerationManager().handleSanctionNotification(moderator, targetIdentity.name(), "muted"); + if (onlineTarget != null && onlineTarget.isOnline()) { + if (expiresAt != null) { + onlineTarget.sendMessage(" §c⌚ §cYou are muted for §d" + arguments[1] + " §cfor §b" + reason + "§c."); + } else { + onlineTarget.sendMessage(" §c⌚ §cYou are muted §cfor §b" + reason + "§c."); + } } return true; @@ -75,21 +79,27 @@ private boolean handleUnmute(CommandSender moderator, String[] arguments) { return false; } - Player target = requireTarget(moderator, arguments[0]); - if (target == null) { + String targetName = arguments[0]; + OfflineTargetIdentity targetIdentity = getPunishmentManager().resolvePlayerIdentity(targetName); + if (targetIdentity == null) { + warn(moderator, "Unable to find player §4" + targetName); return false; } - if (!getPunishmentManager().isMuted(target.getUniqueId())) { - warn(moderator, target.getName() + " is not muted."); + if (!getPunishmentManager().isMuted(targetIdentity.uniqueId())) { + warn(moderator, targetIdentity.name() + " is not muted."); return false; } - getPunishmentManager().removePunishment(target.getUniqueId(), PunishmentData.PunishmentType.MUTE); + getPunishmentManager().removePunishment(targetIdentity.uniqueId(), PunishmentData.PunishmentType.MUTE); - String notification = " §d§lSTAFF! §9" + moderator.getName() + "§e unmuted §d" + target.getName() + "§e."; + String notification = " §d§lSTAFF! §9" + moderator.getName() + "§e unmuted §d" + targetIdentity.name() + "§e."; getModerationManager().broadcastToModerators(notification); - target.sendMessage(" §a⚑ §7You are no longer muted."); + + Player onlineTarget = Bukkit.getPlayerExact(targetName); + if (onlineTarget != null && onlineTarget.isOnline()) { + onlineTarget.sendMessage(" §a⚑ §7You are no longer muted."); + } return true; } } diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/BlightedModerator.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/BlightedModerator.java index c4c640fb..3f9332c8 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/BlightedModerator.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/BlightedModerator.java @@ -60,7 +60,7 @@ public void onEnable() { saveState(); clearPlayerState(); applyModerationState(); - setVanished(true, true); + setVanished(true, false); giveModerationTools(); this.isInModerationMode = true; @@ -74,7 +74,7 @@ public void onDisable() { } player.getInventory().clear(); restoreState(); - setVanished(false, true); + setVanished(false, false); this.isInModerationMode = false; player.sendMessage(" §dModeration Mode §etoggled §cOFF§e."); @@ -148,20 +148,25 @@ public void giveModerationTools() { public void setVanished(boolean vanished, boolean notifyPlayer) { this.isVanished = vanished; + ModerationManager.getInstance().setVanished(player.getUniqueId(), vanished); JavaPlugin instance = BlightedMod.getInstance(); if (vanished) { hideFromNonModerators(instance); - if (!notifyPlayer) player.sendMessage(" §dVanish §etoggled §aON§e."); + if (notifyPlayer) { + player.sendMessage(" §dVanish §etoggled §aON§e."); + } } else { showToAllPlayers(instance); - if (!notifyPlayer) player.sendMessage(" §dVanish §etoggled §cOFF§e."); + if (notifyPlayer) { + player.sendMessage(" §dVanish §etoggled §cOFF§e."); + } } updateVanishTool(); } public void setVanished(boolean vanished) { - setVanished(vanished, false); + setVanished(vanished, true); } private void hideFromNonModerators(JavaPlugin instance) { diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationManager.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationManager.java index 129d137b..930a12b5 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationManager.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationManager.java @@ -6,6 +6,7 @@ import lombok.Getter; import org.bukkit.Bukkit; import org.bukkit.Location; +import org.bukkit.command.CommandSender; import org.bukkit.entity.Player; import java.util.*; @@ -23,12 +24,13 @@ public enum ChatChannel { @Getter private final PunishmentManager punishmentManager; private final Map moderators = new ConcurrentHashMap<>(); - private final Set frozenPlayers = new HashSet<>(); + private final Set frozenPlayers = ConcurrentHashMap.newKeySet(); private final Map frozenLocations = new ConcurrentHashMap<>(); private final Map lastChatTimestamps = new ConcurrentHashMap<>(); private final Map playerChatChannels = new ConcurrentHashMap<>(); private final Set messageInspectEnabled = ConcurrentHashMap.newKeySet(); private final Map lastMessageTargets = new ConcurrentHashMap<>(); + private final Set vanishedPlayers = ConcurrentHashMap.newKeySet(); @Getter private int slowmodeDelaySeconds = 0; @@ -52,7 +54,11 @@ public static ModerationManager getInstance() { } public BlightedModerator getModerator(Player player) { - return moderators.computeIfAbsent(player.getUniqueId(), _ -> new BlightedModerator(player)); + BlightedModerator moderator = moderators.computeIfAbsent(player.getUniqueId(), _ -> new BlightedModerator(player)); + if (vanishedPlayers.contains(player.getUniqueId()) && !moderator.isVanished()) { + moderator.setVanished(true, false); + } + return moderator; } public BlightedModerator getModeratorIfPresent(Player player) { @@ -154,6 +160,40 @@ public void broadcastToModerators(InteractiveMessage interactiveMessage) { .forEach(interactiveMessage::send); } + public void broadcastToModeratorsExcept(CommandSender excludedModerator, InteractiveMessage interactiveMessage) { + Bukkit.getOnlinePlayers().stream() + .filter(this::isModerator) + .filter(moderator -> !moderator.equals(excludedModerator)) + .forEach(interactiveMessage::send); + } + + public void handleSanctionNotification(CommandSender moderator, String targetName, String actionDescription) { + if (moderator instanceof Player executingPlayer) { + InteractiveMessage.text(" §eSanction applied to §d" + targetName + "§7∙ ") + .hoverAndExecute("§3[View Details]", "§fClick to view sanctions for §d" + targetName + "§f.", "/sanctions " + targetName) + .send(executingPlayer); + } else { + moderator.sendMessage(" §eSanction applied to §d" + targetName + "."); + } + + InteractiveMessage staffMessage = InteractiveMessage.text(" §d§lSTAFF! §9" + moderator.getName() + " §e" + actionDescription + " §d" + targetName + "§7∙ ") + .hoverAndExecute("§3[View Details]", "§fClick to view sanctions for §d" + targetName + "§f.", "/sanctions " + targetName); + + broadcastToModeratorsExcept(moderator, staffMessage); + } + + public boolean isVanished(UUID playerId) { + return vanishedPlayers.contains(playerId); + } + + public void setVanished(UUID playerId, boolean vanished) { + if (vanished) { + vanishedPlayers.add(playerId); + } else { + vanishedPlayers.remove(playerId); + } + } + public ChatChannel getChatChannel(Player player) { return playerChatChannels.getOrDefault(player.getUniqueId(), ChatChannel.ALL); } From 3d2b7870396a88a454bc786b30a512d09e08955a Mon Sep 17 00:00:00 2001 From: Moussa Date: Fri, 18 Sep 2026 20:42:14 +0200 Subject: [PATCH 03/31] fix(mod): enforce muted command restrictions and allow offline target reports - block private messaging commands for muted players in ModerationListener - correct InteractiveChatListener priority to HIGHEST - update report notification format and allow reporting offline players - restore real-time TickableMenu updates in SanctionsMenu --- .../commands/impl/ReportCommand.java | 20 +-- .../listeners/InteractiveChatListener.java | 2 +- .../listeners/ModerationListener.java | 142 ++++++++++++++---- .../moderator/menus/SanctionsMenu.java | 2 +- .../moderator/reports/ReportManager.java | 10 +- 5 files changed, 125 insertions(+), 51 deletions(-) diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ReportCommand.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ReportCommand.java index 0971e069..0c8c99a0 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ReportCommand.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ReportCommand.java @@ -37,12 +37,9 @@ protected boolean execute(Player player, Command command, String label, String[] } if (subAction.equalsIgnoreCase("submit") && arguments.length >= 3) { - Player target = requireTarget(player, arguments[1]); - if (target == null) { - return false; - } + String targetName = arguments[1]; - if (target.equals(player)) { + if (player.getName().equalsIgnoreCase(targetName)) { warn(player, "You cannot report yourself."); return false; } @@ -52,25 +49,22 @@ protected boolean execute(Player player, Command command, String label, String[] ? String.join(" ", Arrays.copyOfRange(arguments, 3, arguments.length)) : "No message content"; - submitDirectReport(player, target.getName(), reason, chatMessage); + submitDirectReport(player, targetName, reason, chatMessage); return true; } - Player target = requireTarget(player, subAction); - if (target == null) { - return false; - } + String targetName = subAction; - if (target.equals(player)) { + if (player.getName().equalsIgnoreCase(targetName)) { warn(player, "You cannot report yourself."); return false; } if (arguments.length > 1) { String reason = String.join(" ", Arrays.copyOfRange(arguments, 1, arguments.length)); - submitDirectReport(player, target.getName(), reason, "General player report"); + submitDirectReport(player, targetName, reason, "General player report"); } else { - new ReportMenu(target.getName()).open(player); + new ReportMenu(targetName).open(player); } return true; diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/listeners/InteractiveChatListener.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/listeners/InteractiveChatListener.java index 73f586cf..835bd2a9 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/listeners/InteractiveChatListener.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/listeners/InteractiveChatListener.java @@ -16,7 +16,7 @@ public InteractiveChatListener(ModerationManager moderationManager) { this.moderationManager = moderationManager; } - @EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true) + @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true) public void onNormalPlayerChat(AsyncPlayerChatEvent event) { Player sender = event.getPlayer(); String chatMessage = event.getMessage(); diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/listeners/ModerationListener.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/listeners/ModerationListener.java index cc52ed13..4f1a26f3 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/listeners/ModerationListener.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/listeners/ModerationListener.java @@ -1,14 +1,18 @@ package fr.moussax.blightedMod.moderator.listeners; import fr.moussax.bedrock.text.InteractiveMessage; +import fr.moussax.bedrock.ui.menu.Menu; +import fr.moussax.bedrock.ui.menu.types.InteractiveMenu; import fr.moussax.blightedMod.BlightedMod; import fr.moussax.blightedMod.moderator.BlightedModerator; +import fr.moussax.blightedMod.moderator.ModerationGlowHelper; import fr.moussax.blightedMod.moderator.ModerationManager; import fr.moussax.blightedMod.moderator.menus.InvSeeMenu; import fr.moussax.blightedMod.moderator.punishments.DurationParser; import fr.moussax.blightedMod.moderator.punishments.PunishmentData; import fr.moussax.blightedMod.moderator.punishments.PunishmentManager; import org.bukkit.Bukkit; +import org.bukkit.Location; import org.bukkit.Material; import org.bukkit.entity.Player; import org.bukkit.event.EventHandler; @@ -20,6 +24,7 @@ import org.bukkit.event.entity.EntityDamageByEntityEvent; import org.bukkit.event.entity.EntityDamageEvent; import org.bukkit.event.entity.EntityPickupItemEvent; +import org.bukkit.event.entity.EntityTargetLivingEntityEvent; import org.bukkit.event.entity.FoodLevelChangeEvent; import org.bukkit.event.inventory.InventoryClickEvent; import org.bukkit.event.player.*; @@ -165,9 +170,13 @@ public void onPlayerJoin(PlayerJoinEvent event) { Player joiningPlayer = event.getPlayer(); if (moderationManager.isModerator(joiningPlayer)) { BlightedModerator moderator = moderationManager.getModerator(joiningPlayer); - if (moderator.isVanished()) { + boolean isVanished = moderator.isVanished(); + if (isVanished) { event.setJoinMessage(null); } + String notification = " §d§lSTAFF! §9" + joiningPlayer.getName() + " §econnected." + + (isVanished ? " §7(Vanished)" : ""); + moderationManager.broadcastToModerators(notification); return; } @@ -177,30 +186,48 @@ public void onPlayerJoin(PlayerJoinEvent event) { BlightedMod.getInstance(), moderator.getPlayer())); } + @EventHandler + public void onPlayerChangedWorld(PlayerChangedWorldEvent event) { + Player player = event.getPlayer(); + if (moderationManager.isInModerationMode(player)) { + BlightedModerator moderator = moderationManager.getModerator(player); + Player target = moderator.getTargetPlayer(); + if (target != null && target.isOnline() && target.getWorld().equals(player.getWorld())) { + ModerationGlowHelper.applyPinkGlow(player, target); + } + } + } + + @EventHandler + public void onPlayerRespawn(PlayerRespawnEvent event) { + Player player = event.getPlayer(); + moderationManager.getModeratorsView().values().stream() + .filter(BlightedModerator::isInModerationMode) + .forEach(moderator -> { + if (Objects.equals(moderator.getTargetPlayer(), player) && moderator.getPlayer().getWorld().equals(event.getRespawnLocation().getWorld())) { + ModerationGlowHelper.applyPinkGlow(moderator.getPlayer(), player); + } + }); + } + @EventHandler public void onPlayerQuit(PlayerQuitEvent event) { Player quittingPlayer = event.getPlayer(); if (moderationManager.isModerator(quittingPlayer)) { - BlightedModerator moderator = moderationManager.getModerator(quittingPlayer); - if (moderator.isVanished()) { + BlightedModerator moderator = moderationManager.getModeratorIfPresent(quittingPlayer); + boolean isVanished = moderator != null ? moderator.isVanished() : moderationManager.isVanished(quittingPlayer.getUniqueId()); + if (isVanished) { event.setQuitMessage(null); } + String notification = " §d§lSTAFF! §9" + quittingPlayer.getName() + " §edisconnected." + + (isVanished ? " §7(Vanished)" : ""); + moderationManager.broadcastToModerators(notification); } if (!moderationManager.isModerator(quittingPlayer) && moderationManager.isFrozen(quittingPlayer)) { moderationManager.toggleFreeze(quittingPlayer); String reason = "Disconnecting while frozen by a moderator"; - String ipAddress = PunishmentManager.getPlayerIp(quittingPlayer); - punishmentManager.addPunishment( - quittingPlayer.getUniqueId(), - quittingPlayer.getName(), - PunishmentData.PunishmentType.BAN, - reason, - PunishmentManager.CONSOLE_UUID, - "CONSOLE", - null, - ipAddress - ); + punishmentManager.addBan(quittingPlayer, null, reason, null); String notification = " §6§lALERT! §d" + quittingPlayer.getName() + "§e was automatically banned for §fdisconnecting §ewhile being frozen by a moderator."; moderationManager.broadcastToModerators(notification); @@ -228,10 +255,10 @@ public void onFrozenPlayerMove(PlayerMoveEvent event) { Player player = event.getPlayer(); if (moderationManager.isModerator(player) || !moderationManager.isFrozen(player)) return; - org.bukkit.Location frozenLocation = moderationManager.getFrozenLocation(player); + Location frozenLocation = moderationManager.getFrozenLocation(player); if (frozenLocation == null) return; - org.bukkit.Location to = event.getTo(); + Location to = event.getTo(); if (to == null) return; double deltaX = to.getX() - frozenLocation.getX(); @@ -240,22 +267,36 @@ public void onFrozenPlayerMove(PlayerMoveEvent event) { double distanceSquared = deltaX * deltaX + deltaY * deltaY + deltaZ * deltaZ; if (distanceSquared > 0.05) { - org.bukkit.Location returnLocation = frozenLocation.clone(); + Location returnLocation = frozenLocation.clone(); returnLocation.setYaw(to.getYaw()); returnLocation.setPitch(to.getPitch()); event.setTo(returnLocation); } } - @EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true) - public void onPrivateMessageSpy(PlayerCommandPreprocessEvent event) { - String rawCommandLine = event.getMessage(); - if (!rawCommandLine.startsWith("/")) { + @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true) + public void onMutedPlayerCommand(PlayerCommandPreprocessEvent event) { + Player player = event.getPlayer(); + if (moderationManager.isModerator(player) || !punishmentManager.isMuted(player.getUniqueId())) { return; } - String[] parts = rawCommandLine.substring(1).trim().split("\\s+"); - if (parts.length == 0 || parts[0].isEmpty()) { + String[] parts = extractCommandParts(event.getMessage()); + if (parts.length == 0) { + return; + } + + String commandLabel = parts[0].toLowerCase(Locale.ROOT); + if (Set.of("msg", "tell", "w", "whisper", "pm", "r", "reply", "me").contains(commandLabel)) { + event.setCancelled(true); + player.sendMessage(" §c⌚ §cYou are muted and cannot send private messages."); + } + } + + @EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true) + public void onPrivateMessageSpy(PlayerCommandPreprocessEvent event) { + String[] parts = extractCommandParts(event.getMessage()); + if (parts.length == 0) { return; } @@ -268,7 +309,7 @@ public void onPrivateMessageSpy(PlayerCommandPreprocessEvent event) { } String targetName = parts[1]; - Player targetPlayer = Bukkit.getPlayer(targetName); + Player targetPlayer = Bukkit.getPlayerExact(targetName); String recipientName = targetPlayer != null ? targetPlayer.getName() : targetName; String messageContent = String.join(" ", Arrays.copyOfRange(parts, 2, parts.length)); @@ -291,6 +332,19 @@ public void onPrivateMessageSpy(PlayerCommandPreprocessEvent event) { } } + private String[] extractCommandParts(String rawCommandLine) { + if (rawCommandLine == null || !rawCommandLine.startsWith("/")) { + return new String[0]; + } + + String[] parts = rawCommandLine.substring(1).trim().split("\\s+"); + if (parts.length == 0 || parts[0].isEmpty()) { + return new String[0]; + } + + return parts; + } + @EventHandler public void onModeratorDropItem(PlayerDropItemEvent event) { if (moderationManager.isInModerationMode(event.getPlayer())) { @@ -305,6 +359,28 @@ public void onModeratorPickupItem(EntityPickupItemEvent event) { } } + @EventHandler + public void onModeratorExpChange(PlayerExpChangeEvent event) { + if (moderationManager.isInModerationMode(event.getPlayer())) { + event.setAmount(0); + } + } + + @EventHandler + public void onMobTargetModerator(EntityTargetLivingEntityEvent event) { + if (event.getTarget() instanceof Player targetPlayer && moderationManager.isInModerationMode(targetPlayer)) { + event.setCancelled(true); + event.setTarget(null); + } + } + + @EventHandler + public void onModeratorPhysicalInteract(PlayerInteractEvent event) { + if (event.getAction() == Action.PHYSICAL && moderationManager.isInModerationMode(event.getPlayer())) { + event.setCancelled(true); + } + } + @EventHandler public void onModeratorBreakBlock(BlockBreakEvent event) { if (moderationManager.isInModerationMode(event.getPlayer())) event.setCancelled(true); @@ -338,9 +414,10 @@ public void onModeratorEntityDamage(EntityDamageByEntityEvent event) { if (!moderationManager.isInModerationMode(attacker)) return; Material tool = attacker.getInventory().getItemInMainHand().getType(); - if (tool == Material.STICK && event.getEntity() instanceof Player victim) { - moderationManager.getModerator(attacker).setTargetPlayer(victim); - event.setDamage(0); + if (tool == Material.STICK) { + if (event.getEntity() instanceof Player victim) { + moderationManager.getModerator(attacker).setTargetPlayer(victim); + } return; } @@ -350,6 +427,11 @@ public void onModeratorEntityDamage(EntityDamageByEntityEvent event) { @EventHandler public void onModeratorInventoryClick(InventoryClickEvent event) { if (event.getWhoClicked() instanceof Player player && moderationManager.isInModerationMode(player)) { + if (event.getView().getTopInventory().getHolder() instanceof Menu menu) { + if (menu instanceof InteractiveMenu || menu.isInteractable(event.getRawSlot())) { + return; + } + } event.setCancelled(true); } } @@ -423,7 +505,7 @@ private void teleportToRandomPlayer(Player moderator) { eligiblePlayers.remove(moderator); if (eligiblePlayers.isEmpty()) { - moderator.sendMessage("§cNo other players online."); + warn(moderator, "No other players online."); return; } @@ -431,8 +513,8 @@ private void teleportToRandomPlayer(Player moderator) { moderator.teleport(target.getLocation()); moderationManager.getModerator(moderator).setTargetPlayer(target); - InteractiveMessage.text(" §eRandomly teleported to §d" + target.getName() + "§e. ") - .hoverAndExecute("§3[INFO]", "§fClick to view information about §d" + target.getName() + "§f.", "/userinfo " + target.getName()) + InteractiveMessage.text(" §eRandomly teleported to §d" + target.getName()) + .hoverAndExecute("§7∙ §3[Info]", "§fClick to view information about §d" + target.getName() + "§f.", "/userinfo " + target.getName()) .send(moderator); } } diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/menus/SanctionsMenu.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/menus/SanctionsMenu.java index 92e28f6f..9fa657d7 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/menus/SanctionsMenu.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/menus/SanctionsMenu.java @@ -185,7 +185,7 @@ protected int[] getDisplaySlots() { protected ItemStack getEmptyStateItem(@NonNull Player player) { return new ItemBuilder(Material.RED_STAINED_GLASS_PANE) .setDisplayName("§cNo Sanctions Found") - .addLore("§7No sanctions match the current filter.") + .addLore("§7No sanctions match the", "§7current filter.") .toItemStack(); } diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/reports/ReportManager.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/reports/ReportManager.java index a4148e05..bb7aa0b8 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/reports/ReportManager.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/reports/ReportManager.java @@ -39,14 +39,12 @@ public ReportData submitReport(String reporterName, String targetName, String re public void submitAndNotify(Player reporter, String targetName, String reason, String message) { ReportData report = submitReport(reporter.getName(), targetName, reason, message); - inform(reporter, " §a⚑ §7Your report §7has been submitted to online staff."); + inform(reporter, " §a⚑ §7Your report has been submitted to online staff."); - InteractiveMessage notificationMessage = InteractiveMessage.text(" §d§lSTAFF! §f" + reporter.getName() + " §ereported §d" + targetName + " §efor §c" + reason + "§e. ") - .hoverAndExecute("§6[DETAILS]", "§fClick to view §dreport §fdetails.", "/checkreport " + report.id()) + InteractiveMessage notificationMessage = InteractiveMessage.text(" §6§lALERT! §d" + targetName + " §ehas been reported§7∙ ") + .hoverAndExecute("§3[Details]", "§fClick to view §dreport §fdetails.", "/checkreport " + report.id()) .append(" ") - .hoverAndExecute("§b[MTP]", "§fClick to teleport to §d" + targetName + "§f.", "/mtp " + targetName) - .append(" ") - .hoverAndExecute("§3[INFO]", "§fClick to view information about §d" + targetName + "§f.", "/userinfo " + targetName); + .hoverAndExecute("§e[MTP]", "§fClick to teleport to §d" + targetName + "§f.", "/mtp " + targetName); ModerationManager.getInstance().broadcastToModerators(notificationMessage); } From f2381347fcebd5da3445599d8c12d3a34455974f Mon Sep 17 00:00:00 2001 From: Moussa Date: Fri, 18 Sep 2026 20:44:40 +0200 Subject: [PATCH 04/31] fix(mod): improve moderation command feedback and ensure target player is set only in moderation mode --- .../commands/impl/ModTpCommands.java | 10 ++++--- .../commands/impl/ReportsCommand.java | 2 +- .../commands/impl/SanctionsCommand.java | 2 +- .../commands/impl/TargetCommand.java | 4 +-- .../blightedMod/database/PluginDatabase.java | 3 +++ .../moderator/ModerationGlowHelper.java | 14 +++++++--- .../moderator/ModerationTools.java | 4 +++ .../moderator/hud/ModerationHud.java | 9 +++++-- .../registry/CommandsRegistry.java | 26 +------------------ .../blightedMod/registry/EventsRegistry.java | 1 - 10 files changed, 35 insertions(+), 40 deletions(-) diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ModTpCommands.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ModTpCommands.java index 0dfdcece..cb13de7d 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ModTpCommands.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ModTpCommands.java @@ -36,14 +36,16 @@ protected boolean executeModeration(Player moderator, Command command, String la moderator.teleport(target.getLocation()); } - getModerationManager().getModerator(moderator).setTargetPlayer(target); + if (getModerationManager().isInModerationMode(moderator)) { + getModerationManager().getModerator(moderator).setTargetPlayer(target); + } String textMessage = isHere - ? " §eTeleported §d" + target.getName() + "§e to you. " - : " §eTeleported to §d" + target.getName() + "§e. "; + ? " §eTeleported §d" + target.getName() + "§e to you" + : " §eTeleported to §d" + target.getName(); InteractiveMessage.text(textMessage) - .hoverAndExecute("§3[INFO]", "§fClick to view information about §d" + target.getName() + "§f.", "/userinfo " + target.getName()) + .hoverAndExecute("§7∙ §3[Info]", "§fClick to view information about §d" + target.getName() + "§f.", "/userinfo " + target.getName()) .send(moderator); return true; diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ReportsCommand.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ReportsCommand.java index 5fb39b07..b0229eac 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ReportsCommand.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/ReportsCommand.java @@ -18,7 +18,7 @@ protected boolean executeModeration(Player moderator, Command command, String la int reportId = Integer.parseInt(arguments[1]); boolean dismissed = ReportManager.getInstance().dismissReport(reportId); if (dismissed) { - inform(moderator, "§eDismissed report §d#" + reportId +"§e."); + inform(moderator, " §eDismissed report §d#" + reportId + "§e."); } else { warn(moderator, "Report #" + reportId + " not found or already dismissed."); } diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/SanctionsCommand.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/SanctionsCommand.java index 427e1708..0c4aaa55 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/SanctionsCommand.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/SanctionsCommand.java @@ -25,7 +25,7 @@ protected boolean executeModeration(Player moderator, Command command, String la List punishments = getPunishmentManager().getAllPunishments(targetName); if (punishments.isEmpty()) { - warn(moderator, "No recorded sanctions found for player §4" + targetName + "§c."); + warn(moderator, "No recorded sanctions found for §4" + targetName + "§c."); return true; } diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/TargetCommand.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/TargetCommand.java index 46b4c12f..1b06b522 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/TargetCommand.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/commands/impl/TargetCommand.java @@ -39,9 +39,7 @@ protected boolean executeModeration(Player moderator, Command command, String la } blightedModerator.setTargetPlayer(target); - InteractiveMessage.text(" §eTargeting §d" + target.getName() + " §ewith §fModeration HUD§e. ") - .hoverAndExecute("§3[INFO]", "§fClick to view information about §d" + target.getName() + "§f.", "/userinfo " + target.getName()) - .send(moderator); + inform(moderator, " §eTargeting §d" + target.getName() + " §ewith §fModeration HUD§e."); return true; } } diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/database/PluginDatabase.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/database/PluginDatabase.java index f222bef0..077edfc1 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/database/PluginDatabase.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/database/PluginDatabase.java @@ -50,6 +50,9 @@ CREATE TABLE IF NOT EXISTS punishments ( ) """ ); + statement.execute("CREATE INDEX IF NOT EXISTS idx_punishments_player_uuid ON punishments(player_uuid)"); + statement.execute("CREATE INDEX IF NOT EXISTS idx_punishments_ip_address ON punishments(ip_address)"); + statement.execute("CREATE INDEX IF NOT EXISTS idx_punishments_player_name ON punishments(player_name)"); } } } diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationGlowHelper.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationGlowHelper.java index cae0bb9b..49c65a8d 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationGlowHelper.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationGlowHelper.java @@ -23,6 +23,7 @@ public final class ModerationGlowHelper { private static final String GLOW_TEAM_NAME = "mod_glow_pink"; private static final Map ORIGINAL_SCOREBOARDS = new ConcurrentHashMap<>(); + private static final EntityDataAccessor DATA_SHARED_FLAGS = new EntityDataAccessor<>(0, EntityDataSerializers.BYTE); private ModerationGlowHelper() { } @@ -32,6 +33,10 @@ public static void applyPinkGlow(Player moderator, Player target) { return; } + if (!moderator.getWorld().equals(target.getWorld())) { + return; + } + ScoreboardManager manager = Bukkit.getScoreboardManager(); if (manager == null) { return; @@ -68,7 +73,7 @@ public static void removePinkGlow(Player moderator, Player target) { team.removeEntry(target.getName()); } - if (target.isOnline()) { + if (target.isOnline() && moderator.getWorld().equals(target.getWorld())) { sendGlowPacket(moderator, target, false); } @@ -82,14 +87,17 @@ public static void removePinkGlow(Player moderator, Player target) { private static void sendGlowPacket(Player moderator, Player target, boolean glowing) { try { + if (!moderator.isOnline() || !target.isOnline() || !moderator.getWorld().equals(target.getWorld())) { + return; + } CraftPlayer craftTarget = (CraftPlayer) target; CraftPlayer craftModerator = (CraftPlayer) moderator; - byte existingFlags = craftTarget.getHandle().getEntityData().get(new EntityDataAccessor<>(0, EntityDataSerializers.BYTE)); + byte existingFlags = craftTarget.getHandle().getEntityData().get(DATA_SHARED_FLAGS); byte updatedFlags = glowing ? (byte) (existingFlags | 0x40) : (byte) (existingFlags & ~0x40); List> dataValues = new ArrayList<>(); - dataValues.add(SynchedEntityData.DataValue.create(new EntityDataAccessor<>(0, EntityDataSerializers.BYTE), updatedFlags)); + dataValues.add(SynchedEntityData.DataValue.create(DATA_SHARED_FLAGS, updatedFlags)); ClientboundSetEntityDataPacket packet = new ClientboundSetEntityDataPacket(target.getEntityId(), dataValues); craftModerator.getHandle().connection.send(packet); diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationTools.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationTools.java index 383aa06c..ad89bfb0 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationTools.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/ModerationTools.java @@ -7,6 +7,10 @@ import org.bukkit.inventory.ItemStack; public final class ModerationTools { + + private ModerationTools() { + } + public static ItemStack getRandomTeleporter() { return new ItemBuilder(Material.ENDER_EYE) .setDisplayName("§dRandom Teleport §7(Right Click)") diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/hud/ModerationHud.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/hud/ModerationHud.java index ef6607b7..0c08dcc8 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/hud/ModerationHud.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/hud/ModerationHud.java @@ -2,6 +2,7 @@ import fr.moussax.bedrock.ui.actionbar.ActionbarSection; import fr.moussax.blightedMod.moderator.BlightedModerator; +import fr.moussax.blightedMod.moderator.ModerationGlowHelper; import fr.moussax.blightedMod.moderator.ModerationManager; import org.bukkit.attribute.Attribute; import org.bukkit.entity.Player; @@ -34,6 +35,10 @@ private static String render(ModerationManager moderationManager, Player player) return null; } + if (player.getWorld().equals(target.getWorld())) { + ModerationGlowHelper.applyPinkGlow(player, target); + } + double maxHealth = Objects.requireNonNull(target.getAttribute(Attribute.MAX_HEALTH)).getValue(); int healthPercent = (int) Math.round((target.getHealth() / maxHealth) * 100.0); String healthColor = healthPercent >= 60 ? "§a" : healthPercent >= 30 ? "§e" : "§c"; @@ -47,9 +52,9 @@ private static String render(ModerationManager moderationManager, Player player) String pingColor = ping < 100 ? "§a" : ping < 200 ? "§e" : ping < 300 ? "§6" : ping < 500 ? "§c" : "§4"; String pingText = pingColor + ping + "ms"; - return "§fTarget: §d" + target.getName() + return "§fTarget: §a" + target.getName() + " §fHP: " + healthColor + healthPercent + "%" - + " §fDistance: §d" + distanceText + + " §fDistance: §a" + distanceText + " §fPing: " + pingText + " §fFrozen: " + frozenText; } diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/registry/CommandsRegistry.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/registry/CommandsRegistry.java index 1d368a9f..2ae5b97c 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/registry/CommandsRegistry.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/registry/CommandsRegistry.java @@ -2,23 +2,7 @@ import fr.moussax.bedrock.commands.CommandRegistrar; import fr.moussax.bedrock.commands.TabSuggestionRegistry; -import fr.moussax.blightedMod.commands.impl.BanCommand; -import fr.moussax.blightedMod.commands.impl.CheckReportCommand; -import fr.moussax.blightedMod.commands.impl.EnderseeCommand; -import fr.moussax.blightedMod.commands.impl.FreezeCommand; -import fr.moussax.blightedMod.commands.impl.InvseeCommand; -import fr.moussax.blightedMod.commands.impl.KickCommand; -import fr.moussax.blightedMod.commands.impl.ModCommand; -import fr.moussax.blightedMod.commands.impl.ModTpCommands; -import fr.moussax.blightedMod.commands.impl.MuteCommand; -import fr.moussax.blightedMod.commands.impl.ReportCommand; -import fr.moussax.blightedMod.commands.impl.ReportsCommand; -import fr.moussax.blightedMod.commands.impl.SanctionsCommand; -import fr.moussax.blightedMod.commands.impl.SetSlowmodeCommand; -import fr.moussax.blightedMod.commands.impl.SocialSpyCommand; -import fr.moussax.blightedMod.commands.impl.TargetCommand; -import fr.moussax.blightedMod.commands.impl.UserInfoCommand; -import fr.moussax.blightedMod.commands.impl.VanishCommand; +import fr.moussax.blightedMod.commands.impl.*; import org.bukkit.Bukkit; import org.bukkit.entity.Player; import org.bukkit.plugin.java.JavaPlugin; @@ -72,14 +56,6 @@ public static void registerCommands(JavaPlugin plugin) { registrar.register("socialspy", socialSpyCommand); } - - - - - - - - private static TabSuggestionRegistry createSuggestionRegistry() { TabSuggestionRegistry suggestions = new TabSuggestionRegistry(); diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/registry/EventsRegistry.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/registry/EventsRegistry.java index e0b8282f..456e8063 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/registry/EventsRegistry.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/registry/EventsRegistry.java @@ -35,7 +35,6 @@ public void initializeListeners() { pluginManager.registerEvents(new InteractiveChatListener(instance.getModerationManager()), instance); } - public void cleanup() { if (signInputListener != null) { signInputListener.cleanup(); From fa31733bf0711b474a0c4baee8e8578c96ce4c1d Mon Sep 17 00:00:00 2001 From: Moussa Date: Fri, 18 Sep 2026 20:50:43 +0200 Subject: [PATCH 05/31] fix(bedrock): patch MenuSlot item retrieval --- .../main/java/fr/moussax/bedrock/ui/menu/Menu.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java b/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java index 5a0559a6..841ada25 100644 --- a/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java +++ b/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java @@ -722,12 +722,12 @@ public void refresh(@NonNull Player player) { boolean changed = false; for (int slot = 0; slot < size; slot++) { - MenuSlot menuSlot = slots.get(slot); - if (menuSlot == null) { + if (isInteractable(slot)) { continue; } - ItemStack newItem = menuSlot.item; + MenuSlot menuSlot = slots.get(slot); + ItemStack newItem = menuSlot != null ? menuSlot.item : null; ItemStack currentItem = inventory.getItem(slot); if (!isSameItem(currentItem, newItem)) { @@ -742,8 +742,10 @@ public void refresh(@NonNull Player player) { } private boolean isSameItem(@Nullable ItemStack first, @Nullable ItemStack second) { - if (first == null && second == null) return true; - if (first == null || second == null) return false; + boolean firstEmpty = first == null || first.getType().isAir(); + boolean secondEmpty = second == null || second.getType().isAir(); + if (firstEmpty && secondEmpty) return true; + if (firstEmpty || secondEmpty) return false; return first.getAmount() == second.getAmount() && first.isSimilar(second); } From 2ebe4c6c3a772cff194c8c17e1a1dccd21410f96 Mon Sep 17 00:00:00 2001 From: Moussa Date: Fri, 18 Sep 2026 21:08:07 +0200 Subject: [PATCH 06/31] feat(menu): enhance menu navigation and state management --- .../java/fr/moussax/bedrock/ui/menu/Menu.java | 16 ++++++++++++++-- .../bedrock/ui/menu/system/MenuListener.java | 6 +++--- .../bedrock/ui/menu/system/MenuSystem.java | 17 +++++++++++++++++ 3 files changed, 34 insertions(+), 5 deletions(-) diff --git a/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java b/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java index 841ada25..917341ad 100644 --- a/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java +++ b/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java @@ -272,10 +272,14 @@ public void setBackButton(int slot, @NonNull MenuAction action) { public void setBackButton(int slot, @Nullable Menu previousMenu) { setBackButton(slot, (player, _) -> { if (previousMenu == null) { - close(); + goBack(); return; } - previousMenu.open(player); + if (menuSystem != null) { + menuSystem.popAndOpen(player, previousMenu); + } else { + previousMenu.open(player); + } }); } @@ -712,8 +716,16 @@ public void refresh(@NonNull Player player) { return; } + Map preservedInteractableSlots = new HashMap<>(); + for (Map.Entry entry : slots.entrySet()) { + if (isInteractable(entry.getKey())) { + preservedInteractableSlots.put(entry.getKey(), entry.getValue()); + } + } + slots.clear(); build(player); + preservedInteractableSlots.forEach(slots::putIfAbsent); InventoryView openInventory = player.getOpenInventory(); if (openInventory.getTopInventory().getHolder() == this && !openInventory.getTitle().equals(this.title)) { diff --git a/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/system/MenuListener.java b/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/system/MenuListener.java index 664da018..8501319b 100644 --- a/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/system/MenuListener.java +++ b/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/system/MenuListener.java @@ -90,16 +90,16 @@ public void onInventoryClose(InventoryCloseEvent event) { if (!(event.getPlayer() instanceof Player player)) return; if (!(event.getView().getTopInventory().getHolder() instanceof Menu menu)) return; - menu.onClose(player); - PluginContext.delay(() -> { if (!player.isOnline()) { + menu.onClose(player); menuSystem.cleanup(player); return; } Inventory topInventory = player.getOpenInventory().getTopInventory(); if (!(topInventory.getHolder() instanceof Menu)) { - menuSystem.closeActiveMenu(player); + menu.onClose(player); + menuSystem.cleanup(player); } }, 1L); } diff --git a/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/system/MenuSystem.java b/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/system/MenuSystem.java index 9b7aff8e..b42f061c 100644 --- a/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/system/MenuSystem.java +++ b/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/system/MenuSystem.java @@ -130,6 +130,23 @@ public void goBack(@NonNull Player player) { } } + /** + * Pops active menu from navigation history and opens the target menu. + * + * @param player player navigating to target menu + * @param targetMenu menu to open + */ + public void popAndOpen(@NonNull Player player, @NonNull Menu targetMenu) { + if (shutdownInitiated) return; + + UUID playerId = player.getUniqueId(); + Deque stack = menuHistory.get(playerId); + if (stack != null && !stack.isEmpty()) { + stack.pop(); + } + openMenu(targetMenu, player); + } + /** * Removes active menu reference for a player without clearing navigation history. * From 304236e0560d50cfe4a6ce74f5e91e7802f77efb Mon Sep 17 00:00:00 2001 From: Moussa Date: Wed, 23 Sep 2026 13:51:17 +0200 Subject: [PATCH 07/31] refactor(items): streamline `ItemRegistry` and `BlightedPlayer` method calls --- .../engine/items/BlightedItem.java | 2 +- .../items/recipes/forging/ForgeRecipe.java | 4 +- .../items/recipes/forging/menu/ForgeMenu.java | 6 +- .../forging/menu/ForgeRecipePreviewMenu.java | 6 +- .../engine/items/registry/ItemRegistry.java | 2 +- .../engine/items/rules/ItemRuleListener.java | 6 +- .../engine/loot/results/ItemResult.java | 4 +- .../engine/loot/results/gems/GemsItem.java | 29 +--------- .../engine/player/BlightedPlayer.java | 56 ++++++++++++------- .../engine/player/PlayerListener.java | 7 +-- .../engine/player/hud/PlayerHudManager.java | 4 +- .../engine/quest/BlightedRitualAnimation.java | 2 +- 12 files changed, 59 insertions(+), 69 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/BlightedItem.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/BlightedItem.java index c419f655..8770f1f8 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/BlightedItem.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/BlightedItem.java @@ -215,7 +215,7 @@ public static BlightedItem fromItemStack(@NonNull ItemStack itemStack) { String itemId = container.get(BLIGHTED_ID_KEY, PersistentDataType.STRING); if (itemId == null) return null; - return ItemRegistry.getItem(itemId); + return ItemRegistry.get(itemId); } /** diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/ForgeRecipe.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/ForgeRecipe.java index dc283341..7e14c976 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/ForgeRecipe.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/ForgeRecipe.java @@ -85,7 +85,7 @@ public static Builder of(BlightedItem item, int amount) { * @return a new forge recipe builder */ public static Builder of(String itemId, int amount) { - return new Builder(ItemRegistry.getItem(itemId), amount); + return new Builder(ItemRegistry.get(itemId), amount); } /** @@ -129,7 +129,7 @@ public Builder addIngredient(BlightedItem item, int amount) { * @return this builder */ public Builder addIngredient(String itemId, int amount) { - return addIngredient(ItemRegistry.getItem(itemId), amount); + return addIngredient(ItemRegistry.get(itemId), amount); } /** diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/menu/ForgeMenu.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/menu/ForgeMenu.java index b220799c..c3d9ba90 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/menu/ForgeMenu.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/menu/ForgeMenu.java @@ -119,7 +119,7 @@ private void setupResultDisplay() { } private void checkRequirements(Player player) { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); Map requiredCounts = aggregateRequirements(); Map inventoryCounts = new HashMap<>(); @@ -241,7 +241,7 @@ private void setupNavigationButtons() { } private void setupFuelButtons(Player player) { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); int currentFuel = blightedPlayer.getForgeFuel(); setItem(34, createFuelMeter(currentFuel), (_, _) -> { @@ -388,7 +388,7 @@ private void forgeItem(Player player) { this.isForging = true; this.canForge = false; - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); consumeIngredients(player); blightedPlayer.removeForgeFuel(recipe.getFuelCost()); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/menu/ForgeRecipePreviewMenu.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/menu/ForgeRecipePreviewMenu.java index bb372d49..f97c105f 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/menu/ForgeRecipePreviewMenu.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/forging/menu/ForgeRecipePreviewMenu.java @@ -58,7 +58,7 @@ public long tickPeriodTicks() { @Override public void onTick(Player player) { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); int currentFuel = blightedPlayer != null ? blightedPlayer.getForgeFuel() : 0; Map requirements = aggregateForgeIngredients(recipe); @@ -115,7 +115,7 @@ private void setupStatusPanes(Player player) { } private boolean checkCanHyperforge(Player player) { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); int currentFuel = blightedPlayer != null ? blightedPlayer.getForgeFuel() : 0; int fuelCost = recipe.getFuelCost(); boolean hasSufficientFuel = currentFuel >= fuelCost; @@ -172,7 +172,7 @@ private void setupFuelDisplay() { } private void setupHyperforgeButton(Player player) { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); int currentFuel = blightedPlayer != null ? blightedPlayer.getForgeFuel() : 0; int fuelCost = recipe.getFuelCost(); boolean hasSufficientFuel = currentFuel >= fuelCost; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/registry/ItemRegistry.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/registry/ItemRegistry.java index d9315aaf..c68a29c9 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/registry/ItemRegistry.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/registry/ItemRegistry.java @@ -43,7 +43,7 @@ public static void register(BlightedItem... items) { } @NonNull - public static BlightedItem getItem(@NonNull String itemId) { + public static BlightedItem get(@NonNull String itemId) { BlightedItem item = REGISTRY.get(itemId); if (item == null) { throw new IllegalArgumentException("Unknown item ID: " + itemId); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/rules/ItemRuleListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/rules/ItemRuleListener.java index 378e3847..3007e2c5 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/rules/ItemRuleListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/rules/ItemRuleListener.java @@ -28,9 +28,9 @@ private BlightedItem getManager(ItemStack itemStack) { if (itemStack == null || !itemStack.hasItemMeta()) return null; ItemMeta itemMeta = itemStack.getItemMeta(); if (itemMeta == null) return null; - String id = itemMeta.getPersistentDataContainer().get(BLIGHTED_ID_KEY, PersistentDataType.STRING); - if (id == null) return null; - return ItemRegistry.getItem(id); + String itemId = itemMeta.getPersistentDataContainer().get(BLIGHTED_ID_KEY, PersistentDataType.STRING); + if (itemId == null) return null; + return ItemRegistry.get(itemId); } @EventHandler(ignoreCancelled = true) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/ItemResult.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/ItemResult.java index 25f6acef..67cd1b25 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/ItemResult.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/ItemResult.java @@ -43,7 +43,7 @@ private ItemResult(ItemStack itemStack, Consumer modifier) { */ public static ItemResult of(String itemId) { ItemStack item = Objects.requireNonNull( - ItemRegistry.getItem(itemId), "Item not found in registry: " + itemId + ItemRegistry.get(itemId), "Item not found in registry: " + itemId ).toItemStack(); return new ItemResult(item, (Consumer) null); } @@ -77,7 +77,7 @@ public static ItemResult of(ItemStack itemStack) { */ public static ItemResult of(String itemId, Consumer modifier) { ItemStack item = Objects.requireNonNull( - ItemRegistry.getItem(itemId), "Item not found in registry: " + itemId + ItemRegistry.get(itemId), "Item not found in registry: " + itemId ).toItemStack(); return new ItemResult(item, modifier); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/gems/GemsItem.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/gems/GemsItem.java index 70f61584..184fa59d 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/gems/GemsItem.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/gems/GemsItem.java @@ -53,7 +53,7 @@ public static class BlightedGemstoneAbility implements AbilityManagerTracks persistent player resources (gems, mana pool, forge fuel), equipment state, * active armor set bonuses, and ability cooldowns. Context instances are keyed by player - * {@link UUID} and retrieved via {@link #getBlightedPlayer(Player)}.

+ * {@link UUID} and retrieved via {@link #get(Player)}.

*/ public final class BlightedPlayer { @@ -97,16 +97,6 @@ public static BlightedPlayer get(Player player) { return players.computeIfAbsent(player.getUniqueId(), _ -> new BlightedPlayer(player)); } - /** - * Retrieves the player context associated with a Bukkit player. - * - * @param player player whose context to retrieve - * @return registered player context, or {@code null} if no context exists - */ - public static BlightedPlayer getBlightedPlayer(Player player) { - return get(player); - } - /** * Returns an unmodifiable view of all active registered player contexts. * @@ -163,6 +153,20 @@ public void removeCooldown(CooldownEntry entry) { cooldowns.remove(entry); } + /** + * Sets or replaces the cooldown duration for a string key and ability type. + * + * @param key cooldown key or ability name + * @param type ability type associated with the cooldown + * @param seconds cooldown duration in seconds + */ + public void setCooldown(String key, AbilityType type, int seconds) { + long expire = System.currentTimeMillis() + (seconds * 1000L); + cooldowns.removeIf(currentCooldown -> + currentCooldown.key().equals(key) && currentCooldown.abilityType() == type); + cooldowns.add(new CooldownEntry(key, type, expire)); + } + /** * Sets or replaces the cooldown duration for an ability manager and ability type. * @@ -172,33 +176,43 @@ public void removeCooldown(CooldownEntry entry) { */ @SuppressWarnings("rawtypes") public void setCooldown(Class managerClass, AbilityType type, int seconds) { - long expire = System.currentTimeMillis() + (seconds * 1000L); - cooldowns.removeIf(currentCooldown -> - currentCooldown.abilityManager().equals(managerClass) && currentCooldown.abilityType() == type); - cooldowns.add(new CooldownEntry(managerClass, type, expire)); + setCooldown(managerClass != null ? managerClass.getName() : "", type, seconds); } /** - * Returns the remaining cooldown duration in seconds for an ability manager and ability type. + * Returns the remaining cooldown duration in seconds for a string key and ability type. * *

Expired cooldown entries are removed before performing the lookup.

* - * @param managerClass ability manager class associated with the cooldown - * @param type ability type associated with the cooldown + * @param key cooldown key or ability name + * @param type ability type associated with the cooldown * @return remaining cooldown in seconds, or {@code 0} if no active cooldown exists */ - @SuppressWarnings("rawtypes") - public double getRemainingCooldown(Class managerClass, AbilityType type) { + public double getRemainingCooldown(String key, AbilityType type) { cooldowns.removeIf(CooldownEntry::isExpired); for (CooldownEntry entry : cooldowns) { - if (entry.abilityManager().equals(managerClass) && entry.abilityType() == type) { + if (entry.key().equals(key) && entry.abilityType() == type) { return entry.getRemainingCooldownTimeInSeconds(); } } return 0; } + /** + * Returns the remaining cooldown duration in seconds for an ability manager and ability type. + * + *

Expired cooldown entries are removed before performing the lookup.

+ * + * @param managerClass ability manager class associated with the cooldown + * @param type ability type associated with the cooldown + * @return remaining cooldown in seconds, or {@code 0} if no active cooldown exists + */ + @SuppressWarnings("rawtypes") + public double getRemainingCooldown(Class managerClass, AbilityType type) { + return getRemainingCooldown(managerClass != null ? managerClass.getName() : "", type); + } + /** * Clears all tracked armor pieces. */ diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/PlayerListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/PlayerListener.java index 2a15077e..03248acf 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/PlayerListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/PlayerListener.java @@ -24,8 +24,8 @@ public void onJoin(PlayerJoinEvent event) { event.setJoinMessage(" §f" + event.getPlayer().getName() + " §7joined the SMP."); if (!player.hasPlayedBefore()) { - player.getInventory().setHelmet(ItemRegistry.getItem("BLIGHTED_BANNER").toItemStack()); - player.getInventory().setItemInOffHand(ItemRegistry.getItem("BLIGHTED_CODEX").toItemStack()); + player.getInventory().setHelmet(ItemRegistry.get("BLIGHTED_BANNER").toItemStack()); + player.getInventory().setItemInOffHand(ItemRegistry.get("BLIGHTED_CODEX").toItemStack()); player.setHealth(4.0); player.addPotionEffect(new PotionEffect(PotionEffectType.BLINDNESS, 100, 0, false, false, false)); @@ -51,10 +51,9 @@ public void onJoin(PlayerJoinEvent event) { @EventHandler public void onQuit(PlayerQuitEvent event) { Player player = event.getPlayer(); - clearTargetedMobs(player); - BlightedPlayer blighted = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blighted = BlightedPlayer.get(player); if (blighted != null) { blighted.saveData(); BlightedPlayer.removePlayer(player); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/hud/PlayerHudManager.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/hud/PlayerHudManager.java index 34f2807a..671f9203 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/hud/PlayerHudManager.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/hud/PlayerHudManager.java @@ -30,13 +30,13 @@ public PlayerHudManager(@NonNull ActionbarService actionBarService) { private void initializeDefaultSections() { actionBarService.registerSection(ActionbarSection.of(SECTION_GEMS, 0, player -> { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); if (blightedPlayer == null) return null; return "§d" + Formatter.formatDecimalWithCommas(blightedPlayer.getGems()) + "✵ Gems"; })); actionBarService.registerSection(ActionbarSection.of(SECTION_MANA, 10, player -> { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); if (blightedPlayer == null) return null; return "§b" + Formatter.formatDouble(blightedPlayer.getCurrentMana(), 0) + "/" + Formatter.formatDouble(blightedPlayer.getMaxMana(), 0) + "✎ Mana"; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/quest/BlightedRitualAnimation.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/quest/BlightedRitualAnimation.java index 1edf492f..ccbbdccc 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/quest/BlightedRitualAnimation.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/quest/BlightedRitualAnimation.java @@ -178,7 +178,7 @@ private void executeManifestationClimax() { Objects.requireNonNull(centerLocation.getWorld()).strikeLightningEffect(centerLocation); - ItemStack rewardItem = ItemRegistry.getItem("BLIGHTED_WORKBENCH").toItemStack(); + ItemStack rewardItem = ItemRegistry.get("BLIGHTED_WORKBENCH").toItemStack(); centerLocation.getWorld().dropItem(targetBlock.getLocation().add(0, 1.5, 0), rewardItem); spawnClimaxParticles(); From ecf3d05f3bb65be3057cc0b09fc35a6f2cdfe75a Mon Sep 17 00:00:00 2001 From: Moussa Date: Wed, 23 Sep 2026 14:01:00 +0200 Subject: [PATCH 08/31] refactor: reformat code --- .../blightedSMP/commands/impl/FlyCommand.java | 4 +--- .../blightedSMP/commands/impl/GemsCommand.java | 10 +++++----- .../blightedSMP/commands/impl/GiveItemCommand.java | 2 +- .../commands/impl/NightVisionCommand.java | 3 +-- .../blightedSMP/engine/entities/BlightedEntity.java | 6 +++--- .../entities/listeners/BlightedEntitiesListener.java | 2 +- .../engine/entities/rituals/AncientRitual.java | 2 +- .../entities/rituals/menu/RitualAltarMenu.java | 6 +++--- .../entities/spawnable/condition/SpawnRules.java | 12 ++++++------ .../blightedSMP/engine/fishing/FishingListener.java | 6 +++--- 10 files changed, 25 insertions(+), 28 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/FlyCommand.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/FlyCommand.java index 6ab8322a..b3efac96 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/FlyCommand.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/FlyCommand.java @@ -4,8 +4,6 @@ import org.bukkit.command.Command; import org.bukkit.entity.Player; -import static fr.moussax.bedrock.text.InteractiveMessage.text; - public final class FlyCommand extends AdminCommand { @Override protected boolean executeAdmin(Player player, Command command, String label, String[] args) { @@ -21,7 +19,7 @@ private void toggleFlightMode(Player player) { } else { player.setAllowFlight(true); player.setFlying(true); - text(" §fFlight Mode §etoggled §aON§e. ").hoverAndExecute("§4[§c➟ Disable§4]", "§eClick to disable your §6Flight Mode§e.", "/fly").send(player); + player.sendMessage(" §fFlight Mode §etoggled §aON§e."); } } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/GemsCommand.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/GemsCommand.java index 84327520..2eb25632 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/GemsCommand.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/GemsCommand.java @@ -88,7 +88,7 @@ private boolean handleModify(Player sender, String[] args, boolean add) { Integer amount = parseAmount(sender, args[2]); if (amount == null) return false; - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(target); + BlightedPlayer blightedPlayer = BlightedPlayer.get(target); if (add) { blightedPlayer.addGems(amount); @@ -114,7 +114,7 @@ private boolean handleSet(Player sender, String[] args) { Integer amount = parseAmount(sender, args[2]); if (amount == null) return false; - BlightedPlayer.getBlightedPlayer(target).setGems(amount); + BlightedPlayer.get(target).setGems(amount); inform(sender, "§e Set §d" + target.getName() + "§e's gems balance to §d" + amount + "§e."); inform(target, "§7 Your gems balance has been set to §d" + amount + "§7."); return true; @@ -131,7 +131,7 @@ private boolean handleReset(Player sender, String[] args) { return false; } - BlightedPlayer.getBlightedPlayer(target).setGems(0); + BlightedPlayer.get(target).setGems(0); inform(sender, "§e You reset §d" + target.getName() + "§e's gems."); inform(target, " §7Your gems balance has been reset."); return true; @@ -139,7 +139,7 @@ private boolean handleReset(Player sender, String[] args) { private boolean handleResetAll(Player sender) { Bukkit.getOnlinePlayers().forEach(player -> - BlightedPlayer.getBlightedPlayer(player).setGems(0) + BlightedPlayer.get(player).setGems(0) ); inform(sender, "Reset all §donline §7players' gems."); @@ -156,7 +156,7 @@ private boolean handleGiveAll(Player sender, String[] args) { if (amount == null) return false; Bukkit.getOnlinePlayers().forEach(player -> { - BlightedPlayer.getBlightedPlayer(player).addGems(amount); + BlightedPlayer.get(player).addGems(amount); inform(player, " §7You received §d" + amount + " §7gems."); }); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/GiveItemCommand.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/GiveItemCommand.java index c3286723..311206ce 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/GiveItemCommand.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/GiveItemCommand.java @@ -43,7 +43,7 @@ protected boolean executeAdmin(Player player, Command command, String label, Str } String itemId = args[argumentIndex].toUpperCase(); - BlightedItem blightedItem = ItemRegistry.getItem(itemId); + BlightedItem blightedItem = ItemRegistry.get(itemId); int amount = 1; if (args.length > argumentIndex + 1) { diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/NightVisionCommand.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/NightVisionCommand.java index 2c0da415..74d052cb 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/NightVisionCommand.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/NightVisionCommand.java @@ -6,7 +6,6 @@ import org.bukkit.potion.PotionEffect; import org.bukkit.potion.PotionEffectType; -import static fr.moussax.bedrock.text.InteractiveMessage.text; import static fr.moussax.bedrock.text.Messenger.inform; public final class NightVisionCommand extends AdminCommand { @@ -23,7 +22,7 @@ private void toggleNightVision(Player player) { inform(player," §fNight Vision §etoggled §cOFF§e."); } else { player.addPotionEffect(new PotionEffect(PotionEffectType.NIGHT_VISION, PotionEffect.INFINITE_DURATION, 0, false, false)); - text(" §fNight Vision §etoggled §aON§e. ").hoverAndExecute("§4[§c➟ Disable§4]", "§eClick to disable your §6Night Vision §eeffect.", "/nv").send(player); + inform(player," §fNight Vision §etoggled §aON§e."); } } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java index aa966009..e78e7bca 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java @@ -501,7 +501,7 @@ public List getNearbyBlightedPlayers(double radius) { */ public List getNearbyBlightedPlayers(Location center, double radius) { return getNearbyPlayers(center, radius).stream() - .map(BlightedPlayer::getBlightedPlayer) + .map(BlightedPlayer::get) .filter(Objects::nonNull) .toList(); } @@ -514,7 +514,7 @@ public List getNearbyBlightedPlayers(Location center, double rad */ public BlightedPlayer getNearestBlightedPlayer(double radius) { Player target = getNearestPlayer(radius); - return target != null ? BlightedPlayer.getBlightedPlayer(target) : null; + return target != null ? BlightedPlayer.get(target) : null; } /** @@ -526,7 +526,7 @@ public BlightedPlayer getNearestBlightedPlayer(double radius) { */ public BlightedPlayer getNearestBlightedPlayer(Location center, double radius) { Player target = getNearestPlayer(center, radius); - return target != null ? BlightedPlayer.getBlightedPlayer(target) : null; + return target != null ? BlightedPlayer.get(target) : null; } /** diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java index 9ede7130..fd8e9934 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java @@ -322,7 +322,7 @@ public void onEntityDeath(EntityDeathEvent event) { blighted.cleanup(); BlightedPlayer killer = dead.getKiller() != null - ? BlightedPlayer.getBlightedPlayer(dead.getKiller()) + ? BlightedPlayer.get(dead.getKiller()) : null; blighted.dropLoot(dead.getLocation(), killer); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientRitual.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientRitual.java index 36c16c56..3497407f 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientRitual.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientRitual.java @@ -131,7 +131,7 @@ public Builder addOffering(BlightedItem item, int amount) { * @return this builder */ public Builder addOffering(String itemId, int amount) { - return addOffering(ItemRegistry.getItem(itemId), amount); + return addOffering(ItemRegistry.get(itemId), amount); } /** diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/RitualAltarMenu.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/RitualAltarMenu.java index a4d508a5..68d0b02b 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/RitualAltarMenu.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/RitualAltarMenu.java @@ -55,7 +55,7 @@ public void onTick(Player player) { boolean initialCanInvoke = this.canInvoke; checkRequirements(player); - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); int currentLevel = player.getLevel(); double currentGems = blightedPlayer != null ? blightedPlayer.getGems() : 0; @@ -132,7 +132,7 @@ private void checkRequirements(Player player) { return; } - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); Map requiredCounts = aggregateRequirements(); Map inventoryCounts = new HashMap<>(); @@ -281,7 +281,7 @@ private void consumeIngredients(Player player) { for (CraftingObject ingredient : ritual.getOfferings()) { Utilities.consumeItemsFromInventory(player, ingredient); } - BlightedPlayer.getBlightedPlayer(player).removeGems(ritual.getGemsCost()); + BlightedPlayer.get(player).removeGems(ritual.getGemsCost()); player.setLevel(player.getLevel() - ritual.getLevelCost()); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/condition/SpawnRules.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/condition/SpawnRules.java index 63f70257..4918e4eb 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/condition/SpawnRules.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/condition/SpawnRules.java @@ -34,7 +34,7 @@ private SpawnRules() { */ public static SpawnCondition biome(Biome... allowed) { Set biomeSet = Set.of(allowed); - return (location, world) -> biomeSet.contains(location.getBlock().getBiome()); + return (location, _) -> biomeSet.contains(location.getBlock().getBiome()); } /** @@ -44,7 +44,7 @@ public static SpawnCondition biome(Biome... allowed) { * @return environment spawn condition predicate */ public static SpawnCondition environment(World.Environment environment) { - return (location, world) -> world.getEnvironment() == environment; + return (_, world) -> world.getEnvironment() == environment; } /** @@ -64,7 +64,7 @@ public static SpawnCondition atLeastY(int minY) { * @return maximum height spawn condition predicate */ public static SpawnCondition atMostY(int maxY) { - return (location, world) -> location.getBlockY() <= maxY; + return (location, _) -> location.getBlockY() <= maxY; } /** @@ -74,7 +74,7 @@ public static SpawnCondition atMostY(int maxY) { * @return block light spawn condition predicate */ public static SpawnCondition maxBlockLight(int max) { - return (location, world) -> location.getBlock().getLightFromBlocks() <= max; + return (location, _) -> location.getBlock().getLightFromBlocks() <= max; } /** @@ -84,7 +84,7 @@ public static SpawnCondition maxBlockLight(int max) { * @return light level spawn condition predicate */ public static SpawnCondition maxLightLevel(int max) { - return (location, world) -> location.getBlock().getLightLevel() <= max; + return (location, _) -> location.getBlock().getLightLevel() <= max; } /** @@ -111,7 +111,7 @@ public static SpawnCondition notInLiquid() { * @return nighttime spawn condition predicate */ public static SpawnCondition nightTime() { - return (location, world) -> { + return (_, world) -> { long time = world.getTime(); return time >= 13000 && time <= 23000; }; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingListener.java index 97dd3870..7c99d6f5 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingListener.java @@ -88,7 +88,7 @@ private void handleFishingCast(Player player, FishHook hook, PlayerFishEvent eve Messenger.warn(player, "This rod thirsts for molten depths, not ordinary waters."); event.setCancelled(true); } else { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); new LavaFishingHook( hook, blightedPlayer, @@ -106,7 +106,7 @@ private void handleFishingCast(Player player, FishHook hook, PlayerFishEvent eve Messenger.warn(player, "This rod answers only to the void of the End."); event.setCancelled(true); } else { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); new VoidFishingHook( hook, blightedPlayer, @@ -180,7 +180,7 @@ private void handleStandardFishing(PlayerFishEvent event, Player player, FishHoo int currentCombo = FishingComboTracker.getCombo(player, FishingMethod.WATER); if (ThreadLocalRandom.current().nextDouble() <= CUSTOM_LOOT_CHANCE) { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); FishingLootTable lootTable = FishingLootRegistry.getTable(environment, FishingMethod.WATER); Vector velocity = calculateVelocity(hook.getLocation(), player.getLocation()); From 60e543f12c153b5d3216dc009288bad1e2e7bf9f Mon Sep 17 00:00:00 2001 From: Moussa Date: Sat, 26 Sep 2026 20:08:08 +0200 Subject: [PATCH 09/31] chore(deps): bumps spigot version to 26.3 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index a9911c3c..32ea93bc 100644 --- a/pom.xml +++ b/pom.xml @@ -6,7 +6,7 @@ fr.moussax blightedmc - 1.0-SNAPSHOT + 1.2.0 pom BlightedMC @@ -20,7 +20,7 @@ 25 UTF-8 - 26.2-R0.1-SNAPSHOT + 26.3-R0.1-SNAPSHOT 1.18.46 3.45.3.0 5.10.2 From 6b3996e96bdd4c621e77eea12f172240ff697dda Mon Sep 17 00:00:00 2001 From: Moussa Date: Sun, 27 Sep 2026 10:09:03 +0200 Subject: [PATCH 10/31] refactor(abilities): merge Ability record into AbilityManager eliminates the redundant Ability wrapper by placing name, trigger type, and lore formatting directly on AbilityManager with default lifecycle hooks --- .../engine/items/abilities/Ability.java | 102 ------------------ .../items/abilities/AbilityExecutor.java | 48 ++++----- .../items/abilities/AbilityListener.java | 32 +++--- .../items/abilities/AbilityManager.java | 92 ++++++++++++---- .../engine/items/abilities/AbilityType.java | 56 +++++++--- .../engine/items/abilities/ArmorManager.java | 6 +- .../engine/items/abilities/CooldownEntry.java | 6 +- .../engine/items/abilities/FullSetBonus.java | 5 +- 8 files changed, 157 insertions(+), 190 deletions(-) delete mode 100644 blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/Ability.java diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/Ability.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/Ability.java deleted file mode 100644 index 22146004..00000000 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/Ability.java +++ /dev/null @@ -1,102 +0,0 @@ -package fr.moussax.blightedSMP.engine.items.abilities; - -import org.bukkit.event.Event; - -import java.util.ArrayList; -import java.util.List; - -/** - * Represents a gameplay ability with a manager, name, and type. - * - *

The {@code manager} handles event logic, {@code name} uniquely identifies - * the ability, and {@code type} defines its behavior.

- * - * @param manager the event manager for this ability - * @param name the unique identifier - * @param type the ability's behavior type - */ -public record Ability(AbilityManager manager, String name, AbilityType type) { - - /** - * Creates an ability with the specified name, trigger type, and execution manager. - * - * @param name ability display name - * @param type trigger type - * @param manager execution manager - * @return a new ability instance - */ - public static Ability of(String name, AbilityType type, AbilityManager manager) { - return new Ability(manager, name, type); - } - - /** - * Creates a right-click triggered ability. - * - * @param name ability display name - * @param manager execution manager - * @return a new right-click ability instance - */ - public static Ability rightClick(String name, AbilityManager manager) { - return of(name, AbilityType.RIGHT_CLICK, manager); - } - - /** - * Creates a left-click triggered ability. - * - * @param name ability display name - * @param manager execution manager - * @return a new left-click ability instance - */ - public static Ability leftClick(String name, AbilityManager manager) { - return of(name, AbilityType.LEFT_CLICK, manager); - } - - /** - * Creates a passive ability. - * - * @param name ability display name - * @param manager execution manager - * @return a new passive ability instance - */ - public static Ability passive(String name, AbilityManager manager) { - return of(name, AbilityType.PASSIVE, manager); - } - - /** - * Creates a sneak triggered ability. - * - * @param name ability display name - * @param manager execution manager - * @return a new sneak ability instance - */ - public static Ability sneak(String name, AbilityManager manager) { - return of(name, AbilityType.SNEAK, manager); - } - - /** - * Formats and constructs lore lines displaying the ability name, type, description, and resource costs. - * - * @return formatted list of item lore lines - */ - public List getAbilityLore() { - List lore = new ArrayList<>(); - - lore.add(""); - lore.add("§5 Ability: " + name + " " + type.getDisplayName()); - - for (String line : manager.getDescription()) { - lore.add("§7 " + line); - } - - int mana = manager.getManaCost(); - int cooldown = manager.getCooldownSeconds(); - - if (mana > 0) { - lore.add("§8 Mana Cost: §3" + mana); - } - if (cooldown > 0) { - lore.add("§8 Cooldown: §a" + cooldown + "s"); - } - return lore; - } -} diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityExecutor.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityExecutor.java index 80d922c5..f79f1f97 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityExecutor.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityExecutor.java @@ -1,9 +1,9 @@ package fr.moussax.blightedSMP.engine.items.abilities; -import fr.moussax.blightedSMP.engine.player.BlightedPlayer; -import fr.moussax.blightedSMP.engine.player.hud.PlayerHudManager; import fr.moussax.bedrock.ui.actionbar.ActionbarService; import fr.moussax.bedrock.utils.debug.Log; +import fr.moussax.blightedSMP.engine.player.BlightedPlayer; +import fr.moussax.blightedSMP.engine.player.hud.PlayerHudManager; import org.bukkit.Sound; import org.bukkit.event.Cancellable; import org.bukkit.event.Event; @@ -13,7 +13,7 @@ import static fr.moussax.bedrock.text.Messenger.warn; /** - * Validates player resources, checks active cooldowns, and executes custom item abilities. + * Evaluates requirements, resource costs, and active cooldowns to execute item abilities. */ public final class AbilityExecutor { @@ -21,36 +21,33 @@ private AbilityExecutor() { } /** - * Evaluates cooldowns, verifies mana sufficiency, and executes the specified ability. + * Evaluates active cooldowns, verifies mana sufficiency, and executes an ability. * * @param event type - * @param ability ability to execute + * @param ability ability manager to execute * @param player player context triggering the ability * @param event triggering Bukkit event */ - public static void execute(Ability ability, BlightedPlayer player, T event) { - AbilityManager manager = castManager(ability.manager()); + public static void execute(AbilityManager ability, BlightedPlayer player, T event) { + String cooldownKey = ability.getName() != null && !ability.getName().isBlank() + ? ability.getName() + : ability.getClass().getName(); - double remaining = player.getRemainingCooldown(manager.getClass(), ability.type()); + double remaining = player.getRemainingCooldown(cooldownKey, ability.getType()); if (remaining > 0) { - warn(player.getPlayer(), "§c⌚ Your §f" + ability.name() + " §cability is on cooldown for §d" + (int) Math.ceil(remaining) + "s§c!"); + warn(player.getPlayer(), "§c⌚ Your §f" + ability.getName() + " §cability is on cooldown for §d" + (int) Math.ceil(remaining) + "s§c!"); cancel(event); return; } - if (!manager.canTrigger(player)) { + if (!ability.canTrigger(player)) { cancel(event); return; } - int manaCost = manager.getManaCost(); + int manaCost = ability.getManaCost(); if (!player.hasMana(manaCost)) { - player.getPlayer().playSound( - player.getPlayer().getLocation(), - Sound.ENTITY_ENDERMAN_TELEPORT, - 100f, - 0.5f - ); + player.getPlayer().playSound(player.getPlayer().getLocation(), Sound.ENTITY_ENDERMAN_TELEPORT, 100f, 0.5f); ActionbarService.ifPresent(service -> service.sendSlotAlert( player.getPlayer(), PlayerHudManager.SECTION_MANA, "§c§lNOT ENOUGH MANA", Duration.ofSeconds(2)) ); @@ -59,23 +56,23 @@ public static void execute(Ability ability, BlightedPlayer pla } try { - boolean success = manager.triggerAbility(event); + boolean success = ability.triggerAbility(event); if (!success) { - if (manager.cancelEvent(false)) cancel(event); + if (ability.cancelEvent(false)) cancel(event); return; } - if (manager.cancelEvent(true)) cancel(event); + if (ability.cancelEvent(true)) cancel(event); if (manaCost > 0) { player.consumeMana(manaCost); ActionbarService.ifPresent(service -> service.renderPlayer(player.getPlayer())); } - manager.start(player); + ability.start(player); - if (manager.getCooldownSeconds() > 0) { - player.setCooldown(manager.getClass(), ability.type(), manager.getCooldownSeconds()); + if (ability.getCooldownSeconds() > 0) { + player.setCooldown(cooldownKey, ability.getType(), ability.getCooldownSeconds()); } } catch (Exception exception) { Log.error("AbilityExecutor", "Ability execution failed: " + exception.getClass().getSimpleName()); @@ -88,9 +85,4 @@ private static void cancel(Event event) { cancellable.setCancelled(true); } } - - @SuppressWarnings("unchecked") - private static AbilityManager castManager(AbilityManager manager) { - return (AbilityManager) manager; - } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityListener.java index 39de91ca..5712d40d 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityListener.java @@ -4,12 +4,14 @@ import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import org.bukkit.Bukkit; +import org.bukkit.Material; import org.bukkit.entity.Player; import org.bukkit.event.Event; import org.bukkit.event.EventHandler; import org.bukkit.event.EventPriority; import org.bukkit.event.Listener; import org.bukkit.event.block.Action; +import org.bukkit.event.block.BlockBreakEvent; import org.bukkit.event.block.BlockDispenseArmorEvent; import org.bukkit.event.entity.PlayerDeathEvent; import org.bukkit.event.inventory.InventoryClickEvent; @@ -17,6 +19,7 @@ import org.bukkit.event.inventory.InventoryType; import org.bukkit.event.player.*; import org.bukkit.inventory.EquipmentSlot; +import org.bukkit.inventory.ItemStack; import java.util.HashSet; import java.util.List; @@ -24,7 +27,7 @@ import java.util.UUID; /** - * Listens for Bukkit interaction events, armor changes, and player states to trigger abilities and schedule armor updates. + * Listens for Bukkit interaction, block break, and inventory events to trigger item abilities and schedule armor updates. */ public final class AbilityListener implements Listener { private final Set dirtyArmorPlayers = new HashSet<>(); @@ -48,7 +51,7 @@ private void processArmorUpdates() { Player player = Bukkit.getPlayer(uuid); if (player == null || !player.isOnline()) continue; - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); if (blightedPlayer == null) continue; ArmorManager.updatePlayerArmor(blightedPlayer); @@ -115,7 +118,7 @@ public void onPlayerJoin(PlayerJoinEvent event) { @EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true) public void onSneakToggle(PlayerToggleSneakEvent event) { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(event.getPlayer()); + BlightedPlayer blightedPlayer = BlightedPlayer.get(event.getPlayer()); if (blightedPlayer != null) { ArmorManager.handleSneakUpdate(blightedPlayer, event.isSneaking()); } @@ -147,7 +150,7 @@ public void onPlayerInteract(PlayerInteractEvent event) { } @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true) - public void onBlockBreak(org.bukkit.event.block.BlockBreakEvent event) { + public void onBlockBreak(BlockBreakEvent event) { trigger(event.getPlayer(), event); } @@ -156,8 +159,9 @@ private boolean isArmorMaterial(String name) { || name.endsWith("_LEGGINGS") || name.endsWith("_BOOTS") || name.equals("ELYTRA"); } + @SuppressWarnings({"unchecked", "rawtypes"}) private void trigger(Player player, T event) { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(player); + BlightedPlayer blightedPlayer = BlightedPlayer.get(player); if (blightedPlayer == null) return; BlightedItem blightedItem = null; @@ -166,9 +170,9 @@ private void trigger(Player player, T event) { if (interactEvent.getItem() != null) { blightedItem = BlightedItem.fromItemStack(interactEvent.getItem()); } - } else if (event instanceof org.bukkit.event.block.BlockBreakEvent) { - org.bukkit.inventory.ItemStack mainHand = player.getInventory().getItemInMainHand(); - if (mainHand.getType() != org.bukkit.Material.AIR) { + } else if (event instanceof BlockBreakEvent) { + ItemStack mainHand = player.getInventory().getItemInMainHand(); + if (mainHand.getType() != Material.AIR) { blightedItem = BlightedItem.fromItemStack(mainHand); } } else { @@ -177,19 +181,19 @@ private void trigger(Player player, T event) { if (blightedItem == null) return; - List abilities = blightedItem.getAbilities(); + List> abilities = blightedItem.getAbilities(); if (abilities.isEmpty()) return; - Ability bestMatch = null; - for (Ability ability : abilities) { - if (!ability.type().matches(event)) continue; - if (bestMatch == null || isMoreSpecific(ability.type(), bestMatch.type())) { + AbilityManager bestMatch = null; + for (AbilityManager ability : abilities) { + if (!ability.getType().matches(event)) continue; + if (bestMatch == null || isMoreSpecific(ability.getType(), bestMatch.getType())) { bestMatch = ability; } } if (bestMatch != null) { - AbilityExecutor.execute(bestMatch, blightedPlayer, event); + AbilityExecutor.execute((AbilityManager) bestMatch, blightedPlayer, event); } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityManager.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityManager.java index 4eb762dd..f1ba7935 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityManager.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityManager.java @@ -3,73 +3,125 @@ import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import org.bukkit.event.Event; +import java.util.ArrayList; +import java.util.List; + /** - * Defines the execution logic, lifecycle hooks, and resource requirements for an {@link Ability}. + * Defines execution logic, lifecycle hooks, and resource requirements for an item ability. * - * @param event type that triggers this ability + * @param Bukkit event type that triggers this ability */ public interface AbilityManager { + /** + * Gets the display name of this ability. + * + * @return ability display name + */ + String getName(); + + /** + * Gets the trigger condition type for this ability. + * + * @return ability trigger type + */ + AbilityType getType(); + /** * Executes the ability logic when triggered by an event. * * @param event triggering Bukkit event - * @return {@code true} if execution succeeded, {@code false} otherwise + * @return {@code true} if ability execution succeeded, {@code false} otherwise */ boolean triggerAbility(T event); /** * Gets the cooldown duration applied after triggering this ability. * - * @return cooldown duration in seconds + * @return cooldown duration in seconds, defaulting to {@code 0} */ - int getCooldownSeconds(); + default int getCooldownSeconds() { + return 0; + } /** * Gets the mana cost required to activate this ability. * - * @return required mana amount + * @return required mana cost, defaulting to {@code 0} */ - int getManaCost(); + default int getManaCost() { + return 0; + } /** - * Checks whether the specified player meets the requirements to trigger this ability. + * Evaluates whether a player meets requirements to trigger this ability. * * @param player player context to evaluate - * @return {@code true} if the player can activate the ability, {@code false} otherwise + * @return {@code true} if the player can activate this ability, {@code false} otherwise */ - boolean canTrigger(BlightedPlayer player); + default boolean canTrigger(BlightedPlayer player) { + return true; + } /** - * Called immediately after successful ability execution. + * Called immediately following successful ability execution. * * @param player player context that activated the ability */ - void start(BlightedPlayer player); + default void start(BlightedPlayer player) { + } /** - * Stops and cleans up active ability effects or scheduled tasks. + * Cleans up active ability effects or background tasks for a player. * - * @param player player context owning the ability + * @param player player context owning the active ability */ - void stop(BlightedPlayer player); + default void stop(BlightedPlayer player) { + } /** - * Determines whether the triggering event should be cancelled following ability execution. + * Determines whether the triggering Bukkit event should be cancelled. * - * @param success outcome of {@link #triggerAbility(Event)} - * @return {@code true} to cancel the triggering event, {@code false} to allow vanilla event resolution + * @param success outcome returned by {@link #triggerAbility(Event)} + * @return {@code true} to cancel the triggering event, {@code false} to allow normal resolution */ default boolean cancelEvent(boolean success) { return true; } /** - * Gets description lines formatted for item tooltip lore display. + * Gets description lines for item tooltip lore display. * - * @return array of lore description lines + * @return array of description lore lines */ default String[] getDescription() { return new String[0]; } + + /** + * Formats lore lines displaying the ability name, trigger type, description, and resource costs. + * + * @return formatted list of item lore lines + */ + default List getAbilityLore() { + List lore = new ArrayList<>(); + + lore.add(""); + lore.add("§5 Ability: " + getName() + " " + getType().getDisplayName()); + + for (String line : getDescription()) { + lore.add("§7 " + line); + } + + int mana = getManaCost(); + int cooldown = getCooldownSeconds(); + + if (mana > 0) { + lore.add("§8 Mana Cost: §3" + mana); + } + if (cooldown > 0) { + lore.add("§8 Cooldown: §a" + cooldown + "s"); + } + return lore; + } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityType.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityType.java index 167b8d01..f59c6e61 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityType.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/AbilityType.java @@ -13,29 +13,53 @@ @Getter public enum AbilityType { - /** Ability triggered by right-clicking. */ + /** + * Ability triggered by right-clicking. + */ RIGHT_CLICK("§d§lRIGHT CLICK"), - /** Ability triggered by left-clicking. */ + /** + * Ability triggered by left-clicking. + */ LEFT_CLICK("§d§lLEFT CLICK"), - /** Ability triggered by either left or right clicking. */ + /** + * Ability triggered by either left or right clicking. + */ LEFT_OR_RIGHT_CLICK("§d§lCLICK"), - /** Ability triggered while sneaking. */ + /** + * Ability triggered while sneaking. + */ SNEAK("§d§lSNEAK"), - /** Ability triggered by sneaking and right-clicking. */ - SNEAK_RIGHT_CLICK("§d§lSNEAK + RIGHT CLICK"), - /** Ability triggered by sneaking and left-clicking. */ - SNEAK_LEFT_CLICK("§d§lSNEAK + LEFT CLICK"), - /** Ability triggered by sneaking and clicking. */ - SNEAK_LEFT_OR_RIGHT_CLICK("§d§lSNEAK + CLICK"), - /** Ability activated when a full armor set is worn. */ + /** + * Ability triggered by sneaking and right-clicking. + */ + SNEAK_RIGHT_CLICK("§d§lSNEAK RIGHT CLICK"), + /** + * Ability triggered by sneaking and left-clicking. + */ + SNEAK_LEFT_CLICK("§d§lSNEAK LEFT CLICK"), + /** + * Ability triggered by sneaking and clicking. + */ + SNEAK_LEFT_OR_RIGHT_CLICK("§d§lSNEAK CLICK"), + /** + * Ability activated when a full armor set is worn. + */ FULL_SET_BONUS("§6§lFULL SET BONUS"), - /** Ability triggered when hitting an entity. */ + /** + * Ability triggered when hitting an entity. + */ ENTITY_HIT("§d§lON HIT"), - /** Ability triggered before dealing damage. */ + /** + * Ability triggered before dealing damage. + */ PRE_HIT("§d§lPRE HIT"), - /** Ability triggered after dealing damage. */ + /** + * Ability triggered after dealing damage. + */ AFTER_HIT("§d§lAFTER HIT"), - /** Passive ability continuously active or triggered on passive events. */ + /** + * Passive ability continuously active or triggered on passive events. + */ PASSIVE(""); private final String displayName; @@ -45,7 +69,7 @@ public enum AbilityType { } /** - * Determines whether the given event matches the trigger criteria for this ability type. + * Determines whether a Bukkit event satisfies this trigger condition. * * @param event Bukkit event to evaluate * @return {@code true} if the event satisfies this trigger condition, {@code false} otherwise diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/ArmorManager.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/ArmorManager.java index 3e6e5020..f7c8a6a3 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/ArmorManager.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/ArmorManager.java @@ -1,8 +1,8 @@ package fr.moussax.blightedSMP.engine.items.abilities; +import fr.moussax.bedrock.utils.debug.Log; import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; -import fr.moussax.bedrock.utils.debug.Log; import org.bukkit.inventory.ItemStack; import java.util.ArrayList; @@ -55,7 +55,7 @@ public static void updatePlayerArmor(BlightedPlayer player) { bonusCount.forEach((bonusClass, count) -> { boolean isRunning = player.getActiveFullSetBonuses().stream() - .anyMatch(b -> b.getClass().equals(bonusClass)); + .anyMatch(fullSetBonus -> fullSetBonus.getClass().equals(bonusClass)); if (isRunning) return; @@ -74,7 +74,7 @@ public static void updatePlayerArmor(BlightedPlayer player) { /** * Toggles sneak-dependent set bonuses when a player changes sneak state. * - * @param player player context + * @param player player context * @param isSneaking {@code true} if player started sneaking, {@code false} if stopped */ public static void handleSneakUpdate(BlightedPlayer player, boolean isSneaking) { diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/CooldownEntry.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/CooldownEntry.java index 5c0e8c03..1b4e1885 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/CooldownEntry.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/CooldownEntry.java @@ -1,13 +1,13 @@ package fr.moussax.blightedSMP.engine.items.abilities; /** - * Tracks an active cooldown for a specific ability execution manager and type. + * Tracks an active cooldown for a specific ability execution manager or key and type. * - * @param abilityManager class of the {@link AbilityManager} owning this cooldown + * @param key unique identifier or class name owning this cooldown * @param abilityType ability trigger type under cooldown * @param expirationTimeMillis epoch timestamp in milliseconds when the cooldown expires */ -public record CooldownEntry(Class abilityManager, AbilityType abilityType, long expirationTimeMillis) { +public record CooldownEntry(String key, AbilityType abilityType, long expirationTimeMillis) { /** * Checks whether the cooldown period has elapsed. diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/FullSetBonus.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/FullSetBonus.java index 36eb5bf1..105d85da 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/FullSetBonus.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/abilities/FullSetBonus.java @@ -89,10 +89,7 @@ default boolean hasListener() { */ default void activate() { if (hasListener()) { - Bukkit.getPluginManager().registerEvents( - (Listener) this, - BlightedSMP.getInstance() - ); + Bukkit.getPluginManager().registerEvents((Listener) this, BlightedSMP.getInstance()); } startAbilityEffect(); } From 81219ef4a196b992e2e4fe91423d08818928488c Mon Sep 17 00:00:00 2001 From: Moussa Date: Mon, 28 Sep 2026 13:17:11 +0200 Subject: [PATCH 11/31] chore: update AGENTS.md, CONTRIBUTING.md & Agent Skills --- .agents/skills/abstraction-tax/SKILL.md | 76 -- .agents/skills/clean-commit/SKILL.md | 275 +------ .agents/skills/code-review/SKILL.md | 145 ++-- .agents/skills/codebase-design/DEEPENIN.md | 37 - .../skills/codebase-design/DESIGN-IT-TWICE.md | 44 -- .agents/skills/codebase-design/SKILL.md | 114 --- .agents/skills/design-review/SKILL.md | 136 ++++ .agents/skills/game-design/SKILL.md | 301 +++++--- .agents/skills/game-implement/SKILL.md | 172 +++-- .agents/skills/generate-docs/SKILL.md | 170 +++-- .agents/skills/generate-docs/evals/evals.json | 25 +- .agents/skills/grill-me/SKILL.md | 7 - .agents/skills/grilling/SKILL.md | 28 - .../HTML-REPORT.md | 123 ---- .../improve-codebase-architecture/SKILL.md | 71 -- .agents/skills/patch-bug/SKILL.md | 116 ++- AGENTS.md | 687 +++++++++++------- CONTRIBUTING.md | 8 +- 18 files changed, 1133 insertions(+), 1402 deletions(-) delete mode 100644 .agents/skills/abstraction-tax/SKILL.md delete mode 100644 .agents/skills/codebase-design/DEEPENIN.md delete mode 100644 .agents/skills/codebase-design/DESIGN-IT-TWICE.md delete mode 100644 .agents/skills/codebase-design/SKILL.md create mode 100644 .agents/skills/design-review/SKILL.md delete mode 100644 .agents/skills/grill-me/SKILL.md delete mode 100644 .agents/skills/grilling/SKILL.md delete mode 100644 .agents/skills/improve-codebase-architecture/HTML-REPORT.md delete mode 100644 .agents/skills/improve-codebase-architecture/SKILL.md diff --git a/.agents/skills/abstraction-tax/SKILL.md b/.agents/skills/abstraction-tax/SKILL.md deleted file mode 100644 index f5eeb1c3..00000000 --- a/.agents/skills/abstraction-tax/SKILL.md +++ /dev/null @@ -1,76 +0,0 @@ ---- -name: abstraction-tax -description: >- - Audits an existing core system/module (not a single diff) for - over-engineering, DX friction, and unnecessary abstraction, and proposes - zero-regression fixes. Use for "is this over-engineered", "review this - system's design", "find what's making this hard to use", "audit this for - over-engineering", or when a user who previously flagged one system's - abstraction as painful asks to look at a different, unrelated core system - with the same lens. Also trigger for a "coderabbit-like" architectural - review, or a report on necessary vs. accidental complexity. NOT for a - single function, a single PR diff, or bugs unrelated to design/structure — - use patch-bug or a plain review for that. Read-only by default: produces a - findings report; only makes code changes or an agent fix-prompt on request. ---- - -# Abstraction Tax - -Every abstraction has a carrying cost — indirection, extra call sites, more surface to learn — paid whether or not it earns its keep. This skill audits an existing system to find where that tax is being paid without a corresponding benefit, applying YAGNI-first, deletion-over-addition reasoning backwards onto code that already exists, rather than forwards onto code being written. - -## What this skill is for - -A system that solves real duplication (e.g. one loot pipeline instead of three) can still be over-engineered in specific, local ways — an interface with no polymorphic consumer, a sum type crammed into nullable fields with runtime guards, an overload set simulating a builder, duplicated logic that crept back in at a layer above the abstraction. The goal is to find *exactly those*, and nothing else — not to relitigate the whole design, and not to declare something unnecessary without proof. - -## The one rule that matters most - -**Never declare a method, overload, field, or type "unused" or "unnecessary" without an actual, exhaustive search of the codebase for call sites.** A constructor that looks like redundant sugar may be the only path to a registry lookup that produces real state (lore, NBT, config) nothing else provides. A "marker interface with no purpose" may have exactly one consumer three packages away. Guessing that something is dead because it *looks* dead from the file in front of you is the single most damaging failure mode this skill can produce — it turns an audit into a regression generator. Every "remove this" or "this is unnecessary" claim in the final report must cite what you searched for and what you found (including "zero matches found for X across the codebase" as explicit evidence, not silence). - -If you cannot search the full codebase (only the pasted files are available, no repo access), say so explicitly in the report and downgrade every removal-flavored finding to a question: "this looks unused from what's shown — can you confirm no other call site depends on it?" Never phrase an unverified guess as a finding with the same confidence as a verified one. - -## Process - -### 1. Establish what the system is for - -Before judging any individual class, state in one or two sentences what problem the system was built to solve and what it correctly centralized (the thing that would have to be reinvented per-domain without it). This is the baseline against which "over-engineered" is measured — a design isn't over-engineered relative to some abstract ideal, it's over-engineered relative to what its own requirements actually needed. - -### 2. Inventory the abstractions - -List every interface, abstract class, generic type, strategy/decorator/factory pattern, and multi-overload API surface in the system. For each one, ask: - -- **Does something actually consume this polymorphically** (an `instanceof` check elsewhere, a collection typed to the interface, a factory returning the interface type and being passed around as such) — or does exactly one implementation exist and get used concretely everywhere? A single-implementation interface with no polymorphic call site is a candidate for removal, but only after the search from the rule above. -- **Does a sum-type-shaped concept (exactly one of several mutually exclusive kinds) get modeled as one class with nullable fields and runtime-exception accessors**, instead of a sealed hierarchy? This is almost always a real finding when the language supports sealed types/enums with data. -- **Does an overload set exist because of genuinely different construction paths** (e.g., "build from a registry ID" vs. "build from a raw value" — different *semantics*, not just different *types*), or because someone manually enumerated the cartesian product of optional parameters that a single flexible signature (varargs, a small options record, `Optional`, a builder that already exists elsewhere in the codebase) would cover in one path? -- **Has duplicated logic reappeared at a layer the core abstraction was supposed to eliminate** — e.g. three near-identical decorator/handler/adapter classes across domains that differ only in a lookup table, when the abstraction below them already unified everything else? This is usually the highest-value finding: it means the abstraction is sound but incomplete. -- **Are there nullable/optional fields on a shared context or value object that force null-checks at many call sites**, and if so, is that the necessary cost of genuinely supporting multiple calling scenarios (keep, maybe note it), or a symptom of the object trying to serve one caller's needs plus every hypothetical future caller's needs (flag it)? - -### 3. Separate findings into two buckets, explicitly - -- **Necessary complexity.** State this list even though it's not the interesting part of the report — it prevents the fix step (yours or an agent's) from "helpfully" simplifying something load-bearing. Anything that produces meaningfully different runtime state (a registry lookup, a validated/normalized value, a security or trust-boundary check) belongs here even if it looks like sugar. -- **Actual findings.** Only things that survive the "did I search for usage" gate above. For each finding, use this shape: - - **Problem** — the concrete symptom (duplication, runtime type-guard, overload sprawl, unconsumed polymorphism). - - **Evidence** — what you searched for, and what you found (or didn't). - - **Root cause** — why this happened (usually: DX designed before requirements were fully known, or one abstraction reused past its natural boundary). - - **Fix** — a concrete, minimal proposal. Prefer collapsing to what already exists elsewhere in the codebase over inventing a new pattern. - - **Call-site impact** — rough count/list of what would need to change if this fix were applied. - -### 4. Order findings by leverage, not by file order - -Put the finding that removes the most duplication or the most runtime-crash risk first, not the first class you happened to read. End with an explicit "leave alone" section naming the parts of the system that are correctly scoped — this matters as much as the findings, because it tells the reader (or a fix agent) where *not* to touch. - -## Output modes - -**Default: findings report**, written directly in the conversation (or as a doc/artifact if the codebase is large enough that the user will want to keep it) — no code changes, no file edits to the audited system. This is the deliverable most requests want. - -**On request: zero-regression fix agent prompt.** If the user asks you to turn the findings into something an agent can execute, produce a structured prompt with: -- A role/scope statement restricting the agent to only the listed findings. -- Explicit non-negotiable constraints: search for every call site before changing a signature, one task at a time with verification between tasks, no unrelated reformatting, no behavior change beyond what each task states. -- One task per finding, ordered by dependency (a finding that changes a type other findings build on goes first), each with Problem / Fix / Acceptance criteria / known ambiguous cases to stop-and-report on rather than guess at. -- An explicit "out of scope" section — this must include anything from the "necessary complexity" bucket that might otherwise look temptingly simplifiable to an agent working file-by-file without the full picture. -- A final-report format requirement so the agent reports call sites touched and anything it couldn't verify, rather than silently asserting success. - -**On request: apply the fixes directly.** Only if explicitly asked — follow the same task-by-task, verify-before-proceeding discipline as the agent prompt would specify, and stop to ask if a finding turns out to be more load-bearing than the audit assumed (this happens — it's not a failure, it's the search-before-removing rule doing its job mid-fix instead of before the report). - -## What "done" looks like - -A good audit report is disprovable — someone could take any single finding, go check the evidence cited, and either confirm or reject it without having to re-derive your reasoning from scratch. A report that says "X seems unnecessary" with no search evidence is not an audit, it's a guess with formatting. \ No newline at end of file diff --git a/.agents/skills/clean-commit/SKILL.md b/.agents/skills/clean-commit/SKILL.md index 956f939a..d33c1695 100644 --- a/.agents/skills/clean-commit/SKILL.md +++ b/.agents/skills/clean-commit/SKILL.md @@ -1,274 +1,59 @@ --- name: clean-commit -description: >- - Drafts commit messages in `category(scope): message` conventional-commit - format, in the voice of a senior dev who wrote it in ten seconds because - it was obvious — not in AI-generated-commit voice (marketing adjectives, - restated diffs, emoji, exclamation points). Use ONLY when the user - explicitly asks to write, generate, or clean up a commit message, or - explicitly asks to commit. Never trigger this proactively after finishing - an unrelated coding task, and never run `git commit` (or stage/push for - that purpose) without the user's separate, explicit approval of the exact - message shown — drafting and executing are two different steps requiring - two different asks. NOT for PR descriptions or changelogs — those need - more context than a commit subject line and are a different deliverable. +description: Draft a concise conventional commit message from the actual diff and the repository's existing commit style. Use only when explicitly asked for a commit message or to commit. --- # Clean Commit -A commit message's job is to tell the next person (often future-you) *why* -a change happened, in one line, using the fewest words that don't lose -information. AI-generated commit messages fail this by explaining the diff -back to the reader in marketing prose. This skill writes the other kind — -and it never runs `git commit` on its own say-so. +Write the commit message from the actual change, not from the task description. -## Approval gate — read this first +## Inspect -- **Never invoke this skill unprompted.** Finishing a coding task is not, by - itself, a reason to draft or suggest a commit message. Wait for the user - to ask for one, explicitly, in this turn. -- **Drafting is not committing.** A request like "commit this" or "write a - commit message for these changes" means: inspect the diff, draft the - message, show it. It does not mean run `git commit`. -- **Executing requires a second, explicit approval of the shown message** — - something like "yes, commit it," "use that," or "run it." A vague - continuation of the conversation is not approval. If there's any doubt - whether the user approved the *specific message shown* versus just the - idea of committing in general, ask before running the command. -- This gate applies regardless of how small or routine the change looks. - There is no change trivial enough to skip it. +Read the staged diff when one exists. -## Process +If nothing is staged, inspect the relevant working-tree diff or ask what change the message should describe. -### 1. Read the actual diff +Check recent commit history for the repository's established category, scope, and formatting conventions. -Never write a commit message from a task description or file list alone — -run `git diff --staged` (or the equivalent for what's being committed) and -read it. The subject line describes the *effect* of the change, which is -often not obvious from "what files changed." +Do not invent a commit convention when the repository already has one. -If nothing is staged, ask what to inspect rather than inventing content. +## Write -### 2. Match the repo's existing convention, don't invent one +Use: -- Check `git log --oneline -20` for the categories and scope granularity - already in use. If the repo's `CONTRIBUTING`/convention doc lists aliases - (`feat` vs `feature`), use whichever one recent history actually uses; if - neither is established yet, default to the shorter form (`feat`, not - `feature`). -- Scope should match a real module/directory/component name already used in - prior commits or in the repo's own folder structure — never a vague - placeholder like `core`, `misc`, or `stuff`, and never invented naming - that doesn't match what the codebase calls that area. If the repo has its - own naming rules (e.g. a banned-abbreviations list in its agent - guidelines), the scope name follows those too — a commit scope is still - an identifier a reader has to parse. -- Pick exactly one category. If the diff genuinely spans two (a fix bundled - with an unrelated refactor, a feature bundled with its docs), say so and - suggest splitting into separate commits — do not pick the closest category - and silently bury the rest of the change under it. - -### 3. Write the subject line like it cost nothing to write - -- Imperative present tense: `add`, `fix`, `remove`, `rename` — not `added`, - `adding`, or `adds`. -- Lowercase after the `category(scope): ` prefix, no trailing period. -- Describes what changed and, if it's not obvious from that alone, why — - never restates the diff mechanically ("update file to add new function"). - A senior dev's commit answers "what would confuse someone reading `git - blame` on this line in a year" — often that's a constraint or a bug - symptom, not a description of the edit itself. -- Target ~50–72 characters. If the real reason needs more room, put it in - the body — don't cram it into the subject or drop it. - -### 4. Body — only when the subject line isn't enough - -Add a body only if there's a *why* that isn't inferable from the subject and -the diff: a tradeoff made, a constraint that ruled out the obvious approach, -a bug's root cause, a reference to the report/issue that prompted this. - -- Prose or short bullets, but never a bullet list that mirrors the diff - hunks one-for-one ("- changed X to Y", "- added import Z") — that's - restating information the diff already carries losslessly. If you find - yourself doing this, delete the body; the diff is a better changelog of - itself than a paraphrase of it. -- Wrap at ~72 chars if the repo's history does; match existing style rather - than imposing one. -- Use a `BREAKING CHANGE:` footer only for actual breaking changes, per the - Conventional Commits / Angular convention — not for every notable change. - -### 5. Strip every AI-commit tell before presenting the result - -Check the draft against this list and remove anything that matches: - -- Marketing adjectives: "comprehensive," "robust," "seamless," "powerful," - "enhanced," "improved" (without a number backing it up). -- Throat-clearing: "This commit adds...", "This change introduces...", - "This PR...". The subject line already says what it does — don't - re-announce it in the body. -- Emoji, exclamation points, title-case subject lines ("Add New Feature For - Avatar Component"). -- Restating the obvious: if the diff adds one function, the message doesn't - need a paragraph describing what the function does — that's what the code - and its own comments are for. -- `Co-Authored-By` / "Generated with [tool]" trailers, unless the user - explicitly asks for attribution. -- Hedging or uncertainty ("this should fix...", "attempts to..."). State - what the commit does. - -## Example - -Diff: adds a `size` prop to an `Avatar` component, used by a new compact -list view elsewhere in the same PR. - -**AI-generated (reject this shape):** +```text +category(scope): message ``` -feat(components): ✨ Enhance Avatar component with new size prop for better flexibility! -This commit introduces a comprehensive update to the Avatar component by -adding a new `size` prop that allows developers to easily customize the -dimensions of the avatar. This change improves the overall flexibility and -usability of the component across the application. -``` +unless the repository clearly uses another convention. -**Senior dev (write this shape):** -``` -feat(avatar): add size prop +The subject should: -defaults to md; needed for the compact list view in settings -``` +* use imperative present tense +* stay concise +* describe the meaningful effect of the change +* avoid restating obvious implementation details +* avoid marketing language, emoji, and filler -Second example — a fix, where the *why* is the bug's actual mechanism, not -a restatement that "a bug was fixed": +Add a body only when the reason for the change is not clear from the subject and diff. -**Reject:** -``` -fix(auth): fix bug with authentication -``` +Useful body content includes: -**Write:** -``` -fix(auth): don't retry token refresh on expired-session 401 +* the underlying bug mechanism +* an important design trade-off +* a constraint that shaped the implementation +* a meaningful migration or compatibility note -retry logic treated all 401s as transient; expired sessions -need a re-login, not a retry loop -``` +Do not write the body as a paraphrased diff. ## Output -Present the finished message in a fenced block, ready to paste into -`git commit -m` or `-F`. Don't narrate the category/scope reasoning back to -the user unless asked — show the result, not the process. - -**Then stop.** Do not run `git commit`, `git add`, or `git push` after -showing the message. Wait for the user's explicit, separate approval of -that specific message before executing anything. - - -### 2. Match the repo's existing convention, don't invent one - -- Check `git log --oneline -20` for the categories and scope granularity - already in use. If the repo's `CONTRIBUTING`/convention doc lists aliases - (`feat` vs `feature`), use whichever one recent history actually uses; if - neither is established yet, default to the shorter form (`feat`, not - `feature`). -- Scope should match a real module/directory/component name already used in - prior commits or in the repo's own folder structure — never a vague - placeholder like `core`, `misc`, or `stuff`, and never invented naming - that doesn't match what the codebase calls that area. -- Pick exactly one category. If the diff genuinely spans two (a fix bundled - with an unrelated refactor, a feature bundled with its docs), say so and - suggest splitting into separate commits — do not pick the closest category - and silently bury the rest of the change under it. - -### 3. Write the subject line like it cost nothing to write - -- Imperative present tense: `add`, `fix`, `remove`, `rename` — not `added`, - `adding`, or `adds`. -- Lowercase after the `category(scope): ` prefix, no trailing period. -- Describes what changed and, if it's not obvious from that alone, why — - never restates the diff mechanically ("update file to add new function"). - A senior dev's commit answers "what would confuse someone reading `git - blame` on this line in a year" — often that's a constraint or a bug - symptom, not a description of the edit itself. -- Target ~50–72 characters. If the real reason needs more room, put it in - the body — don't cram it into the subject or drop it. +Return the finished message in a fenced block: -### 4. Body — only when the subject line isn't enough - -Add a body only if there's a *why* that isn't inferable from the subject and -the diff: a tradeoff made, a constraint that ruled out the obvious approach, -a bug's root cause, a reference to the report/issue that prompted this. - -- Prose or short bullets, but never a bullet list that mirrors the diff - hunks one-for-one ("- changed X to Y", "- added import Z") — that's - restating information the diff already carries losslessly. If you find - yourself doing this, delete the body; the diff is a better changelog of - itself than a paraphrase of it. -- Wrap at ~72 chars if the repo's history does; match existing style rather - than imposing one. -- Use a `BREAKING CHANGE:` footer only for actual breaking changes, per the - Conventional Commits / Angular convention — not for every notable change. - -### 5. Strip every AI-commit tell before presenting the result - -Check the draft against this list and remove anything that matches: - -- Marketing adjectives: "comprehensive," "robust," "seamless," "powerful," - "enhanced," "improved" (without a number backing it up). -- Throat-clearing: "This commit adds...", "This change introduces...", - "This PR...". The subject line already says what it does — don't - re-announce it in the body. -- Emoji, exclamation points, title-case subject lines ("Add New Feature For - Avatar Component"). -- Restating the obvious: if the diff adds one function, the message doesn't - need a paragraph describing what the function does — that's what the code - and its own comments are for. -- `Co-Authored-By` / "Generated with [tool]" trailers, unless the user - explicitly asks for attribution. -- Hedging or uncertainty ("this should fix...", "attempts to..."). State - what the commit does. - -## Example - -Diff: adds a `size` prop to an `Avatar` component, used by a new compact -list view elsewhere in the same PR. - -**AI-generated (reject this shape):** -``` -feat(components): ✨ Enhance Avatar component with new size prop for better flexibility! - -This commit introduces a comprehensive update to the Avatar component by -adding a new `size` prop that allows developers to easily customize the -dimensions of the avatar. This change improves the overall flexibility and -usability of the component across the application. -``` - -**Senior dev (write this shape):** +```text +fix(spawn): cap replacement probability at one ``` -feat(avatar): add size prop -defaults to md; needed for the compact list view in settings -``` - -Second example — a fix, where the *why* is the bug's actual mechanism, not -a restatement that "a bug was fixed": - -**Reject:** -``` -fix(auth): fix bug with authentication -``` - -**Write:** -``` -fix(auth): don't retry token refresh on expired-session 401 - -retry logic treated all 401s as transient; expired sessions -need a re-login, not a retry loop -``` - -## Output +Do not run `git add`, `git commit`, or `git push`. -Present the finished message in a fenced block, ready to paste into -`git commit -m` or `-F`. Don't narrate the category/scope reasoning back to -the user unless asked — show the result, not the process. \ No newline at end of file +Execution requires separate explicit authorization after the exact message has been reviewed. diff --git a/.agents/skills/code-review/SKILL.md b/.agents/skills/code-review/SKILL.md index 7d8988a6..8b27fac9 100644 --- a/.agents/skills/code-review/SKILL.md +++ b/.agents/skills/code-review/SKILL.md @@ -1,87 +1,126 @@ --- name: code-review -description: "Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue/spec asked for?). Runs both reviews in parallel sub-agents and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to \"review since X\"." +description: Review a diff for correctness, scope, maintainability, API and developer experience, and alignment with the repository's requirements. --- -Two-axis review of the diff between `HEAD` and a fixed point the user supplies: +# Code Review -- **Standards**: does the code conform to this repo's documented coding standards? -- **Spec**: does the code faithfully implement the originating issue / spec? +Review the change as code that will be maintained and consumed, not as a checklist exercise. -Both axes run as **parallel sub-agents** so they don't pollute each other's context, then this skill aggregates their findings. +## 1. Establish the change -The issue tracker should have been provided to you. If `docs/agents/issue-tracker.md` is missing, tell the user to run `/setup-matt-pocock-skills`. +Identify the comparison point and inspect the complete diff. -## Process +Read the surrounding code for changed areas. A diff is not sufficient context when behavior depends on callers, shared abstractions, configuration, lifecycle, or framework APIs. -### 1. Pin the fixed point +Identify the originating issue, task, or specification when one is available. -Whatever the user said is the fixed point (a commit SHA, branch name, tag, `main`, `HEAD~5`, etc.). If they didn't specify one, ask for it. +Do not require a spec when none exists. -Capture the diff command once: `git diff ...HEAD` (three-dot, so the comparison is against the merge-base). Also note the list of commits via `git log ..HEAD --oneline`. +## 2. Review the change -Before going further, confirm the fixed point resolves (`git rev-parse `) and the diff is non-empty. A bad ref or empty diff should fail here, not inside two parallel sub-agents. +Look for problems in these areas: -### 2. Identify the spec source +### Correctness -Look for the originating spec, in this order: +Check behavior, edge cases, state transitions, error handling, concurrency, lifecycle, and integration with surrounding code. -1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.), fetched via the workflow in `docs/agents/issue-tracker.md`. -2. A path the user passed as an argument. -3. A spec file under `docs/`, `specs/`, or `.scratch/` matching the branch name or feature. -4. If nothing is found, ask the user where the spec is. If they say there isn't one, the **Spec** sub-agent will skip and report "no spec available". +### Requirements -### 3. Identify the standards sources +Check whether the requested behavior is implemented completely and whether the change introduces behavior outside the requested scope. -Anything in the repo that documents how code should be written, such as `CODING_STANDARDS.md` or `CONTRIBUTING.md`. +A missing requirement and unnecessary scope are both findings. -On top of whatever the repo documents, the Standards axis always carries the **smell baseline** below: a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo documents nothing. Two rules bind it: +### Design -- **The repo overrides.** A documented repo standard always wins; where it endorses something the baseline would flag, suppress the smell. -- **Always a judgement call.** Each smell is a labelled heuristic ("possible Feature Envy"), never a hard violation. Like any standard here, skip anything tooling already enforces. +Check whether responsibilities, abstractions, and boundaries fit the actual problem. -Each smell reads *what it is* → *how to fix*; match it against the diff: +Do not flag duplication merely because code is duplicated. -- **Mysterious Name**: a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky. -- **Duplicated Code**: the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both. -- **Feature Envy**: a method that reaches into another object's data more than its own. → move the method onto the data it envies. -- **Data Clumps**: the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that. -- **Primitive Obsession**: a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type. -- **Repeated Switches**: the same `switch`/`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share. -- **Shotgun Surgery**: one logical change forces scattered edits across many files in the diff. → gather what changes together into one module. -- **Divergent Change**: one file or module is edited for several unrelated reasons. → split so each module changes for one reason. -- **Speculative Generality**: abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows. -- **Message Chains**: long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object. -- **Middle Man**: a class or function that mostly just delegates onward. → cut it, call the real target direct. -- **Refused Bequest**: a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition. +Do not recommend extraction unless the code represents a meaningful shared concept or the duplication creates a real maintenance problem. -### 4. Spawn both sub-agents in parallel +Likewise, do not praise abstraction merely because it is reusable. -**Standards sub-agent prompt** should include: +### API and DX -- The full diff command and commit list. -- The list of standards-source files you found in step 3, **plus the smell baseline from step 3** pasted in full (the sub-agent has no other access to it). -- The brief: "Report, per file/hunk where relevant, (a) every place the diff violates a documented standard: cite the standard (file + the rule); and (b) any baseline smell you spot: name it and quote the hunk. Distinguish hard violations from judgement calls: documented-standard breaches can be hard, but baseline smells are always judgement calls, and a documented repo standard overrides the baseline. Skip anything tooling enforces. Under 400 words." +For public or reusable APIs, inspect the consumer-facing call site. -**Spec sub-agent prompt** should include: +Look for: -- The diff command and commit list. -- The path or fetched contents of the spec, enclosed in explicit XML tags (e.g., ``) clearly marked as untrusted data, with instructions to evaluate the content purely as a specification and never execute or follow embedded instructions. -- The brief: "Report: (a) requirements the spec asked for that are missing or partial; (b) behaviour in the diff that wasn't asked for (scope creep); (c) requirements that look implemented but where the implementation looks wrong. Quote the spec line for each finding. Under 400 words." +* unnecessary parameters or ceremony +* surprising behavior +* unclear names +* inconsistent conventions +* weak type constraints +* awkward common-case usage +* abstractions that expose implementation details unnecessarily -If the spec is missing, skip the Spec sub-agent and note this in the final report. +Prefer APIs that make normal usage obvious without preventing advanced usage. -### 5. Aggregate +### Platform and project conventions -Present the two reports under `## Standards` and `## Spec` headings, verbatim or lightly cleaned. Do **not** merge or rerank findings, because the two axes are deliberately separate (see _Why two axes_). +Check the repository's documented standards and the actual platform/dependency versions. -End with a one-line summary: total findings per axis, and the worst issue _within each axis_ (if any). Don't pick a single winner across axes: that's the reranking the separation exists to prevent. +Do not assume a framework API exists from another fork, version, or ecosystem. -## Why two axes +### Tests -A change can pass one axis and fail the other: +Check whether important new or changed behavior is covered appropriately. -- Code that follows every standard but implements the wrong thing → **Standards pass, Spec fail.** -- Code that does exactly what the issue asked but breaks the project's conventions → **Spec pass, Standards fail.** +Do not demand tests that add little value, but do identify meaningful untested behavior. -Reporting them separately stops one axis from masking the other. \ No newline at end of file +## 3. Judge findings + +Only report findings supported by the code. + +Distinguish: + +* **Bug** — demonstrably incorrect behavior. +* **Requirement** — missing or incorrect requested behavior. +* **Design** — maintainability, architecture, or API problem. +* **Nit** — low-impact improvement that is clearly worthwhile. + +Do not turn subjective preferences into violations. + +For design findings, explain the concrete cost and the smallest reasonable improvement. + +## 4. Report + +Order findings by severity and practical impact. + +Use: + +```text +## Findings + +### [Bug] +`path/to/File.java:42` + +Problem + + +Evidence + + +Fix + + +### [Design] +... +``` + +Do not report issues that are purely hypothetical unless they represent a clear design risk. + +Finish with: + +```text +## Summary + + +``` + +Do not provide an overall score or arbitrary quality rating. + +## Review-only means review-only + +Do not modify the repository unless the user explicitly asks to apply the findings. diff --git a/.agents/skills/codebase-design/DEEPENIN.md b/.agents/skills/codebase-design/DEEPENIN.md deleted file mode 100644 index 3a374b43..00000000 --- a/.agents/skills/codebase-design/DEEPENIN.md +++ /dev/null @@ -1,37 +0,0 @@ -# Deepening - -How to deepen a cluster of shallow modules safely, given its dependencies. Assumes the vocabulary in [SKILL.md](SKILL.md): **module**, **interface**, **seam**, **adapter**. - -## Dependency categories - -When assessing a candidate for deepening, classify its dependencies. The category determines how the deepened module is tested across its seam. - -### 1. In-process - -Pure computation, in-memory state, no I/O. Always deepenable: merge the modules and test through the new interface directly. No adapter needed. - -### 2. Local-substitutable - -Dependencies that have local test stand-ins (PGLite for Postgres, in-memory filesystem). Deepenable if the stand-in exists. The deepened module is tested with the stand-in running in the test suite. The seam is internal; no port at the module's external interface. - -### 3. Remote but owned (Ports & Adapters) - -Your own services across a network boundary (microservices, internal APIs). Define a **port** (interface) at the seam. The deep module owns the logic; the transport is injected as an **adapter**. Tests use an in-memory adapter. Production uses an HTTP/gRPC/queue adapter. - -Recommendation shape: *"Define a port at the seam, implement an HTTP adapter for production and an in-memory adapter for testing, so the logic sits in one deep module even though it's deployed across a network."* - -### 4. True external (Mock) - -Third-party services (Stripe, Twilio, etc.) you don't control. The deepened module takes the external dependency as an injected port; tests provide a mock adapter. - -## Seam discipline - -- **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a port unless at least two adapters are justified (typically production + test). A single-adapter seam is just indirection. -- **Internal seams vs external seams.** A deep module can have internal seams (private to its implementation, used by its own tests) as well as the external seam at its interface. Don't expose internal seams through the interface just because tests use them. - -## Testing strategy: replace, don't layer - -- Old unit tests on shallow modules become waste once tests at the deepened module's interface exist; delete them. -- Write new tests at the deepened module's interface. The **interface is the test surface**. -- Tests assert on observable outcomes through the interface, not internal state. -- Tests should survive internal refactors, since they describe behaviour, not implementation. If a test has to change when the implementation changes, it's testing past the interface. \ No newline at end of file diff --git a/.agents/skills/codebase-design/DESIGN-IT-TWICE.md b/.agents/skills/codebase-design/DESIGN-IT-TWICE.md deleted file mode 100644 index aff1749f..00000000 --- a/.agents/skills/codebase-design/DESIGN-IT-TWICE.md +++ /dev/null @@ -1,44 +0,0 @@ -# Design It Twice - -When the user wants to explore alternative interfaces for a chosen deepening candidate, use this parallel sub-agent pattern. Based on "Design It Twice" (Ousterhout): your first idea is unlikely to be the best. - -Uses the vocabulary in [SKILL.md](SKILL.md): **module**, **interface**, **seam**, **adapter**, **leverage**. - -## Process - -### 1. Frame the problem space - -Before spawning sub-agents, write a user-facing explanation of the problem space for the chosen candidate: - -- The constraints any new interface would need to satisfy -- The dependencies it would rely on, and which category they fall into (see [DEEPENING.md](DEEPENING.md)) -- A rough illustrative code sketch to ground the constraints, not a proposal, just a way to make the constraints concrete - -Show this to the user, then immediately proceed to Step 2. The user reads and thinks while the sub-agents work in parallel. - -### 2. Spawn sub-agents - -Spawn 3+ sub-agents in parallel. Each must produce a **radically different** interface for the deepened module. - -Prompt each sub-agent with a separate technical brief (file paths, coupling details, dependency category from [DEEPENING.md](DEEPENING.md), what sits behind the seam). The brief is independent of the user-facing problem-space explanation in Step 1. Give each agent a different design constraint: - -- Agent 1: "Minimize the interface: aim for 1–3 entry points max. Maximise leverage per entry point." -- Agent 2: "Maximise flexibility: support many use cases and extension." -- Agent 3: "Optimise for the most common caller: make the default case trivial." -- Agent 4 (if applicable): "Design around ports & adapters for cross-seam dependencies." - -Include both [SKILL.md](SKILL.md) vocabulary and CONTEXT.md vocabulary in the brief so each sub-agent names things consistently with the architecture language and the project's domain language. - -Each sub-agent outputs: - -1. Interface (types, methods, params, plus invariants, ordering, error modes) -2. Usage example showing how callers use it -3. What the implementation hides behind the seam -4. Dependency strategy and adapters (see [DEEPENING.md](DEEPENING.md)) -5. Trade-offs: where leverage is high, where it's thin - -### 3. Present and compare - -Present designs sequentially so the user can absorb each one, then compare them in prose. Contrast by **depth** (leverage at the interface), **locality** (where change concentrates), and **seam placement**. - -After comparing, give your own recommendation: which design you think is strongest and why. If elements from different designs would combine well, propose a hybrid. Be opinionated: the user wants a strong read, not a menu. \ No newline at end of file diff --git a/.agents/skills/codebase-design/SKILL.md b/.agents/skills/codebase-design/SKILL.md deleted file mode 100644 index 561d9bf0..00000000 --- a/.agents/skills/codebase-design/SKILL.md +++ /dev/null @@ -1,114 +0,0 @@ ---- -name: codebase-design -description: Shared vocabulary for designing deep modules. Use when the user wants to design or improve a module's interface, find deepening opportunities, decide where a seam goes, make code more testable or AI-navigable, or when another skill needs the deep-module vocabulary. ---- - -# Codebase Design - -Design **deep modules**: a lot of behaviour behind a small interface, placed at a clean seam, testable through that interface. Use this language and these principles wherever code is being designed or restructured. The aim is leverage for callers, locality for maintainers, and testability for everyone. - -## Glossary - -Use these terms exactly: don't substitute "component," "service," "API," or "boundary." Consistent language is the whole point. - -**Module**: anything with an interface and an implementation. Deliberately scale-agnostic: a function, class, package, or tier-spanning slice. _Avoid_: unit, component, service. - -**Interface**: everything a caller must know to use the module correctly: the type signature, but also invariants, ordering constraints, error modes, required configuration, and performance characteristics. _Avoid_: API, signature (too narrow, they refer only to the type-level surface). - -**Implementation**: what's inside a module, its body of code. Distinct from **Adapter**: a thing can be a small adapter with a large implementation (a Postgres repo) or a large adapter with a small implementation (an in-memory fake). Reach for "adapter" when the seam is the topic; "implementation" otherwise. - -**Depth**: leverage at the interface. The amount of behaviour a caller (or test) can exercise per unit of interface they have to learn. A module is **deep** when a large amount of behaviour sits behind a small interface, **shallow** when the interface is nearly as complex as the implementation. - -**Seam** _(Michael Feathers)_: a place where you can alter behaviour without editing in that place; the *location* at which a module's interface lives. Where to put the seam is its own design decision, distinct from what goes behind it. _Avoid_: boundary (overloaded with DDD's bounded context). - -**Adapter**: a concrete thing that satisfies an interface at a seam. Describes *role* (what slot it fills), not substance (what's inside). - -**Leverage**: what callers get from depth. More capability per unit of interface they learn. One implementation pays back across N call sites and M tests. - -**Locality**: what maintainers get from depth. Change, bugs, knowledge, and verification concentrate in one place rather than spreading across callers. Fix once, fixed everywhere. - -## Deep vs shallow - -**Deep module** = small interface + lots of implementation: - -``` -┌─────────────────────┐ -│ Small Interface │ ← Few methods, simple params -├─────────────────────┤ -│ │ -│ Deep Implementation│ ← Complex logic hidden -│ │ -└─────────────────────┘ -``` - -**Shallow module** = large interface + little implementation (avoid): - -``` -┌─────────────────────────────────┐ -│ Large Interface │ ← Many methods, complex params -├─────────────────────────────────┤ -│ Thin Implementation │ ← Just passes through -└─────────────────────────────────┘ -``` - -When designing an interface, ask: - -- Can I reduce the number of methods? -- Can I simplify the parameters? -- Can I hide more complexity inside? - -## Principles - -- **Depth is a property of the interface, not the implementation.** A deep module can be internally composed of small, mockable, swappable parts; they just aren't part of the interface. A module can have **internal seams** (private to its implementation, used by its own tests) as well as the **external seam** at its interface. -- **The deletion test.** Imagine deleting the module. If complexity vanishes, it was a pass-through. If complexity reappears across N callers, it was earning its keep. -- **The interface is the test surface.** Callers and tests cross the same seam. If you want to test *past* the interface, the module is probably the wrong shape. -- **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a seam unless something actually varies across it. - -## Designing for testability - -Good interfaces make testing natural: - -1. **Accept dependencies, don't create them.** - - ```typescript - // Testable - function processOrder(order, paymentGateway) {} - - // Hard to test - function processOrder(order) { - const gateway = new StripeGateway(); - } - ``` - -2. **Return results, don't produce side effects.** - - ```typescript - // Testable - function calculateDiscount(cart): Discount {} - - // Hard to test - function applyDiscount(cart): void { - cart.total -= discount; - } - ``` - -3. **Small surface area.** Fewer methods = fewer tests needed. Fewer params = simpler test setup. - -## Relationships - -- A **Module** has exactly one **Interface** (the surface it presents to callers and tests). -- **Depth** is a property of a **Module**, measured against its **Interface**. -- A **Seam** is where a **Module**'s **Interface** lives. -- An **Adapter** sits at a **Seam** and satisfies the **Interface**. -- **Depth** produces **Leverage** for callers and **Locality** for maintainers. - -## Rejected framings - -- **Depth as ratio of implementation-lines to interface-lines** (Ousterhout): rewards padding the implementation. We use depth-as-leverage instead. -- **"Interface" as the TypeScript `interface` keyword or a class's public methods**: too narrow: interface here includes every fact a caller must know. -- **"Boundary"**: overloaded with DDD's bounded context. Say **seam** or **interface**. - -## Going deeper - -- **Deepening a cluster given its dependencies**, see [DEEPENING.md](DEEPENING.md): dependency categories, seam discipline, and replace-don't-layer testing. -- **Exploring alternative interfaces**, see [DESIGN-IT-TWICE.md](DESIGN-IT-TWICE.md): spin up parallel sub-agents to design the interface several radically different ways, then compare on depth, locality, and seam placement. \ No newline at end of file diff --git a/.agents/skills/design-review/SKILL.md b/.agents/skills/design-review/SKILL.md new file mode 100644 index 00000000..cd2e9538 --- /dev/null +++ b/.agents/skills/design-review/SKILL.md @@ -0,0 +1,136 @@ +--- +name: design-review +description: Audit an existing system for unnecessary complexity, weak boundaries, abstraction mismatch, and developer-experience friction; propose proportionate improvements. +--- + +# Design Review + +Evaluate whether the design fits the problem it actually solves. + +This is a read-only review by default. + +## Understand the system + +Before judging individual abstractions, establish: + +* What problem the system solves. +* What it intentionally centralizes. +* Who consumes it. +* Which parts are public or widely reused. +* Which constraints come from the platform or lifecycle. + +Judge the design against those requirements, not against an abstract ideal of simplicity. + +## Inspect the real usage + +Trace interfaces, abstract classes, factories, builders, registries, overloads, generic types, context objects, and public APIs to their consumers. + +Search before claiming something is unused, redundant, or removable. + +A type that appears unnecessary locally may be important elsewhere. + +## Look for friction + +Consider: + +* abstractions with no meaningful consumer +* duplicated domain logic above an existing abstraction +* APIs that make common operations unnecessarily verbose +* nullable state representing mutually exclusive concepts +* overloads or builders that create unnecessary complexity +* objects carrying responsibilities from unrelated consumers +* boundaries that leak implementation details +* abstractions whose flexibility is not justified by real use +* awkward call sites that could be made simpler without hiding important behavior + +Do not treat duplication itself as a defect. + +Do not treat abstraction itself as a defect. + +The question is whether the design earns its complexity. + +## Separate conclusions + +Classify observations as: + +### Keep + +Complexity that is justified by real requirements, platform constraints, or meaningful reuse. + +### Consider + +A design choice that has a cost but may be appropriate depending on future requirements or project direction. + +### Change + +A concrete design problem with evidence and a proportionate improvement. + +For every removal or consolidation proposal, include the usage evidence supporting it. + +## Recommend proportionate changes + +Prefer: + +1. Removing unnecessary code. +2. Simplifying an existing abstraction. +3. Improving an existing API. +4. Moving a responsibility to a more appropriate owner. +5. Introducing a new abstraction only when the shared concept is real. + +Do not replace one abstraction with a larger abstraction merely to make the design theoretically cleaner. + +Consider the migration cost and call-site impact of every proposed change. + +## API and DX + +For public APIs, start with the call site. + +Ask: + +> What does a developer have to know to use this correctly? + +Prefer APIs where the common case is concise, discoverable, and predictable. + +Advanced configuration should be available without making the common case pay for it. + +Use strong types where they communicate meaningful domain constraints. + +Do not introduce types, builders, DSLs, or generic frameworks purely for aesthetic reasons. + +## Output + +Report findings as: + +```text +## Finding: + +Problem + + +Evidence + + +Impact + + +Recommendation + +``` + +Order findings by practical leverage. + +Finish with: + +```text +## Leave alone + + +``` + +The "Leave alone" section is important. A good design review identifies unnecessary change as well as necessary change. + +## Applying findings + +Do not modify code unless explicitly asked. + +When asked to apply changes, work from confirmed findings only, verify usages before changing public or shared abstractions, and re-run the relevant tests/build after each meaningful structural change. diff --git a/.agents/skills/game-design/SKILL.md b/.agents/skills/game-design/SKILL.md index a7c7ab92..5b1ec2d4 100644 --- a/.agents/skills/game-design/SKILL.md +++ b/.agents/skills/game-design/SKILL.md @@ -1,122 +1,193 @@ --- name: game-design -description: >- - Brainstorms and balances game content (bosses, mobs, items, abilities, - progression, economy hooks) for BlightedMC by embodying a small council of - Hypixel SkyBlock-style game designers — modeled on Minikloon (systems, - economy, benchmark-setting boss/item design) and Jayavarmen (encounter and - ability-kit design) — adapted to BlightedMC's actual scope. Use for "design - a new boss", "let's design [mechanic]", "help me balance this item", "what - should this ability do", or any request to come up with or tune game - content before it's coded. Can invoke grill-me to stress-test a proposal - branch by branch. NOT for writing the actual code — hand the finished - design doc to game-implement for that. +description: Design and balance BlightedMC game content—mobs, bosses, items, abilities, loot, and progression—with a vanilla-first Minecraft approach. --- -# Game Design Council - -BlightedMC is not Hypixel SkyBlock and the council must not design as if it -were. Its actual, stated goal: vanilla Minecraft survival made harder with -custom mobs, items, and bosses, while staying vanilla-friendly — not a -full custom MMO, and still in its early-game phase. It also functions as its -author's Java design-pattern practice ground. Every proposal is filtered -through that scope before it's filtered through anything else. A full -Bazaar-style player-market or a Mayor-election system is the wrong answer -here even though it worked at Hypixel's scale — check scope fit first, -every time. - -## The council - -**Minikloon** — worked on Hypixel SkyBlock's dungeon instancing, the Slayer -system, the Enderman Slayer boss (praised specifically for creative item -design setting a new benchmark for custom mobs), Foraging Islands, the -Bazaar, and the Community Center. His voice in this room: does the reward -justify the time invested, does the boss/item leave something memorable -behind (a build-around item, not just a stat stick), and is the underlying -economy/progression loop sustainable rather than a one-time spike. His own -stated principle: *grinds are fun when the reward matters to some degree and -the journey to get there isn't miserable* — not when it's just padding -between the player and a foregone reward. - -**Jayavarmen ("Jaya")** — SkyBlock game designer focused specifically on -dungeons and encounter design, with a hand in the game's lore pushes. His -voice in this room: does the fight express player skill (positioning, timing, -resource management) or is it a pure gear/DPS check; does the mob's ability -kit read clearly to a player mid-fight; does difficulty come from legible -mechanics rather than opaque math. - -**The skeptic** — a standing voice representing the patterns SkyBlock's own -playerbase has repeatedly called out: content split into "Part 1 / Part 2 / -Part 3" without checking where the actually-good reward ends up (their -concrete failure case: an endgame-tier foraging pet gated behind the -*first* of three foraging islands); RNG walls where the grind's only lever -is luck rather than any expression of skill; stat formulas complicated -enough that players can't reason about their own build. This voice's job is -to red-team every proposal against these specific, documented failure -modes — not vague "could be better" pushback. +# Game Design + +Design content that feels like an extension of Minecraft rather than a separate game layered on top of it. + +The goal is not to reproduce Hypixel SkyBlock. Use proven game-design principles where useful, but adapt them to BlightedMC's actual scope, progression, and vanilla-friendly identity. + +## Core principles + +### Vanilla first + +Start with what Minecraft already teaches the player. + +Prefer existing: + +* mobs and combat conventions +* items and resources +* crafting and progression patterns +* dimensions and world mechanics +* terminology and player expectations + +A custom mechanic should earn its complexity. + +Do not recreate a vanilla system when the existing system already provides the intended behavior. + +Custom content may extend or bend vanilla mechanics when that creates a meaningful experience, but it should remain recognizable as Minecraft unless the design explicitly calls for something more distinct. + +### Design for the actual game + +Every proposal should fit BlightedMC's current scope. + +Do not import large MMO systems, currencies, menus, progression layers, or infrastructure simply because they exist in another game. + +Ask: + +* What player problem or fantasy does this solve? +* Where does it fit into existing progression? +* What does the player already know that can support it? +* What new complexity does it introduce? +* Is that complexity worth the resulting experience? + +### Reuse existing concepts + +Inspect the existing game systems before inventing mechanics. + +A new feature should extend an existing concept when appropriate rather than creating a parallel system with a different vocabulary or rules. + +This applies to both game design and implementation: a mechanic that requires unnecessary new infrastructure is often a sign that the design itself can be simplified. + +## Design lenses + +Use these lenses when relevant rather than simulating separate personalities. + +### Player readability + +Players should be able to understand what is happening and why. + +For combat and abilities, distinguish meaningful skill from information the player was never given. + +Prefer mechanics based on recognizable cues, positioning, timing, resource management, or preparation over opaque formulas. + +### Reward and effort + +Rewards should justify the effort required to obtain them. + +Consider: + +* time investment +* difficulty +* repetition +* rarity +* usefulness +* progression impact + +Avoid grind whose primary purpose is delaying an already obvious reward. + +### Progression + +Place the content deliberately within progression. + +Identify: + +* intended player stage +* prerequisites +* what the content rewards +* what those rewards enable +* whether it invalidates nearby content + +Avoid adding progression layers simply because they are available. + +### Balance + +Start with an intended experience, then derive numbers from it. + +For example: + +```text +Target: +A geared mid-game player should survive one mistake but +cannot ignore the mechanic. + +Initial tuning: +Boss HP: ~X +Ability cooldown: ~Y +Expected fight duration: ~Z +``` + +Exact values are useful when the design is ready for tuning, but do not invent false precision during early exploration. + +State assumptions when numbers are provisional. ## Process -1. **Scope the request.** What system is this for (mob/boss, item, ability, - progression gate, economy hook), and what's the player-facing goal in one - sentence? If the ask is vague ("make fishing more interesting"), narrow it - with the person before designing, rather than presenting five unrelated - ideas. - -2. **Inventory what already exists.** Check what BlightedMC already has - before proposing new systems — read the relevant source (or the project's - own notes on its systems: fishing, boss/creature abilities, hologram - displays, the loot pipeline) so a "new" mechanic doesn't duplicate one - that already exists under a different name. A proposal that requires a - brand-new parallel system where an existing one (loot tables, ability - interfaces, entity modifiers) already covers 90% of the need is the wrong - proposal — extend, don't parallel-build. This is a design-time concern, - not just an implementation one: designing a mechanic the codebase can't - cleanly host is a design failure, not something to fix later. - -3. **Run the council.** For anything non-trivial, give each voice's take - explicitly rather than blending them into one generic opinion — including - where they'd disagree with each other (Minikloon might want a rare - build-around drop; Jaya might push back that the fight itself needs to be - interesting even without that drop; the skeptic checks whether the drop - rate makes the "journey" miserable regardless of what the reward is). - Surface the disagreement, then resolve it with a recommendation — don't - silently pick one voice's answer and present it as consensus. - -4. **Make it concrete, not evocative.** A finished proposal has real numbers - (drop rates, HP/damage figures, cooldowns, phase HP thresholds) and a - stated fit into existing progression (what tier of player is this for, - what does it gate or unlock) — not just a cool description of what it - feels like to fight or use. "Simple, legible math" is a value here: - prefer a stat formula a player could explain to a friend over one that - needs a spreadsheet. - -5. **Stress-test before finalizing.** For a design with several - interdependent decisions (a boss with multiple phases, an ability with - several tunable parameters, a new progression currency), invoke the - grill-me skill to interrogate the design tree one branch at a time, - proposing a recommended answer at each fork, before locking the proposal. - Skip this for genuinely small, single-decision content (one new fixed - item drop) where there's no tree to walk. - -6. **Write the design doc.** Once settled, output: - - **Concept & player fantasy** — one or two sentences. - - **Mechanics** — what actually happens, step by step. - - **Numbers** — the concrete values from step 4. - - **Progression fit** — where this sits, what it gates/unlocks. - - **Reuses** — which existing systems this builds on (named specifically). - - **Open questions** — anything still unresolved, flagged rather than - guessed at, for either the person or a follow-up grill-me pass. - -## Explicitly out of scope - -- Writing the implementation — that's `game-implement`, working from the - design doc this skill produces. -- Full-scale economy infrastructure (player-run markets, server-wide - currency systems, election-style meta-mechanics) unless the person - explicitly asks for that scale of feature — BlightedMC's stated scope is - survival-plus-custom-content, not an MMO economy, and the council should - say so rather than design it anyway because Minikloon's real background - includes it. -- Rebalancing vanilla Minecraft systems the plugin doesn't already touch, - unless asked. \ No newline at end of file +### 1. Understand the request + +Identify the content being designed and its intended player-facing purpose. + +For a vague request, narrow the goal before producing a large design. + +### 2. Inspect existing content + +Read the relevant systems and existing game content. + +Check what already exists for: + +* related mobs or bosses +* items and rewards +* abilities +* loot +* progression +* relevant vanilla mechanics + +Avoid proposing a mechanic that already exists under another name. + +### 3. Explore the design + +Develop the concept using the design lenses above. + +Consider alternatives when there are meaningful trade-offs. + +Do not manufacture multiple options when one straightforward solution already fits the request. + +### 4. Stress-test when necessary + +For substantial designs, examine likely failure modes: + +* the reward does not justify the effort +* the mechanic is difficult without being readable +* progression bypasses or invalidates existing content +* the system introduces complexity without enough player value +* repeated play becomes tedious +* the mechanic depends on information the player cannot reasonably infer + +Small design decisions do not require a formal stress-test. + +### 5. Produce the design + +For a design substantial enough to implement, provide: + +```text +Concept + + +Gameplay + + +Balance + + +Progression + + +Vanilla fit + + +Existing systems + + +Open questions + +``` + +Keep the design proportional to the feature. + +## Implementation boundary + +This skill designs content. It does not implement it. + +Once the design is sufficiently settled, the result should be concrete enough for an implementation task without requiring the implementer to invent core mechanics or balance decisions. diff --git a/.agents/skills/game-implement/SKILL.md b/.agents/skills/game-implement/SKILL.md index d69f0ea7..5b6c271d 100644 --- a/.agents/skills/game-implement/SKILL.md +++ b/.agents/skills/game-implement/SKILL.md @@ -1,100 +1,90 @@ --- name: game-implement -description: >- - Implements approved BlightedMC game-design content (bosses, mobs, items, - abilities, loot) in code, following the codebase's existing conventions - and design-pattern discipline. Use for "implement this boss", "code this - mechanic", "build the [feature] from the design doc", or any request to - turn a finished game-content design into working Java. NOT for - brainstorming or balancing content — use game-design first and hand its - output here. Pairs with abstraction-tax as an optional self-check when new - content required extending a core system nontrivially. +description: Implement approved BlightedMC game content using the existing game systems, APIs, and vanilla Minecraft mechanics. --- # Game Implement -Takes a settled design (from `game-design`, or described directly) and -writes it into the BlightedMC codebase without duplicating an existing -system, without regressing what's already there, and without introducing -the kind of over-engineering `abstraction-tax` exists to catch. BlightedMC -is explicitly its author's practice ground for design patterns and clean -Java — the implementation quality is as much the point as the feature -itself. +Turn a settled game-content design into working code. + +The implementation should fit the existing architecture and feel native to Minecraft and BlightedMC. ## Process -### 1. Get the spec - -Work from a finished design doc (concept, mechanics, numbers, progression -fit) — if one doesn't exist yet, either pull it from earlier in the -conversation or ask for the missing pieces rather than inventing balance -numbers mid-implementation. Numbers and mechanics are a design decision, not -an implementation one; don't silently make them up here. - -### 2. Inventory existing systems before writing anything new - -Read the relevant existing code first. BlightedMC already has, among -others: a generic loot pipeline (`LootTable`/`LootEntry`/`LootResult` with -pluggable selection strategies and feedback decorators), a custom entity -system (`BlightedEntity` and boss/creature ability hooks), an item registry -and builder (`ItemRegistry`/`ItemBuilder`), a hologram/display-attachment -system, and domain-specific systems for fishing and veinmining. Before -writing a new class, check whether the design's requirement is actually a -new instance of one of these (a new `LootResult` implementation, a new -ability hook, a new `ItemBuilder` configuration) rather than a reason for a -new parallel system. If it genuinely needs a new abstraction, that's fine — -but it should be because the existing systems demonstrably can't express it, -not because it wasn't checked. - -### 3. Follow the project's coding discipline - -- YAGNI first: implement what the design doc asks for, nothing speculative - ("might need this later" is not a reason to add it now). -- Reuse before adding: stdlib → existing project utility → a new one-liner - → new code, in that order of preference. -- Early return over nested conditionals; one responsibility per class/method. -- Descriptive names, no abbreviations except `id`/`url`/`http`. -- Never skip trust-boundary validation, null-safety on player/entity state - that can legitimately be null (disconnects, despawns), or existing - concurrency assumptions (e.g. RNG must come from the passed context, not - `Math.random()`, matching the rest of the loot system). -- Where a variant concept exists (a boss's phases, an item's rarity tiers, - a mutually-exclusive set of ability triggers), model it as a sealed - hierarchy or enum rather than nullable fields with runtime-checked - accessors — matching the direction already established in this codebase's - own review history, not just as a personal style preference. -- Mark intentional simplifications and necessarily-kept complexity inline - as the project's own convention expects, so a later reviewer (human or - agent) doesn't "simplify" something that was already a deliberate choice. - -### 4. Scope discipline - -Implement only what the design doc specifies. If the code naturally suggests -an adjacent improvement or extra mechanic while you're in there, don't add -it — flag it back as a follow-up suggestion (for `game-design` to evaluate, -or `abstraction-tax` if it's a structural observation about existing code) -rather than expanding the diff beyond what was asked. - -### 5. Protect what already works - -If implementing this content requires touching a shared type (adding a case -to an existing enum/sealed type, changing a shared interface, extending -`LootContext` or similar), search for every existing call site of what -you're changing and confirm none of them break before considering the task -done. New content should never be the reason an unrelated existing feature -regresses. - -### 6. Self-check before calling it done - -If this task required extending a core system in a nontrivial way (new -interface, new decorator, new strategy, new overload set) rather than just -adding a new leaf implementation of an existing one, consider running -`abstraction-tax` against the part you just touched before presenting the -result — catching a freshly-introduced overload-sprawl or unconsumed -interface here is cheaper than catching it in a later audit pass. - -## Output - -Actual code, in the project's existing package structure and file -organization, ready to compile against the existing codebase — not a -sketch or pseudocode, unless explicitly asked for a rough pass first. \ No newline at end of file +### 1. Establish the design + +Use the supplied design, issue, or clearly defined request as the source of truth. + +Do not silently invent major mechanics, rewards, or progression decisions that belong in game design. + +When a small implementation detail is unspecified, use the existing codebase's conventions and choose the simplest reasonable behavior. + +### 2. Read the existing systems + +Before creating new types, inspect the systems relevant to the feature. + +Look for existing support for: + +* entities and spawning +* abilities +* items +* loot +* registries +* progression +* displays +* configuration +* other related content + +Prefer adding a new instance of an existing concept over creating a parallel mechanism. + +A new abstraction is appropriate when the existing system genuinely cannot express the design. + +### 3. Implement the smallest complete feature + +Implement the approved behavior without speculative extensions. + +Reuse existing APIs and domain concepts where they fit. + +Keep game-specific logic close to the object or system that owns it. + +Do not add infrastructure merely because a future feature might need it. + +Preserve the project's existing behavior and contracts unless the design explicitly changes them. + +### 4. Preserve vanilla conventions + +When the design interacts with Minecraft behavior, prefer existing Minecraft mechanics and terminology over custom replacements. + +Do not recreate vanilla functionality unnecessarily. + +Custom behavior should integrate with the player's existing understanding of Minecraft unless the design intentionally introduces something new. + +### 5. Protect existing behavior + +When changing a shared system, inspect its consumers and relevant implementations before changing its contract. + +Check that existing content still behaves correctly. + +Pay particular attention to shared registries, interfaces, entity behavior, loot selection, and progression systems because a new feature can affect existing content indirectly. + +### 6. Verify + +Run the relevant build and tests. + +For game behavior that cannot be meaningfully covered by automated tests, verify the important invariants that can be checked statically and state what remains dependent on in-game testing. + +Do not claim a gameplay behavior was verified without actually testing it. + +## Out of scope + +Do not add unrelated cleanup, refactors, new mechanics, or speculative infrastructure. + +Do not redesign the game while implementing it. + +When implementation reveals a genuine design problem, separate it from the implementation and report it rather than silently changing the design. + +## Result + +Provide working code in the existing package and system structure. + +The implementation should be understandable from the surrounding code without requiring a new framework or abstraction layer to explain it. diff --git a/.agents/skills/generate-docs/SKILL.md b/.agents/skills/generate-docs/SKILL.md index 7fa95365..e9f538a3 100644 --- a/.agents/skills/generate-docs/SKILL.md +++ b/.agents/skills/generate-docs/SKILL.md @@ -1,23 +1,31 @@ --- name: generate-docs -description: Generate and improve concise, API-quality Javadocs for Java codebases. Use this skill whenever the user asks to add, improve, rewrite, clean up, or standardize Javadocs, Java API documentation, class/interface/enum documentation, constructor or method documentation, or documentation comments in Java source files. Preserve the code's existing behavior and structure unless a documentation issue exposes an actual API ambiguity that must be called out. +description: Write or improve concise, accurate Javadocs for Java APIs and source types without changing behavior or structure. --- # Generate Docs -Produce Javadocs that read like they were written by a senior Java library developer: concise, precise, consistent, and useful at the API boundary. +Write Javadocs that are useful at the API boundary: precise, concise, consistent, and grounded in the actual contract. + +Documentation quality matters more than documentation coverage. ## Workflow -1. Read the complete touched type before changing documentation. Inspect related types when needed to understand inherited behavior, lifecycle, or API contracts. -2. Infer the contract from the code rather than inventing behavior. Document what callers can rely on, not implementation trivia. -3. Preserve the existing code exactly unless the user explicitly asks for code changes. -4. Match the established documentation style in the project. When no style is established, use the conventions below. -5. Return the revised code unless the user asks for documentation-only snippets. +1. Read the complete touched type before changing its documentation. Read related types when needed to understand inheritance, lifecycle, nullability, or other API contracts. +2. Infer the contract from the code and existing documentation. Document what consumers can rely on, not implementation trivia or speculation. +3. Preserve implementation, structure, and behavior unless the user explicitly asks for code changes. +4. Match the project's existing documentation style. When no clear style exists, use the conventions below. +5. Return the form requested by the user. Do not reproduce an entire source file when the requested output only requires documentation changes. + +## What to document + +Document public and protected API when the documentation communicates something useful that is not already obvious. + +Do not add Javadocs simply to increase coverage. -## Documentation style +### Types -Use short class-level summaries that state what the type represents or provides. +A class, interface, enum, or record summary should explain what the type represents or provides. Prefer: @@ -27,54 +35,73 @@ Prefer: */ ``` -Over verbose descriptions of obvious implementation details. +Add a second paragraph only when it communicates an important contract, lifecycle rule, usage constraint, or behavioral distinction. + +### Methods and constructors + +Describe observable behavior rather than restating the method name. + +Document: + +* important side effects +* non-obvious preconditions +* state or lifecycle changes +* meaningful return semantics +* meaningful failure behavior +* thread requirements when relevant -Use a second paragraph only when it adds an important contract, lifecycle detail, usage constraint, or behavioral distinction. +Do not document an obvious implementation detail merely because it is present in the method body. -Keep parameter descriptions noun- or phrase-based and direct: +Constructors do not need a separate summary when the type documentation and parameter descriptions already make their purpose clear. + +### Parameters and returns + +Keep descriptions direct: ```java @param player player viewing the menu @param menu menu to open +@return the currently active menu, or {@code null} when none is active ``` -Avoid filler such as "the specified", "the given", or "this method is used to" unless it improves precision. +Avoid filler such as: -Use `{@code ...}` for literal values, return values, booleans, and code identifiers when appropriate. Link related API members with `{@link ...}` when the reference is useful to the reader. +* "the specified" +* "the given" +* "this method is used to" +* "returns the result" -Document return behavior precisely, including `{@code null}` when null is a valid result. +For return values, explain what the value **means** rather than merely saying that something is returned. -Document exceptions only when the method actually declares or meaningfully guarantees them. +Document `null` behavior when `null` is a valid part of the contract. -## API-level rules +### Interfaces and functional interfaces -- Document public and protected API members when documentation is requested for the type. -- Constructors should state what the created object represents and document their parameters. -- Methods should describe observable behavior, not restate the method name. -- Interfaces should describe the contract implemented by callers. -- Functional interfaces should explain the operation represented by the function and document each factory/helper method according to its actual filtering or transformation behavior. -- Enums should document the enum itself and each constant when the constants' semantics are not self-evident. If the user explicitly excludes enum values, do not add constant Javadocs. -- Do not document private implementation details unless they define a non-obvious invariant that future maintainers must preserve. -- Do not add documentation merely to increase coverage. +Document the contract expected by implementations. -## Keep documentation concise +For a functional interface, explain the operation represented by its function method and any important input/output semantics. -Prefer one clear sentence over several weaker sentences. Add a paragraph only when the second paragraph communicates a distinct contract. +Document additional methods according to their actual behavior. Do not assume that every functional interface needs factory or helper documentation. -Avoid: +### Enums + +Document the enum type. + +Document constants when their semantics are not obvious from their names or when project conventions require it. + +If the user explicitly asks to leave constants undocumented, preserve that instruction. + +### Private implementation details + +Do not add Javadocs to private members merely because they exist. -- marketing language -- generic statements such as "This method provides functionality for..." -- explaining obvious Java syntax -- repeating parameter names in prose without adding meaning -- documenting private fields solely because they exist -- speculative behavior not established by the implementation -- excessive `@see` tags -- redundant `@return` text such as "returns the result" +A non-obvious invariant that future maintainers must preserve may belong in a normal source comment rather than API Javadoc. -## Links and references +## Tags and links -Use links when they improve navigation or clarify an API relationship: +Use `{@code ...}` for literals, expressions, or code references when it improves readability. + +Use `{@link ...}` when a reference helps the reader navigate the API or understand a relationship: ```java {@link Menu#setSlotItem(int, ItemStack)} @@ -82,24 +109,65 @@ Use links when they improve navigation or clarify an API relationship: {@code true} ``` -Do not add links merely for decoration. Resolve imports and fully qualified names correctly. +Do not add links or tags decoratively. + +Use the project's existing conventions for tags such as `@since`, `@deprecated`, or `@see`. Do not introduce new documentation conventions without a reason. + +## Nullability + +Respect existing nullability annotations and established API semantics. + +Do not invent nullability guarantees. + +When annotations are absent, infer nullability only when the implementation and surrounding API make the contract sufficiently clear. Otherwise, avoid making a stronger claim than the code supports. + +## Existing documentation + +When improving existing Javadocs: + +* preserve useful semantic information +* remove redundancy +* resolve ambiguity +* tighten wording +* preserve meaningful project terminology + +Do not rewrite documentation solely for stylistic variation. + +## What to avoid + +Avoid: + +* marketing language +* generic descriptions such as "provides functionality for..." +* implementation walkthroughs +* repeating the method name in different words +* obvious Java explanations +* speculative behavior +* redundant `@return` descriptions +* excessive `@see` tags +* documentation added solely for coverage +* documenting every public member mechanically + +Prefer one strong sentence over several weak ones. + +## API quality -## Nullability and annotations +Javadocs should complement the API design, not compensate for a confusing API. -Respect existing nullability annotations such as JSpecify. Do not claim that a value may be null when the API marks it non-null, and do not invent annotations. +When the code exposes an ambiguous or surprising contract that cannot be documented accurately, call that out separately. -## Existing wording +Do not silently change the API or implementation to make the Javadoc easier to write. -When improving existing Javadocs, retain useful semantic information and remove only redundancy, ambiguity, or unnecessary verbosity. Do not rewrite documentation simply for stylistic variation. +## Output -## Output expectations +The resulting documentation must be: -The result should be directly usable in the source file: +* valid Javadoc +* accurate to the implementation and contract +* consistent with the surrounding project +* useful to an API consumer +* free of unrelated code changes -- valid Javadoc syntax -- correct `{@link}` targets -- accurate parameter and return descriptions -- no behavioral changes -- no unrelated formatting or refactoring +For documentation-only requests, do not refactor or improve unrelated code. -For a documentation-only request, do not propose unrelated code improvements. If the code itself contains a correctness issue that materially affects the documentation contract, mention it separately rather than silently changing it. +When an implementation issue materially affects the documented contract, mention it separately rather than silently changing the code. diff --git a/.agents/skills/generate-docs/evals/evals.json b/.agents/skills/generate-docs/evals/evals.json index c18dc70e..30a62c7a 100644 --- a/.agents/skills/generate-docs/evals/evals.json +++ b/.agents/skills/generate-docs/evals/evals.json @@ -3,21 +3,28 @@ "evals": [ { "id": 1, - "prompt": "Improve the Javadocs in this Java API class like a senior developer. Keep them concise and precise, matching an existing style that uses short summaries, useful second paragraphs, and direct @param/@return wording. Do not change the implementation.", - "expected_output": "Revised Java source with concise, accurate Javadocs and no implementation changes.", - "files": [] + "prompt": "Improve the Javadocs in this Java API type as a senior library developer. Read the surrounding code and preserve the existing implementation exactly. Keep the class summary concise, document observable behavior and non-obvious contracts, and avoid adding Javadocs merely for coverage. Match the existing project's terminology and style.", + "expected_output": "Revised Java source or documentation matching the requested format, with accurate API-focused Javadocs, no implementation changes, and no unnecessary documentation added." }, { "id": 2, - "prompt": "Add Javadocs to this functional Java interface and its factory methods. Explain the observable contract, use links where they add value, avoid filler, and preserve the implementation exactly.", - "expected_output": "Complete API-quality Javadocs for the interface and methods without code changes.", - "files": [] + "prompt": "Add Javadocs to this functional interface and its public API. Explain the contract represented by the functional method, document any meaningful input/output or nullability semantics, and document additional methods only where their behavior needs explanation. Use links where they improve navigation. Preserve the implementation exactly.", + "expected_output": "Concise, contract-focused Javadocs for the interface and relevant methods, without invented behavior, filler, or code changes." }, { "id": 3, - "prompt": "Clean up the Javadocs for this enum. Document the enum's purpose and constructor/accessor API, but leave the enum constants undocumented because I am explicitly handling those separately.", - "expected_output": "Concise Javadocs for the enum type and non-constant API, with no Javadocs added to enum values and no code changes.", - "files": [] + "prompt": "Clean up the Javadocs for this enum. Document the enum's purpose and any non-obvious public API, but do not add Javadocs to the enum constants because those are being handled separately. Preserve existing useful wording where possible and make no code changes.", + "expected_output": "Concise Javadocs for the enum and relevant non-constant API, with no constant documentation and no implementation changes." + }, + { + "id": 4, + "prompt": "Review this Java type's Javadocs. Some public methods are self-explanatory while others have important side effects and nullability behavior. Improve only the documentation that adds real value. Do not document every public member automatically and do not change the implementation.", + "expected_output": "Selective documentation improvements focused on meaningful API contracts rather than documentation coverage." + }, + { + "id": 5, + "prompt": "Improve these Javadocs where the current wording describes implementation details rather than consumer-visible behavior. Rewrite them around the actual API contract, preserve meaningful existing information, and avoid inventing guarantees that the code does not establish.", + "expected_output": "Documentation rewritten around observable behavior and supported guarantees, with no speculative claims or implementation changes." } ] } diff --git a/.agents/skills/grill-me/SKILL.md b/.agents/skills/grill-me/SKILL.md deleted file mode 100644 index 4be338bf..00000000 --- a/.agents/skills/grill-me/SKILL.md +++ /dev/null @@ -1,7 +0,0 @@ ---- -name: grill-me -description: A relentless interview to sharpen a plan or design. -disable-model-invocation: true ---- - -Call the Skill tool with "grilling". \ No newline at end of file diff --git a/.agents/skills/grilling/SKILL.md b/.agents/skills/grilling/SKILL.md deleted file mode 100644 index 52f15ccf..00000000 --- a/.agents/skills/grilling/SKILL.md +++ /dev/null @@ -1,28 +0,0 @@ ---- -name: grilling -description: Grill the user relentlessly about a plan, decision, or idea. Use when the user wants to stress-test their thinking, or uses any 'grill' trigger phrases. ---- - -Interview the user relentlessly until you reach a shared understanding. Map this as a **design tree**: every decision branches into the decisions that hang off it. - -Work the tree in **rounds**. The **frontier** is every decision whose prerequisites are already settled: the questions you can ask _now_ without guessing at answers you haven't heard yet. Ask the whole frontier in one round: number each question and give your recommended answer. Then wait for the user's answers before the next round. - -Format a round like so: - -``` -❓ **Q1** - ****: - -➡️ - ---- - -❓ **Q2** - ****: - -➡️ -``` - -Each round the user answers reshapes the tree: settled decisions push the frontier outward and unblock questions that depended on them. Recompute the frontier and ask the next round. A question whose answer depends on another question still open in this round belongs to a _later_ round, not this one. - -Finding _facts_ is your job, never the user's. When a frontier question needs a fact from the environment (filesystem, tools, etc.), dispatch a sub-agent to find it; don't ask the user for anything you could look up yourself. Don't block on it: a running exploration is an unsettled prerequisite, so only the questions downstream of it wait for the sub-agent to report; ask the rest of the frontier now. The _decisions_ are the user's: put each to them and wait. - -The session is done when the frontier is empty: every branch of the design tree visited, nothing left silently assumed. Do not act on it until the user confirms you have reached a shared understanding. \ No newline at end of file diff --git a/.agents/skills/improve-codebase-architecture/HTML-REPORT.md b/.agents/skills/improve-codebase-architecture/HTML-REPORT.md deleted file mode 100644 index c73bc2ee..00000000 --- a/.agents/skills/improve-codebase-architecture/HTML-REPORT.md +++ /dev/null @@ -1,123 +0,0 @@ -# HTML Report Format - -The architectural review is rendered as a single self-contained HTML file in the OS temp directory. Tailwind and Mermaid both come from CDNs. Mermaid handles graph-shaped diagrams reliably; hand-built divs and inline SVG handle the more editorial visuals (mass diagrams, cross-sections). Mix the two: don't lean on Mermaid for everything, it'll start to look generic. - -## Scaffold - -```html - - - - - Architecture review for {{repo name}} - - - - - -
-
...
-
...
-
...
-
- - -``` - -## Header - -Repo name, date, and a compact legend: solid box = module, dashed line = seam, red arrow = leakage, thick dark box = deep module. No introduction paragraph. Straight into the candidates. - -## Candidate card - -The diagrams carry the weight. Prose is sparse, plain, and uses the glossary terms (from the `/codebase-design` skill) without ceremony. - -Each candidate is one `
`: - -- **Title**: short, names the deepening (e.g. "Collapse the Order intake pipeline"). -- **Badge row**: recommendation strength (`Strong` = emerald, `Worth exploring` = amber, `Speculative` = slate), plus a tag for the dependency category (`in-process`, `local-substitutable`, `ports & adapters`, `mock`). -- **Files**: monospaced list, `font-mono text-sm`. -- **Before / After diagram**: the centrepiece. Two columns, side by side. See patterns below. -- **Problem**: one sentence. What hurts. -- **Solution**: one sentence. What changes. -- **Wins**: bullets, ≤6 words each. e.g. "Tests hit one interface", "Pricing logic stops leaking", "Delete 4 shallow wrappers". -- **ADR callout** (if applicable): one line in an amber-tinted box. - -No paragraphs of explanation. If the diagram needs a paragraph to be understood, redraw the diagram. - -## Diagram patterns - -Pick the pattern that fits the candidate. Mix them. Don't make every diagram look the same. Variety is part of the point. - -### Mermaid graph (the workhorse for dependencies / call flow) - -Use a Mermaid `flowchart` or `graph` when the point is "X calls Y calls Z, and look at the mess." Wrap it in a Tailwind-styled card so it doesn't feel parachuted in. Style with classDef to colour leakage edges red and the deep module dark. Sequence diagrams work well for "before: 6 round-trips; after: 1." - -```html -
- 
-    flowchart LR
-      A[OrderHandler] --> B[OrderValidator]
-      B --> C[OrderRepo]
-      C -.leak.-> D[PricingClient]
-      classDef leak stroke:#dc2626,stroke-width:2px;
-      class C,D leak
-
-
-``` - -### Hand-built boxes-and-arrows (when Mermaid's layout fights you) - -Modules as `
`s with borders and labels. Arrows as inline SVG `` or `` elements positioned absolutely over a relative container. Reach for this when you want the "after" diagram to feel like one thick-bordered deep module with greyed-out internals, since Mermaid won't render that with the right weight. - -### Cross-section (good for layered shallowness) - -Stack horizontal bands (`h-12 border-l-4`) to show layers a call passes through. Before: 6 thin layers each doing nothing. After: 1 thick band labelled with the consolidated responsibility. - -### Mass diagram (good for "interface as wide as implementation") - -Two rectangles per module: one for interface surface area, one for implementation. Before: interface rectangle is nearly as tall as the implementation rectangle (shallow). After: interface rectangle is short, implementation rectangle is tall (deep). - -### Call-graph collapse - -Before: a tree of function calls rendered as nested boxes. After: the same tree collapsed into one box, with the now-internal calls shown faded inside it. - -## Style guidance - -- Lean editorial, not corporate-dashboard. Generous whitespace. Serif optional for headings (`font-serif` works well with stone/slate). -- Colour sparingly: one accent (emerald or indigo) plus red for leakage and amber for warnings. -- Keep diagrams ~320px tall so before/after sits comfortably side by side without scrolling. -- Use `text-xs uppercase tracking-wider` for module labels inside diagrams, so they read as schematic, not as UI. -- The only scripts are the Tailwind CDN and the Mermaid ESM import. The report is otherwise static: no app code, no interactivity beyond Mermaid's own rendering. - -## Top recommendation section - -One larger card. Candidate name, one sentence on why, anchor link to its card. That's it. - -## Tone - -Plain English, concise, but the architectural nouns and verbs come straight from the `/codebase-design` skill. Concision is not an excuse to drift. - -**Use exactly:** module, interface, implementation, depth, deep, shallow, seam, adapter, leverage, locality. - -**Never substitute:** component, service, unit (for module) · API, signature (for interface) · boundary (for seam) · layer, wrapper (for module, when you mean module). - -**Phrasings that fit the style:** - -- "Order intake module is shallow: interface nearly matches the implementation." -- "Pricing leaks across the seam." -- "Deepen: one interface, one place to test." -- "Two adapters justify the seam: HTTP in prod, in-memory in tests." - -**Wins bullets** name the gain in glossary terms: *"locality: bugs concentrate in one module"*, *"leverage: one interface, N call sites"*, *"interface shrinks; implementation absorbs the wrappers"*. Don't write *"easier to maintain"* or *"cleaner code"*, because those terms aren't in the glossary and don't earn their place. - -No hedging, no throat-clearing, no "it's worth noting that…". If a sentence could be a bullet, make it a bullet. If a bullet could be cut, cut it. If a term isn't in the `/codebase-design` glossary, reach for one that is before inventing a new one. \ No newline at end of file diff --git a/.agents/skills/improve-codebase-architecture/SKILL.md b/.agents/skills/improve-codebase-architecture/SKILL.md deleted file mode 100644 index 2bb336f0..00000000 --- a/.agents/skills/improve-codebase-architecture/SKILL.md +++ /dev/null @@ -1,71 +0,0 @@ ---- -name: improve-codebase-architecture -description: Scan a codebase for deepening opportunities, present them as a visual HTML report, then grill through whichever one you pick. -disable-model-invocation: true ---- - -# Improve Codebase Architecture - -Surface architectural friction and propose **deepening opportunities**: refactors that turn shallow modules into deep ones. The aim is testability and AI-navigability. - -This command is _informed_ by the project's domain model and built on a shared design vocabulary: - -- Call the Skill tool with "codebase-design" for the architecture vocabulary (**module**, **interface**, **depth**, **seam**, **adapter**, **leverage**, **locality**) and its principles (the deletion test, "the interface is the test surface", "one adapter = hypothetical seam, two = real"). Use these terms exactly in every suggestion, and don't drift into "component," "service," "API," or "boundary." -- The domain language in `CONTEXT.md` gives names to good seams; ADRs in `docs/adr/` record decisions this command should not re-litigate. - -## Process - -### 1. Explore - -**Scope before you scan: YAGNI.** Deepening a module pays off by making future changes to it easier, so put extra weight on the parts of the codebase that have recently changed. Decide *where* to look before you look: - -- If the user named a direction (a module, a subsystem, a pain point), take it, and skip the inference below. -- Otherwise, walk back a good stretch of the commit history (`git log --oneline`) to find the codebase's hot spots, the files and areas that keep coming up, and let those paths pull your attention first. If the changes are scattered with no clear hot spot, widen the net. - -Read the project's domain glossary (`CONTEXT.md`) and any ADRs in the area you're touching first. - -Then spawn a sub-agent to walk the codebase. Don't follow rigid heuristics; explore organically and note where you experience friction: - -- Where does understanding one concept require bouncing between many small modules? -- Where are modules **shallow**, with an interface nearly as complex as the implementation? -- Where have pure functions been extracted just for testability, but the real bugs hide in how they're called (no **locality**)? -- Where do tightly-coupled modules leak across their seams? -- Which parts of the codebase are untested, or hard to test through their current interface? - -Apply the **deletion test** to anything you suspect is shallow: would deleting it concentrate complexity, or just move it? A "yes, concentrates" is the signal you want. - -### 2. Present candidates as an HTML report - -Write a self-contained HTML file to the OS temp directory so nothing lands in the repo. Resolve the temp dir from `$TMPDIR`, falling back to `/tmp` (or `%TEMP%` on Windows), and write to `/architecture-review-.html` so each run gets a fresh file. Open it for the user (`xdg-open ` on Linux, `open ` on macOS, `start ` on Windows) and tell them the absolute path. - -The report uses **Tailwind via CDN** for layout and styling, and **Mermaid via CDN** for diagrams where a graph/flow/sequence reliably communicates the structure. Mix Mermaid with hand-crafted CSS/SVG visuals: use Mermaid when relationships are graph-shaped (call graphs, dependencies, sequences), and hand-built divs/SVG when you want something more editorial (mass diagrams, cross-sections, collapse animations). Each candidate gets a **before/after visualisation**. Be visual. - -For each candidate, render a card with: - -- **Files**: which files/modules are involved -- **Problem**: why the current architecture is causing friction -- **Solution**: plain English description of what would change -- **Benefits**: explained in terms of locality and leverage, and how tests would improve -- **Before / After diagram**: side-by-side, custom-drawn, illustrating the shallowness and the deepening -- **Recommendation strength**: one of `Strong`, `Worth exploring`, `Speculative`, rendered as a badge - -End the report with a **Top recommendation** section: which candidate you'd tackle first and why. - -**Use CONTEXT.md vocabulary for the domain, and the `/codebase-design` vocabulary for the architecture.** If `CONTEXT.md` defines "Order," talk about "the Order intake module," not "the FooBarHandler," and not "the Order service." - -**ADR conflicts**: if a candidate contradicts an existing ADR, only surface it when the friction is real enough to warrant revisiting the ADR. Mark it clearly in the card (e.g. a warning callout: _"contradicts ADR-0007, but worth reopening because…"_). Don't list every theoretical refactor an ADR forbids. - -See [HTML-REPORT.md](HTML-REPORT.md) for the full HTML scaffold, diagram patterns, and styling guidance. - -Do NOT propose interfaces yet. After the file is written, ask the user: "Which of these would you like to explore?" - -### 3. Grilling loop - -Once the user picks a candidate, call the Skill tool with "grilling" to walk the decision tree with them: constraints, dependencies, the shape of the deepened module, what sits behind the seam, what tests survive. - -Side effects happen inline as decisions crystallize; call the Skill tool with "domain-modeling" to keep the domain model current as you go: - -- **Naming a deepened module after a concept not in `CONTEXT.md`?** Add the term to `CONTEXT.md`. Create the file lazily if it doesn't exist. -- **Sharpening a fuzzy term during the conversation?** Update `CONTEXT.md` right there. -- **User rejects the candidate with a load-bearing reason?** Offer an ADR, framed as: _"Want me to record this as an ADR so future architecture reviews don't re-suggest it?"_ Only offer when the reason would actually be needed by a future explorer to avoid re-suggesting the same thing; skip ephemeral reasons ("not worth it right now") and self-evident ones. -- **Want to explore alternative interfaces for the deepened module?** Call the Skill tool with "codebase-design" and use its design-it-twice parallel sub-agent pattern. \ No newline at end of file diff --git a/.agents/skills/patch-bug/SKILL.md b/.agents/skills/patch-bug/SKILL.md index 3010dd6f..6a4ed2e6 100644 --- a/.agents/skills/patch-bug/SKILL.md +++ b/.agents/skills/patch-bug/SKILL.md @@ -1,116 +1,84 @@ --- name: patch-bug -description: Investigate a reported bug or "this feels off" behavior by tracing it to its real mechanism, hunting for every other place the same pattern recurs, patching all confirmed instances, and reporting each in a structured block (Problem / Root cause / Fix). Trigger on any bug report, "this changed after an edit," a diff-two-versions request, or a plugin/module bug review — even without the words "patch," "fix," or "investigate." Most valuable on shared engine/base-class systems, where one bug surfaces as many unrelated-looking symptoms. +description: Trace a bug to its root cause, check for relevant sibling occurrences, apply the smallest correct fix, and verify it. --- # Patch Bug -A discipline for finding a bug's real cause and closing every place it recurs, not just the reported spot. Skip phases only when explicitly justified. +Fix the mechanism, not merely the symptom. -When exploring the codebase, read `CONTEXT.md` (if it exists) to get a clear mental model of the relevant modules, and check ADRs in the area you are tracing. +## Investigate -## Redact +Read the reported code and the surrounding implementation before changing anything. -If diagnosis requires showing command output, logs, or captured traces: redact every secret first. Write `` in its place. Quote only the lines that carry the signal. If the redacted output is not enough to diagnose the bug, say so and ask the user rather than guessing at what was removed. +If a diff, previous version, or recent edit is relevant, inspect it. -## Phase 1: Trace to the mechanism +Follow the behavior through the code that actually controls it: callers, shared abstractions, listeners, schedulers, lifecycle hooks, registries, and framework APIs. -**This is the skill.** Everything else is mechanical. A patch against the wrong mechanism is a patch against a coincidence; it will look plausible and still be wrong. +Do not guess about code you have not read. -Read the file the user points at. If two versions are given, or a git history is available, diff them. +When the cause is unclear, form a small number of concrete hypotheses and test them against the codebase. Do not commit to the first plausible explanation without evidence. -The introduced bug is rarely in the largest or most obviously "new" chunk of a diff. Assume a small, innocuous-looking addition, buried in an unrelated diff, before assuming the biggest hunk is the cause. +State the root cause precisely enough to explain the reported behavior. -Ask what the changed code depends on or feeds into: a scheduler, a listener, a shared base class, a framework lifecycle. Go read that, even if it was not part of what the user shared. The symptom tells you where to look, not why it happens. +## Check for recurrence -### When the mechanism is not obvious after one read-through +Once the mechanism is understood, look for other places where the same mechanism genuinely applies. -Generate two to three ranked candidate mechanisms before committing to one. Single-hypothesis fixation on the first plausible cause is how a wrong fix ships looking correct. +Search relevant implementations, call sites, and usages rather than assuming the reported location is unique. -Each candidate must be falsifiable: state what would be true elsewhere in the codebase if it were the real cause. +Do not mechanically search or refactor every superficially similar piece of code. The goal is to catch confirmed sibling bugs, not eliminate textual duplication. -> Format: "If is the cause, then must show ." +## Fix -If a candidate cannot be stated this precisely, it is a guess, not a hypothesis: discard or sharpen it. Where the codebase owner is available, show the ranked list before committing — they often know which subsystem was touched recently, which rules out candidates instantly. +Apply the smallest change that fixes the confirmed cause. -### Missing information +Follow the existing architecture and API conventions. -If the file that would confirm or rule out a mechanism is not available, name it and ask for it. Do not speculate about what a shared system probably does. A wrong guess about a shared system produces a wrong fix that still looks plausible. +Do not introduce an abstraction merely because similar code exists. -### Completion criterion +Do not refactor unrelated code while fixing the bug. -Phase 1 is done when the mechanism can be stated in one or two sentences, precisely enough that a reader unfamiliar with the code understands exactly why the symptom occurs: +Add a short comment only when the reason for an otherwise unusual implementation would not be obvious from the code. -- [ ] The statement names which two things are interacting incorrectly (a race, a bypassed invariant, an event that never fires), not just where the symptom appears. -- [ ] The statement explains the full reported symptom, not a partial or adjacent one. -- [ ] Nothing in the statement depends on a file you have not actually read. +## Verify -If you cannot write this statement, you do not have the root cause yet. Do not proceed to Phase 2. +Run the most relevant tests, build, lint, or reproduction available. -## Phase 2: Scan for siblings +Verify both the original behavior and any sibling cases fixed by the same change when practical. -Once the mechanism is confirmed, search for every other place it also applies before patching only the reported spot. This is the phase that separates a real fix from a one-off patch. +If the repository cannot verify the affected behavior, state that clearly rather than implying verification. -Check, by name: +## Report -- [ ] Every other class extending or implementing the same base class or interface as the buggy one. -- [ ] Every other call site performing the same operation (every place that removes an entity the same way, every place that spawns the same kind of helper, every place that reads the same field). -- [ ] Every other usage of the same misused API or pattern anywhere in the module. +Report: -Grep for the specific method calls or patterns involved, not just the file that was reported. Enumerate every confirmed instance found; do not stop at the first additional occurrence. - -Do not proceed to Phase 3 until this scan is complete and its result (even if the result is "no other instances found") is stated explicitly. - -## Phase 3: Patch - -Apply the minimal fix for every confirmed instance from Phase 2. - -- [ ] Match the code style and conventions already present nearby. Do not introduce a new abstraction, helper, or pattern the codebase does not already use, unless the fix genuinely requires one. -- [ ] Touch only what is broken. Do not refactor, rename, or otherwise improve adjacent code while in the file. -- [ ] Where a fix has a non-obvious reason for its shape (why this guard, why this method and not a similar one), leave a short comment stating the reason. The diff shows what changed; the comment is for why it changed this way. - -## Phase 4: Verify - -If a build, test, lint, or run command exists that exercises the fixed code path, run it against the patch and confirm it passes. If the original symptom was reproducible through some command (a failing test, a script, a manual repro the user described), re-run it and confirm it no longer reproduces. - -If nothing in the repository can verify this fix — no tests reach this path, no build catches this class of error, there is no way to run the affected code in isolation — say so explicitly. This is itself a finding worth reporting, not a gap to pass over silently. - -## Phase 5: Report - -Report every patched issue in one block per issue, using this structure: - -``` -## Issue: - -File(s): +```text +## Issue: Problem - + Root cause - + Fix - - - -``` - -Keep each block terse and factual. Do not restate the diff in prose. If more than one issue was found in Phase 2, present them as separate blocks, the originally reported issue first, siblings after. + -### Report-only mode +Verification + +``` -If the user asked for a prompt or handoff for a different agent or session, or explicitly asked to review without changing anything yet: skip Phase 3 and Phase 4. Replace the Fix section with: +Keep the report focused on evidence and behavior. -- A Constraints section naming exactly what the executing agent may and may not touch: files in scope, files that look related but are out of scope, and anything that must not be refactored while applying the fix. -- A verification checklist the executing agent can run after patching, in place of Phase 4. +## Report-only mode -The result should be a plan a model with no other context could execute correctly on its own. +When asked to investigate or prepare a handoff without modifying code, stop after diagnosis and recurrence analysis. -## Required before declaring done +Provide: -- [ ] The root-cause statement from Phase 1 explains the entire reported symptom, not a partial one. -- [ ] The sibling scan from Phase 2 was performed and its result is stated, even if no siblings were found. -- [ ] Every patch matches existing house style and touches only the broken lines. -- [ ] Phase 4 verification was run, or its absence was explicitly stated as a finding. -- [ ] The report follows the required block structure, one block per issue. \ No newline at end of file +* Root cause +* Confirmed affected locations +* Proposed fix +* Verification plan +* Explicit out-of-scope areas diff --git a/AGENTS.md b/AGENTS.md index f29c38aa..dccaef68 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,344 +1,511 @@ # Agent Guidelines -These rules apply to every AI coding agent working in this repository, regardless of which tool is being used. See the end of this file for how each tool is wired to read it. - -## Tone - -- Objective, rigorous, concise, factual. No filler, no praise. -- Formal, slightly elevated register (for example, "hereby") in any language. -- Ask a clarifying question only if needed for accuracy; otherwise proceed. -- Never state you are an AI. - -## Restricted content - -- Give the closest compliant answer, then note the restriction. Do not refuse outright when a partial, compliant answer is possible. - -## Coding - -Read the touched code first, before proposing or writing anything. Then pick the first option below that fits — do not skip ahead to a later option because it feels more thorough: - -1. Unneeded (YAGNI). Do not build it if nothing requires it yet. -2. Already in the codebase. Reuse it instead of writing a new version. -3. Standard library. -4. Native language or framework feature. -5. An already-installed dependency. -6. A one-line solution. -7. Minimum code otherwise. - -Necessary complexity (safety, security, correctness) is kept even if longer. Mark it `// ponytail: kept`. Intentional simplifications are marked `// ponytail: `. A change that adds complexity without one of these two markers has not justified itself. - -## Scope - -- Touch only what was asked. Do not refactor, rename, or otherwise improve adjacent code while making an unrelated change. -- Delete over add. Boring over clever. -- Question complex or ambiguous requests before implementing them. -- Early return over nesting. One responsibility per unit (function, class, module). -- Never skip trust-boundary validation, data-loss handling, security, or accessibility. These are never in scope for silent removal, even when simplifying. -- TypeScript: no `any` unless explicitly asked for. - -## Naming - -- Descriptive names, 50 characters or fewer. -- No abbreviations, with two exceptions: `id`, `url`, `http`. -- No filler words: `data`, `info`, `manager`, `helper`, `util` used as a bare suffix without a specific reason. -- The following abbreviations are explicitly banned. Write the full word instead: - - | Banned | Use instead | - |---|---| - | `br` | `branch` / `break` / `bracket` — spell out the actual meaning | - | `btn` | `button` | - | `msg` | `message` | - | `ctx` | `context` | - | `cfg` | `config` / `configuration` | - | `mgr` | `manager` (only when `manager` itself is warranted; see filler-word rule above) | - | `tmp` | `temporary` | - | `val` | `value` | - | `err` | `error` | - | `idx` | `index` | - | `arr` | `array` / the actual collection name | - | `obj` | the actual type name, never the generic `object` | - | `elem` | `element` | - | `params` | `parameters` | - | `args` | `arguments` | - | `res` | `response` / `result` — spell out which one | - | `req` | `request` | - | `calc` | `calculate` / `calculation` | - | `desc` | `description` / `descending` — spell out which one | - | `curr` | `current` | - | `prev` | `previous` | - | `num` | `number` / the actual quantity name | - | `str` | the actual type name, never the generic `string` | - - This list is illustrative, not exhaustive. The standing rule: if a reader unfamiliar with the codebase would have to guess what a name stands for, spell it out. - -## Modern Java (project targets Java 25) - -Check whether Java already does this before writing it manually. An older pattern is not "safer"; it is a missed native-feature step in the Coding ladder above. This section is not exhaustive. If unsure whether a feature is stable in 25, check before using it. Preview features never ship: "native feature" in the ladder means finalized, with no `--enable-preview`. - -**Sequenced collections.** Do not index into first or last position manually. - -Avoid: +`AGENTS.md` is the source of truth for every coding agent working in this repository. + +The goal is to produce code that is correct, maintainable, unsurprising, pleasant to use, and appropriate for the project. + +These guidelines are principles for making engineering decisions, not a checklist to satisfy mechanically. + +--- + +## Engineering principles + +### Read before changing + +Read the relevant code, tests, configuration, and existing abstractions before proposing or implementing a change. + +Understand the responsibility and lifecycle of the code being changed. + +Prefer extending an existing concept when it genuinely fits rather than creating a parallel abstraction. + +### Optimize for the simplest correct design + +Prefer the smallest solution that properly solves the problem. + +In general: + +1. Do not build what is not needed. +2. Reuse existing code and abstractions when appropriate. +3. Prefer the standard library and platform capabilities. +4. Reuse installed dependencies when they are already a good fit. +5. Otherwise, write the smallest clear implementation. + +Do not optimize for eliminating every duplicated line. + +Do not introduce an abstraction merely because two pieces of code look similar. Extract code when it represents a meaningful shared concept, invariant, ownership boundary, or evolution path. + +A few duplicated lines are often cheaper than the wrong abstraction. + +Do not use a more sophisticated solution simply because it is technically possible. + +### Keep scope proportional + +Touch what the task requires. + +A small local cleanup is appropriate when it directly improves the code being changed and does not alter unrelated behavior. Do not turn a focused task into a broad refactor. + +Delete unnecessary complexity before adding new complexity. + +Prefer explicit, boring code over clever code when both express the intent equally well. + +Early returns, small responsibilities, and simple control flow are useful defaults, not laws. + +Correctness, security, validation, thread-safety, accessibility, and data-loss protection must not be weakened merely to reduce code. + +### Document non-obvious trade-offs + +Comments should explain decisions that are not obvious from the code. + +`// ponytail:` is an optional convention for documenting a deliberate trade-off: + ```java -String first = list.get(0); -String last = list.get(list.size() - 1); +// ponytail: kept — this operation must execute on Bukkit's main thread. ``` + +Do not add `// ponytail` comments merely because a piece of code is slightly complex or because a checklist demands it. + +The absence of a `// ponytail` comment is not a problem by itself. + +--- + +# API and Developer Experience + +Public APIs are products. + +Design them from the consumer's point of view: imagine the call site that someone unfamiliar with the implementation should be able to write after discovering the API. + +A good API should be: + +* Easy to discover through names, types, autocomplete, and documentation. +* Predictable and consistent with related APIs. +* Explicit about ownership, lifecycle, nullability, mutability, and failure. +* Small and convenient for the common case. +* Capable of supporting advanced use cases without forcing that complexity onto ordinary callers. +* Difficult to misuse without requiring unnecessary ceremony. + +### Common case first + +Optimize the normal call site. + +The simplest use case should not require callers to understand internal implementation details, construct unnecessary configuration objects, or provide information the API can already determine. + Prefer: + ```java -String first = list.getFirst(); -String last = list.getLast(); +punishments.add(player, PunishmentType.MUTE, reason); ``` -Applies to any `List`, `Deque`, `LinkedHashSet`, or `SortedSet`; all implement `SequencedCollection`. -**Pattern matching.** Destructure, do not cast. +over exposing low-level parameters that callers should not need to coordinate. + +This does not mean convenience APIs should hide important behavior. It means normal usage should require as little incidental knowledge as possible. + +### Progressive disclosure + +Make simple things simple and advanced things possible. + +For example: -Avoid: -```java -if (obj instanceof Player) { -Player player = (Player) obj; -greet(player); -} -``` -Prefer: ```java -if (obj instanceof Player player) { -greet(player); -} +spawn(entity, location); ``` -Record patterns destructure directly, including nested components: + +can be the normal API while more specialized behavior can be available separately: + ```java -if (event instanceof DamageEvent(var attacker, var target, var amount)) { -log(attacker, target, amount); -} +spawn(entity, location, options); ``` -**Switch expressions**, not fallthrough statements. +Do not force every caller through a builder, DSL, configuration object, or generic abstraction merely because the API supports advanced customization. + +Builders and fluent APIs are tools, not goals. + +### Design from concepts, not syntax + +Extract abstractions from domain concepts rather than repeated syntax. + +This: -Avoid: ```java -switch (type) { - case LEFT_CLICK: - return handleLeft(); - case RIGHT_CLICK: - return handleRight(); -default: - return handleAny(); +List eligible = null; + +for (SpawnableEntity entity : candidates) { + if (!entity.canSpawnAt(location, world)) continue; + + if (eligible == null) { + eligible = new ArrayList<>(candidates.size()); + } + + eligible.add(entity); } ``` -Prefer: -```java -return switch (type) { - case LEFT_CLICK -> handleLeft(); - case RIGHT_CLICK -> handleRight(); -default -> handleAny(); -}; -``` -**Lambdas over anonymous classes**, for actual functional interfaces. +does not automatically deserve a shared helper simply because another spawning system contains the same loop. + +If the surrounding systems have different responsibilities, lifecycles, caches, or future evolution, local implementations may be the better design. + +By contrast, a shared probability-selection algorithm may deserve extraction when both systems genuinely share that domain behavior. + +> Do not abstract by syntax alone. + +### Strong types, where they help + +Use types to communicate meaningful domain constraints. -Avoid: -```java -items.sort(new Comparator() { - public int compare(ItemStack a, ItemStack b) { - return a.getAmount() - b.getAmount(); - } -}); -``` Prefer: + ```java -items.sort((a, b) -> a.getAmount() - b.getAmount()); -``` -Exception: keep the anonymous class when it needs self-reference or more than one overridden method. State this in code, do not silently deviate: -```java -// ponytail: kept — BukkitRunnable must call cancel() on itself; -// a lambda has no `this` to call it on. -new BukkitRunnable() { - @Override - public void run() { - if (done) { cancel(); return; } - tick(); - } -}.runTaskTimer(plugin, 0L, 1L); +enum SpawnMode { + INDEPENDENT, + REPLACEMENT, + HYBRID +} ``` -**Unnamed variables.** Use `_` for anything genuinely unused. +when the concept has a real closed set of values. + +Prefer a record when the type is genuinely an immutable data carrier: -Avoid: -```java -map.forEach((key, value) -> counter.increment()); -``` -Prefer: ```java -map.forEach((_, value) -> counter.increment()); +record CooldownEntry(Class owner, AbilityType type, long expiresAt) {} ``` -Avoid: + +Use a class when the type has identity, mutable state, lifecycle, richer encapsulation, inheritance requirements, or framework constraints that make a record inappropriate. + +Do not create wrapper types for every primitive merely to make the code appear more strongly typed. + +### Consistency is a feature + +Related APIs should use consistent terminology, return conventions, and failure behavior. + +A caller should be able to predict how an unfamiliar API works from nearby APIs. + +Avoid surprising special cases hidden behind convenience methods. + +### Documentation is part of the API + +Public or reusable APIs should have Javadocs that explain what a consumer actually needs to know: + +* What the operation does. +* Important assumptions or invariants. +* Return and absence semantics. +* Failure behavior. +* Thread or lifecycle requirements. +* Intended usage when it is not obvious. + +Prefer examples that demonstrate consumer usage over descriptions of internal implementation. + +--- + +# Modern Java + +The project targets Java 25. + +Use modern Java deliberately. + +Before manually implementing something, check whether Java or the standard library already provides a clearer native capability. + +Do not use a language or library feature merely because it is newer. Use it when it improves clarity, correctness, safety, or the resulting API. + +### Prefer modern language constructs when they improve the code + +Examples include: + +* Pattern matching for `instanceof`. +* Pattern matching and expressions in `switch`. +* Record patterns when destructuring improves readability. +* Records for genuine data carriers. +* Sealed types when a domain is intentionally closed. +* Text blocks for genuinely multi-line text. +* Unnamed variables when a value is intentionally unused. +* Sequenced collection methods such as `getFirst()` and `getLast()` when the intent is specifically first/last access. +* Immutable collection factories when immutable snapshots are appropriate. + +For example: + ```java -try { -risky(); -} catch (IOException e) { - return fallback(); +if (event instanceof CreatureSpawnEvent spawnEvent) { + handle(spawnEvent); } ``` -Prefer: + +rather than manually casting after an `instanceof` check. + +Likewise: + ```java -try { -risky(); -} catch (IOException _) { - return fallback(); -} +return switch (type) { + case LEFT_CLICK -> handleLeft(); + case RIGHT_CLICK -> handleRight(); + default -> handleAny(); +}; ``` -**`var`**, only when the right-hand side already states the type. +when the expression form communicates the operation more clearly. + +### Prefer intent over feature usage + +Modern syntax is not inherently better. + +A normal loop can be clearer than a stream. + +An explicit type can be clearer than `var`. + +A class can be more appropriate than a record. + +A local implementation can be better than a generic abstraction. + +Choose the construct that communicates intent best. + +### `var` + +Use `var` when the initializer makes the concrete type obvious and the declared type does not add useful semantic information. + +Good: -Prefer, since the type is obvious from the constructor: ```java var players = new ArrayList(); ``` -Avoid, since it hides what is being iterated: -```java -var result = process(data); -``` -Prefer keeping the explicit type here instead: + +Less useful when the abstraction itself matters: + ```java -ProcessResult result = process(data); +Map> cache = createCache(); ``` -**Text blocks** for multi-line strings. Never manual concatenation. +Do not use `var` simply to minimize characters. + +### Collections + +When the intent is specifically first or last element access: -Avoid: ```java -String json = "{\n" + - " \"id\": \"" + id + "\"\n" + - "}"; +values.getFirst(); +values.getLast(); ``` + +Use indexed access when the index itself is meaningful to the algorithm. + +Choose collection implementations according to their actual semantics and requirements. + +Do not manually reimplement standard collection behavior without a reason. + +### Streams + +Streams are appropriate when they make a transformation or aggregation clearer. + +Do not convert straightforward imperative logic into streams merely to appear modern. + +A loop is often preferable when the operation has early exits, mutation, multiple conditions, or meaningful control flow. + +### Virtual threads + +Virtual threads do not change Bukkit's threading requirements. + +Use the Bukkit scheduler for Bukkit work. + +Virtual threads are appropriate for isolated workloads such as suitable blocking I/O when no Bukkit API is accessed from the virtual thread. + +Do not move Bukkit API work to arbitrary background threads simply because virtual threads exist. + +### Preview features + +Do not introduce preview features unless the project explicitly enables and intends to use them. + +When uncertain about the status or suitability of a Java 25 feature, verify it before using it. + +--- + +# Minecraft and Spigot + +This project targets **Spigot 26.2**, not Paper. + +### Use the actual target API + +Do not assume an API exists because it appears in Paper documentation, a Paper plugin, or a generic Minecraft tutorial. + +Verify Bukkit/Spigot APIs against the actual Spigot dependency and version used by the project. + +Do not silently introduce Paper-only APIs. + +Examples of Paper-specific concepts that must not be assumed available include Paper-only events, schedulers, and APIs. + +### Threading + +Respect Bukkit's execution model. + +Bukkit state and APIs that require the main server thread must remain on the appropriate thread. + +Keep asynchronous work isolated and return to the Bukkit scheduler before interacting with thread-confined server state. + +### Deprecated APIs + +Do not introduce deprecated Bukkit or Spigot APIs when a current replacement exists. + +When an obsolete API is genuinely necessary because the target platform exposes no suitable alternative, document the reason near the usage. + +### NMS and server internals + +Prefer the public Spigot API. + +Do not introduce mapping, remapping, or reobfuscation workflows for the project's current Minecraft target. + +Do not parse Minecraft versions from NMS package names. + +When internal server code is genuinely necessary, isolate it behind an appropriate project abstraction rather than spreading version-specific implementation details throughout the codebase. + +--- + +# Naming + +Names should communicate meaning without requiring the reader to decode them. + +Prefer concise, descriptive names. + +Avoid unnecessary abbreviations. The following are acceptable when they genuinely represent the intended concept: + +* `id` +* `url` +* `http` + +Do not use vague names such as `data`, `info`, `helper`, or `util` when a more specific name exists. + +Do not shorten names merely to save characters. + Prefer: + ```java -String json = """ - { - "id": "%s" - } - """.formatted(id); +List candidates; ``` -**Records for data carriers.** Never a hand-rolled POJO. +over: -Avoid: ```java -class CooldownEntry { - private final Class manager; - private final AbilityType type; - private final long expiresAt; - // plus constructor, getters, equals, hashCode, toString -} -``` -Prefer: -```java -record CooldownEntry(Class manager, AbilityType type, long expiresAt) {} +List arr; ``` -**Virtual threads.** Do not blanket-replace `runTaskAsynchronously`. Virtual threads are a JVM feature; they know nothing about Bukkit's main-thread requirement. Keep `Bukkit.getScheduler().runTaskAsynchronously` for anything that touches Bukkit API afterward. Reach for a virtual thread only for isolated I/O with zero Bukkit API inside it, and mark the choice either way, since the reason is not obvious from the diff: +Names should reflect the domain concept rather than generic implementation details. + +--- + +# Nullability and absence + +Do not use `null` casually, but do not replace every nullable internal value with ceremony. + +Use an explicit absence mechanism when it makes an API clearer. + +`Optional` is primarily useful for appropriate return values; it is not a requirement for fields, parameters, or every internal local. + +A simple nullable local can be the clearest implementation when the value is only created when needed: + ```java -// ponytail: kept — plain async task, not a virtual thread: this callback -// re-enters Bukkit API (inventory access), which must stay off any thread -// Bukkit does not manage itself. -Bukkit.getScheduler().runTaskAsynchronously(plugin, this::fetchAndApply); +List eligible = null; + +for (SpawnableEntity entity : candidates) { + if (!entity.canSpawnAt(location, world)) continue; + + if (eligible == null) { + eligible = new ArrayList<>(candidates.size()); + } + + eligible.add(entity); +} ``` -**Stream gatherers.** Niche, not a default. `Stream.gather(...)` (finalized Java 24) exists for custom intermediate operations a `Collector` cannot express: sliding windows, stateful folds. Reach for it only when a plain `.map()` / `.filter()` / `.collect()` chain genuinely cannot express the logic; otherwise it fails the "boring over clever" rule above. +Do not introduce a generic helper solely to eliminate this pattern. + +--- + +# Allocation and performance + +Prefer correct, understandable code first. -## Minecraft and Spigot target +Avoid unnecessary copies and allocations when ownership and lifecycle are already clear. -This project targets **Spigot 26.2**, built through BuildTools. It is not a Paper project. Do not assume Paper's extended API is available. +Use immutable snapshots when immutability provides a useful guarantee. -### Do not use Paper-only API +Do not perform micro-optimizations without a meaningful reason or workload. -Vanilla Bukkit and Spigot expose a smaller surface than Paper. Before proposing any Bukkit API call, confirm it exists on the Spigot API specifically, not on Paper's fork of it. A method seen in a Paper plugin tutorial or a Paper Javadoc page is not evidence it exists here. +A small allocation is not automatically a performance problem. -Known landmines to check for specifically: +Likewise, do not sacrifice readability for a theoretical optimization that does not matter to the actual workload. -- `Player#sendActionBar(Component)` and the `Audience` interface are Paper-only. On Spigot, action bars go through `player.spigot().sendMessage(ChatMessageType.ACTION_BAR, ...)` using `net.md_5.bungee.api.chat` types. -- Paper's own events (for example `AsyncChatEvent`, `ServerTickManager`-related events) do not exist on Spigot; use the vanilla Bukkit equivalents. -- `paper-plugin.yml` and Paper's plugin-loading extensions do not apply; this project uses `plugin.yml`. -- PaperLib and any Paper-exclusive registry or scheduler extensions (including Folia's region-aware scheduler variants) are unavailable. +When performance genuinely matters, reason from the relevant workload and measure rather than guessing. -If a task appears to require Paper-only functionality, state this explicitly and ask whether the target should change, rather than silently writing Paper-specific code against a Spigot build. +--- + +# Validation and errors -### Do not use deprecated API without justification +Validate external or untrusted input at the boundary where it enters the system. -Check whether a Bukkit or Spigot method is annotated `@Deprecated` before using it. If a current, non-deprecated replacement exists, use it. If a deprecated method is genuinely the only path available, mark the call `// ponytail: kept — `. +Keep domain invariants close to the objects or methods responsible for enforcing them. -### Do not reintroduce NMS mapping or remapping workflows +Prefer designs that make invalid states difficult to represent. -Minecraft ships unobfuscated as of version 26.1. Server-internal (NMS) classes carry their real, readable names directly; there is no obfuscated intermediate layer left to map. Do not add or suggest: +Do not duplicate validation everywhere when a trusted internal abstraction already guarantees the invariant. -- BuildTools `--remapped` / Mojang-mappings development workflows. -- Reobfuscation build steps (for example `specialsource-maven-plugin` or equivalent remap plugins) to convert Mojang-mapped code back to Spigot mappings before packaging. -- Any mapping file, mapping dependency, or remap-at-compile-time configuration. +Do not swallow exceptions silently. -These solved a problem — obfuscated internals — that no longer exists for this target version. Treat any of the above appearing in a proposed change as a sign the version target has been assumed incorrectly; verify against 26.2 before proceeding. +Error behavior should be predictable and useful to the caller. + +--- -Do not parse the Minecraft version out of an NMS package name (a pre-existing anti-pattern even before 26.1, since Paper had already stopped relocating the CraftBukkit package by 1.20.5). Use `Bukkit.getBukkitVersion()` or `Bukkit.getServer().getVersion()`, or reuse a version-detection utility already in the codebase if one exists, per the Coding ladder above. +# Testing -## Version control +Read existing tests before adding new ones and follow their established conventions. -Agents may draft a commit message. Agents must never create a commit, stage -files for the purpose of committing, or push, without the user's explicit, -turn-by-turn approval. This is a hard gate, not a courtesy, and it does not -weaken based on how small or routine the change looks. +Prefer tests of observable behavior and important invariants over implementation details. -- **Drafting is not committing.** A request such as "commit this" or "write - a commit message for these changes" authorizes inspecting the diff and - producing a message to review. It does not authorize running `git commit`. -- **No proactive commits.** Finishing a task, reaching a good stopping - point, or the user moving on to a new request is never, by itself, - grounds to draft or run a commit. Only an explicit ask starts this flow. -- **Executing requires a second, specific approval** of the exact message - shown — for example "yes, commit it" or "use that." Agreement with the - underlying change, or silence, is not approval to run the command. If - there is any ambiguity about whether the user approved the *message shown* - versus just the idea of committing, ask before running anything. -- This applies uniformly across tools (Claude Code, Cursor, Copilot, - Windsurf, Cline, or any other agent reading this file) and across commit - message conventions the repository may adopt. +When designing or changing an API, test the API from the consumer's perspective where practical. -## Required before submitting code +A good API test should resemble the way another part of the plugin is actually expected to use the API. -- [ ] The touched code was read before anything was proposed. -- [ ] Every added line of complexity is marked `// ponytail: kept` or `// ponytail: `. -- [ ] Nothing outside the requested scope was refactored, renamed, or otherwise "improved." -- [ ] No banned abbreviation from the Naming table appears in any new identifier. -- [ ] Every new Java construct checked against the Modern Java section; no manually-written equivalent of a listed native feature was introduced without a stated reason. -- [ ] Every new Bukkit or Spigot API call was verified against the Spigot API, not assumed from Paper documentation or examples. -- [ ] No deprecated API was used without a `// ponytail: kept` justification. -- [ ] No mapping, remapping, or reobfuscation workflow was added or suggested. -- [ ] No commit was created, staged for committing, or pushed without the user's explicit, message-specific approval in this turn. +Run the relevant build and test checks before submitting a change. + +Never claim that a build or test passed unless it was actually run. --- -## Cross-agent setup (for repository maintainers, not agents) +# Compatibility and public APIs -This file (`AGENTS.md`) is the single source of truth. Every other tool-specific rules file is a thin pointer to it, never a copy, to avoid drift. +Treat public APIs as contracts. -- **Claude Code** does not read `AGENTS.md` directly. Create `CLAUDE.md` at the repository root containing only: - ``` - @AGENTS.md - ``` - Claude Code resolves the `@path` import and loads the full content. +Before changing or removing a public class, method, constructor, field, enum value, or configuration format, inspect its usages and determine whether compatibility matters. -- **Cursor**: create `.cursor/rules/main.mdc` as a symlink to `AGENTS.md` (or, on Windows, or if symlinks are not practical, a file containing "Read and follow AGENTS.md at the repository root before responding."). +Do not build speculative compatibility layers for consumers that do not exist. -- **GitHub Copilot**: symlink `.github/copilot-instructions.md` to `AGENTS.md`. +When compatibility is required, prefer the simplest migration path that preserves the contract without introducing unnecessary architectural complexity. -- **Windsurf**: symlink `.windsurfrules` to `AGENTS.md`. +A clean API for real consumers is more valuable than theoretical compatibility with imaginary ones. -- **Cline**: symlink `.clinerules` to `AGENTS.md`. +--- -Symlink setup, run once from the repository root: -```bash -echo '@AGENTS.md' > CLAUDE.md # CLAUDE.md must be an import, not a symlink -mkdir -p .cursor/rules && ln -sfn ../../AGENTS.md .cursor/rules/main.mdc -mkdir -p .github && ln -sfn ../AGENTS.md .github/copilot-instructions.md -ln -sfn AGENTS.md .windsurfrules -ln -sfn AGENTS.md .clinerules -``` +# Version control + +Agents must not create commits, stage files for committing, or push changes without explicit authorization from the user. + +If a commit is requested, show the exact commit message and obtain approval before executing it. + +Do not commit merely because a task is complete. + +Agents may inspect diffs and draft commit messages without creating commits. + +--- -Commit all of the above to version control so every contributor and every agent gets the same rules regardless of which tool they run. \ No newline at end of file +# Before submitting code + +Verify that: + +* The relevant existing code was read before changing it. +* The solution is proportional to the problem. +* Existing abstractions were reused where they genuinely fit. +* New abstractions solve a real problem rather than merely removing textual duplication. +* The public API is understandable from the consumer's point of view. +* The common use case is simple. +* Modern Java capabilities were considered where they materially improve the code. +* No preview feature was introduced unintentionally. +* Bukkit/Spigot APIs were verified against the actual target rather than assumed from Paper. +* No unnecessary deprecated API was introduced. +* Threading remains compatible with Bukkit's execution model. +* Tests and build checks relevant to the change were run. +* Unrelated code was not refactored without a reason. +* No commit, staging, or push occurred without explicit authorization. diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a08d7091..ae093748 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -3,15 +3,15 @@ Before you create a Pull Request, please check whether your commits comply with the commit conventions used in this repository. -When you create a commit we kindly ask you to follow the convention +When you create a commit, we kindly ask you to follow the convention `category(scope or module): message` in your commit message while using one of the following categories: - `feat / feature`: all changes that introduce completely new code or new features -- `fix`: changes that fix a bug (ideally you will additionally reference an +- `fix`: changes that fix a bug (ideally, you will additionally reference an issue if present) -- `refactor`: any code related change that is not a fix nor a feature +- `refactor`: any code-related change that is not a fix nor a feature - `docs`: changing existing or creating new documentation (i.e., README, docs for usage of a lib or cli usage) - `build`: all changes regarding the build of the software, changes to @@ -19,7 +19,7 @@ the following categories: - `test`: all changes regarding tests (adding new tests or changing existing ones) - `ci`: all changes regarding the configuration of continuous integration (i.e., - GitHub actions, ci system) + GitHub Actions, ci system) - `chore`: all changes to the repository that do not fit into any of the above categories From 1ef8b4c4067cb5e2385d63231801572f69623163 Mon Sep 17 00:00:00 2001 From: Moussa Date: Mon, 28 Sep 2026 22:32:44 +0200 Subject: [PATCH 12/31] chore(deps): update dependencies and project metadata - Upgrade Java version to 26 and Lombok to 1.18.48 - Update Spigot version to 26.3 in project files and workflows - Bump project version to 1.2.0 across submodules --- .github/workflows/maven.yml | 4 ++-- README.md | 6 +++--- bedrock/pom.xml | 2 +- blighted-mod/pom.xml | 2 +- blighted-smp/pom.xml | 2 +- pom.xml | 4 ++-- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 384aec9d..8eaac953 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -32,13 +32,13 @@ jobs: uses: actions/cache@v4 with: path: ~/.m2/repository/org/spigotmc - key: spigot-26.2 + key: spigot-26.3 restore-keys: spigot- - name: Build and install Spigot via BuildTools uses: SpraxDev/Action-SpigotMC@v5 with: - versions: 26.2 + versions: 26.3 remapped: true generateSrc: false generateDoc: false diff --git a/README.md b/README.md index 565cc10d..85ddb5d8 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # BlightedMC -A Spigot 26.2 plugin providing a high-difficulty survival experience inspired by custom RPG mechanics. Vanilla Minecraft is no longer challenging enough. That's why we're bringing you BlightedMC! +A Spigot 26.3 plugin providing a high-difficulty survival experience inspired by custom RPG mechanics. Vanilla Minecraft is no longer challenging enough. That's why we're bringing you BlightedMC! ## Features @@ -17,8 +17,8 @@ A Spigot 26.2 plugin providing a high-difficulty survival experience inspired by ## Requirements -- Java 25+ -- Spigot 26.2 server build +- Java 26 +- Spigot 26.3 server build ## Building from Source diff --git a/bedrock/pom.xml b/bedrock/pom.xml index 8ce34cc9..ca9c91c8 100644 --- a/bedrock/pom.xml +++ b/bedrock/pom.xml @@ -7,7 +7,7 @@ fr.moussax blightedmc - 1.0-SNAPSHOT + 1.2.0 bedrock diff --git a/blighted-mod/pom.xml b/blighted-mod/pom.xml index d0b6a1c4..39d97002 100644 --- a/blighted-mod/pom.xml +++ b/blighted-mod/pom.xml @@ -7,7 +7,7 @@ fr.moussax blightedmc - 1.0-SNAPSHOT + 1.2.0 blighted-mod diff --git a/blighted-smp/pom.xml b/blighted-smp/pom.xml index 9e2fda15..3f363543 100644 --- a/blighted-smp/pom.xml +++ b/blighted-smp/pom.xml @@ -7,7 +7,7 @@ fr.moussax blightedmc - 1.0-SNAPSHOT + 1.2.0 blighted-smp diff --git a/pom.xml b/pom.xml index 32ea93bc..c5c245ea 100644 --- a/pom.xml +++ b/pom.xml @@ -18,10 +18,10 @@ - 25 + 26 UTF-8 26.3-R0.1-SNAPSHOT - 1.18.46 + 1.18.48 3.45.3.0 5.10.2 From c75c3f4416fae03c2705bac19dc667c7be8300ee Mon Sep 17 00:00:00 2001 From: Moussa Date: Mon, 28 Sep 2026 22:33:01 +0200 Subject: [PATCH 13/31] ci: remove code-ql workflow configuration --- .github/workflows/code-ql.yml | 36 ----------------------------------- 1 file changed, 36 deletions(-) delete mode 100644 .github/workflows/code-ql.yml diff --git a/.github/workflows/code-ql.yml b/.github/workflows/code-ql.yml deleted file mode 100644 index 000724cf..00000000 --- a/.github/workflows/code-ql.yml +++ /dev/null @@ -1,36 +0,0 @@ -name: CodeQL - -on: - pull_request: - schedule: - - cron: '0 4 * * 1' # weekly, Monday 04:00 UTC - -permissions: - contents: read - security-events: write - -concurrency: - group: ${{ github.workflow }}-${{ github.ref }} - cancel-in-progress: true - -jobs: - analyze: - runs-on: ubuntu-latest - timeout-minutes: 20 - steps: - - uses: actions/checkout@v4 - - - uses: actions/setup-java@v4 - with: - java-version: '25' - distribution: 'temurin' - cache: 'maven' - - - uses: github/codeql-action/init@v3 - with: - languages: java - - - name: Build - run: mvn -B compile --file pom.xml - - - uses: github/codeql-action/analyze@v3 \ No newline at end of file From 49ac3e1c9511a0eff1bb723d3136c3f45b661634 Mon Sep 17 00:00:00 2001 From: Moussa Date: Mon, 28 Sep 2026 23:00:28 +0200 Subject: [PATCH 14/31] (1/4) refactor(entities): extract runtime tracking and orphan cleanup to EntityManager Move active blighted entity tracking, attachment mappings, chunk rehydration, and periodic orphan sweeping out of BlightedEntitiesListener into a dedicated EntityManager component to isolate runtime state management from event handling. --- .../bedrock/ui/toast/AdvancementToast.java | 169 ----------- .../engine/entities/BlightedEntity.java | 86 +++--- .../engine/entities/EntityManager.java | 278 ++++++++++++++++++ .../engine/entities/LifecycleTaskManager.java | 115 +++++--- .../listeners/BlightedEntitiesListener.java | 229 +++++---------- .../spawnable/engine/SpawnEvaluator.java | 61 ++++ 6 files changed, 526 insertions(+), 412 deletions(-) delete mode 100644 bedrock/src/main/java/fr/moussax/bedrock/ui/toast/AdvancementToast.java create mode 100644 blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityManager.java create mode 100644 blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/SpawnEvaluator.java diff --git a/bedrock/src/main/java/fr/moussax/bedrock/ui/toast/AdvancementToast.java b/bedrock/src/main/java/fr/moussax/bedrock/ui/toast/AdvancementToast.java deleted file mode 100644 index 1497018f..00000000 --- a/bedrock/src/main/java/fr/moussax/bedrock/ui/toast/AdvancementToast.java +++ /dev/null @@ -1,169 +0,0 @@ -package fr.moussax.bedrock.ui.toast; - -import fr.moussax.bedrock.scheduling.PluginContext; -import net.minecraft.advancements.*; -import net.minecraft.advancements.triggers.Criterion; -import net.minecraft.network.chat.Component; -import net.minecraft.network.protocol.game.ClientboundUpdateAdvancementsPacket; -import net.minecraft.resources.Identifier; -import net.minecraft.server.level.ServerPlayer; -import net.minecraft.world.item.Item; -import net.minecraft.world.item.ItemStackTemplate; -import org.bukkit.Bukkit; -import org.bukkit.Material; -import org.bukkit.NamespacedKey; -import org.bukkit.craftbukkit.entity.CraftPlayer; -import org.bukkit.craftbukkit.util.CraftMagicNumbers; -import org.bukkit.entity.Player; -import org.jspecify.annotations.NonNull; - -import java.util.*; - -/** - * Sends custom advancement toast notifications to players. - * - *

Constructs and sends ephemeral packet-level advancements to render client-side - * toast popups without registering persistent server advancements.

- */ -public final class AdvancementToast { - - private static final String TRIGGER = "toast_trigger"; - private static final long REMOVAL_DELAY_TICKS = 10L; - - private final NamespacedKey key; - private final Material icon; - private final String message; - private final Type type; - - private AdvancementToast(@NonNull String message, @NonNull Material icon, @NonNull Type type) { - this.key = new NamespacedKey(PluginContext.get(), UUID.randomUUID().toString()); - this.message = message; - this.icon = icon.isItem() ? icon : Material.COMMAND_BLOCK; - this.type = type; - } - - /** - * Displays a task toast to a player. - * - * @param player player receiving the toast - * @param message toast message text - * @param icon material icon displayed on the toast - */ - public static void task(@NonNull Player player, @NonNull String message, @NonNull Material icon) { - show(player, message, icon, Type.TASK); - } - - /** - * Displays a goal toast to a player. - * - * @param player player receiving the toast - * @param message toast message text - * @param icon material icon displayed on the toast - */ - public static void goal(@NonNull Player player, @NonNull String message, @NonNull Material icon) { - show(player, message, icon, Type.GOAL); - } - - /** - * Displays a challenge toast to a player. - * - * @param player player receiving the toast - * @param message toast message text - * @param icon material icon displayed on the toast - */ - public static void challenge(@NonNull Player player, @NonNull String message, @NonNull Material icon) { - show(player, message, icon, Type.CHALLENGE); - } - - /** - * Displays a toast with the specified {@link Type} to a player. - * - * @param player player receiving the toast - * @param message toast message text - * @param icon material icon displayed on the toast - * @param type toast display frame type - */ - public static void show(@NonNull Player player, @NonNull String message, @NonNull Material icon, @NonNull Type type) { - if (!player.isOnline()) return; - new AdvancementToast(message, icon, type).display(player); - } - - private void display(Player player) { - ServerPlayer nmsPlayer = ((CraftPlayer) player).getHandle(); - Identifier id = Identifier.fromNamespaceAndPath( - key.getNamespace(), - key.getKey() - ); - - AdvancementHolder holder = createAdvancement(id); - AdvancementRequirements requirements = AdvancementRequirements.allOf(List.of(TRIGGER)); - AdvancementProgress progress = new AdvancementProgress(); - progress.update(requirements); - progress.grantProgress(TRIGGER); - - nmsPlayer.connection.send(new ClientboundUpdateAdvancementsPacket( - false, - List.of(holder), - Set.of(), - Map.of(id, progress), - true - )); - - Bukkit.getScheduler().runTaskLater(PluginContext.get(), () -> { - if (!player.isOnline()) return; - nmsPlayer.connection.send(new ClientboundUpdateAdvancementsPacket( - false, - List.of(), - Set.of(id), - Map.of(), - false - ) - ); - }, - REMOVAL_DELAY_TICKS - ); - } - - private AdvancementHolder createAdvancement(Identifier id) { - Item item = CraftMagicNumbers.getItem(icon); - ItemStackTemplate itemTemplate = new ItemStackTemplate(item); - - AdvancementType advancementType = switch (type) { - case GOAL -> AdvancementType.GOAL; - case TASK -> AdvancementType.TASK; - case CHALLENGE -> AdvancementType.CHALLENGE; - }; - - DisplayInfo displayInfo = new DisplayInfo( - itemTemplate, - Component.literal(message), - Component.empty(), - Optional.empty(), - advancementType, - true, - false, - true - ); - - AdvancementRequirements requirements = AdvancementRequirements.allOf(List.of(TRIGGER)); - Advancement advancement = new Advancement( - Optional.empty(), - Optional.of(displayInfo), - AdvancementRewards.EMPTY, - Map.of(TRIGGER, new Criterion<>(null, null)), - requirements, - false - ); - - return new AdvancementHolder(id, advancement); - } - - /** - * Visual frame styles for advancement toast notifications. - */ - public enum Type { - TASK, - GOAL, - CHALLENGE - } -} diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java index e78e7bca..0181ec0c 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java @@ -1,24 +1,20 @@ package fr.moussax.blightedSMP.engine.entities; +import fr.moussax.bedrock.utils.debug.Log; import fr.moussax.blightedSMP.BlightedSMP; -import fr.moussax.blightedSMP.engine.entities.components.AffixRegistry; import fr.moussax.blightedSMP.engine.entities.attachment.AttachmentRole; import fr.moussax.blightedSMP.engine.entities.attachment.EntityAttachment; +import fr.moussax.blightedSMP.engine.entities.components.AffixRegistry; import fr.moussax.blightedSMP.engine.entities.components.EntityComponent; import fr.moussax.blightedSMP.engine.entities.defense.DamageType; import fr.moussax.blightedSMP.engine.entities.defense.EntityDefenses; import fr.moussax.blightedSMP.engine.entities.defense.EntityImmunity; -import fr.moussax.blightedSMP.engine.entities.listeners.BlightedEntitiesListener; -import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import fr.moussax.blightedSMP.engine.loot.LootContext; import fr.moussax.blightedSMP.engine.loot.LootTable; -import fr.moussax.bedrock.utils.debug.Log; +import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import lombok.Getter; import lombok.Setter; import org.bukkit.*; - -import java.util.*; - import org.bukkit.attribute.Attribute; import org.bukkit.attribute.AttributeInstance; import org.bukkit.attribute.AttributeModifier; @@ -32,13 +28,13 @@ import org.bukkit.inventory.EntityEquipment; import org.bukkit.inventory.ItemStack; import org.bukkit.persistence.PersistentDataType; -import org.bukkit.scheduler.BukkitRunnable; import org.bukkit.util.Vector; import org.jspecify.annotations.NonNull; -import java.util.function.Consumer; +import java.util.*; import java.util.concurrent.CopyOnWriteArraySet; import java.util.concurrent.ThreadLocalRandom; +import java.util.function.Consumer; /** * Base class for custom runtime-controlled entities backed by a Bukkit {@link LivingEntity}. @@ -178,7 +174,7 @@ public LivingEntity spawn(Location location) { createBossBar(); } - BlightedEntitiesListener.registerEntity(entity, this); + EntityManager.registerEntity(entity, this); initComponents(); initRuntime(); @@ -202,7 +198,7 @@ public void attachToExisting(LivingEntity existing) { if (isBoss) { createBossBar(); } - BlightedEntitiesListener.registerEntity(existing, this); + EntityManager.registerEntity(existing, this); initComponents(); onRehydrate(existing); @@ -241,7 +237,7 @@ public void cleanup() { destroyComponents(); coreTasks.cancelAll(); phaseTasks.cancelAll(); - BlightedEntitiesListener.unregisterEntity(entity); + EntityManager.unregisterEntity(entity); } /** @@ -766,7 +762,7 @@ public void addAttachment(Entity attachmentEntity, AttachmentRole role, Vector o } Vector vector = offset != null ? offset : new Vector(0, 0, 0); attachments.add(new EntityAttachment(attachmentEntity, role, vector, syncYaw, syncPitch)); - BlightedEntitiesListener.registerAttachment(attachmentEntity, this); + EntityManager.registerAttachment(attachmentEntity, this); if (entity != null) { attachmentEntity.getPersistentDataContainer().set(ATTACHMENT_OWNER_KEY, PersistentDataType.STRING, entity.getUniqueId().toString()); @@ -810,7 +806,7 @@ public void syncAttachments() { if (attachedEntity == null || !attachedEntity.isValid() || attachedEntity.isDead()) { attachments.remove(attachment); if (attachedEntity != null) { - BlightedEntitiesListener.unregisterAttachment(attachedEntity); + EntityManager.unregisterAttachment(attachedEntity); } continue; } @@ -828,17 +824,26 @@ public void syncAttachments() { double zPrime = baseLocation.getZ() + (offset.getX() * sin + offset.getZ() * cos); double yPrime = baseLocation.getY() + offset.getY(); - // When syncYaw/syncPitch are false, preserve current yaw/pitch - float targetYaw = attachment.syncYaw() ? baseLocation.getYaw() : 0.0f; - float targetPitch = attachment.syncPitch() ? baseLocation.getPitch() : 0.0f; + Location currentLoc = attachedEntity.getLocation(); + float targetYaw = attachment.syncYaw() ? baseLocation.getYaw() : currentLoc.getYaw(); + float targetPitch = attachment.syncPitch() ? baseLocation.getPitch() : currentLoc.getPitch(); + + if (currentLoc.getWorld() == baseLocation.getWorld() + && Math.abs(currentLoc.getX() - xPrime) < 0.001 + && Math.abs(currentLoc.getY() - yPrime) < 0.001 + && Math.abs(currentLoc.getZ() - zPrime) < 0.001 + && Math.abs(currentLoc.getYaw() - targetYaw) < 0.1f + && Math.abs(currentLoc.getPitch() - targetPitch) < 0.1f) { + continue; + } Location targetLocation = new Location( baseLocation.getWorld(), xPrime, yPrime, zPrime, - attachment.syncYaw() ? baseLocation.getYaw() : attachedEntity.getLocation().getYaw(), - attachment.syncPitch() ? baseLocation.getPitch() : attachedEntity.getLocation().getPitch() + targetYaw, + targetPitch ); attachedEntity.teleport(targetLocation); @@ -860,7 +865,7 @@ public void killAllAttachments() { continue; } - BlightedEntitiesListener.unregisterAttachment(attachmentEntity); + EntityManager.unregisterAttachment(attachmentEntity); attachmentEntity.remove(); } attachments.clear(); @@ -883,7 +888,7 @@ public void killAttachments(AttachmentRole role) { Entity attachmentEntity = attachment.entity(); if (attachmentEntity != null) { - BlightedEntitiesListener.unregisterAttachment(attachmentEntity); + EntityManager.unregisterAttachment(attachmentEntity); attachmentEntity.remove(); } attachments.remove(attachment); @@ -1209,35 +1214,28 @@ public void addResistance(DamageType type, double percent) { } private void scheduleAbility(LifecycleTaskManager manager, long delayTicks, long periodTicks, Runnable action) { - manager.addRepeatingTask(() -> new BukkitRunnable() { - @Override - public void run() { - if (!isAlive()) { - cancel(); - return; - } - try { - action.run(); - } catch (Exception exception) { - Log.warn("BlightedEntity", "Ability threw an exception on entity '" + name + "': " + exception.getMessage()); - } + manager.addRepeatingTask(() -> { + if (!isAlive()) { + return; + } + try { + action.run(); + } catch (Exception exception) { + Log.warn("BlightedEntity", "Ability threw an exception on entity '" + name + "': " + exception.getMessage()); } }, delayTicks, periodTicks); if (canScheduleTask()) manager.scheduleLast(); } private void scheduleDelayedAction(LifecycleTaskManager manager, long delayTicks, Runnable action) { - manager.addDelayedTask(() -> new BukkitRunnable() { - @Override - public void run() { - if (!isAlive()) { - return; - } - try { - action.run(); - } catch (Exception exception) { - Log.warn("BlightedEntity", "Delayed action threw an exception on entity '" + name + "': " + exception.getMessage()); - } + manager.addDelayedTask(() -> { + if (!isAlive()) { + return; + } + try { + action.run(); + } catch (Exception exception) { + Log.warn("BlightedEntity", "Delayed action threw an exception on entity '" + name + "': " + exception.getMessage()); } }, delayTicks); if (canScheduleTask()) manager.scheduleLast(); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityManager.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityManager.java new file mode 100644 index 00000000..a7cad7f7 --- /dev/null +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityManager.java @@ -0,0 +1,278 @@ +package fr.moussax.blightedSMP.engine.entities; + +import fr.moussax.blightedSMP.BlightedSMP; +import fr.moussax.blightedSMP.engine.entities.attachment.AttachmentRole; +import fr.moussax.blightedSMP.engine.entities.attachment.EntityAttachment; +import fr.moussax.blightedSMP.engine.entities.registry.EntitiesRegistry; +import org.bukkit.Bukkit; +import org.bukkit.Chunk; +import org.bukkit.entity.Entity; +import org.bukkit.entity.LivingEntity; +import org.bukkit.persistence.PersistentDataContainer; +import org.bukkit.persistence.PersistentDataType; +import org.bukkit.util.Vector; +import org.jspecify.annotations.Nullable; + +import java.util.Collection; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import java.util.concurrent.ConcurrentHashMap; + +import static fr.moussax.blightedSMP.engine.entities.BlightedEntity.*; + +/** + * Central runtime entity manager tracking active {@link BlightedEntity} instances, + * attachments, chunk rehydration, and orphan sweeping. + */ +public final class EntityManager { + + private static final Map BLIGHTED_ENTITIES = new ConcurrentHashMap<>(); + private static final Map ATTACHMENT_OWNERS = new ConcurrentHashMap<>(); + private static final long ORPHAN_SWEEP_PERIOD_TICKS = 100L; // 5s + + private EntityManager() { + } + + /** + * Initializes background orphan entity cleanup task. + */ + public static void initialize() { + Bukkit.getScheduler().runTaskTimer( + BlightedSMP.getInstance(), EntityManager::sweepOrphanedEntities, + ORPHAN_SWEEP_PERIOD_TICKS, ORPHAN_SWEEP_PERIOD_TICKS + ); + } + + /** + * Sweeps and cleans up invalid or dead entities from tracking maps. + */ + public static void sweepOrphanedEntities() { + for (BlightedEntity blighted : List.copyOf(BLIGHTED_ENTITIES.values())) { + LivingEntity entity = blighted.getEntity(); + if (entity == null || entity.isDead() || !entity.isValid()) { + if (entity != null) { + BLIGHTED_ENTITIES.remove(entity.getUniqueId(), blighted); + } else { + BLIGHTED_ENTITIES.values().remove(blighted); + } + blighted.cleanup(); + } + } + } + + /** + * Registers active entity instance with its runtime wrapper. + * + * @param entity living entity to track + * @param blighted blighted entity wrapper instance + */ + public static void registerEntity(LivingEntity entity, BlightedEntity blighted) { + if (entity == null || blighted == null) return; + BLIGHTED_ENTITIES.put(entity.getUniqueId(), blighted); + } + + /** + * Unregisters active entity instance from tracking. + * + * @param entity living entity to stop tracking + */ + public static void unregisterEntity(LivingEntity entity) { + if (entity == null) return; + BLIGHTED_ENTITIES.remove(entity.getUniqueId()); + } + + /** + * Registers attachment entity to its owning blighted entity wrapper. + * + * @param attachment attachment entity + * @param owner owning blighted entity wrapper + */ + public static void registerAttachment(Entity attachment, BlightedEntity owner) { + if (attachment == null || owner == null) return; + ATTACHMENT_OWNERS.put(attachment.getUniqueId(), owner); + } + + /** + * Unregisters attachment entity from tracking. + * + * @param attachment attachment entity to unregister + */ + public static void unregisterAttachment(Entity attachment) { + if (attachment == null) return; + ATTACHMENT_OWNERS.remove(attachment.getUniqueId()); + } + + /** + * Retrieves blighted entity wrapper associated with entity or attachment entity. + * + * @param entity target entity + * @return blighted entity wrapper, or {@code null} if untracked + */ + @Nullable + public static BlightedEntity getBlightedEntity(Entity entity) { + if (entity == null) return null; + UUID id = entity.getUniqueId(); + BlightedEntity blighted = BLIGHTED_ENTITIES.get(id); + return blighted != null ? blighted : ATTACHMENT_OWNERS.get(id); + } + + /** + * Retrieves owning blighted entity wrapper for attachment entity UUID. + * + * @param entityId attachment entity unique identifier + * @return owning blighted entity wrapper, or {@code null} if untracked + */ + @Nullable + public static BlightedEntity getAttachmentOwner(UUID entityId) { + if (entityId == null) return null; + return ATTACHMENT_OWNERS.get(entityId); + } + + /** + * Retrieves registered blighted entity wrapper by entity UUID. + * + * @param entityId target entity unique identifier + * @return direct blighted entity wrapper, or {@code null} if untracked + */ + @Nullable + public static BlightedEntity getDirectBlightedEntity(UUID entityId) { + if (entityId == null) return null; + return BLIGHTED_ENTITIES.get(entityId); + } + + /** + * Returns snapshot collection of all currently tracked active blighted entities. + * + * @return active blighted entity collection + */ + public static Collection getActiveEntities() { + return List.copyOf(BLIGHTED_ENTITIES.values()); + } + + /** + * Removes attachment owner tracking entry by entity UUID. + * + * @param entityId target attachment entity unique identifier + */ + public static void removeAttachmentOwner(UUID entityId) { + if (entityId == null) return; + ATTACHMENT_OWNERS.remove(entityId); + } + + /** + * Removes direct blighted entity tracking entry by entity UUID. + * + * @param entityId target entity unique identifier + */ + public static void removeDirectBlightedEntity(UUID entityId) { + if (entityId == null) return; + BLIGHTED_ENTITIES.remove(entityId); + } + + /** + * Rehydrates blighted entities and attachment entities stored in persistent data when chunk loads. + * + * @param chunk loaded chunk to rehydrate + */ + public static void rehydrateChunk(Chunk chunk) { + if (chunk == null || !chunk.isLoaded()) { + return; + } + Entity[] entities = chunk.getEntities(); + + // Pass 1: rehydrate main blighted entities. + for (Entity entity : entities) { + if (!(entity instanceof LivingEntity living)) continue; + if (!living.getScoreboardTags().contains(FAST_PASS_TAG)) continue; + + PersistentDataContainer persistentDataContainer = living.getPersistentDataContainer(); + if (!persistentDataContainer.has(ENTITY_ID_KEY, PersistentDataType.STRING)) continue; + + BlightedEntity existing = BLIGHTED_ENTITIES.get(living.getUniqueId()); + if (existing != null) { + if (existing.getEntity() != living) { + existing.attachToExisting(living); + } + continue; + } + + String entityId = persistentDataContainer.get(ENTITY_ID_KEY, PersistentDataType.STRING); + BlightedEntity prototype = EntitiesRegistry.get(entityId); + if (prototype == null) continue; + + prototype.clone().attachToExisting(living); + } + + // Pass 2: re-register attachment entities carrying ATTACHMENT_OWNER_KEY. + for (Entity entity : entities) { + if (!entity.getScoreboardTags().contains(FAST_PASS_TAG)) continue; + + PersistentDataContainer persistentDataContainer = entity.getPersistentDataContainer(); + if (!persistentDataContainer.has(ATTACHMENT_OWNER_KEY, PersistentDataType.STRING)) continue; + + String ownerUuidString = persistentDataContainer.get(ATTACHMENT_OWNER_KEY, PersistentDataType.STRING); + String roleString = persistentDataContainer.get(ATTACHMENT_ROLE_KEY, PersistentDataType.STRING); + if (ownerUuidString == null || roleString == null) continue; + + UUID ownerUuid; + try { + ownerUuid = UUID.fromString(ownerUuidString); + } catch (IllegalArgumentException _) { + continue; + } + + BlightedEntity owner = BLIGHTED_ENTITIES.get(ownerUuid); + if (owner == null) continue; + + AttachmentRole role; + try { + role = AttachmentRole.valueOf(roleString); + } catch (IllegalArgumentException _) { + role = AttachmentRole.SUBORDINATE; + } + + Double offsetX = persistentDataContainer.get(ATTACHMENT_OFFSET_X_KEY, PersistentDataType.DOUBLE); + Double offsetY = persistentDataContainer.get(ATTACHMENT_OFFSET_Y_KEY, PersistentDataType.DOUBLE); + Double offsetZ = persistentDataContainer.get(ATTACHMENT_OFFSET_Z_KEY, PersistentDataType.DOUBLE); + Vector offset = new Vector( + offsetX != null ? offsetX : 0.0, + offsetY != null ? offsetY : 0.0, + offsetZ != null ? offsetZ : 0.0 + ); + + Byte yawByte = persistentDataContainer.get(ATTACHMENT_SYNC_YAW_KEY, PersistentDataType.BYTE); + Byte pitchByte = persistentDataContainer.get(ATTACHMENT_SYNC_PITCH_KEY, PersistentDataType.BYTE); + boolean syncYaw = yawByte == null || yawByte == 1; + boolean syncPitch = pitchByte != null && pitchByte == 1; + + owner.attachments.removeIf(a -> a.entity() != null && a.entity().getUniqueId().equals(entity.getUniqueId())); + owner.attachments.add(new EntityAttachment(entity, role, offset, syncYaw, syncPitch)); + registerAttachment(entity, owner); + } + + // Pass 3: Purge orphan attachments whose owner entity no longer exists. + Bukkit.getScheduler().runTaskLater(BlightedSMP.getInstance(), () -> { + if (!chunk.isLoaded()) return; + for (Entity entity : chunk.getEntities()) { + if (!entity.getScoreboardTags().contains(FAST_PASS_TAG)) continue; + PersistentDataContainer persistentDataContainer = entity.getPersistentDataContainer(); + if (!persistentDataContainer.has(ATTACHMENT_OWNER_KEY, PersistentDataType.STRING)) continue; + + String ownerUuidString = persistentDataContainer.get(ATTACHMENT_OWNER_KEY, PersistentDataType.STRING); + if (ownerUuidString == null) continue; + + try { + UUID ownerUuid = UUID.fromString(ownerUuidString); + BlightedEntity owner = BLIGHTED_ENTITIES.get(ownerUuid); + if (owner == null || owner.getEntity() == null || !owner.getEntity().isValid()) { + entity.remove(); + ATTACHMENT_OWNERS.remove(entity.getUniqueId()); + } + } catch (IllegalArgumentException _) { + entity.remove(); + } + } + }, 3L); + } +} diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/LifecycleTaskManager.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/LifecycleTaskManager.java index 2b20f476..a4335e51 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/LifecycleTaskManager.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/LifecycleTaskManager.java @@ -1,29 +1,49 @@ package fr.moussax.blightedSMP.engine.entities; import fr.moussax.blightedSMP.BlightedSMP; +import org.bukkit.Bukkit; import org.bukkit.scheduler.BukkitRunnable; +import org.bukkit.scheduler.BukkitTask; import java.util.ArrayList; import java.util.List; import java.util.function.Supplier; /** - * Manages scheduler tasks bound to the lifecycle of an {@link BlightedEntity}. + * Manages scheduler tasks bound to the lifecycle of a {@link BlightedEntity}. *

- * Allows entities to register delayed or repeating {@link BukkitRunnable} tasks that - * are automatically scheduled on initialization and canceled on destruction. - * Tasks are executed through the {@link BlightedSMP} plugin scheduler and can be - * rescheduled as needed during the entity’s lifetime. + * Allows entities to register delayed or repeating tasks that are automatically + * scheduled on initialization and canceled on destruction. */ public final class LifecycleTaskManager { + private List tasks; + /** - * Holds all registered scheduled tasks for the associated entity. + * Adds a repeating task using a {@link Runnable} action. + * + * @param action task action + * @param delayTicks initial delay in ticks + * @param periodTicks execution interval in ticks */ - private List tasks; + public void addRepeatingTask(Runnable action, long delayTicks, long periodTicks) { + ensureList(); + tasks.add(new ScheduledTask(action, null, delayTicks, periodTicks, true)); + } + + /** + * Adds a delayed task using a {@link Runnable} action. + * + * @param action task action + * @param delayTicks delay in ticks + */ + public void addDelayedTask(Runnable action, long delayTicks) { + ensureList(); + tasks.add(new ScheduledTask(action, null, delayTicks, 0L, false)); + } /** - * Adds a repeating task that executes periodically for the entity lifecycle. + * Adds a repeating task using a {@link BukkitRunnable} supplier (for backwards compatibility). * * @param factory supplier creating a new {@link BukkitRunnable} instance * @param delayTicks initial delay before the first execution, in ticks @@ -31,23 +51,22 @@ public final class LifecycleTaskManager { */ public void addRepeatingTask(Supplier factory, long delayTicks, long periodTicks) { ensureList(); - tasks.add(new ScheduledTask(factory, delayTicks, periodTicks, true)); + tasks.add(new ScheduledTask(null, factory, delayTicks, periodTicks, true)); } /** - * Adds a delayed one-time task that runs once after the given delay. + * Adds a delayed task using a {@link BukkitRunnable} supplier (for backwards compatibility). * * @param factory supplier creating a new {@link BukkitRunnable} instance * @param delayTicks delay before execution, in ticks */ public void addDelayedTask(Supplier factory, long delayTicks) { ensureList(); - tasks.add(new ScheduledTask(factory, delayTicks, 0L, false)); + tasks.add(new ScheduledTask(null, factory, delayTicks, 0L, false)); } /** - * Schedules all registered tasks. This is typically invoked - * during the entity’s runtime initialization phase. + * Schedules all registered tasks. */ public void scheduleAll() { if (tasks == null) return; @@ -58,7 +77,6 @@ public void scheduleAll() { /** * Schedules only the most recently added task. - * Useful for adding new runtime behaviors dynamically. */ public void scheduleLast() { if (tasks == null || tasks.isEmpty()) return; @@ -66,8 +84,7 @@ public void scheduleLast() { } /** - * Cancels all currently running scheduled tasks associated with the entity. - * This should be invoked during entity destruction or killing. + * Cancels all currently running tasks associated with this manager. */ public void cancelAll() { if (tasks == null) return; @@ -85,21 +102,19 @@ private void ensureList() { private void onTaskComplete(ScheduledTask task) { if (tasks == null) return; tasks.remove(task); - task.current = null; } - /** - * Represents a scheduled Bukkit task bound to an entity’s lifecycle. - * Handles its own scheduling, cancellation, and re-initialization logic. - */ private static final class ScheduledTask { + private final Runnable action; private final Supplier factory; private final long delayTicks; private final long periodTicks; private final boolean repeating; - private BukkitRunnable current; + private BukkitTask currentTask; + private BukkitRunnable currentRunnable; - private ScheduledTask(Supplier factory, long delayTicks, long periodTicks, boolean repeating) { + private ScheduledTask(Runnable action, Supplier factory, long delayTicks, long periodTicks, boolean repeating) { + this.action = action; this.factory = factory; this.delayTicks = delayTicks; this.periodTicks = periodTicks; @@ -110,35 +125,55 @@ private void schedule(LifecycleTaskManager manager) { cancel(); if (repeating) { - current = factory.get(); - current.runTaskTimer(BlightedSMP.getInstance(), delayTicks, periodTicks); + if (action != null) { + currentTask = Bukkit.getScheduler().runTaskTimer(BlightedSMP.getInstance(), action, delayTicks, periodTicks); + } else if (factory != null) { + currentRunnable = factory.get(); + currentTask = currentRunnable.runTaskTimer(BlightedSMP.getInstance(), delayTicks, periodTicks); + } } else { - current = new BukkitRunnable() { - private final BukkitRunnable inner = factory.get(); - - @Override - public void run() { + if (action != null) { + currentTask = Bukkit.getScheduler().runTaskLater(BlightedSMP.getInstance(), () -> { try { - if (inner != null) inner.run(); + action.run(); } finally { - // Ensure this is removed from the list even if the logic crashes manager.onTaskComplete(ScheduledTask.this); } - } - }; - current.runTaskLater(BlightedSMP.getInstance(), delayTicks); + }, delayTicks); + } else if (factory != null) { + currentRunnable = new BukkitRunnable() { + private final BukkitRunnable inner = factory.get(); + + @Override + public void run() { + try { + if (inner != null) inner.run(); + } finally { + manager.onTaskComplete(ScheduledTask.this); + } + } + }; + currentTask = currentRunnable.runTaskLater(BlightedSMP.getInstance(), delayTicks); + } } } private void cancel() { - if (current != null) { + if (currentTask != null) { + try { + currentTask.cancel(); + } catch (Exception _) { + } + currentTask = null; + } + if (currentRunnable != null) { try { - if (!current.isCancelled()) { - current.cancel(); + if (!currentRunnable.isCancelled()) { + currentRunnable.cancel(); } - } catch (IllegalStateException ignored) { + } catch (Exception _) { } - current = null; + currentRunnable = null; } } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java index fd8e9934..0ea11df4 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java @@ -2,96 +2,93 @@ import fr.moussax.blightedSMP.BlightedSMP; import fr.moussax.blightedSMP.engine.entities.BlightedEntity; +import fr.moussax.blightedSMP.engine.entities.EntityManager; import fr.moussax.blightedSMP.engine.entities.attachment.AttachmentRole; import fr.moussax.blightedSMP.engine.entities.attachment.EntityAttachment; import fr.moussax.blightedSMP.engine.entities.defense.EntityImmunity; -import fr.moussax.blightedSMP.engine.entities.registry.EntitiesRegistry; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import org.bukkit.Bukkit; import org.bukkit.Chunk; import org.bukkit.Sound; -import org.bukkit.entity.*; +import org.bukkit.entity.Entity; +import org.bukkit.entity.LivingEntity; +import org.bukkit.entity.Player; +import org.bukkit.entity.Projectile; import org.bukkit.event.EventHandler; import org.bukkit.event.EventPriority; import org.bukkit.event.Listener; -import org.bukkit.event.entity.EntityDamageByEntityEvent; -import org.bukkit.event.entity.EntityDamageEvent; -import org.bukkit.event.entity.EntityDeathEvent; -import org.bukkit.event.entity.EntityPotionEffectEvent; -import org.bukkit.event.entity.EntityRegainHealthEvent; +import org.bukkit.event.entity.*; import org.bukkit.event.world.ChunkLoadEvent; import org.bukkit.inventory.EntityEquipment; import org.bukkit.persistence.PersistentDataContainer; import org.bukkit.persistence.PersistentDataType; import org.bukkit.util.Vector; -import java.util.*; +import java.util.Collection; +import java.util.Set; +import java.util.UUID; import java.util.concurrent.ConcurrentHashMap; -import static fr.moussax.blightedSMP.engine.entities.BlightedEntity.ATTACHMENT_OFFSET_X_KEY; -import static fr.moussax.blightedSMP.engine.entities.BlightedEntity.ATTACHMENT_OFFSET_Y_KEY; -import static fr.moussax.blightedSMP.engine.entities.BlightedEntity.ATTACHMENT_OFFSET_Z_KEY; -import static fr.moussax.blightedSMP.engine.entities.BlightedEntity.ATTACHMENT_OWNER_KEY; -import static fr.moussax.blightedSMP.engine.entities.BlightedEntity.ATTACHMENT_ROLE_KEY; -import static fr.moussax.blightedSMP.engine.entities.BlightedEntity.ATTACHMENT_SYNC_PITCH_KEY; -import static fr.moussax.blightedSMP.engine.entities.BlightedEntity.ATTACHMENT_SYNC_YAW_KEY; -import static fr.moussax.blightedSMP.engine.entities.BlightedEntity.ENTITY_ID_KEY; -import static fr.moussax.blightedSMP.engine.entities.BlightedEntity.FAST_PASS_TAG; +import static fr.moussax.blightedSMP.engine.entities.BlightedEntity.*; +/** + * Event listener handling damage, potion effects, health updates, death, and chunk loading + * for {@link BlightedEntity} instances and delegating runtime entity tracking to {@link EntityManager}. + */ public final class BlightedEntitiesListener implements Listener { - private static final Map BLIGHTED_ENTITIES = new ConcurrentHashMap<>(); - private static final Map ATTACHMENT_OWNERS = new ConcurrentHashMap<>(); private final Set processingDamageIds = ConcurrentHashMap.newKeySet(); - private static final long ORPHAN_SWEEP_PERIOD_TICKS = 100L; // 5s - public BlightedEntitiesListener() { - Bukkit.getScheduler().runTaskTimer( - BlightedSMP.getInstance(), BlightedEntitiesListener::sweepOrphanedEntities, - ORPHAN_SWEEP_PERIOD_TICKS, ORPHAN_SWEEP_PERIOD_TICKS - ); - } - - private static void sweepOrphanedEntities() { - for (BlightedEntity blighted : List.copyOf(BLIGHTED_ENTITIES.values())) { - LivingEntity entity = blighted.getEntity(); - if (entity == null || entity.isDead() || !entity.isValid()) { - if (entity != null) { - BLIGHTED_ENTITIES.remove(entity.getUniqueId(), blighted); - } else { - BLIGHTED_ENTITIES.values().remove(blighted); - } - blighted.cleanup(); - } - } + EntityManager.initialize(); } + /** + * Delegates entity registration to {@link EntityManager#registerEntity(LivingEntity, BlightedEntity)}. + * + * @param entity living entity to track + * @param blighted blighted entity wrapper instance + */ public static void registerEntity(LivingEntity entity, BlightedEntity blighted) { - if (entity == null || blighted == null) return; - BLIGHTED_ENTITIES.put(entity.getUniqueId(), blighted); + EntityManager.registerEntity(entity, blighted); } + /** + * Delegates entity unregistration to {@link EntityManager#unregisterEntity(LivingEntity)}. + * + * @param entity living entity to stop tracking + */ public static void unregisterEntity(LivingEntity entity) { - if (entity == null) return; - BLIGHTED_ENTITIES.remove(entity.getUniqueId()); + EntityManager.unregisterEntity(entity); } + /** + * Delegates attachment registration to {@link EntityManager#registerAttachment(Entity, BlightedEntity)}. + * + * @param attachment attachment entity + * @param owner owning blighted entity wrapper + */ public static void registerAttachment(Entity attachment, BlightedEntity owner) { - if (attachment == null || owner == null) return; - ATTACHMENT_OWNERS.put(attachment.getUniqueId(), owner); + EntityManager.registerAttachment(attachment, owner); } + /** + * Delegates attachment unregistration to {@link EntityManager#unregisterAttachment(Entity)}. + * + * @param attachment attachment entity to unregister + */ public static void unregisterAttachment(Entity attachment) { - if (attachment == null) return; - ATTACHMENT_OWNERS.remove(attachment.getUniqueId()); + EntityManager.unregisterAttachment(attachment); } + /** + * Delegates entity lookup to {@link EntityManager#getBlightedEntity(Entity)}. + * + * @param entity target entity + * @return blighted entity wrapper, or {@code null} if untracked + */ public static BlightedEntity getBlightedEntity(Entity entity) { - if (entity == null) return null; - UUID id = entity.getUniqueId(); - BlightedEntity blighted = BLIGHTED_ENTITIES.get(id); - return blighted != null ? blighted : ATTACHMENT_OWNERS.get(id); + return EntityManager.getBlightedEntity(entity); } @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true) @@ -108,12 +105,12 @@ public void onEntityDamage(EntityDamageEvent event) { processingDamageIds.add(entityId); try { - BlightedEntity owner = ATTACHMENT_OWNERS.get(entityId); + BlightedEntity owner = EntityManager.getAttachmentOwner(entityId); if (owner != null) { LivingEntity ownerEntity = owner.getEntity(); if (ownerEntity == null || ownerEntity.isDead()) { target.remove(); - ATTACHMENT_OWNERS.remove(entityId); + EntityManager.removeAttachmentOwner(entityId); return; } @@ -124,12 +121,14 @@ public void onEntityDamage(EntityDamageEvent event) { } } - if (target instanceof LivingEntity living) { - BlightedEntity blighted = BLIGHTED_ENTITIES.get(entityId); - if (blighted != null) { - handleBlightedEntityDamage(blighted, living, event); - } + if (!(target instanceof LivingEntity living)) { + return; + } + BlightedEntity blighted = EntityManager.getDirectBlightedEntity(entityId); + if (blighted == null) { + return; } + handleBlightedEntityDamage(blighted, living, event); } finally { processingDamageIds.remove(entityId); } @@ -179,7 +178,7 @@ private void handleAttachmentDamage( LivingEntity ownerEntity = owner.getEntity(); if (ownerEntity == null || ownerEntity.isDead()) { attachmentEntity.remove(); - ATTACHMENT_OWNERS.remove(attachmentEntity.getUniqueId()); + EntityManager.removeAttachmentOwner(attachmentEntity.getUniqueId()); return; } @@ -255,7 +254,7 @@ public void onEntityPotionEffect(EntityPotionEffectEvent event) { Entity target = event.getEntity(); if (!target.getScoreboardTags().contains(FAST_PASS_TAG)) return; - BlightedEntity owner = ATTACHMENT_OWNERS.get(target.getUniqueId()); + BlightedEntity owner = EntityManager.getAttachmentOwner(target.getUniqueId()); if (owner == null) return; LivingEntity ownerEntity = owner.getEntity(); @@ -295,7 +294,7 @@ public void onEntityHeal(EntityRegainHealthEvent event) { if (!entity.getScoreboardTags().contains(FAST_PASS_TAG)) return; UUID entityId = entity.getUniqueId(); - BlightedEntity blighted = BLIGHTED_ENTITIES.get(entityId); + BlightedEntity blighted = EntityManager.getDirectBlightedEntity(entityId); if (blighted != null) { blighted.updateBossBar(); } @@ -307,7 +306,12 @@ public void onEntityDeath(EntityDeathEvent event) { if (!dead.getScoreboardTags().contains(FAST_PASS_TAG)) return; UUID uuid = dead.getUniqueId(); - boolean isAttachment = ATTACHMENT_OWNERS.remove(uuid) != null + BlightedEntity attachmentOwner = EntityManager.getAttachmentOwner(uuid); + if (attachmentOwner != null) { + EntityManager.removeAttachmentOwner(uuid); + } + + boolean isAttachment = attachmentOwner != null || dead.getPersistentDataContainer().has(ATTACHMENT_OWNER_KEY, PersistentDataType.STRING); if (isAttachment) { @@ -316,8 +320,9 @@ public void onEntityDeath(EntityDeathEvent event) { return; } - BlightedEntity blighted = BLIGHTED_ENTITIES.remove(uuid); + BlightedEntity blighted = EntityManager.getDirectBlightedEntity(uuid); if (blighted == null) return; + EntityManager.removeDirectBlightedEntity(uuid); blighted.cleanup(); @@ -340,105 +345,11 @@ public void onChunkLoad(ChunkLoadEvent event) { } public static Collection getActiveEntities() { - return List.copyOf(BLIGHTED_ENTITIES.values()); + return EntityManager.getActiveEntities(); } public static void rehydrateChunk(Chunk chunk) { - Entity[] entities = chunk.getEntities(); - - // Pass 1: rehydrate main blighted entities. - for (Entity entity : entities) { - if (!(entity instanceof LivingEntity living)) continue; - if (!living.getScoreboardTags().contains(FAST_PASS_TAG)) continue; - - PersistentDataContainer persistentDataContainer = living.getPersistentDataContainer(); - if (!persistentDataContainer.has(ENTITY_ID_KEY, PersistentDataType.STRING)) continue; - - BlightedEntity existing = BLIGHTED_ENTITIES.get(living.getUniqueId()); - if (existing != null) { - if (existing.getEntity() != living) { - existing.attachToExisting(living); - } - continue; - } - - String entityId = persistentDataContainer.get(ENTITY_ID_KEY, PersistentDataType.STRING); - BlightedEntity prototype = EntitiesRegistry.get(entityId); - if (prototype == null) continue; - - prototype.clone().attachToExisting(living); - } - - // Pass 2: re-register attachment entities carrying ATTACHMENT_OWNER_KEY. - for (Entity entity : entities) { - if (!entity.getScoreboardTags().contains(FAST_PASS_TAG)) continue; - - PersistentDataContainer persistentDataContainer = entity.getPersistentDataContainer(); - if (!persistentDataContainer.has(ATTACHMENT_OWNER_KEY, PersistentDataType.STRING)) continue; - - String ownerUuidString = persistentDataContainer.get(ATTACHMENT_OWNER_KEY, PersistentDataType.STRING); - String roleString = persistentDataContainer.get(ATTACHMENT_ROLE_KEY, PersistentDataType.STRING); - if (ownerUuidString == null || roleString == null) continue; - - UUID ownerUuid; - try { - ownerUuid = UUID.fromString(ownerUuidString); - } catch (IllegalArgumentException _) { - continue; - } - - BlightedEntity owner = BLIGHTED_ENTITIES.get(ownerUuid); - if (owner == null) continue; - - AttachmentRole role; - try { - role = AttachmentRole.valueOf(roleString); - } catch (IllegalArgumentException _) { - role = AttachmentRole.SUBORDINATE; - } - - Double offsetX = persistentDataContainer.get(ATTACHMENT_OFFSET_X_KEY, PersistentDataType.DOUBLE); - Double offsetY = persistentDataContainer.get(ATTACHMENT_OFFSET_Y_KEY, PersistentDataType.DOUBLE); - Double offsetZ = persistentDataContainer.get(ATTACHMENT_OFFSET_Z_KEY, PersistentDataType.DOUBLE); - Vector offset = new Vector( - offsetX != null ? offsetX : 0.0, - offsetY != null ? offsetY : 0.0, - offsetZ != null ? offsetZ : 0.0 - ); - - Byte yawByte = persistentDataContainer.get(ATTACHMENT_SYNC_YAW_KEY, PersistentDataType.BYTE); - Byte pitchByte = persistentDataContainer.get(ATTACHMENT_SYNC_PITCH_KEY, PersistentDataType.BYTE); - boolean syncYaw = yawByte == null || yawByte == 1; - boolean syncPitch = pitchByte != null && pitchByte == 1; - - owner.attachments.removeIf(a -> a.entity() != null && a.entity().getUniqueId().equals(entity.getUniqueId())); - owner.attachments.add(new EntityAttachment(entity, role, offset, syncYaw, syncPitch)); - registerAttachment(entity, owner); - } - - // Pass 3: Purge orphan attachments whose owner entity no longer exists. - Bukkit.getScheduler().runTaskLater(BlightedSMP.getInstance(), () -> { - if (!chunk.isLoaded()) return; - for (Entity entity : chunk.getEntities()) { - if (!entity.getScoreboardTags().contains(FAST_PASS_TAG)) continue; - PersistentDataContainer persistentDataContainer = entity.getPersistentDataContainer(); - if (!persistentDataContainer.has(ATTACHMENT_OWNER_KEY, PersistentDataType.STRING)) continue; - - String ownerUuidString = persistentDataContainer.get(ATTACHMENT_OWNER_KEY, PersistentDataType.STRING); - if (ownerUuidString == null) continue; - - try { - UUID ownerUuid = UUID.fromString(ownerUuidString); - BlightedEntity owner = BLIGHTED_ENTITIES.get(ownerUuid); - if (owner == null || owner.getEntity() == null || !owner.getEntity().isValid()) { - entity.remove(); - ATTACHMENT_OWNERS.remove(entity.getUniqueId()); - } - } catch (IllegalArgumentException _) { - entity.remove(); - } - } - }, 3L); + EntityManager.rehydrateChunk(chunk); } private Player getPlayerDamager(Entity damager) { diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/SpawnEvaluator.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/SpawnEvaluator.java new file mode 100644 index 00000000..8f8eff20 --- /dev/null +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/SpawnEvaluator.java @@ -0,0 +1,61 @@ +package fr.moussax.blightedSMP.engine.entities.spawnable.engine; + +import fr.moussax.blightedSMP.engine.entities.spawnable.SpawnableEntity; +import org.bukkit.Location; +import org.bukkit.World; +import org.jspecify.annotations.Nullable; + +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.ThreadLocalRandom; + +/** + * Utility for evaluating spawn conditions and selecting spawnable entity candidates weighted by probability. + */ +public final class SpawnEvaluator { + + private SpawnEvaluator() {} + + /** + * Evaluates a list of candidate entities against a target location and selects an eligible entity weighted by probability. + * + * @param candidates candidate spawnable entity prototypes + * @param location target spawn location + * @param world target world + * @param random random number generator + * @return selected entity definition, or {@code null} if no spawn condition was met or the roll failed + */ + @Nullable + public static SpawnableEntity selectCandidate(List candidates, Location location, World world, ThreadLocalRandom random) { + if (candidates == null || candidates.isEmpty() || location == null || world == null) { + return null; + } + + List eligible = null; + for (SpawnableEntity entity : candidates) { + if (!entity.canSpawnAt(location, world)) continue; + if (eligible == null) eligible = new ArrayList<>(candidates.size()); + eligible.add(entity); + } + + if (eligible == null) return null; + + double totalChance = 0.0; + for (SpawnableEntity entity : eligible) { + totalChance += entity.getSpawnProbability(); + } + + if (random.nextDouble() >= Math.min(totalChance, 1.0)) return null; + + double selectionRoll = random.nextDouble() * totalChance; + double cumulative = 0.0; + for (SpawnableEntity entity : eligible) { + cumulative += entity.getSpawnProbability(); + if (selectionRoll < cumulative) { + return entity; + } + } + + return null; + } +} From 72fb86075f5014da3ab8913ef441825e456f6ce9 Mon Sep 17 00:00:00 2001 From: Moussa Date: Mon, 28 Sep 2026 23:01:02 +0200 Subject: [PATCH 15/31] (2/4) refactor(entities): consolidate prototype tracking under EntitiesRegistry Unify custom blighted entity prototype registration within EntitiesRegistry and convert SpawnableEntitiesRegistry into a delegating read-only view. --- .../entities/registry/EntitiesRegistry.java | 66 ++++++++++++++++--- .../registry/SpawnableEntitiesRegistry.java | 42 +++++++----- 2 files changed, 85 insertions(+), 23 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/EntitiesRegistry.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/EntitiesRegistry.java index 2249d2c8..90a1e1f3 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/EntitiesRegistry.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/EntitiesRegistry.java @@ -1,10 +1,10 @@ package fr.moussax.blightedSMP.engine.entities.registry; +import fr.moussax.bedrock.utils.debug.Log; import fr.moussax.blightedSMP.engine.entities.BlightedEntity; import fr.moussax.blightedSMP.engine.entities.spawnable.SpawnableEntity; import fr.moussax.blightedSMP.registry.EngineRegistry; import fr.moussax.blightedSMP.registry.RegistryModule; -import fr.moussax.bedrock.utils.debug.Log; import org.jspecify.annotations.Nullable; import java.util.ArrayList; @@ -12,7 +12,7 @@ import java.util.function.Consumer; /** - * Central registry for all {@link BlightedEntity} prototypes. + * Central registry for prototype {@link BlightedEntity} instances. */ public final class EntitiesRegistry { @@ -24,24 +24,34 @@ public final class EntitiesRegistry { private EntitiesRegistry() { } + /** + * Adds callback executed when a prototype entity is registered. + * + * @param callback callback runnable + */ public static void addOnRegisterCallback(Runnable callback) { onRegisterCallbacks.add(callback); } + /** + * Initializes registry with defined registration modules. + * + * @param modules list of registry modules + */ public static void initialize(List>> modules) { clear(); REGISTRY.initialize(modules); } + /** + * Registers entity prototype and executes registration callbacks. + * + * @param entity entity prototype to register + */ public static void register(BlightedEntity entity) { if (entity == null) return; - boolean isNew = !REGISTRY.contains(entity.getEntityId()); REGISTRY.register(entity); - if (isNew && entity instanceof SpawnableEntity spawnable) { - SpawnableEntitiesRegistry.register(spawnable); - } - onRegisterCallbacks.forEach(callback -> { try { callback.run(); @@ -51,21 +61,61 @@ public static void register(BlightedEntity entity) { }); } + /** + * Retrieves cloned instance of registered entity prototype by ID. + * + * @param entityId target entity identifier + * @return cloned entity instance, or {@code null} if untracked + */ @Nullable public static BlightedEntity get(String entityId) { BlightedEntity prototype = REGISTRY.get(entityId); return prototype != null ? prototype.clone() : null; } + /** + * Retrieves cloned instance of registered spawnable entity prototype by ID. + * + * @param entityId target entity identifier + * @return cloned spawnable entity instance, or {@code null} if untracked or not spawnable + */ + @Nullable + public static SpawnableEntity getSpawnable(String entityId) { + BlightedEntity entity = REGISTRY.get(entityId); + if (!(entity instanceof SpawnableEntity spawnable)) { + return null; + } + return spawnable.clone(); + } + + /** + * Returns list of cloned instances of all registered entity prototypes. + * + * @return list of cloned entity prototypes + */ public static List getAll() { return REGISTRY.getAll().stream() .map(BlightedEntity::clone) .toList(); } + /** + * Returns list of cloned instances of all registered spawnable entity prototypes. + * + * @return list of cloned spawnable entity prototypes + */ + public static List getSpawnables() { + return REGISTRY.getAll().stream() + .filter(SpawnableEntity.class::isInstance) + .map(e -> ((SpawnableEntity) e).clone()) + .toList(); + } + + /** + * Clears all registered entity prototypes and registration callbacks. + */ public static void clear() { REGISTRY.clear(); - SpawnableEntitiesRegistry.clear(); onRegisterCallbacks.clear(); } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/SpawnableEntitiesRegistry.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/SpawnableEntitiesRegistry.java index bb6146bd..2ad6dd1d 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/SpawnableEntitiesRegistry.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/SpawnableEntitiesRegistry.java @@ -3,37 +3,49 @@ import fr.moussax.blightedSMP.engine.entities.spawnable.SpawnableEntity; import org.jspecify.annotations.Nullable; -import java.util.HashMap; import java.util.List; -import java.util.Map; +/** + * Convenience view delegating spawnable entity queries to {@link EntitiesRegistry}. + */ public final class SpawnableEntitiesRegistry { - private static final Map SPAWNABLE_ENTITIES = new HashMap<>(); - - private SpawnableEntitiesRegistry() {} - - static void register(SpawnableEntity entity) { - SPAWNABLE_ENTITIES.put(entity.getEntityId(), entity); + private SpawnableEntitiesRegistry() { } + /** + * Retrieves cloned instance of registered spawnable entity prototype by ID. + * + * @param entityId target entity identifier + * @return cloned spawnable entity instance, or {@code null} if untracked or not spawnable + */ @Nullable public static SpawnableEntity get(String entityId) { - SpawnableEntity prototype = SPAWNABLE_ENTITIES.get(entityId); - return prototype != null ? prototype.clone() : null; + return EntitiesRegistry.getSpawnable(entityId); } + /** + * Returns list of cloned instances of all registered spawnable entity prototypes. + * + * @return list of cloned spawnable entity prototypes + */ public static List getAll() { - return SPAWNABLE_ENTITIES.values().stream() - .map(SpawnableEntity::clone) - .toList(); + return EntitiesRegistry.getSpawnables(); } + /** + * Returns total number of registered spawnable entity prototypes. + * + * @return registered spawnable entity count + */ public static int count() { - return SPAWNABLE_ENTITIES.size(); + return EntitiesRegistry.getSpawnables().size(); } + /** + * No-op delegate for compatibility; delegate clearing is handled by {@link EntitiesRegistry#clear()}. + */ public static void clear() { - SPAWNABLE_ENTITIES.clear(); + // No-op: delegate handled by EntitiesRegistry.clear() } } From c65732578e534abcc4db15f56f54598ffb0aeb5f Mon Sep 17 00:00:00 2001 From: Moussa Date: Mon, 28 Sep 2026 23:01:33 +0200 Subject: [PATCH 16/31] (3/4) refactor(entities): extract spawn selection logic to SpawnEvaluator Decouple probability-weighted spawn condition evaluation into SpawnEvaluator to reduce duplication across BlightedSpawnEngine and SpawnableEntitiesListener. --- .../listeners/SpawnableEntitiesListener.java | 45 +++++++------------ .../spawnable/engine/BlightedSpawnEngine.java | 28 ++---------- 2 files changed, 19 insertions(+), 54 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/SpawnableEntitiesListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/SpawnableEntitiesListener.java index bfc3e60f..065ed9ef 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/SpawnableEntitiesListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/SpawnableEntitiesListener.java @@ -2,6 +2,7 @@ import fr.moussax.blightedSMP.engine.entities.registry.SpawnableEntitiesRegistry; import fr.moussax.blightedSMP.engine.entities.spawnable.SpawnableEntity; +import fr.moussax.blightedSMP.engine.entities.spawnable.engine.SpawnEvaluator; import fr.moussax.blightedSMP.engine.entities.spawnable.engine.SpawnMode; import org.bukkit.Location; import org.bukkit.World; @@ -14,6 +15,9 @@ import java.util.*; import java.util.concurrent.ThreadLocalRandom; +/** + * Event listener replacing natural creature spawns with custom {@link SpawnableEntity} instances. + */ public final class SpawnableEntitiesListener implements Listener { private volatile Map> spawnCache = Collections.emptyMap(); @@ -25,7 +29,7 @@ public void onCreatureSpawn(CreatureSpawnEvent event) { CreatureSpawnEvent.SpawnReason reason = event.getSpawnReason(); if (reason != CreatureSpawnEvent.SpawnReason.NATURAL - && reason != CreatureSpawnEvent.SpawnReason.REINFORCEMENTS) { + && reason != CreatureSpawnEvent.SpawnReason.REINFORCEMENTS) { return; } @@ -36,38 +40,16 @@ public void onCreatureSpawn(CreatureSpawnEvent event) { World world = location.getWorld(); if (world == null) return; - List eligible = null; - for (SpawnableEntity entity : candidates) { - if (!entity.canSpawnAt(location, world)) continue; - if (eligible == null) eligible = new ArrayList<>(candidates.size()); - eligible.add(entity); - } - - if (eligible == null) return; - - ThreadLocalRandom random = ThreadLocalRandom.current(); - - // First roll: does any replacement spawn happen at all? - double totalChance = 0.0; - for (SpawnableEntity entity : eligible) { - totalChance += entity.getSpawnProbability(); - } - - if (random.nextDouble() >= Math.min(totalChance, 1.0)) return; - - // Second roll: which entity wins, weighted by individual probability. - double selectionRoll = random.nextDouble() * totalChance; - double cumulative = 0.0; - for (SpawnableEntity entity : eligible) { - cumulative += entity.getSpawnProbability(); - if (selectionRoll < cumulative) { - event.setCancelled(true); - entity.clone().spawn(location); - return; - } + SpawnableEntity selected = SpawnEvaluator.selectCandidate(candidates, location, world, ThreadLocalRandom.current()); + if (selected != null) { + event.setCancelled(true); + selected.clone().spawn(location); } } + /** + * Rebuilds spawn candidate cache from registered spawnable entities configured for replacement or hybrid spawning. + */ public synchronized void rebuildCache() { if (!cacheDirty) return; @@ -83,6 +65,9 @@ public synchronized void rebuildCache() { this.cacheDirty = false; } + /** + * Marks spawn cache as dirty to trigger rebuild on the next spawn event. + */ public void invalidateCache() { this.cacheDirty = true; } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/BlightedSpawnEngine.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/BlightedSpawnEngine.java index 584be36e..b5379013 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/BlightedSpawnEngine.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/BlightedSpawnEngine.java @@ -125,30 +125,10 @@ private void attemptSpawnInChunk(Chunk chunk, World world, ThreadLocalRandom ran Location location = new Location(world, x + 0.5, y, z + 0.5); - List eligible = null; - for (SpawnableEntity entity : cachedIndependentEntities) { - if (!entity.canSpawnAt(location, world)) continue; - if (eligible == null) eligible = new ArrayList<>(cachedIndependentEntities.size()); - eligible.add(entity); - } - - if (eligible == null) continue; - - double totalChance = 0.0; - for (SpawnableEntity entity : eligible) { - totalChance += entity.getSpawnProbability(); - } - - if (random.nextDouble() >= Math.min(totalChance, 1.0)) continue; - - double selectionRoll = random.nextDouble() * totalChance; - double cumulative = 0.0; - for (SpawnableEntity entity : eligible) { - cumulative += entity.getSpawnProbability(); - if (selectionRoll < cumulative) { - entity.clone().spawn(location); - return; // Stop scanning column once an entity spawns - } + SpawnableEntity selected = SpawnEvaluator.selectCandidate(cachedIndependentEntities, location, world, random); + if (selected != null) { + selected.clone().spawn(location); + return; // Stop scanning column once an entity spawns } } } From def1c4031a9f89069947f34846e91cc88743fb1f Mon Sep 17 00:00:00 2001 From: Moussa Date: Mon, 28 Sep 2026 23:01:56 +0200 Subject: [PATCH 17/31] (4/4) feat(entities): enhance EntityLootTableBuilder DX and streamline mob loot definitions Add type-safe BlightedItem support, default COMMON rarity fallbacks, and a symmetrical 5-tier overload hierarchy to EntityLootTableBuilder. Update custom mob definitions to consume the streamlined loot table builder API. --- .../content/entities/BlightedEntities.java | 3 +- .../entities/bosses/CorruptedChampion.java | 26 +- .../blightsworn/BlightswornBogged.java | 11 +- .../blightsworn/BlightswornDrowned.java | 10 +- .../factions/blightsworn/BlightswornHusk.java | 6 +- .../blightsworn/BlightswornParched.java | 8 +- .../blightsworn/BlightswornPiglin.java | 8 +- .../blightsworn/BlightswornSkeleton.java | 8 +- .../blightsworn/BlightswornStray.java | 11 +- .../BlightswornWitherSkeleton.java | 10 +- .../blightsworn/BlightswornZombie.java | 12 +- .../BlightswornZombifiedPiglin.java | 8 +- .../factions/celestial/CelestialCreature.java | 20 +- .../factions/celestial/CelestialEnderman.java | 1 + .../content/entities/powerful/Endersent.java | 8 +- .../content/entities/powerful/Illusioner.java | 16 +- .../content/entities/powerful/Watchling.java | 8 +- .../entities/EntityLootTableBuilder.java | 435 ++++++++++++++---- 18 files changed, 440 insertions(+), 169 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/BlightedEntities.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/BlightedEntities.java index d5253c90..87d6dac8 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/BlightedEntities.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/BlightedEntities.java @@ -3,6 +3,8 @@ import fr.moussax.blightedSMP.content.entities.bosses.CorruptedChampion; import fr.moussax.blightedSMP.content.entities.factions.blightsworn.*; import fr.moussax.blightedSMP.content.entities.powerful.Endersent; +import fr.moussax.blightedSMP.content.entities.powerful.Illusioner; +import fr.moussax.blightedSMP.content.entities.powerful.Watchling; import fr.moussax.blightedSMP.engine.entities.BlightedEntity; import fr.moussax.blightedSMP.registry.RegistryModule; @@ -22,7 +24,6 @@ public void register(Consumer registry) { registry.accept(new BlightswornWitherSkeleton()); registry.accept(new BlightswornZombie()); registry.accept(new BlightswornZombifiedPiglin()); - registry.accept(new CorruptedChampion()); registry.accept(new Endersent()); registry.accept(new Watchling()); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/bosses/CorruptedChampion.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/bosses/CorruptedChampion.java index 4b2cefbb..66ec294b 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/bosses/CorruptedChampion.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/bosses/CorruptedChampion.java @@ -1,14 +1,13 @@ package fr.moussax.blightedSMP.content.entities.bosses; +import fr.moussax.bedrock.utils.ItemBuilder; +import fr.moussax.bedrock.utils.debug.Log; import fr.moussax.blightedSMP.BlightedSMP; import fr.moussax.blightedSMP.engine.entities.BlightedEntity; import fr.moussax.blightedSMP.engine.entities.defense.DamageType; import fr.moussax.blightedSMP.engine.entities.defense.EntityImmunities; import fr.moussax.blightedSMP.engine.entities.defense.EntityResistance; -import fr.moussax.blightedSMP.engine.entities.defense.EntityResistances; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; -import fr.moussax.bedrock.utils.ItemBuilder; -import fr.moussax.bedrock.utils.debug.Log; import org.bukkit.*; import org.bukkit.attribute.Attribute; import org.bukkit.attribute.AttributeInstance; @@ -25,13 +24,14 @@ import org.bukkit.scheduler.BukkitRunnable; import org.bukkit.util.Vector; -import java.util.*; +import java.util.ArrayList; +import java.util.Comparator; +import java.util.List; +import java.util.Objects; import java.util.concurrent.CopyOnWriteArrayList; @EntityImmunities({DamageType.FALL, DamageType.MACE, DamageType.PROJECTILE}) -@EntityResistances({ - @EntityResistance(type = DamageType.MAGIC, percent = 75.0), -}) +@EntityResistance(type = DamageType.MAGIC, percent = 75.0) public class CorruptedChampion extends BlightedEntity { private static final int MELEE_DAMAGE = 28; @@ -47,7 +47,7 @@ public class CorruptedChampion extends BlightedEntity { private static final Particle.DustOptions VOID_PURPLE = new Particle.DustOptions(Color.fromRGB(150, 40, 240), 1.2f); private static final Particle.DustOptions CHAMPION_GOLD = new Particle.DustOptions(Color.fromRGB(255, 200, 30), 1.5f); - private final List activeStabs = new CopyOnWriteArrayList<>(); + private List activeStabs = new CopyOnWriteArrayList<>(); private int currentPhase = 1; public CorruptedChampion() { @@ -257,7 +257,7 @@ private void stabTargetPlayers() { return; } - BlightedPlayer blightedTarget = BlightedPlayer.getBlightedPlayer(target); + BlightedPlayer blightedTarget = BlightedPlayer.get(target); if (blightedTarget == null) { return; } @@ -778,13 +778,7 @@ public String getEntityId() { @Override public CorruptedChampion clone() { CorruptedChampion clone = (CorruptedChampion) super.clone(); - try { - var activeStabsField = CorruptedChampion.class.getDeclaredField("activeStabs"); - activeStabsField.setAccessible(true); - activeStabsField.set(clone, new CopyOnWriteArrayList<>()); - } catch (Exception e) { - throw new RuntimeException("Failed to clone sword lists", e); - } + clone.activeStabs = new CopyOnWriteArrayList<>(); return clone; } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornBogged.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornBogged.java index d6eccf00..91e70f1a 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornBogged.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornBogged.java @@ -26,18 +26,17 @@ public BlightswornBogged() { setDroppedExp(12); itemInMainHand = new ItemStack(Material.BOW); setLootTable(new EntityLootTableBuilder() - .addLoot(Material.BONE, 2, 4, 1.0, COMMON) - .addLoot(Material.ARROW, 2, 5, 1.0, COMMON) + .addLoot(Material.BONE, 2, 4, 1.0) + .addLoot(Material.ARROW, 2, 5, 1.0) .addLoot(Material.TIPPED_ARROW, builder -> builder.setItemMeta( meta -> ((PotionMeta) meta).setBasePotionType(PotionType.POISON)), 1, 3, - 0.4, - UNCOMMON + 0.4 ) - .addDamagedLoot(Material.BOW, 0.10, 0.75, 0.15, RARE) - .addGemsLoot(5, 0.04, VERY_RARE) + .addDamagedItem(Material.BOW, 0.10, 0.75, 0.15, RARE) + .addGems(5, 0.04, VERY_RARE) .build()); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornDrowned.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornDrowned.java index b5144fcc..d51c9826 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornDrowned.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornDrowned.java @@ -37,11 +37,11 @@ public BlightswornDrowned() { setDamage(6); setDroppedExp(10); setLootTable(new EntityLootTableBuilder() - .addLoot(Material.ROTTEN_FLESH, 2, 5, 1.0, COMMON) - .addLoot(Material.COPPER_INGOT, 1, 3, 0.4, UNCOMMON) - .addLoot(Material.NAUTILUS_SHELL, 1, 0.08, RARE) - .addDamagedLoot(Material.TRIDENT, 0.05, 0.80, 0.02, VERY_RARE) - .addGemsLoot(5, 0.04, VERY_RARE) + .addLoot(Material.ROTTEN_FLESH, 2, 5, 1.0) + .addLoot(Material.COPPER_INGOT, 1, 3, 0.4) + .addLoot(Material.NAUTILUS_SHELL, 0.08, RARE) + .addDamagedItem(Material.TRIDENT, 0.05, 0.80, 0.02, VERY_RARE) + .addGems(5, 0.04, VERY_RARE) .build() ); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornHusk.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornHusk.java index 05200ce2..1a977e00 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornHusk.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornHusk.java @@ -19,10 +19,10 @@ public BlightswornHusk() { setDamage(6); setDroppedExp(12); setLootTable(new EntityLootTableBuilder() - .addLoot(Material.ROTTEN_FLESH, 2, 5, 1.0, COMMON) - .addLoot(Material.SAND, 1, 3, 0.3, UNCOMMON) + .addLoot(Material.ROTTEN_FLESH, 2, 5, 1.0) + .addLoot(Material.SAND, 1, 3, 0.3) .addLoot(Material.IRON_INGOT, 1, 2, 0.1, RARE) - .addGemsLoot(5, 0.04, VERY_RARE) + .addGems(5, 0.04, VERY_RARE) .build() ); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornParched.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornParched.java index 704038c1..82bf55f5 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornParched.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornParched.java @@ -24,10 +24,10 @@ public BlightswornParched() { setDamage(6); setDroppedExp(12); setLootTable(new EntityLootTableBuilder() - .addLoot(Material.BONE, 2, 5, 1.0, COMMON) - .addLoot(Material.ARROW, 2, 5, 1.0, COMMON) - .addDamagedLoot(Material.BOW, 0.10, 0.75, 0.15, RARE) - .addGemsLoot(5, 0.04, VERY_RARE) + .addLoot(Material.BONE, 2, 5, 1.0) + .addLoot(Material.ARROW, 2, 5, 1.0) + .addDamagedItem(Material.BOW, 0.10, 0.75, 0.15, RARE) + .addGems(5, 0.04, VERY_RARE) .build() ); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornPiglin.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornPiglin.java index 9050e8bf..59923163 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornPiglin.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornPiglin.java @@ -26,10 +26,10 @@ public BlightswornPiglin() { super("BLIGHTSWORN_PIGLIN", "Blightsworn Piglin", EntityType.PIGLIN); itemInMainHand = new ItemStack(Material.GOLDEN_SWORD); setLootTable(new EntityLootTableBuilder() - .addLoot(Material.GOLD_NUGGET, 2, 6, 1.0, COMMON) - .addLoot(Material.GOLD_INGOT, 1, 3, 0.4, UNCOMMON) - .addDamagedLoot(Material.CROSSBOW, 0.10, 0.80, 0.1, RARE) - .addGemsLoot(5, 0.04, VERY_RARE) + .addLoot(Material.GOLD_NUGGET, 2, 6, 1.0) + .addLoot(Material.GOLD_INGOT, 1, 3, 0.4) + .addDamagedItem(Material.CROSSBOW, 0.10, 0.80, 0.1, RARE) + .addGems(5, 0.04, VERY_RARE) .build() ); setDamage(8); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornSkeleton.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornSkeleton.java index ce5f09b5..5034ec0e 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornSkeleton.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornSkeleton.java @@ -24,10 +24,10 @@ public BlightswornSkeleton() { setDamage(6); setDroppedExp(12); setLootTable(new EntityLootTableBuilder() - .addLoot(Material.BONE, 2, 5, 1.0, COMMON) - .addLoot(Material.ARROW, 2, 5, 1.0, COMMON) - .addDamagedLoot(Material.BOW, 0.1, 0.8, 0.15, RARE) - .addGemsLoot(5, 0.04, VERY_RARE) + .addLoot(Material.BONE, 2, 5, 1.0) + .addLoot(Material.ARROW, 2, 5, 1.0) + .addDamagedItem(Material.BOW, 0.1, 0.8, 0.15, RARE) + .addGems(5, 0.04, VERY_RARE) .build() ); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornStray.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornStray.java index 4988c5d7..932b8f5f 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornStray.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornStray.java @@ -20,18 +20,17 @@ public BlightswornStray() { setDamage(6); setDroppedExp(12); setLootTable(new EntityLootTableBuilder() - .setMaxDrop(4) - .addLoot(Material.BONE, 2, 5, 1.0, COMMON) - .addLoot(Material.ARROW, 2, 5, 1.0, COMMON) + .maxDrops(4) + .addLoot(Material.BONE, 2, 5, 1.0) + .addLoot(Material.ARROW, 2, 5, 1.0) .addLoot(Material.TIPPED_ARROW, builder -> builder.setItemMeta( meta -> ((PotionMeta) meta).setBasePotionType(PotionType.SLOWNESS) ), 1, 3, - 0.4, - UNCOMMON + 0.4 ) - .addGemsLoot(5, 0.04, VERY_RARE) + .addGems(5, 0.04, VERY_RARE) .build() ); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornWitherSkeleton.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornWitherSkeleton.java index 86937edc..4a48cade 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornWitherSkeleton.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornWitherSkeleton.java @@ -25,11 +25,11 @@ public final class BlightswornWitherSkeleton extends BlightswornEliteArchetype { public BlightswornWitherSkeleton() { super("BLIGHTSWORN_WITHER_SKELETON", "Blightsworn Wither Skeleton", EntityType.WITHER_SKELETON); setLootTable(new EntityLootTableBuilder() - .setMaxDrop(4) - .addLoot(Material.BONE, 2, 5, 1.0, COMMON) - .addLoot(Material.COAL, 1, 3, 0.5, UNCOMMON) - .addLoot(Material.WITHER_SKELETON_SKULL, 1, 0.03, VERY_RARE) - .addGemsLoot(5, 0.04, VERY_RARE) + .maxDrops(4) + .addLoot(Material.BONE, 2, 5, 1.0) + .addLoot(Material.COAL, 1, 3, 0.5) + .addLoot(Material.WITHER_SKELETON_SKULL, 0.03, VERY_RARE) + .addGems(5, 0.04, VERY_RARE) .build() ); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornZombie.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornZombie.java index 0b1be581..3b1bbaf6 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornZombie.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornZombie.java @@ -16,12 +16,12 @@ public BlightswornZombie() { setDamage(6); setDroppedExp(12); setLootTable(new EntityLootTableBuilder() - .setMaxDrop(3) - .addLoot(Material.ROTTEN_FLESH, 1, 2, 1.0, COMMON) - .addLoot(Material.POTATO, 1, 0.025, UNCOMMON) - .addLoot(Material.CARROT, 1, 0.025, UNCOMMON) - .addLoot(Material.IRON_INGOT, 1, 0.02, RARE) - .addGemsLoot(2, 0.01, VERY_RARE) + .maxDrops(3) + .addLoot(Material.ROTTEN_FLESH, 1, 2, 1.0) + .addLoot(Material.POTATO, 0.025) + .addLoot(Material.CARROT, 0.025) + .addLoot(Material.IRON_INGOT, 0.02, RARE) + .addGems(2, 0.01, VERY_RARE) .build() ); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornZombifiedPiglin.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornZombifiedPiglin.java index 715ab7ca..30a4e971 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornZombifiedPiglin.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/blightsworn/BlightswornZombifiedPiglin.java @@ -26,11 +26,11 @@ public BlightswornZombifiedPiglin() { setDamage(8); setDroppedExp(16); setLootTable(new EntityLootTableBuilder() - .setMaxDrop(3) - .addLoot(Material.ROTTEN_FLESH, 2, 6, 1.0, COMMON) - .addLoot(Material.GOLD_NUGGET, 2, 6, 1.0, COMMON) + .maxDrops(3) + .addLoot(Material.ROTTEN_FLESH, 2, 6, 1.0) + .addLoot(Material.GOLD_NUGGET, 2, 6, 1.0) .addLoot(Material.GOLD_INGOT, 1, 2, 0.15, RARE) - .addGemsLoot(5, 0.04, VERY_RARE) + .addGems(5, 0.04, VERY_RARE) .build() ); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/celestial/CelestialCreature.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/celestial/CelestialCreature.java index 62f6e59f..7579fd35 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/celestial/CelestialCreature.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/celestial/CelestialCreature.java @@ -1,4 +1,22 @@ package fr.moussax.blightedSMP.content.entities.factions.celestial; -public abstract class CelestialCreature { +import fr.moussax.blightedSMP.engine.entities.spawnable.SpawnableEntity; +import org.bukkit.Location; +import org.bukkit.entity.EntityType; +import org.bukkit.entity.LivingEntity; +import org.bukkit.potion.PotionEffect; +import org.bukkit.potion.PotionEffectType; + +public abstract class CelestialCreature extends SpawnableEntity { + protected CelestialCreature(String entityId, String name, int maxHealth, EntityType entityType, double probability) { + super(entityId, name, maxHealth, entityType, probability); + } + + @Override + public LivingEntity spawn(Location location) { + LivingEntity entity = super.spawn(location); + entity.addPotionEffect(new PotionEffect(PotionEffectType.GLOWING, PotionEffect.INFINITE_DURATION, 1)); + entity.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, PotionEffect.INFINITE_DURATION, 1)); + return entity; + } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/celestial/CelestialEnderman.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/celestial/CelestialEnderman.java index 58e3287a..b6c0d36f 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/celestial/CelestialEnderman.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/factions/celestial/CelestialEnderman.java @@ -1,4 +1,5 @@ package fr.moussax.blightedSMP.content.entities.factions.celestial; + public class CelestialEnderman { } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Endersent.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Endersent.java index 6e1d3148..ecf4d69a 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Endersent.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Endersent.java @@ -40,11 +40,11 @@ public Endersent() { addAttribute(Attribute.MOVEMENT_SPEED, 0.25); setLootTable(new EntityLootTableBuilder() - .setMaxDrop(2) - .addLoot(Material.ENDER_PEARL, 4, 8, 1.0, COMMON) - .addLoot(Material.ENDER_EYE, 1, 3, 0.31, UNCOMMON) + .maxDrops(2) + .addLoot(Material.ENDER_PEARL, 4, 8, 1.0) + .addLoot(Material.ENDER_EYE, 1, 3, 0.31) .addLoot("ENCHANTED_ENDER_PEARL", 1, 4, 0.11, RARE) - .addGemsLoot(30, 0.03, VERY_RARE) + .addGems(30, 0.03, VERY_RARE) .build() ); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Illusioner.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Illusioner.java index 22582aca..a4b8a84e 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Illusioner.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Illusioner.java @@ -1,4 +1,4 @@ -package fr.moussax.blightedSMP.content.entities; +package fr.moussax.blightedSMP.content.entities.powerful; import fr.moussax.blightedSMP.engine.entities.EntityLootTableBuilder; import fr.moussax.blightedSMP.engine.entities.components.impl.ShieldComponent; @@ -17,16 +17,16 @@ public Illusioner() { setDamage(12); this.lootTable = new EntityLootTableBuilder() - .addLoot(Material.SPECTRAL_ARROW, 4, 12, 0.6, EntityLootRarity.COMMON) - .addLoot(Material.GLASS_BOTTLE, 1, 2, 0.4, EntityLootRarity.COMMON) - .addLoot(Material.TOTEM_OF_UNDYING, 1, 0.02, EntityLootRarity.VERY_RARE) - .addLoot(Material.OMINOUS_BOTTLE, 1, 0.15, EntityLootRarity.UNCOMMON) - .addGemsLoot(12, 0.25, EntityLootRarity.UNCOMMON) - .addEnchantedBookLoot( + .maxDrops(4) + .addLoot(Material.SPECTRAL_ARROW, 4, 12, 0.6) + .addLoot(Material.GLASS_BOTTLE, 1, 2, 0.4) + .addLoot(Material.TOTEM_OF_UNDYING, 0.02, EntityLootRarity.VERY_RARE) + .addLoot(Material.OMINOUS_BOTTLE, 0.15) + .addGems(12, 0.25) + .addEnchantedBook( List.of(Enchantment.QUICK_CHARGE, Enchantment.PIERCING, Enchantment.POWER), 1, 7, 0.07, EntityLootRarity.RARE ) - .setMaxDrop(4) .build(); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Watchling.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Watchling.java index 5474c9ba..69af090b 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Watchling.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/entities/powerful/Watchling.java @@ -1,4 +1,4 @@ -package fr.moussax.blightedSMP.content.entities; +package fr.moussax.blightedSMP.content.entities.powerful; import fr.moussax.blightedSMP.content.utils.ai.EndermanAI; import fr.moussax.blightedSMP.engine.entities.EntityLootTableBuilder; @@ -34,9 +34,9 @@ public Watchling() { setDroppedExp(10); setLootTable(new EntityLootTableBuilder() - .setMaxDrop(2) - .addLoot(Material.ENDER_PEARL, 1, 2, 1.0, COMMON) - .addGemsLoot(5, 0.03, VERY_RARE) + .maxDrops(2) + .addLoot(Material.ENDER_PEARL, 1, 2, 1.0) + .addGems(5, 0.03, VERY_RARE) .build() ); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityLootTableBuilder.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityLootTableBuilder.java index 5da0b4dc..ccd2278e 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityLootTableBuilder.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityLootTableBuilder.java @@ -1,5 +1,7 @@ package fr.moussax.blightedSMP.engine.entities; +import fr.moussax.bedrock.utils.ItemBuilder; +import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.loot.LootCondition; import fr.moussax.blightedSMP.engine.loot.LootEntry; import fr.moussax.blightedSMP.engine.loot.LootTable; @@ -10,7 +12,6 @@ import fr.moussax.blightedSMP.engine.loot.results.ItemResult; import fr.moussax.blightedSMP.engine.loot.results.gems.GemsResult; import fr.moussax.blightedSMP.engine.loot.strategies.LootingAwareProbabilisticStrategy; -import fr.moussax.bedrock.utils.ItemBuilder; import org.bukkit.Material; import org.bukkit.Sound; import org.bukkit.enchantments.Enchantment; @@ -44,31 +45,164 @@ public final class EntityLootTableBuilder { private int maxDrops = 3; /** - * Adds a registered item loot entry with a variable quantity range. + * Adds custom blighted item drop with fixed quantity of 1. + * + * @param item custom blighted item + * @param dropChance selection probability (0.0 to 1.0) + * @return this builder + */ + public EntityLootTableBuilder addLoot(BlightedItem item, double dropChance) { + if (item == null) return this; + return addLoot( + item.getItemId(), + 1, + 1, + dropChance, + EntityLootRarity.COMMON, + LootCondition.alwaysTrue() + ); + } + + /** + * Adds custom blighted item drop with fixed quantity of 1 and rarity feedback. + * + * @param item custom blighted item + * @param dropChance selection probability (0.0 to 1.0) + * @param rarity rarity tier for feedback + * @return this builder + */ + public EntityLootTableBuilder addLoot(BlightedItem item, double dropChance, EntityLootRarity rarity) { + if (item == null) return this; + return addLoot(item.getItemId(), 1, 1, dropChance, rarity, LootCondition.alwaysTrue()); + } + + /** + * Adds custom blighted item drop with quantity range. + * + * @param item custom blighted item + * @param minAmount minimum drop quantity + * @param maximumAmount maximum drop quantity + * @param dropChance selection probability (0.0 to 1.0) + * @return this builder + */ + public EntityLootTableBuilder addLoot(BlightedItem item, int minAmount, int maximumAmount, double dropChance) { + if (item == null) return this; + return addLoot(item.getItemId(), minAmount, maximumAmount, dropChance, EntityLootRarity.COMMON, LootCondition.alwaysTrue()); + } + + /** + * Adds custom blighted item drop with quantity range and rarity feedback. + * + * @param item custom blighted item + * @param minimumAmount minimum drop quantity + * @param maximumAmount maximum drop quantity + * @param dropChance selection probability (0.0 to 1.0) + * @param rarity rarity tier for feedback + * @return this builder + */ + public EntityLootTableBuilder addLoot(BlightedItem item, int minimumAmount, int maximumAmount, double dropChance, EntityLootRarity rarity) { + if (item == null) return this; + return addLoot(item.getItemId(), minimumAmount, maximumAmount, dropChance, rarity, LootCondition.alwaysTrue()); + } + + /** + * Adds custom blighted item drop with quantity range, rarity feedback, and eligibility condition. * - * @param itemId registry ID of the item + * @param item custom blighted item * @param minimumAmount minimum drop quantity * @param maximumAmount maximum drop quantity * @param dropChance selection probability (0.0 to 1.0) * @param rarity rarity tier for feedback + * @param condition eligibility condition + * @return this builder + */ + public EntityLootTableBuilder addLoot( + BlightedItem item, + int minimumAmount, + int maximumAmount, + double dropChance, + EntityLootRarity rarity, + LootCondition condition + ) { + if (item == null) return this; + return addLoot(item.getItemId(), minimumAmount, maximumAmount, dropChance, rarity, condition); + } + + /** + * Adds registered item drop with fixed quantity of 1. + * + * @param itemId registered item identifier + * @param dropChance selection probability (0.0 to 1.0) + * @return this builder + */ + public EntityLootTableBuilder addLoot(String itemId, double dropChance) { + return addLoot(itemId, 1, 1, dropChance, EntityLootRarity.COMMON, LootCondition.alwaysTrue()); + } + + /** + * Adds registered item drop with fixed quantity of 1 and rarity feedback. + * + * @param itemId registered item identifier + * @param dropChance selection probability (0.0 to 1.0) + * @param rarity rarity tier for feedback * @return this builder */ - public EntityLootTableBuilder addLoot(String itemId, int minimumAmount, int maximumAmount, double dropChance, EntityLootRarity rarity) { + public EntityLootTableBuilder addLoot(String itemId, double dropChance, EntityLootRarity rarity) { + return addLoot(itemId, 1, 1, dropChance, rarity, LootCondition.alwaysTrue()); + } + + /** + * Adds registered item drop with quantity range. + * + * @param itemId registered item identifier + * @param minimumAmount minimum drop quantity + * @param maximumAmount maximum drop quantity + * @param dropChance selection probability (0.0 to 1.0) + * @return this builder + */ + public EntityLootTableBuilder addLoot(String itemId, int minimumAmount, int maximumAmount, double dropChance) { + return addLoot(itemId, minimumAmount, maximumAmount, dropChance, EntityLootRarity.COMMON, LootCondition.alwaysTrue()); + } + + /** + * Adds registered item drop with quantity range and rarity feedback. + * + * @param itemId registered item identifier + * @param minimumAmount minimum drop quantity + * @param maximumAmount maximum drop quantity + * @param dropChance selection probability (0.0 to 1.0) + * @param rarity rarity tier for feedback + * @return this builder + */ + public EntityLootTableBuilder addLoot( + String itemId, + int minimumAmount, + int maximumAmount, + double dropChance, + EntityLootRarity rarity + ) { return addLoot(itemId, minimumAmount, maximumAmount, dropChance, rarity, LootCondition.alwaysTrue()); } /** - * Adds a registered item loot entry with a variable quantity range and selection condition. + * Adds registered item drop with quantity range, rarity feedback, and eligibility condition. * - * @param itemId registry ID of the item + * @param itemId registered item identifier * @param minimumAmount minimum drop quantity * @param maximumAmount maximum drop quantity * @param dropChance selection probability (0.0 to 1.0) * @param rarity rarity tier for feedback - * @param condition condition required for eligibility + * @param condition eligibility condition * @return this builder */ - public EntityLootTableBuilder addLoot(String itemId, int minimumAmount, int maximumAmount, double dropChance, EntityLootRarity rarity, LootCondition condition) { + public EntityLootTableBuilder addLoot( + String itemId, + int minimumAmount, + int maximumAmount, + double dropChance, + EntityLootRarity rarity, + LootCondition condition + ) { builder.addEntry( LootEntry.probabilistic( new GenericFeedbackDecorator<>( @@ -83,58 +217,85 @@ public EntityLootTableBuilder addLoot(String itemId, int minimumAmount, int maxi } /** - * Adds a registered item loot entry with a fixed quantity. + * Adds vanilla material item drop with fixed quantity of 1. * - * @param itemId registry ID of the item - * @param amount drop quantity + * @param material item material * @param dropChance selection probability (0.0 to 1.0) - * @param rarity rarity tier for feedback * @return this builder */ - public EntityLootTableBuilder addLoot(String itemId, int amount, double dropChance, EntityLootRarity rarity) { - return addLoot(itemId, amount, amount, dropChance, rarity, LootCondition.alwaysTrue()); + public EntityLootTableBuilder addLoot(Material material, double dropChance) { + return addLoot(material, 1, 1, dropChance, EntityLootRarity.COMMON, LootCondition.alwaysTrue()); } /** - * Adds a registered item loot entry with a fixed quantity and selection condition. + * Adds vanilla material item drop with fixed quantity of 1 and rarity feedback. * - * @param itemId registry ID of the item - * @param amount drop quantity + * @param material item material * @param dropChance selection probability (0.0 to 1.0) * @param rarity rarity tier for feedback - * @param condition condition required for eligibility * @return this builder */ - public EntityLootTableBuilder addLoot(String itemId, int amount, double dropChance, EntityLootRarity rarity, LootCondition condition) { - return addLoot(itemId, amount, amount, dropChance, rarity, condition); + public EntityLootTableBuilder addLoot(Material material, double dropChance, EntityLootRarity rarity) { + return addLoot(material, 1, 1, dropChance, rarity, LootCondition.alwaysTrue()); } /** - * Adds a material item loot entry with a variable quantity range. + * Adds vanilla material item drop with quantity range. * - * @param material material to drop + * @param material item material + * @param minimumAmount minimum drop quantity + * @param maximumAmount maximum drop quantity + * @param dropChance selection probability (0.0 to 1.0) + * @return this builder + */ + public EntityLootTableBuilder addLoot( + Material material, + int minimumAmount, + int maximumAmount, + double dropChance + ) { + return addLoot(material, minimumAmount, maximumAmount, dropChance, EntityLootRarity.COMMON, LootCondition.alwaysTrue()); + } + + /** + * Adds vanilla material item drop with quantity range and rarity feedback. + * + * @param material item material * @param minimumAmount minimum drop quantity * @param maximumAmount maximum drop quantity * @param dropChance selection probability (0.0 to 1.0) * @param rarity rarity tier for feedback * @return this builder */ - public EntityLootTableBuilder addLoot(Material material, int minimumAmount, int maximumAmount, double dropChance, EntityLootRarity rarity) { + public EntityLootTableBuilder addLoot( + Material material, + int minimumAmount, + int maximumAmount, + double dropChance, + EntityLootRarity rarity + ) { return addLoot(material, minimumAmount, maximumAmount, dropChance, rarity, LootCondition.alwaysTrue()); } /** - * Adds a material item loot entry with a variable quantity range and selection condition. + * Adds vanilla material item drop with quantity range, rarity feedback, and eligibility condition. * - * @param material material to drop + * @param material item material * @param minimumAmount minimum drop quantity * @param maximumAmount maximum drop quantity * @param dropChance selection probability (0.0 to 1.0) * @param rarity rarity tier for feedback - * @param condition condition required for eligibility + * @param condition eligibility condition * @return this builder */ - public EntityLootTableBuilder addLoot(Material material, int minimumAmount, int maximumAmount, double dropChance, EntityLootRarity rarity, LootCondition condition) { + public EntityLootTableBuilder addLoot( + Material material, + int minimumAmount, + int maximumAmount, + double dropChance, + EntityLootRarity rarity, + LootCondition condition + ) { builder.addEntry( LootEntry.probabilistic( new GenericFeedbackDecorator<>( @@ -149,60 +310,98 @@ public EntityLootTableBuilder addLoot(Material material, int minimumAmount, int } /** - * Adds a material item loot entry with a fixed quantity. + * Adds modified material item drop with fixed quantity of 1. * - * @param material material to drop - * @param amount drop quantity + * @param material item material + * @param modifier item builder modification function * @param dropChance selection probability (0.0 to 1.0) - * @param rarity rarity tier for feedback * @return this builder */ - public EntityLootTableBuilder addLoot(Material material, int amount, double dropChance, EntityLootRarity rarity) { - return addLoot(material, amount, amount, dropChance, rarity, LootCondition.alwaysTrue()); + public EntityLootTableBuilder addLoot(Material material, Consumer modifier, double dropChance) { + return addLoot(material, modifier, 1, 1, dropChance, EntityLootRarity.COMMON, LootCondition.alwaysTrue()); } /** - * Adds a material item loot entry with a fixed quantity and selection condition. + * Adds modified material item drop with fixed quantity of 1 and rarity feedback. * - * @param material material to drop - * @param amount drop quantity + * @param material item material + * @param modifier item builder modification function * @param dropChance selection probability (0.0 to 1.0) * @param rarity rarity tier for feedback - * @param condition condition required for eligibility * @return this builder */ - public EntityLootTableBuilder addLoot(Material material, int amount, double dropChance, EntityLootRarity rarity, LootCondition condition) { - return addLoot(material, amount, amount, dropChance, rarity, condition); + public EntityLootTableBuilder addLoot( + Material material, + Consumer modifier, + double dropChance, + EntityLootRarity rarity + ) { + return addLoot(material, modifier, 1, 1, dropChance, rarity, LootCondition.alwaysTrue()); + } + + /** + * Adds modified material item drop with quantity range. + * + * @param material item material + * @param modifier item builder modification function + * @param minimumAmount minimum drop quantity + * @param maximumAmount maximum drop quantity + * @param dropChance selection probability (0.0 to 1.0) + * @return this builder + */ + public EntityLootTableBuilder addLoot( + Material material, + Consumer modifier, + int minimumAmount, + int maximumAmount, + double dropChance + ) { + return addLoot(material, modifier, minimumAmount, maximumAmount, dropChance, EntityLootRarity.COMMON, LootCondition.alwaysTrue()); } /** - * Adds a modified material item loot entry with a variable quantity range. + * Adds modified material item drop with quantity range and rarity feedback. * - * @param material material to drop - * @param modifier function to modify the item builder + * @param material item material + * @param modifier item builder modification function * @param minimumAmount minimum drop quantity * @param maximumAmount maximum drop quantity * @param dropChance selection probability (0.0 to 1.0) * @param rarity rarity tier for feedback * @return this builder */ - public EntityLootTableBuilder addLoot(Material material, Consumer modifier, int minimumAmount, int maximumAmount, double dropChance, EntityLootRarity rarity) { + public EntityLootTableBuilder addLoot( + Material material, + Consumer modifier, + int minimumAmount, + int maximumAmount, + double dropChance, + EntityLootRarity rarity + ) { return addLoot(material, modifier, minimumAmount, maximumAmount, dropChance, rarity, LootCondition.alwaysTrue()); } /** - * Adds a modified material item loot entry with a variable quantity range and selection condition. + * Adds modified material item drop with quantity range, rarity feedback, and eligibility condition. * - * @param material material to drop - * @param modifier function to modify the item builder + * @param material item material + * @param modifier item builder modification function * @param minimumAmount minimum drop quantity * @param maximumAmount maximum drop quantity * @param dropChance selection probability (0.0 to 1.0) * @param rarity rarity tier for feedback - * @param condition condition required for eligibility + * @param condition eligibility condition * @return this builder */ - public EntityLootTableBuilder addLoot(Material material, Consumer modifier, int minimumAmount, int maximumAmount, double dropChance, EntityLootRarity rarity, LootCondition condition) { + public EntityLootTableBuilder addLoot( + Material material, + Consumer modifier, + int minimumAmount, + int maximumAmount, + double dropChance, + EntityLootRarity rarity, + LootCondition condition + ) { builder.addEntry( LootEntry.probabilistic( new GenericFeedbackDecorator<>( @@ -217,43 +416,29 @@ public EntityLootTableBuilder addLoot(Material material, Consumer m } /** - * Adds a modified material item loot entry with a fixed quantity. + * Adds enchanted book drop selected from an enchantment map pool. * - * @param material material to drop - * @param modifier function to modify the item builder - * @param amount drop quantity - * @param dropChance selection probability (0.0 to 1.0) - * @param rarity rarity tier for feedback - * @return this builder - */ - public EntityLootTableBuilder addLoot(Material material, Consumer modifier, int amount, double dropChance, EntityLootRarity rarity) { - return addLoot(material, modifier, amount, amount, dropChance, rarity, LootCondition.alwaysTrue()); - } - - /** - * Adds a modified material item loot entry with a fixed quantity and selection condition. - * - * @param material material to drop - * @param modifier function to modify the item builder - * @param amount drop quantity - * @param dropChance selection probability (0.0 to 1.0) - * @param rarity rarity tier for feedback - * @param condition condition required for eligibility + * @param enchantmentPool map of candidate enchantments to levels + * @param dropChance selection probability (0.0 to 1.0) * @return this builder */ - public EntityLootTableBuilder addLoot(Material material, Consumer modifier, int amount, double dropChance, EntityLootRarity rarity, LootCondition condition) { - return addLoot(material, modifier, amount, amount, dropChance, rarity, condition); + public EntityLootTableBuilder addEnchantedBook(Map enchantmentPool, double dropChance) { + return addEnchantedBook(enchantmentPool, dropChance, EntityLootRarity.COMMON); } /** - * Adds an enchanted book loot entry where the enchantment and level are selected from a pool. + * Adds enchanted book drop selected from an enchantment map pool with rarity feedback. * - * @param enchantmentPool map of enchantments to levels + * @param enchantmentPool map of candidate enchantments to levels * @param dropChance selection probability (0.0 to 1.0) * @param rarity rarity tier for feedback * @return this builder */ - public EntityLootTableBuilder addEnchantedBookLoot(Map enchantmentPool, double dropChance, EntityLootRarity rarity) { + public EntityLootTableBuilder addEnchantedBook( + Map enchantmentPool, + double dropChance, + EntityLootRarity rarity + ) { builder.addEntry( LootEntry.probabilistic( new GenericFeedbackDecorator<>( @@ -268,7 +453,25 @@ public EntityLootTableBuilder addEnchantedBookLoot(Map enc } /** - * Adds an enchanted book loot entry with a level range selected from candidate enchantments. + * Adds enchanted book drop with level range selected from candidate enchantments. + * + * @param enchantments list of candidate enchantments + * @param minimumLevel minimum enchantment level + * @param maximumLevel maximum enchantment level + * @param dropChance selection probability (0.0 to 1.0) + * @return this builder + */ + public EntityLootTableBuilder addEnchantedBook( + List enchantments, + int minimumLevel, + int maximumLevel, + double dropChance + ) { + return addEnchantedBook(enchantments, minimumLevel, maximumLevel, dropChance, EntityLootRarity.COMMON); + } + + /** + * Adds enchanted book drop with level range selected from candidate enchantments with rarity feedback. * * @param enchantments list of candidate enchantments * @param minimumLevel minimum enchantment level @@ -277,7 +480,13 @@ public EntityLootTableBuilder addEnchantedBookLoot(Map enc * @param rarity rarity tier for feedback * @return this builder */ - public EntityLootTableBuilder addEnchantedBookLoot(List enchantments, int minimumLevel, int maximumLevel, double dropChance, EntityLootRarity rarity) { + public EntityLootTableBuilder addEnchantedBook( + List enchantments, + int minimumLevel, + int maximumLevel, + double dropChance, + EntityLootRarity rarity + ) { builder.addEntry( LootEntry.probabilistic( new GenericFeedbackDecorator<>( @@ -292,20 +501,48 @@ public EntityLootTableBuilder addEnchantedBookLoot(List enchantment } /** - * Adds an item loot entry whose durability is rolled within a percentage range. + * Adds item drop with durability rolled in a percentage range. * - * @param material material to drop + * @param material item material + * @param minimumPercentage minimum durability percentage + * @param maximumPercentage maximum durability percentage + * @param dropChance selection probability (0.0 to 1.0) + * @return this builder + */ + public EntityLootTableBuilder addDamagedItem( + Material material, + double minimumPercentage, + double maximumPercentage, + double dropChance + ) { + return addDamagedItem(material, minimumPercentage, maximumPercentage, dropChance, EntityLootRarity.COMMON); + } + + /** + * Adds item drop with durability rolled in a percentage range with rarity feedback. + * + * @param material item material * @param minimumPercentage minimum durability percentage * @param maximumPercentage maximum durability percentage * @param dropChance selection probability (0.0 to 1.0) * @param rarity rarity tier for feedback * @return this builder */ - public EntityLootTableBuilder addDamagedLoot(Material material, double minimumPercentage, double maximumPercentage, double dropChance, EntityLootRarity rarity) { + public EntityLootTableBuilder addDamagedItem( + Material material, + double minimumPercentage, + double maximumPercentage, + double dropChance, + EntityLootRarity rarity + ) { builder.addEntry( LootEntry.probabilistic( new GenericFeedbackDecorator<>( - ItemResult.randomDurability(material, minimumPercentage, maximumPercentage), rarity, ENTITY_FEEDBACK_MAPPER + ItemResult.randomDurability( + material, + minimumPercentage, + maximumPercentage + ), rarity, ENTITY_FEEDBACK_MAPPER ), dropChance, AmountProvider.fixed(1), @@ -316,14 +553,25 @@ public EntityLootTableBuilder addDamagedLoot(Material material, double minimumPe } /** - * Adds a gem reward loot entry. + * Adds gem reward drop. + * + * @param gems gem reward quantity + * @param dropChance selection probability (0.0 to 1.0) + * @return this builder + */ + public EntityLootTableBuilder addGems(int gems, double dropChance) { + return addGems(gems, dropChance, EntityLootRarity.COMMON); + } + + /** + * Adds gem reward drop with rarity feedback. * - * @param gems quantity of gems granted + * @param gems gem reward quantity * @param dropChance selection probability (0.0 to 1.0) * @param rarity rarity tier for feedback * @return this builder */ - public EntityLootTableBuilder addGemsLoot(int gems, double dropChance, EntityLootRarity rarity) { + public EntityLootTableBuilder addGems(int gems, double dropChance, EntityLootRarity rarity) { builder.addEntry( LootEntry.probabilistic( new GenericFeedbackDecorator<>(new GemsResult(), rarity, ENTITY_FEEDBACK_MAPPER), @@ -336,20 +584,31 @@ public EntityLootTableBuilder addGemsLoot(int gems, double dropChance, EntityLoo } /** - * Sets the maximum number of loot drops allowed per roll. + * Sets maximum number of loot drops allowed per roll. + * + * @param maxDrops maximum drop count + * @return this builder + */ + public EntityLootTableBuilder maxDrops(int maxDrops) { + this.maxDrops = maxDrops; + return this; + } + + /** + * Sets maximum number of loot drops allowed per roll. * - * @param maxDrops maximum number of drops + * @param maxDrops maximum drop count * @return this builder */ - public EntityLootTableBuilder setMaxDrop(int maxDrops) { + public EntityLootTableBuilder setMaxDrops(int maxDrops) { this.maxDrops = maxDrops; return this; } /** - * Constructs the configured {@link LootTable} instance. + * Constructs configured {@link LootTable} instance. * - * @return a new entity loot table + * @return new entity loot table */ public LootTable build() { return builder From be1a05d641a385e8339a6b0bfbbfb87398d4e4a2 Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 20:23:42 +0200 Subject: [PATCH 18/31] (1/2) refactor(entities): simplify task scheduling logic in LifecycleTaskManager --- .../engine/entities/LifecycleTaskManager.java | 57 ++++++++++--------- 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/LifecycleTaskManager.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/LifecycleTaskManager.java index a4335e51..234a6f42 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/LifecycleTaskManager.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/LifecycleTaskManager.java @@ -113,7 +113,12 @@ private static final class ScheduledTask { private BukkitTask currentTask; private BukkitRunnable currentRunnable; - private ScheduledTask(Runnable action, Supplier factory, long delayTicks, long periodTicks, boolean repeating) { + private ScheduledTask( + Runnable action, + Supplier factory, + long delayTicks, + long periodTicks, + boolean repeating) { this.action = action; this.factory = factory; this.delayTicks = delayTicks; @@ -124,38 +129,36 @@ private ScheduledTask(Runnable action, Supplier factory, long de private void schedule(LifecycleTaskManager manager) { cancel(); + var plugin = BlightedSMP.getInstance(); + if (repeating) { if (action != null) { - currentTask = Bukkit.getScheduler().runTaskTimer(BlightedSMP.getInstance(), action, delayTicks, periodTicks); + currentTask = Bukkit.getScheduler().runTaskTimer(plugin, action, delayTicks, periodTicks); } else if (factory != null) { currentRunnable = factory.get(); - currentTask = currentRunnable.runTaskTimer(BlightedSMP.getInstance(), delayTicks, periodTicks); - } - } else { - if (action != null) { - currentTask = Bukkit.getScheduler().runTaskLater(BlightedSMP.getInstance(), () -> { - try { - action.run(); - } finally { - manager.onTaskComplete(ScheduledTask.this); - } - }, delayTicks); - } else if (factory != null) { - currentRunnable = new BukkitRunnable() { - private final BukkitRunnable inner = factory.get(); - - @Override - public void run() { - try { - if (inner != null) inner.run(); - } finally { - manager.onTaskComplete(ScheduledTask.this); - } - } - }; - currentTask = currentRunnable.runTaskLater(BlightedSMP.getInstance(), delayTicks); + if (currentRunnable != null) { + currentTask = currentRunnable.runTaskTimer(plugin, delayTicks, periodTicks); + } } + return; } + + Runnable taskAction = action != null ? action : () -> { + if (factory != null) { + currentRunnable = factory.get(); + if (currentRunnable != null) { + currentRunnable.run(); + } + } + }; + + currentTask = Bukkit.getScheduler().runTaskLater(plugin, () -> { + try { + taskAction.run(); + } finally { + manager.onTaskComplete(ScheduledTask.this); + } + }, delayTicks); } private void cancel() { From 3111281c5c6e861bf93e395d81dbe9d4ed4b9d5d Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 20:23:57 +0200 Subject: [PATCH 19/31] (2/2) refactor(entities): streamline damage handling and attachment cleanup in BlightedEntitiesListener and BlightedEntity --- .../engine/entities/BlightedEntity.java | 59 ++++++++---------- .../listeners/BlightedEntitiesListener.java | 62 +++++++++---------- 2 files changed, 56 insertions(+), 65 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java index 0181ec0c..fb113cde 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java @@ -96,6 +96,7 @@ public abstract class BlightedEntity implements Cloneable { @Setter protected boolean isBoss = false; + @Getter @Setter protected boolean isPerformingAbility = false; @@ -107,6 +108,7 @@ public abstract class BlightedEntity implements Cloneable { @Getter private EntityDefenses defenses = EntityDefenses.fromClass(getClass()); + private boolean runtimeInitialized = false; private boolean componentsInitialized = false; @@ -375,6 +377,7 @@ protected final void addCoreDelayedAction(long delayTicks, Runnable action) { * @param delayTicks delay in server ticks * @param action task action */ + @SuppressWarnings("SameParameterValue") protected final void addPhaseDelayedAction(long delayTicks, Runnable action) { scheduleDelayedAction(phaseTasks, delayTicks, action); } @@ -446,9 +449,15 @@ public List getNearbyPlayers(double radius) { */ public List getNearbyPlayers(Location center, double radius) { if (!isAlive() || center == null || center.getWorld() == null) return Collections.emptyList(); - return center.getWorld().getNearbyEntities(center, radius, radius, radius, - entity -> entity instanceof Player player && player.getGameMode() == GameMode.SURVIVAL - ).stream() + return center + .getWorld() + .getNearbyEntities( + center, + radius, + radius, + radius, + entity -> entity instanceof Player player && player.getGameMode() == GameMode.SURVIVAL) + .stream() .map(entity -> (Player) entity) .toList(); } @@ -472,8 +481,7 @@ public Player getNearestPlayer(double radius) { */ public Player getNearestPlayer(Location center, double radius) { if (center == null) return null; - return getNearbyPlayers(center, radius) - .stream() + return getNearbyPlayers(center, radius).stream() .min(Comparator.comparingDouble(player -> player.getLocation().distanceSquared(center))) .orElse(null); } @@ -509,8 +517,7 @@ public List getNearbyBlightedPlayers(Location center, double rad * @return nearest BlightedMC player, or {@code null} */ public BlightedPlayer getNearestBlightedPlayer(double radius) { - Player target = getNearestPlayer(radius); - return target != null ? BlightedPlayer.get(target) : null; + return getNearestBlightedPlayer(entity != null ? entity.getLocation() : null, radius); } /** @@ -660,9 +667,9 @@ public ItemDisplay attachItemDisplay(Vector offset, Consumer config } Vector localOffset = offset != null ? offset : new Vector(0, 0, 0); Location spawnLoc = entity.getLocation().clone().add(localOffset); - ItemDisplay display = entity.getWorld().spawn(spawnLoc, ItemDisplay.class, d -> { + ItemDisplay display = entity.getWorld().spawn(spawnLoc, ItemDisplay.class, itemDisplay -> { if (configurator != null) { - configurator.accept(d); + configurator.accept(itemDisplay); } }); addAttachment(display, AttachmentRole.VISUAL, localOffset, true, false); @@ -837,14 +844,7 @@ public void syncAttachments() { continue; } - Location targetLocation = new Location( - baseLocation.getWorld(), - xPrime, - yPrime, - zPrime, - targetYaw, - targetPitch - ); + Location targetLocation = new Location(baseLocation.getWorld(), xPrime, yPrime, zPrime, targetYaw, targetPitch); attachedEntity.teleport(targetLocation); } @@ -881,18 +881,17 @@ public void killAttachments(AttachmentRole role) { return; } - for (EntityAttachment attachment : attachments) { + attachments.removeIf(attachment -> { if (attachment.role() != role) { - continue; + return false; } - Entity attachmentEntity = attachment.entity(); if (attachmentEntity != null) { EntityManager.unregisterAttachment(attachmentEntity); attachmentEntity.remove(); } - attachments.remove(attachment); - } + return true; + }); } /** @@ -1042,14 +1041,7 @@ public void dropLoot(Location location, BlightedPlayer player) { World world = Objects.requireNonNull(location.getWorld()); Biome biome = world.getBiome(location); - LootContext context = new LootContext( - player, - world, - biome, - location, - ThreadLocalRandom.current(), - null - ); + LootContext context = new LootContext(player, world, biome, location, ThreadLocalRandom.current(), null); lootTable.execute(context); } @@ -1276,13 +1268,16 @@ private void manageBossBarViewers() { double rangeSquared = BOSS_BAR_RANGE * BOSS_BAR_RANGE; for (Player player : new ArrayList<>(bossBar.getPlayers())) { - if (!player.isOnline() || player.getWorld() != world || player.getLocation().distanceSquared(entityLocation) > rangeSquared) { + if (!player.isOnline() + || player.getWorld() != world + || player.getLocation().distanceSquared(entityLocation) > rangeSquared) { bossBar.removePlayer(player); } } for (Player player : world.getPlayers()) { - if (player.getLocation().distanceSquared(entityLocation) <= rangeSquared && !bossBar.getPlayers().contains(player)) { + if (player.getLocation().distanceSquared(entityLocation) <= rangeSquared + && !bossBar.getPlayers().contains(player)) { bossBar.addPlayer(player); } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java index 0ea11df4..fb99b785 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java @@ -101,9 +101,8 @@ public void onEntityDamage(EntityDamageEvent event) { if (!target.getScoreboardTags().contains(FAST_PASS_TAG)) return; UUID entityId = target.getUniqueId(); - if (processingDamageIds.contains(entityId)) return; + if (!processingDamageIds.add(entityId)) return; - processingDamageIds.add(entityId); try { BlightedEntity owner = EntityManager.getAttachmentOwner(entityId); if (owner != null) { @@ -135,24 +134,24 @@ public void onEntityDamage(EntityDamageEvent event) { } private AttachmentRole getAttachmentRole(BlightedEntity owner, Entity attachmentEntity) { + if (attachmentEntity == null) { + return AttachmentRole.SUBORDINATE; + } + if (owner != null && owner.attachments != null) { for (EntityAttachment attachment : owner.attachments) { - if (attachment.entity() != null && attachment.entity().equals(attachmentEntity)) { + if (attachmentEntity.equals(attachment.entity())) { return attachment.role(); } } } - if (attachmentEntity != null) { - PersistentDataContainer persistentDataContainer = attachmentEntity.getPersistentDataContainer(); - if (persistentDataContainer.has(ATTACHMENT_ROLE_KEY, PersistentDataType.STRING)) { - String roleString = persistentDataContainer.get(ATTACHMENT_ROLE_KEY, PersistentDataType.STRING); - if (roleString != null) { - try { - return AttachmentRole.valueOf(roleString); - } catch (IllegalArgumentException _) { - } - } + PersistentDataContainer persistentDataContainer = attachmentEntity.getPersistentDataContainer(); + String roleString = persistentDataContainer.get(ATTACHMENT_ROLE_KEY, PersistentDataType.STRING); + if (roleString != null) { + try { + return AttachmentRole.valueOf(roleString); + } catch (IllegalArgumentException _) { } } return AttachmentRole.SUBORDINATE; @@ -160,9 +159,10 @@ private AttachmentRole getAttachmentRole(BlightedEntity owner, Entity attachment private void handleDamageDealt(EntityDamageByEntityEvent event) { Entity rawDamager = event.getDamager(); - Entity source = (rawDamager instanceof Projectile projectile && projectile.getShooter() instanceof Entity shooter) - ? shooter - : rawDamager; + Entity source = + (rawDamager instanceof Projectile projectile && projectile.getShooter() instanceof Entity shooter) + ? shooter + : rawDamager; BlightedEntity damager = getBlightedEntity(source); if (damager != null) { @@ -170,11 +170,7 @@ private void handleDamageDealt(EntityDamageByEntityEvent event) { } } - private void handleAttachmentDamage( - BlightedEntity owner, - Entity attachmentEntity, - EntityDamageEvent event - ) { + private void handleAttachmentDamage(BlightedEntity owner, Entity attachmentEntity, EntityDamageEvent event) { LivingEntity ownerEntity = owner.getEntity(); if (ownerEntity == null || ownerEntity.isDead()) { attachmentEntity.remove(); @@ -215,12 +211,16 @@ private void handleBlightedEntityDamage(BlightedEntity blighted, LivingEntity en double remainingHealth = entity.getHealth() - event.getFinalDamage(); if (remainingHealth > 0) { - Bukkit.getScheduler().runTaskLater(BlightedSMP.getInstance(), () -> { - if (entity.isValid() && !entity.isDead()) { - blighted.updateBossBar(); - blighted.evaluatePhases(entity.getHealth()); - } - }, 1L); + Bukkit.getScheduler() + .runTaskLater( + BlightedSMP.getInstance(), + () -> { + if (entity.isValid() && !entity.isDead()) { + blighted.updateBossBar(); + blighted.evaluatePhases(entity.getHealth()); + } + }, + 1L); return; } blighted.killAllAttachments(); @@ -326,9 +326,7 @@ public void onEntityDeath(EntityDeathEvent event) { blighted.cleanup(); - BlightedPlayer killer = dead.getKiller() != null - ? BlightedPlayer.get(dead.getKiller()) - : null; + BlightedPlayer killer = dead.getKiller() != null ? BlightedPlayer.get(dead.getKiller()) : null; blighted.dropLoot(dead.getLocation(), killer); blighted.onDeath(dead.getLocation()); @@ -339,9 +337,7 @@ public void onEntityDeath(EntityDeathEvent event) { @EventHandler public void onChunkLoad(ChunkLoadEvent event) { - Bukkit.getScheduler().runTaskLater( - BlightedSMP.getInstance(), () -> rehydrateChunk(event.getChunk()), 1L - ); + Bukkit.getScheduler().runTaskLater(BlightedSMP.getInstance(), () -> rehydrateChunk(event.getChunk()), 1L); } public static Collection getActiveEntities() { From 5f833493a0d49e461863b0be20a46536fc2c57b0 Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 20:44:43 +0200 Subject: [PATCH 20/31] refactor(project): improve formatting, imports, and style consistency across modules --- .../engine/entities/EntityManager.java | 7 +- .../components/impl/ShieldComponent.java | 26 ++++-- .../engine/entities/defense/DamageType.java | 24 ++++-- .../entities/defense/EntityDefenses.java | 6 +- .../entities/defense/EntityResistance.java | 6 +- .../listeners/EntityComponentListener.java | 3 +- .../entities/registry/EntitiesRegistry.java | 12 ++- .../registry/SpawnableEntitiesRegistry.java | 4 +- .../entities/rituals/AncientCreature.java | 9 +-- .../entities/rituals/AncientRitual.java | 8 +- .../entities/rituals/RitualAnimations.java | 8 +- .../rituals/menu/AncientRitualsMenu.java | 6 +- .../rituals/menu/RitualAltarMenu.java | 24 +++--- .../entities/spawnable/SpawnableEntity.java | 52 +++++++++--- .../spawnable/condition/SpawnRules.java | 6 +- .../spawnable/engine/SpawnEvaluator.java | 7 +- .../engine/fishing/FishingLootTable.java | 9 +-- .../engine/items/BlightedItem.java | 24 +++--- .../blightedSMP/engine/items/ItemType.java | 7 -- .../items/blocks/BlightedBlockListener.java | 2 +- .../crafting/builder/ShapedRecipeBuilder.java | 80 ++++++++++++++----- .../builder/ShapelessRecipeBuilder.java | 40 +++++++++- .../items/registry/menu/ItemRegistryMenu.java | 1 + .../engine/loot/results/EntityResult.java | 6 +- .../engine/loot/results/gems/GemsItem.java | 11 +++ .../LootingAwareProbabilisticStrategy.java | 2 +- .../engine/player/hud/PlayerHudManager.java | 2 - .../blightedSMP/server/BlightedServer.java | 2 +- .../blightedSMP/server/PluginFiles.java | 2 +- .../blightedSMP/server/PluginSettings.java | 4 +- 30 files changed, 261 insertions(+), 139 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityManager.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityManager.java index a7cad7f7..d6760754 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityManager.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/EntityManager.java @@ -35,7 +35,7 @@ private EntityManager() { } /** - * Initializes background orphan entity cleanup task. + * Initializes a background orphan entity cleanup task. */ public static void initialize() { Bukkit.getScheduler().runTaskTimer( @@ -62,7 +62,7 @@ public static void sweepOrphanedEntities() { } /** - * Registers active entity instance with its runtime wrapper. + * Registers an active entity instance with its runtime wrapper. * * @param entity living entity to track * @param blighted blighted entity wrapper instance @@ -246,7 +246,8 @@ public static void rehydrateChunk(Chunk chunk) { boolean syncYaw = yawByte == null || yawByte == 1; boolean syncPitch = pitchByte != null && pitchByte == 1; - owner.attachments.removeIf(a -> a.entity() != null && a.entity().getUniqueId().equals(entity.getUniqueId())); + owner.attachments.removeIf(attachment -> attachment.entity() != null + && attachment.entity().getUniqueId().equals(entity.getUniqueId())); owner.attachments.add(new EntityAttachment(entity, role, offset, syncYaw, syncPitch)); registerAttachment(entity, owner); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/components/impl/ShieldComponent.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/components/impl/ShieldComponent.java index 85ea2779..2a6e36bb 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/components/impl/ShieldComponent.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/components/impl/ShieldComponent.java @@ -16,7 +16,7 @@ /** * Directional blocking shield component for entities, blocking frontal attacks unless jump-crit. */ -public class ShieldComponent implements EntityComponent { +public final class ShieldComponent implements EntityComponent { private final double arcDegrees; private long disableUntil = 0; @@ -51,11 +51,14 @@ public void onDamageTaken(BlightedEntity owner, EntityDamageByEntityEvent event) Entity defender = event.getEntity(); Entity damager = event.getDamager(); - Entity source = (damager instanceof Projectile projectile && projectile.getShooter() instanceof Entity shooter) ? shooter : damager; + Entity source = (damager instanceof Projectile projectile && projectile.getShooter() instanceof Entity shooter) + ? shooter + : damager; Location location = defender.getLocation().add(0, 1.8, 0); if (source instanceof Player player && isAttackBlocked(defender, source)) { - if (player.getLocation().getY() > player.getLocation().getBlockY() || player.getVelocity().getY() > 0.5) { + if (player.getLocation().getY() > player.getLocation().getBlockY() + || player.getVelocity().getY() > 0.5) { disable(5000L); defender.getWorld().spawnParticle(Particle.EXPLOSION, location, 1, 0, 0, 0, 0); defender.getWorld().spawnParticle(Particle.WITCH, location, 30, 0.5, 0.5, 0.5, 0.1); @@ -67,7 +70,16 @@ public void onDamageTaken(BlightedEntity owner, EntityDamageByEntityEvent event) if (isAttackBlocked(defender, source)) { event.setCancelled(true); defender.getWorld().spawnParticle(Particle.SWEEP_ATTACK, location, 1, 0, 0, 0, 0); - defender.getWorld().spawnParticle(Particle.BLOCK_CRUMBLE, location, 20, 0.2, 0.2, 0.2, 0.1, Material.IRON_BLOCK.createBlockData()); + defender.getWorld() + .spawnParticle( + Particle.BLOCK_CRUMBLE, + location, + 20, + 0.2, + 0.2, + 0.2, + 0.1, + Material.IRON_BLOCK.createBlockData()); defender.getWorld().playSound(location, Sound.ITEM_SHIELD_BLOCK, 1.0f, 1.2f); } } @@ -86,8 +98,10 @@ public boolean isAttackBlocked(Entity defender, Entity attacker) { Location attackerLocation = attacker.getLocation(); Vector defenderDirection = defenderLocation.getDirection(); - Vector attackerDirection = attackerLocation.toVector() - .subtract(defenderLocation.toVector()).normalize(); + Vector attackerDirection = attackerLocation + .toVector() + .subtract(defenderLocation.toVector()) + .normalize(); double dotProduct = defenderDirection.dot(attackerDirection); double angle = Math.toDegrees(Math.acos(dotProduct)); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/DamageType.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/DamageType.java index 43f2a620..9f7a707f 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/DamageType.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/DamageType.java @@ -11,7 +11,9 @@ */ public enum DamageType implements EntityImmunity { - /** Immunity to fire, lava, fire tick, and campfire damage. */ + /** + * Immunity to fire, lava, fire tick, and campfire damage. + */ FIRE { @Override public boolean isImmune(LivingEntity livingEntity, EntityDamageEvent event) { @@ -22,7 +24,9 @@ public boolean isImmune(LivingEntity livingEntity, EntityDamageEvent event) { } }, - /** Immunity to direct melee and sweep attacks. */ + /** + * Immunity to direct melee and sweep attacks. + */ MELEE { @Override public boolean isImmune(LivingEntity livingEntity, EntityDamageEvent event) { @@ -31,7 +35,9 @@ public boolean isImmune(LivingEntity livingEntity, EntityDamageEvent event) { } }, - /** Immunity to ranged projectile damage. */ + /** + * Immunity to ranged projectile damage. + */ PROJECTILE { @Override public boolean isImmune(LivingEntity livingEntity, EntityDamageEvent event) { @@ -39,7 +45,9 @@ public boolean isImmune(LivingEntity livingEntity, EntityDamageEvent event) { } }, - /** Immunity to fall damage. */ + /** + * Immunity to fall damage. + */ FALL { @Override public boolean isImmune(LivingEntity livingEntity, EntityDamageEvent event) { @@ -47,7 +55,9 @@ public boolean isImmune(LivingEntity livingEntity, EntityDamageEvent event) { } }, - /** Immunity to heavy mace weapon attacks. */ + /** + * Immunity to heavy mace weapon attacks. + */ MACE { @Override public boolean isImmune(LivingEntity livingEntity, EntityDamageEvent event) { @@ -62,7 +72,9 @@ public String getImmunityMessage() { } }, - /** Immunity to magic, poison, wither, dragon breath, and sonic boom damage. */ + /** + * Immunity to magic, poison, wither, dragon breath, and sonic boom damage. + */ MAGIC { @Override public boolean isImmune(LivingEntity livingEntity, EntityDamageEvent event) { diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/EntityDefenses.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/EntityDefenses.java index d6a5406c..e935ce86 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/EntityDefenses.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/EntityDefenses.java @@ -5,11 +5,7 @@ import org.jspecify.annotations.NonNull; import org.jspecify.annotations.Nullable; -import java.util.ArrayList; -import java.util.Collections; -import java.util.EnumMap; -import java.util.List; -import java.util.Map; +import java.util.*; /** * Encapsulates damage immunities and type resistance rules for an entity. diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/EntityResistance.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/EntityResistance.java index 9ab591f8..5f320edc 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/EntityResistance.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/defense/EntityResistance.java @@ -1,10 +1,6 @@ package fr.moussax.blightedSMP.engine.entities.defense; -import java.lang.annotation.ElementType; -import java.lang.annotation.Repeatable; -import java.lang.annotation.Retention; -import java.lang.annotation.RetentionPolicy; -import java.lang.annotation.Target; +import java.lang.annotation.*; /** * Declares a single damage type resistance percentage for an entity. diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/EntityComponentListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/EntityComponentListener.java index 758a1e90..b01f6f17 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/EntityComponentListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/EntityComponentListener.java @@ -17,7 +17,8 @@ public final class EntityComponentListener implements Listener { public void onEntityDamage(EntityDamageByEntityEvent event) { Entity victim = event.getEntity(); Entity rawDamager = event.getDamager(); - Entity source = (rawDamager instanceof Projectile projectile && projectile.getShooter() instanceof Entity shooter) + Entity source = (rawDamager instanceof Projectile projectile + && projectile.getShooter() instanceof Entity shooter) ? shooter : rawDamager; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/EntitiesRegistry.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/EntitiesRegistry.java index 90a1e1f3..e0e93b1c 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/EntitiesRegistry.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/EntitiesRegistry.java @@ -74,7 +74,7 @@ public static BlightedEntity get(String entityId) { } /** - * Retrieves cloned instance of registered spawnable entity prototype by ID. + * Retrieves a cloned instance of a registered spawnable entity prototype by ID. * * @param entityId target entity identifier * @return cloned spawnable entity instance, or {@code null} if untracked or not spawnable @@ -89,25 +89,23 @@ public static SpawnableEntity getSpawnable(String entityId) { } /** - * Returns list of cloned instances of all registered entity prototypes. + * Returns a list of cloned instances of all registered entity prototypes. * * @return list of cloned entity prototypes */ public static List getAll() { - return REGISTRY.getAll().stream() - .map(BlightedEntity::clone) - .toList(); + return REGISTRY.getAll().stream().map(BlightedEntity::clone).toList(); } /** - * Returns list of cloned instances of all registered spawnable entity prototypes. + * Returns a list of cloned instances of all registered spawnable entity prototypes. * * @return list of cloned spawnable entity prototypes */ public static List getSpawnables() { return REGISTRY.getAll().stream() .filter(SpawnableEntity.class::isInstance) - .map(e -> ((SpawnableEntity) e).clone()) + .map(entity -> ((SpawnableEntity) entity).clone()) .toList(); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/SpawnableEntitiesRegistry.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/SpawnableEntitiesRegistry.java index 2ad6dd1d..7b53859a 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/SpawnableEntitiesRegistry.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/registry/SpawnableEntitiesRegistry.java @@ -14,7 +14,7 @@ private SpawnableEntitiesRegistry() { } /** - * Retrieves cloned instance of registered spawnable entity prototype by ID. + * Retrieves a cloned instance of a registered spawnable entity prototype by ID. * * @param entityId target entity identifier * @return cloned spawnable entity instance, or {@code null} if untracked or not spawnable @@ -25,7 +25,7 @@ public static SpawnableEntity get(String entityId) { } /** - * Returns list of cloned instances of all registered spawnable entity prototypes. + * Returns a list of cloned instances of all registered spawnable entity prototypes. * * @return list of cloned spawnable entity prototypes */ diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientCreature.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientCreature.java index 7ee2f74b..28ab4e4d 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientCreature.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientCreature.java @@ -1,22 +1,17 @@ package fr.moussax.blightedSMP.engine.entities.rituals; +import fr.moussax.bedrock.text.Formatter; import fr.moussax.blightedSMP.BlightedSMP; import fr.moussax.blightedSMP.content.sound.BlightedSounds; import fr.moussax.blightedSMP.engine.entities.BlightedEntity; import fr.moussax.blightedSMP.engine.entities.attachment.AttachmentRole; -import fr.moussax.bedrock.text.Formatter; import lombok.Getter; import lombok.Setter; import org.bukkit.Bukkit; import org.bukkit.Color; import org.bukkit.Location; import org.bukkit.NamespacedKey; -import org.bukkit.entity.Display; -import org.bukkit.entity.Entity; -import org.bukkit.entity.EntityType; -import org.bukkit.entity.LivingEntity; -import org.bukkit.entity.Player; -import org.bukkit.entity.TextDisplay; +import org.bukkit.entity.*; import org.bukkit.persistence.PersistentDataContainer; import org.bukkit.persistence.PersistentDataType; import org.bukkit.util.Transformation; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientRitual.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientRitual.java index 3497407f..ecd8cf0c 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientRitual.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/AncientRitual.java @@ -1,9 +1,9 @@ package fr.moussax.blightedSMP.engine.entities.rituals; +import fr.moussax.bedrock.utils.ItemBuilder; import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.items.recipes.CraftingObject; import fr.moussax.blightedSMP.engine.items.registry.ItemRegistry; -import fr.moussax.bedrock.utils.ItemBuilder; import lombok.Getter; import org.bukkit.Material; import org.bukkit.inventory.ItemStack; @@ -76,7 +76,7 @@ public static Builder of(AncientCreature creature) { /** * Configures the item displayed for this ritual. * - * @param material base material of the displayed item + * @param material base material of the displayed item * @param configure configuration applied to the item builder * @return this builder */ @@ -105,7 +105,7 @@ public Builder addOffering(CraftingObject offering) { * Adds a vanilla material as a required offering. * * @param material required material - * @param amount required amount + * @param amount required amount * @return this builder */ public Builder addOffering(Material material, int amount) { @@ -115,7 +115,7 @@ public Builder addOffering(Material material, int amount) { /** * Adds a custom item as a required offering. * - * @param item required custom item + * @param item required custom item * @param amount required amount * @return this builder */ diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/RitualAnimations.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/RitualAnimations.java index 3eef01ab..1e5fc61d 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/RitualAnimations.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/RitualAnimations.java @@ -169,11 +169,11 @@ private static void drawVoidVortexAndImplosion(Location location, int tick) { double z = radius * Math.sin(angle); double y = Math.sin((tick + i) * 0.4) * 0.8; - Location particleLoc = center.clone().add(x, y, z); - Vector inward = center.toVector().subtract(particleLoc.toVector()).normalize().multiply(0.25); + Location particleLocation = center.clone().add(x, y, z); + Vector inward = center.toVector().subtract(particleLocation.toVector()).normalize().multiply(0.25); - world.spawnParticle(Particle.PORTAL, particleLoc, 0, inward.getX(), inward.getY(), inward.getZ(), 0.8); - world.spawnParticle(Particle.SOUL_FIRE_FLAME, particleLoc, 0, inward.getX(), inward.getY(), inward.getZ(), 0.05); + world.spawnParticle(Particle.PORTAL, particleLocation, 0, inward.getX(), inward.getY(), inward.getZ(), 0.8); + world.spawnParticle(Particle.SOUL_FIRE_FLAME, particleLocation, 0, inward.getX(), inward.getY(), inward.getZ(), 0.05); } world.spawnParticle(Particle.REVERSE_PORTAL, center, 4, 0.1, 0.1, 0.1, 0.08); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/AncientRitualsMenu.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/AncientRitualsMenu.java index d26e335f..a270b937 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/AncientRitualsMenu.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/AncientRitualsMenu.java @@ -1,13 +1,13 @@ package fr.moussax.blightedSMP.engine.entities.rituals.menu; -import fr.moussax.blightedSMP.engine.entities.rituals.AncientRitual; -import fr.moussax.blightedSMP.engine.entities.rituals.registry.RitualRegistry; -import fr.moussax.blightedSMP.engine.items.recipes.CraftingObject; import fr.moussax.bedrock.text.Formatter; import fr.moussax.bedrock.ui.menu.Menu; import fr.moussax.bedrock.ui.menu.interaction.MenuElementPreset; import fr.moussax.bedrock.ui.menu.interaction.MenuItemInteraction; import fr.moussax.bedrock.utils.ItemBuilder; +import fr.moussax.blightedSMP.engine.entities.rituals.AncientRitual; +import fr.moussax.blightedSMP.engine.entities.rituals.registry.RitualRegistry; +import fr.moussax.blightedSMP.engine.items.recipes.CraftingObject; import fr.moussax.blightedSMP.utils.Utilities; import org.bukkit.ChatColor; import org.bukkit.Material; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/RitualAltarMenu.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/RitualAltarMenu.java index 68d0b02b..92800c24 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/RitualAltarMenu.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/rituals/menu/RitualAltarMenu.java @@ -1,24 +1,24 @@ package fr.moussax.blightedSMP.engine.entities.rituals.menu; +import fr.moussax.bedrock.text.Formatter; +import fr.moussax.bedrock.text.Messenger; +import fr.moussax.bedrock.ui.menu.Menu; +import fr.moussax.bedrock.ui.menu.TickableMenu; +import fr.moussax.bedrock.ui.menu.interaction.MenuElementPreset; +import fr.moussax.bedrock.utils.ItemBuilder; import fr.moussax.blightedSMP.BlightedSMP; import fr.moussax.blightedSMP.content.sound.BlightedSounds; import fr.moussax.blightedSMP.engine.entities.rituals.AncientCreature; import fr.moussax.blightedSMP.engine.entities.rituals.AncientRitual; import fr.moussax.blightedSMP.engine.entities.rituals.RitualAnimations; import fr.moussax.blightedSMP.engine.items.recipes.CraftingObject; -import fr.moussax.bedrock.ui.menu.Menu; -import fr.moussax.bedrock.ui.menu.interaction.MenuElementPreset; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; -import fr.moussax.bedrock.utils.ItemBuilder; import fr.moussax.blightedSMP.utils.Utilities; -import fr.moussax.bedrock.text.Formatter; -import fr.moussax.bedrock.text.Messenger; import org.bukkit.Bukkit; import org.bukkit.Location; import org.bukkit.Material; import org.bukkit.Sound; import org.bukkit.entity.Player; -import fr.moussax.bedrock.ui.menu.TickableMenu; import org.bukkit.inventory.ItemStack; import java.util.HashMap; @@ -110,7 +110,8 @@ private void setupResultDisplay() { ItemStack barrier = new ItemBuilder(Material.BARRIER, "§cRitual Required") .addLore("§7Select an ancient ritual to start", "§7the invocation process.") .toItemStack(); - setItem(25, barrier, (_, _) -> {}); + setItem(25, barrier, (_, _) -> { + }); return; } @@ -123,7 +124,8 @@ private void setupResultDisplay() { result = builder.toItemStack(); } - setItem(25, result, (_, _) -> {}); + setItem(25, result, (_, _) -> { + }); } private void checkRequirements(Player player) { @@ -166,7 +168,8 @@ private Map aggregateRequirements() { private void displayRequiredIngredients() { for (int i = 0; i < ritual.getOfferings().size() && i < GRID_SLOTS.length; i++) { CraftingObject ingredient = ritual.getOfferings().get(i); - setItem(GRID_SLOTS[i], createDisplayItem(ingredient), (_, _) -> {}); + setItem(GRID_SLOTS[i], createDisplayItem(ingredient), (_, _) -> { + }); } } @@ -199,7 +202,8 @@ private void setupStatusPanes() { "§7to invoke ancient forgotten entities." ) .toItemStack(); - setItem(14, shriekerIcon, (_, _) -> {}); + setItem(14, shriekerIcon, (_, _) -> { + }); } private Material determineIndicatorMaterial() { diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/SpawnableEntity.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/SpawnableEntity.java index d24867d9..d9fd0ae2 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/SpawnableEntity.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/SpawnableEntity.java @@ -7,7 +7,10 @@ import fr.moussax.blightedSMP.engine.entities.spawnable.condition.SpawnCondition; import fr.moussax.blightedSMP.engine.entities.spawnable.engine.SpawnMode; import lombok.Getter; -import org.bukkit.*; +import org.bukkit.Location; +import org.bukkit.NamespacedKey; +import org.bukkit.Particle; +import org.bukkit.World; import org.bukkit.entity.EntityType; import org.bukkit.entity.LivingEntity; import org.bukkit.persistence.PersistentDataType; @@ -23,17 +26,23 @@ */ public abstract class SpawnableEntity extends BlightedEntity { - /** Persistent data key storing comma-separated active affix IDs assigned to this entity. */ - public static final NamespacedKey AFFIXES_KEY = new NamespacedKey(BlightedSMP.getInstance(), "blighted_active_affix"); + /** + * Persistent data key storing comma-separated active affix IDs assigned to this entity. + */ + public static final NamespacedKey AFFIXES_KEY = + new NamespacedKey(BlightedSMP.getInstance(), "blighted_active_affix"); @Getter private final double spawnProbability; + @Getter private final SpawnMode spawnMode; + private SpawnProfile spawnProfile; @Getter private double affixChance = 0.0; + @Getter private int maxAffixes = 1; @@ -65,7 +74,7 @@ public void setMaxAffixes(int maxAffixes) { * @param entityId unique entity identifier * @param name display name * @param maxHealth maximum health - * @param entityType underlying Minecraft entity type + * @param entityType underlying a Minecraft entity type * @param probability spawn probability in range {@code [0.0, 1.0]} */ protected SpawnableEntity(String entityId, String name, int maxHealth, EntityType entityType, double probability) { @@ -78,11 +87,12 @@ protected SpawnableEntity(String entityId, String name, int maxHealth, EntityTyp * @param entityId unique entity identifier * @param name display name * @param maxHealth maximum health - * @param entityType underlying Minecraft entity type + * @param entityType underlying a Minecraft entity type * @param probability spawn probability in range {@code [0.0, 1.0]} * @param mode spawn mode */ - protected SpawnableEntity(String entityId, String name, int maxHealth, EntityType entityType, double probability, SpawnMode mode) { + protected SpawnableEntity( + String entityId, String name, int maxHealth, EntityType entityType, double probability, SpawnMode mode) { this(entityId, name, maxHealth, 1, 0, entityType, probability, mode); } @@ -93,11 +103,18 @@ protected SpawnableEntity(String entityId, String name, int maxHealth, EntityTyp * @param name display name * @param maxHealth maximum health * @param damage base attack damage - * @param entityType underlying Minecraft entity type + * @param entityType underlying a Minecraft entity type * @param probability spawn probability in range {@code [0.0, 1.0]} * @param mode spawn mode */ - protected SpawnableEntity(String entityId, String name, int maxHealth, int damage, EntityType entityType, double probability, SpawnMode mode) { + protected SpawnableEntity( + String entityId, + String name, + int maxHealth, + int damage, + EntityType entityType, + double probability, + SpawnMode mode) { this(entityId, name, maxHealth, damage, 0, entityType, probability, mode); } @@ -109,12 +126,20 @@ protected SpawnableEntity(String entityId, String name, int maxHealth, int damag * @param maxHealth maximum health * @param damage base attack damage * @param defense base armor defense - * @param entityType underlying Minecraft entity type + * @param entityType underlying a Minecraft entity type * @param probability spawn probability in range {@code [0.0, 1.0]} * @param mode spawn mode * @throws IllegalArgumentException if {@code probability} is outside {@code [0.0, 1.0]} */ - protected SpawnableEntity(String entityId, String name, int maxHealth, int damage, int defense, EntityType entityType, double probability, SpawnMode mode) { + protected SpawnableEntity( + String entityId, + String name, + int maxHealth, + int damage, + int defense, + EntityType entityType, + double probability, + SpawnMode mode) { super(name, maxHealth, damage, defense, entityType); if (probability < 0.0 || probability > 1.0) { throw new IllegalArgumentException("spawnProbability must be in [0.0, 1.0], got: " + probability); @@ -146,7 +171,8 @@ public LivingEntity spawn(Location location) { applyAffix(affix); } - spawned.getPersistentDataContainer().set(AFFIXES_KEY, PersistentDataType.STRING, String.join(",", affixIds)); + spawned.getPersistentDataContainer() + .set(AFFIXES_KEY, PersistentDataType.STRING, String.join(",", affixIds)); } } @@ -197,9 +223,9 @@ private void startEliteAura() { double angle = time * 0.2; double x = Math.cos(angle) * 0.6; double z = Math.sin(angle) * 0.6; - Location orbitLoc = center.clone().add(x, 0, z); + Location orbitLocation = center.clone().add(x, 0, z); - world.spawnParticle(Particle.SCULK_SOUL, orbitLoc, 1, 0.05, 0.05, 0.05, 0.02); + world.spawnParticle(Particle.SCULK_SOUL, orbitLocation, 1, 0.05, 0.05, 0.05, 0.02); if (time % 10 == 0) { world.spawnParticle(Particle.ENCHANT, center, 5, 0.5, 0.5, 0.5, 0.01); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/condition/SpawnRules.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/condition/SpawnRules.java index 4918e4eb..135bc790 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/condition/SpawnRules.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/condition/SpawnRules.java @@ -219,7 +219,7 @@ public static SpawnCondition nearActiveTrialSpawner(int radius) { if (block.getType() != Material.TRIAL_SPAWNER) continue; if (block.getBlockData() instanceof TrialSpawner trialData - && trialData.getTrialSpawnerState() == State.ACTIVE) { + && trialData.getTrialSpawnerState() == State.ACTIVE) { return true; } } @@ -248,8 +248,8 @@ public static SpawnCondition nearOminousTrialSpawner(int radius) { if (block.getType() != Material.TRIAL_SPAWNER) continue; if (block.getBlockData() instanceof TrialSpawner trialData - && trialData.isOminous() - && trialData.getTrialSpawnerState() == State.ACTIVE) { + && trialData.isOminous() + && trialData.getTrialSpawnerState() == State.ACTIVE) { return true; } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/SpawnEvaluator.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/SpawnEvaluator.java index 8f8eff20..5e022d3e 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/SpawnEvaluator.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/spawnable/engine/SpawnEvaluator.java @@ -14,16 +14,17 @@ */ public final class SpawnEvaluator { - private SpawnEvaluator() {} + private SpawnEvaluator() { + } /** - * Evaluates a list of candidate entities against a target location and selects an eligible entity weighted by probability. + * Evaluates spawn conditions for candidate entities and selects an eligible entity weighted by probability. * * @param candidates candidate spawnable entity prototypes * @param location target spawn location * @param world target world * @param random random number generator - * @return selected entity definition, or {@code null} if no spawn condition was met or the roll failed + * @return selected entity prototype, or {@code null} if no spawn condition was met or probability roll failed */ @Nullable public static SpawnableEntity selectCandidate(List candidates, Location location, World world, ThreadLocalRandom random) { diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingLootTable.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingLootTable.java index ea90daef..c9a0ec68 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingLootTable.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingLootTable.java @@ -116,12 +116,9 @@ public static Builder builder() { */ public static final class Builder { private static final Function FISHING_FEEDBACK_MAPPER = quality -> switch (quality) { - case GOOD_CATCH -> - FeedbackSpecification.full(" §5§lGOOD CATCH! §f| §7You found §f", Sound.ENTITY_EXPERIENCE_ORB_PICKUP, 2.0f); - case GREAT_CATCH -> - FeedbackSpecification.full(" §6§lGREAT CATCH! §f| §7You found §f", Sound.ENTITY_EXPERIENCE_ORB_PICKUP, 1.5f); - case OUTSTANDING_CATCH -> - FeedbackSpecification.full(" §d§lOUTSTANDING CATCH! §f| §7You found §f", Sound.ENTITY_PLAYER_LEVELUP, 1.5f); + case GOOD_CATCH -> FeedbackSpecification.full(" §5§lGOOD CATCH! §f| §7You found §f", Sound.ENTITY_EXPERIENCE_ORB_PICKUP, 2.0f); + case GREAT_CATCH -> FeedbackSpecification.full(" §6§lGREAT CATCH! §f| §7You found §f", Sound.ENTITY_EXPERIENCE_ORB_PICKUP, 1.5f); + case OUTSTANDING_CATCH -> FeedbackSpecification.full(" §d§lOUTSTANDING CATCH! §f| §7You found §f", Sound.ENTITY_PLAYER_LEVELUP, 1.5f); default -> null; }; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/BlightedItem.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/BlightedItem.java index 8770f1f8..1b1894e9 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/BlightedItem.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/BlightedItem.java @@ -1,16 +1,16 @@ package fr.moussax.blightedSMP.engine.items; +import fr.moussax.bedrock.ui.menu.Menu; +import fr.moussax.bedrock.utils.ItemBuilder; import fr.moussax.blightedSMP.BlightedSMP; -import fr.moussax.blightedSMP.engine.items.abilities.Ability; import fr.moussax.blightedSMP.engine.items.abilities.AbilityExecutor; +import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; import fr.moussax.blightedSMP.engine.items.abilities.FullSetBonus; import fr.moussax.blightedSMP.engine.items.recipes.RecipePreviewManager; import fr.moussax.blightedSMP.engine.items.registry.ItemRegistry; import fr.moussax.blightedSMP.engine.items.rules.ItemRule; import fr.moussax.blightedSMP.engine.items.rules.ItemRuleEngine; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; -import fr.moussax.bedrock.ui.menu.Menu; -import fr.moussax.bedrock.utils.ItemBuilder; import lombok.Getter; import org.bukkit.Material; import org.bukkit.NamespacedKey; @@ -52,7 +52,7 @@ public final class BlightedItem extends ItemBuilder implements ItemRule, Supplie @Getter private FullSetBonus fullSetBonus; @Getter - private final List abilities = new ArrayList<>(); + private final List> abilities = new ArrayList<>(); @Getter private final ItemRuleEngine ruleEngine = new ItemRuleEngine(); @Getter @@ -93,7 +93,7 @@ public BlightedItem(@NonNull String itemId, @NonNull ItemType type, @NonNull Ite * * @param ability ability to add */ - public void addAbility(Ability ability) { + public void addAbility(AbilityManager ability) { addAbility(ability, true); } @@ -103,7 +103,7 @@ public void addAbility(Ability ability) { * @param ability ability to add * @param injectLore {@code true} to append formatted ability description to lore */ - public void addAbility(Ability ability, boolean injectLore) { + public void addAbility(AbilityManager ability, boolean injectLore) { if (ability == null) return; this.abilities.add(ability); @@ -118,8 +118,9 @@ public void addAbility(Ability ability, boolean injectLore) { * * @param abilities abilities to add */ - public void addAbilities(Ability... abilities) { - for (Ability ability : abilities) { + @SafeVarargs + public final void addAbilities(AbilityManager... abilities) { + for (AbilityManager ability : abilities) { addAbility(ability, true); } } @@ -224,10 +225,11 @@ public static BlightedItem fromItemStack(@NonNull ItemStack itemStack) { * @param blightedPlayer player context executing the ability * @param event triggering event */ + @SuppressWarnings({"unchecked", "rawtypes"}) public void triggerAbilities(BlightedPlayer blightedPlayer, Event event) { - for (Ability ability : abilities) { - if (ability.type().matches(event)) { - AbilityExecutor.execute(ability, blightedPlayer, event); + for (AbilityManager ability : abilities) { + if (ability.getType().matches(event)) { + AbilityExecutor.execute((AbilityManager) ability, blightedPlayer, event); } } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/ItemType.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/ItemType.java index bb96ae60..ecb7a5d5 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/ItemType.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/ItemType.java @@ -69,19 +69,12 @@ public enum ItemType { * Broad grouping for item types used in inventory filtering and display categories. */ public enum Category { - /** Armor equipment category. */ ARMOR, - /** Melee weapon category. */ MELEE_WEAPON, - /** Ranged weapon category. */ RANGE_WEAPON, - /** Tool and utility item category. */ TOOLS, - /** Placeable block category. */ BLOCKS, - /** Material and resource category. */ MATERIAL, - /** Miscellaneous item category. */ MISCELLANEOUS } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java index 195071f6..7b1a8851 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java @@ -191,4 +191,4 @@ private void cleanupBlockData(Block block) { private void cacheMetadata(Block block, String id) { block.setMetadata("blighted_id", new FixedMetadataValue(plugin, id)); } -} \ No newline at end of file +} diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapedRecipeBuilder.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapedRecipeBuilder.java index 219b142e..f9391616 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapedRecipeBuilder.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapedRecipeBuilder.java @@ -1,11 +1,15 @@ package fr.moussax.blightedSMP.engine.items.recipes.crafting.builder; import fr.moussax.blightedSMP.engine.items.BlightedItem; +import fr.moussax.blightedSMP.engine.items.recipes.CraftingObject; import fr.moussax.blightedSMP.engine.items.recipes.crafting.BlightedShapedRecipe; import fr.moussax.blightedSMP.engine.items.recipes.ShapeEncoder; import fr.moussax.blightedSMP.engine.items.registry.ItemRegistry; import org.bukkit.Material; +import java.util.HashMap; +import java.util.Map; + /** * Fluent builder for creating {@link BlightedShapedRecipe} instances. * @@ -17,7 +21,10 @@ public final class ShapedRecipeBuilder { private final BlightedItem result; private final int amount; - private ShapeEncoder encoder; + private String line1; + private String line2; + private String line3; + private final Map bindings = new HashMap<>(); private int attributeSourceSlot = -1; private ShapedRecipeBuilder(BlightedItem result, int amount) { @@ -46,7 +53,7 @@ public static ShapedRecipeBuilder of(BlightedItem result, int amount) { * @throws IllegalArgumentException if the item ID is not registered */ public static ShapedRecipeBuilder of(String resultId, int amount) { - return new ShapedRecipeBuilder(ItemRegistry.getItem(resultId), amount); + return new ShapedRecipeBuilder(ItemRegistry.get(resultId), amount); } /** @@ -58,10 +65,24 @@ public static ShapedRecipeBuilder of(String resultId, int amount) { * @return this builder */ public ShapedRecipeBuilder shape(String line1, String line2, String line3) { - this.encoder = new ShapeEncoder(line1, line2, line3); + this.line1 = line1; + this.line2 = line2; + this.line3 = line3; return this; } + /** + * Binds a crafting shape character to a single material ingredient. + * + * @param key the character used in the recipe shape + * @param material the material represented by the character + * @return this builder + */ + // ponytail: simplified — single-item quantity default overload + public ShapedRecipeBuilder bind(char key, Material material) { + return bind(key, material, 1); + } + /** * Binds a crafting shape character to a material. * @@ -69,15 +90,24 @@ public ShapedRecipeBuilder shape(String line1, String line2, String line3) { * @param material the material represented by the character * @param amount the required amount of the material * @return this builder - * @throws IllegalStateException if {@link #shape(String, String, String)} - * has not been called */ public ShapedRecipeBuilder bind(char key, Material material, int amount) { - validateEncoder(); - encoder.bindKey(key, material, amount); + bindings.put(key, new CraftingObject(material, amount)); return this; } + /** + * Binds a crafting shape character to a single custom item ingredient. + * + * @param key the character used in the recipe shape + * @param item the custom item represented by the character + * @return this builder + */ + // ponytail: simplified — single-item quantity default overload + public ShapedRecipeBuilder bind(char key, BlightedItem item) { + return bind(key, item, 1); + } + /** * Binds a crafting shape character to a custom item. * @@ -85,15 +115,25 @@ public ShapedRecipeBuilder bind(char key, Material material, int amount) { * @param item the custom item represented by the character * @param amount the required amount of the item * @return this builder - * @throws IllegalStateException if {@link #shape(String, String, String)} - * has not been called */ public ShapedRecipeBuilder bind(char key, BlightedItem item, int amount) { - validateEncoder(); - encoder.bindKey(key, item, amount); + bindings.put(key, new CraftingObject(item, amount)); return this; } + /** + * Binds a crafting shape character to a single registered custom item ingredient. + * + * @param key the character used in the recipe shape + * @param itemId the ID of the custom item represented by the character + * @return this builder + * @throws IllegalArgumentException if the item ID is not registered + */ + // ponytail: simplified — single-item quantity default overload + public ShapedRecipeBuilder bind(char key, String itemId) { + return bind(key, itemId, 1); + } + /** * Binds a crafting shape character to a registered custom item. * @@ -102,11 +142,9 @@ public ShapedRecipeBuilder bind(char key, BlightedItem item, int amount) { * @param amount the required amount of the item * @return this builder * @throws IllegalArgumentException if the item ID is not registered - * @throws IllegalStateException if {@link #shape(String, String, String)} - * has not been called */ public ShapedRecipeBuilder bind(char key, String itemId, int amount) { - return bind(key, ItemRegistry.getItem(itemId), amount); + return bind(key, ItemRegistry.get(itemId), amount); } /** @@ -137,8 +175,14 @@ public ShapedRecipeBuilder attributeSource(int slotIndex) { * @return the constructed shaped recipe * @throws IllegalStateException if the recipe shape has not been defined */ + // ponytail: simplified — order-independent shape and key binding resolution upon build public BlightedShapedRecipe build() { - validateEncoder(); + if (line1 == null || line2 == null || line3 == null) { + throw new IllegalStateException("Recipe shape has not been defined yet. Call .shape() first."); + } + ShapeEncoder encoder = new ShapeEncoder(line1, line2, line3); + bindings.forEach(encoder::bindKey); + BlightedShapedRecipe recipe = new BlightedShapedRecipe(result, amount); recipe.setRecipe(encoder.encodeCraftingRecipe()); @@ -148,10 +192,4 @@ public BlightedShapedRecipe build() { return recipe; } - - private void validateEncoder() { - if (encoder == null) { - throw new IllegalStateException("Recipe shape has not been defined yet. Call .shape() first."); - } - } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java index de8a4f33..b9601aa6 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java @@ -45,7 +45,18 @@ public static ShapelessRecipeBuilder of(BlightedItem result) { * @throws IllegalArgumentException if the item ID is not registered */ public static ShapelessRecipeBuilder of(String resultId) { - return new ShapelessRecipeBuilder(ItemRegistry.getItem(resultId)); + return new ShapelessRecipeBuilder(ItemRegistry.get(resultId)); + } + + /** + * Adds a single material ingredient to the recipe. + * + * @param material the material required by the recipe + * @return this builder + */ + // ponytail: simplified — single-item quantity default overload + public ShapelessRecipeBuilder addIngredient(Material material) { + return addIngredient(material, 1, false); } /** @@ -80,6 +91,17 @@ public ShapelessRecipeBuilder addIngredient( return this; } + /** + * Adds a single custom item ingredient to the recipe. + * + * @param item the custom item required by the recipe + * @return this builder + */ + // ponytail: simplified — single-item quantity default overload + public ShapelessRecipeBuilder addIngredient(BlightedItem item) { + return addIngredient(item, 1, false); + } + /** * Adds a custom item ingredient to the recipe. * @@ -112,6 +134,18 @@ public ShapelessRecipeBuilder addIngredient( return this; } + /** + * Adds a single registered custom item as an ingredient. + * + * @param itemId the ID of the required custom item + * @return this builder + * @throws IllegalArgumentException if the item ID is not registered + */ + // ponytail: simplified — single-item quantity default overload + public ShapelessRecipeBuilder addIngredient(String itemId) { + return addIngredient(ItemRegistry.get(itemId), 1, false); + } + /** * Adds a registered custom item as an ingredient. * @@ -121,7 +155,7 @@ public ShapelessRecipeBuilder addIngredient( * @throws IllegalArgumentException if the item ID is not registered */ public ShapelessRecipeBuilder addIngredient(String itemId, int amount) { - return addIngredient(ItemRegistry.getItem(itemId), amount, false); + return addIngredient(ItemRegistry.get(itemId), amount, false); } /** @@ -140,7 +174,7 @@ public ShapelessRecipeBuilder addIngredient( int amount, boolean isAttributeSource ) { - return addIngredient(ItemRegistry.getItem(itemId), amount, isAttributeSource); + return addIngredient(ItemRegistry.get(itemId), amount, isAttributeSource); } /** diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/registry/menu/ItemRegistryMenu.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/registry/menu/ItemRegistryMenu.java index 10a810a0..297839e2 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/registry/menu/ItemRegistryMenu.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/registry/menu/ItemRegistryMenu.java @@ -23,6 +23,7 @@ import java.util.function.Predicate; public final class ItemRegistryMenu { + private static final int[] CATEGORY_SLOTS = PaginatedMenu.INNER_GRID_SLOTS; private static final int SEARCH_SLOT = 41; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/EntityResult.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/EntityResult.java index 2fba1dcd..e746321d 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/EntityResult.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/EntityResult.java @@ -20,7 +20,11 @@ public final class EntityResult implements LootResult { private final Function customSpawner; private final Consumer entityModifier; - private EntityResult(EntityType entityType, Function customSpawner, Consumer entityModifier) { + private EntityResult( + EntityType entityType, + Function customSpawner, + Consumer entityModifier + ) { this.entityType = entityType; this.customSpawner = customSpawner; this.entityModifier = entityModifier; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/gems/GemsItem.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/gems/GemsItem.java index 184fa59d..ff9c1b57 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/gems/GemsItem.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/results/gems/GemsItem.java @@ -4,6 +4,7 @@ import fr.moussax.blightedSMP.content.sound.BlightedSounds; import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; +import fr.moussax.blightedSMP.engine.items.abilities.AbilityType; import fr.moussax.blightedSMP.engine.items.registry.ItemRegistry; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import fr.moussax.bedrock.text.Messenger; @@ -50,6 +51,16 @@ public void addGems(BlightedPlayer player) { */ public static class BlightedGemstoneAbility implements AbilityManager { + @Override + public String getName() { + return "Consume Gems"; + } + + @Override + public AbilityType getType() { + return AbilityType.RIGHT_CLICK; + } + @Override public boolean triggerAbility(PlayerInteractEvent event) { if (event.getItem() == null) return false; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/strategies/LootingAwareProbabilisticStrategy.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/strategies/LootingAwareProbabilisticStrategy.java index c8cac85f..ddae5bb5 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/strategies/LootingAwareProbabilisticStrategy.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/loot/strategies/LootingAwareProbabilisticStrategy.java @@ -59,7 +59,7 @@ public List select(List validEntries, LootContext context) } private int extractLootingLevel(LootContext context) { - if (context.blightedPlayer() == null || context.blightedPlayer().getPlayer() == null) { + if (context.blightedPlayer() == null) { return 0; } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/hud/PlayerHudManager.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/hud/PlayerHudManager.java index 671f9203..7818a0d8 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/hud/PlayerHudManager.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/player/hud/PlayerHudManager.java @@ -11,9 +11,7 @@ */ public final class PlayerHudManager { - /** Action bar section identifier for player gem balance. */ public static final String SECTION_GEMS = "gems"; - /** Action bar section identifier for player mana pool. */ public static final String SECTION_MANA = "mana"; private final ActionbarService actionBarService; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/BlightedServer.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/BlightedServer.java index 9e78d017..c06df5aa 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/BlightedServer.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/BlightedServer.java @@ -48,7 +48,7 @@ public static void rehydrateEntitiesOnLoadedChunks(JavaPlugin plugin) { final Iterator iterator = chunks.iterator(); final int BATCH_SIZE = 100; int processedCount = 0; - long startTime = System.currentTimeMillis(); + final long startTime = System.currentTimeMillis(); @Override public void run() { diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/PluginFiles.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/PluginFiles.java index 82da95e2..04c6ff5d 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/PluginFiles.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/PluginFiles.java @@ -15,7 +15,7 @@ public enum PluginFiles { /** * Primary SQLite database file name. */ - DATABASE("blighted_database.db"); + DATABASE("blightedsmp_database.db"); /** * Relative file name within the plugin data directory. diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/PluginSettings.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/PluginSettings.java index e9caadf2..6a9d1864 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/PluginSettings.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/server/PluginSettings.java @@ -1,9 +1,9 @@ package fr.moussax.blightedSMP.server; -import fr.moussax.blightedSMP.BlightedSMP; import fr.moussax.bedrock.utils.debug.Log; import lombok.Getter; import org.bukkit.configuration.file.FileConfiguration; +import org.bukkit.plugin.java.JavaPlugin; /** * Loads and holds runtime configuration settings from {@code config.yml}. @@ -31,7 +31,7 @@ private PluginSettings() { * @param plugin plugin instance providing configuration access * @return loaded settings instance with defensive defaults */ - public static PluginSettings load(BlightedSMP plugin) { + public static PluginSettings load(JavaPlugin plugin) { PluginSettings settings = new PluginSettings(); try { plugin.reloadConfig(); From 486da650c7f1f4cdcd837c0affbb3f1037d8c231 Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 21:45:06 +0200 Subject: [PATCH 21/31] feat(entities): add type-safe component lookup and encapsulate attachments in BlightedEntity --- .../engine/entities/BlightedEntity.java | 36 ++++++++++++++++--- .../listeners/BlightedEntitiesListener.java | 30 +++++++--------- 2 files changed, 45 insertions(+), 21 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java index fb113cde..bd771b66 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java @@ -63,7 +63,7 @@ public abstract class BlightedEntity implements Cloneable { private LifecycleTaskManager coreTasks = new LifecycleTaskManager(); private LifecycleTaskManager phaseTasks = new LifecycleTaskManager(); private Map components = new HashMap<>(); - public Set attachments = new CopyOnWriteArraySet<>(); + protected Set attachments = new CopyOnWriteArraySet<>(); private long lastDamageTick = -1L; private UUID lastDamagerUuid = null; @@ -699,7 +699,7 @@ public BlockDisplay attachBlockDisplay(Vector offset, Consumer con } /** - * Attaches a multi-part hittable {@link Interaction} hitbox entity. + * Attaches a multipart hittable {@link Interaction} hitbox entity. * * @param offset local offset relative to base entity origin and facing yaw * @param width hitbox width @@ -712,8 +712,8 @@ public Interaction attachHitbox(Vector offset, float width, float height, Consum return null; } Vector localOffset = offset != null ? offset : new Vector(0, 0, 0); - Location spawnLoc = entity.getLocation().clone().add(localOffset); - Interaction interaction = entity.getWorld().spawn(spawnLoc, Interaction.class, i -> { + Location spawnLocation = entity.getLocation().clone().add(localOffset); + Interaction interaction = entity.getWorld().spawn(spawnLocation, Interaction.class, i -> { i.setInteractionWidth(width); i.setInteractionHeight(height); if (configurator != null) { @@ -962,6 +962,15 @@ public void addComponent(EntityComponent component) { } } + /** + * Returns an unmodifiable view of active entity attachments. + * + * @return active entity attachments + */ + public Set getAttachments() { + return Collections.unmodifiableSet(attachments); + } + /** * Returns a registered component by identifier. * @@ -974,6 +983,25 @@ public T getComponent(String id) { return (T) components.get(id); } + /** + * Returns the first registered component matching the specified class type. + * + * @param componentClass expected component class type + * @param expected component type + * @return matching component instance, or {@code null} if not registered + */ + public T getComponent(Class componentClass) { + if (componentClass == null) { + return null; + } + for (EntityComponent component : components.values()) { + if (componentClass.isInstance(component)) { + return componentClass.cast(component); + } + } + return null; + } + /** * Returns a snapshot of all registered components. * diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java index fb99b785..bbe25ea9 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/listeners/BlightedEntitiesListener.java @@ -138,8 +138,8 @@ private AttachmentRole getAttachmentRole(BlightedEntity owner, Entity attachment return AttachmentRole.SUBORDINATE; } - if (owner != null && owner.attachments != null) { - for (EntityAttachment attachment : owner.attachments) { + if (owner != null) { + for (EntityAttachment attachment : owner.getAttachments()) { if (attachmentEntity.equals(attachment.entity())) { return attachment.role(); } @@ -159,10 +159,9 @@ private AttachmentRole getAttachmentRole(BlightedEntity owner, Entity attachment private void handleDamageDealt(EntityDamageByEntityEvent event) { Entity rawDamager = event.getDamager(); - Entity source = - (rawDamager instanceof Projectile projectile && projectile.getShooter() instanceof Entity shooter) - ? shooter - : rawDamager; + Entity source = (rawDamager instanceof Projectile projectile && projectile.getShooter() instanceof Entity shooter) + ? shooter + : rawDamager; BlightedEntity damager = getBlightedEntity(source); if (damager != null) { @@ -211,16 +210,13 @@ private void handleBlightedEntityDamage(BlightedEntity blighted, LivingEntity en double remainingHealth = entity.getHealth() - event.getFinalDamage(); if (remainingHealth > 0) { - Bukkit.getScheduler() - .runTaskLater( - BlightedSMP.getInstance(), - () -> { - if (entity.isValid() && !entity.isDead()) { - blighted.updateBossBar(); - blighted.evaluatePhases(entity.getHealth()); - } - }, - 1L); + Bukkit.getScheduler().runTaskLater(BlightedSMP.getInstance(), + () -> { + if (entity.isValid() && !entity.isDead()) { + blighted.updateBossBar(); + blighted.evaluatePhases(entity.getHealth()); + } + }, 1L); return; } blighted.killAllAttachments(); @@ -237,7 +233,7 @@ private void flashHurtAndCancelKnockback(BlightedEntity owner, Entity hitEntity) ownerEntity.playHurtAnimation(0.0f); } - for (EntityAttachment attachment : owner.attachments) { + for (EntityAttachment attachment : owner.getAttachments()) { if (attachment.role() == AttachmentRole.SUBORDINATE) { continue; } From 68a3f74616220b42ee5deb8e104a8bf8c37210f6 Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 22:55:52 +0200 Subject: [PATCH 22/31] fix(recipes): support result amounts in shapeless recipes and validate result IDs --- .../engine/fishing/FishingListener.java | 37 +++++++--------- .../items/blocks/BlightedBlockListener.java | 21 +++++----- .../crafting/BlightedShapelessRecipe.java | 9 +++- .../crafting/builder/ShapedRecipeBuilder.java | 6 ++- .../builder/ShapelessRecipeBuilder.java | 42 ++++++++++++++++--- .../crafting/registry/RecipeRegistry.java | 12 +++++- 6 files changed, 85 insertions(+), 42 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingListener.java index 7c99d6f5..2f440ee8 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/fishing/FishingListener.java @@ -196,37 +196,30 @@ private void handleStandardFishing(PlayerFishEvent event, Player player, FishHoo FishingComboTracker.spawnBonusExperience(player.getWorld(), player.getLocation(), newCombo); } - private ItemStack findFishingRodItem(Player player, ItemType requiredType) { + private ItemStack getHeldFishingRodStack(Player player) { ItemStack mainHandItem = player.getInventory().getItemInMainHand(); - if (isRodMaterial(mainHandItem)) { - BlightedItem mainHandBlightedItem = BlightedItem.fromItemStack(mainHandItem); - if (mainHandBlightedItem != null && mainHandBlightedItem.getItemType() == requiredType) { - return mainHandItem; - } - } + if (isRodMaterial(mainHandItem)) return mainHandItem; ItemStack offhandItem = player.getInventory().getItemInOffHand(); - if (isRodMaterial(offhandItem)) { - BlightedItem offhandBlightedItem = BlightedItem.fromItemStack(offhandItem); - if (offhandBlightedItem != null && offhandBlightedItem.getItemType() == requiredType) { - return offhandItem; - } - } + if (isRodMaterial(offhandItem)) return offhandItem; return null; } - private int resolveVanillaLuckLevel(Player player) { - ItemStack mainHandItem = player.getInventory().getItemInMainHand(); - if (isRodMaterial(mainHandItem)) { - return mainHandItem.getEnchantmentLevel(Enchantment.LUCK_OF_THE_SEA); + private ItemStack findFishingRodItem(Player player, ItemType requiredType) { + ItemStack rodStack = getHeldFishingRodStack(player); + if (rodStack != null) { + BlightedItem blightedItem = BlightedItem.fromItemStack(rodStack); + if (blightedItem != null && blightedItem.getItemType() == requiredType) { + return rodStack; + } } + return null; + } - ItemStack offhandItem = player.getInventory().getItemInOffHand(); - if (isRodMaterial(offhandItem)) { - return offhandItem.getEnchantmentLevel(Enchantment.LUCK_OF_THE_SEA); - } - return 0; + private int resolveVanillaLuckLevel(Player player) { + ItemStack rodStack = getHeldFishingRodStack(player); + return rodStack != null ? rodStack.getEnchantmentLevel(Enchantment.LUCK_OF_THE_SEA) : 0; } private boolean isRodMaterial(ItemStack itemStack) { diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java index 7b1a8851..24a44d36 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java @@ -16,6 +16,7 @@ import org.bukkit.event.entity.EntityExplodeEvent; import org.bukkit.event.player.PlayerInteractEvent; import org.bukkit.inventory.ItemStack; +import org.bukkit.inventory.meta.ItemMeta; import org.bukkit.metadata.FixedMetadataValue; import org.bukkit.metadata.MetadataValue; import org.bukkit.persistence.PersistentDataContainer; @@ -33,17 +34,14 @@ public BlightedBlockListener() { } private String getBlockId(Block block) { - if (block.hasMetadata("blighted_id")) { - for (MetadataValue value : block.getMetadata("blighted_id")) { - if (value.getOwningPlugin() == plugin) return value.asString(); - } + List metadata = block.getMetadata("blighted_id"); + for (MetadataValue value : metadata) { + if (value.getOwningPlugin() == plugin) return value.asString(); } - BlockState state = block.getState(); - if (state instanceof TileState tile) { - PersistentDataContainer pdc = tile.getPersistentDataContainer(); - if (pdc.has(BLOCK_ID_KEY, PersistentDataType.STRING)) { - String id = pdc.get(BLOCK_ID_KEY, PersistentDataType.STRING); + if (block.getState() instanceof TileState tile) { + String id = tile.getPersistentDataContainer().get(BLOCK_ID_KEY, PersistentDataType.STRING); + if (id != null) { cacheMetadata(block, id); return id; } @@ -62,9 +60,10 @@ public void onBlockPlace(BlockPlaceEvent event) { ItemStack item = event.getItemInHand(); if (!item.hasItemMeta()) return; - var meta = item.getItemMeta(); - String id = Objects.requireNonNull(meta).getPersistentDataContainer().get(BlightedItem.BLIGHTED_ID_KEY, PersistentDataType.STRING); + ItemMeta meta = item.getItemMeta(); + if (meta == null) return; + String id = meta.getPersistentDataContainer().get(BlightedItem.BLIGHTED_ID_KEY, PersistentDataType.STRING); if (id == null) return; BlightedBlock customBlock = BlockRegistry.get(id); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/BlightedShapelessRecipe.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/BlightedShapelessRecipe.java index f652121d..ef9535de 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/BlightedShapelessRecipe.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/BlightedShapelessRecipe.java @@ -18,6 +18,7 @@ public final class BlightedShapelessRecipe extends BlightedRecipe { private final List ingredientList = new ArrayList<>(); private final Map ingredientCountMap = new HashMap<>(); private final BlightedItem resultBlightedItem; + private final int resultAmount; /** * Ingredient acting as the attribute source. @@ -26,7 +27,12 @@ public final class BlightedShapelessRecipe extends BlightedRecipe { private CraftingObject attributeSourceIngredient = null; public BlightedShapelessRecipe(BlightedItem resultBlightedItem) { + this(resultBlightedItem, 1); + } + + public BlightedShapelessRecipe(BlightedItem resultBlightedItem, int resultAmount) { this.resultBlightedItem = resultBlightedItem; + this.resultAmount = resultAmount; } @Override @@ -36,7 +42,7 @@ public BlightedItem getResult() { @Override public int getAmount() { - return 0; + return resultAmount; } /** @@ -49,6 +55,7 @@ public int getAmount() { @Override public ItemStack assemble(List craftingGrid) { ItemStack result = resultBlightedItem.toItemStack().clone(); + result.setAmount(resultAmount); if (attributeSourceIngredient != null) { String targetId = attributeSourceIngredient.getId(); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapedRecipeBuilder.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapedRecipeBuilder.java index f9391616..4add925c 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapedRecipeBuilder.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapedRecipeBuilder.java @@ -53,7 +53,11 @@ public static ShapedRecipeBuilder of(BlightedItem result, int amount) { * @throws IllegalArgumentException if the item ID is not registered */ public static ShapedRecipeBuilder of(String resultId, int amount) { - return new ShapedRecipeBuilder(ItemRegistry.get(resultId), amount); + BlightedItem result = ItemRegistry.get(resultId); + if (result == null) { + throw new IllegalArgumentException("Unknown recipe result item ID: '" + resultId + "'"); + } + return new ShapedRecipeBuilder(result, amount); } /** diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java index b9601aa6..6040856f 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java @@ -19,25 +19,38 @@ public final class ShapelessRecipeBuilder { private final BlightedItem result; + private final int amount; private final List ingredients = new ArrayList<>(); private CraftingObject attributeSource = null; - private ShapelessRecipeBuilder(BlightedItem result) { + private ShapelessRecipeBuilder(BlightedItem result, int amount) { this.result = result; + this.amount = amount; } /** - * Creates a builder for a shapeless recipe producing the specified item. + * Creates a builder for a shapeless recipe producing a single instance of the specified item. * * @param result the item produced by the recipe * @return a new shapeless recipe builder */ public static ShapelessRecipeBuilder of(BlightedItem result) { - return new ShapelessRecipeBuilder(result); + return of(result, 1); } /** - * Creates a builder for a shapeless recipe producing the item registered + * Creates a builder for a shapeless recipe producing the specified item and amount. + * + * @param result the item produced by the recipe + * @param amount the amount produced by the recipe + * @return a new shapeless recipe builder + */ + public static ShapelessRecipeBuilder of(BlightedItem result, int amount) { + return new ShapelessRecipeBuilder(result, amount); + } + + /** + * Creates a builder for a shapeless recipe producing a single instance of the item registered * under the specified ID. * * @param resultId the ID of the result item @@ -45,7 +58,24 @@ public static ShapelessRecipeBuilder of(BlightedItem result) { * @throws IllegalArgumentException if the item ID is not registered */ public static ShapelessRecipeBuilder of(String resultId) { - return new ShapelessRecipeBuilder(ItemRegistry.get(resultId)); + return of(resultId, 1); + } + + /** + * Creates a builder for a shapeless recipe producing the item registered + * under the specified ID and amount. + * + * @param resultId the ID of the result item + * @param amount the amount produced by the recipe + * @return a new shapeless recipe builder + * @throws IllegalArgumentException if the item ID is not registered + */ + public static ShapelessRecipeBuilder of(String resultId, int amount) { + BlightedItem result = ItemRegistry.get(resultId); + if (result == null) { + throw new IllegalArgumentException("Unknown recipe result item ID: '" + resultId + "'"); + } + return new ShapelessRecipeBuilder(result, amount); } /** @@ -186,7 +216,7 @@ public ShapelessRecipeBuilder addIngredient( * @return the constructed shapeless recipe */ public BlightedShapelessRecipe build() { - BlightedShapelessRecipe recipe = new BlightedShapelessRecipe(result); + BlightedShapelessRecipe recipe = new BlightedShapelessRecipe(result, amount); for (CraftingObject ingredient : ingredients) { recipe.addIngredient(ingredient); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/registry/RecipeRegistry.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/registry/RecipeRegistry.java index 79486cb9..9cbae6ed 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/registry/RecipeRegistry.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/registry/RecipeRegistry.java @@ -68,6 +68,16 @@ public static ShapedRecipeBuilder shapedRecipe(String resultId, int amount) { return ShapedRecipeBuilder.of(resultId, amount); } + /** + * Creates a builder for a shapeless custom recipe producing a single item. + * + * @param resultId the item ID of the recipe result + * @return a shapeless recipe builder + */ + public static ShapelessRecipeBuilder shapelessRecipe(String resultId) { + return ShapelessRecipeBuilder.of(resultId, 1); + } + /** * Creates a builder for a shapeless custom recipe. * @@ -76,7 +86,7 @@ public static ShapedRecipeBuilder shapedRecipe(String resultId, int amount) { * @return a shapeless recipe builder */ public static ShapelessRecipeBuilder shapelessRecipe(String resultId, int amount) { - return ShapelessRecipeBuilder.of(resultId); + return ShapelessRecipeBuilder.of(resultId, amount); } /** From e36c6a0a28a1a887ff4bcb4b2121177a13d82a61 Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 23:17:54 +0200 Subject: [PATCH 23/31] fix(menu): preserve empty slots in fillPattern and update sign input NMS calls - Fix Menu.fillPattern column calculation by preserving space character indices. - Update SignInputMenu and SignInputListener for modern NMS sign packet structures. - Streamline ItemRegistry lookups across BlightedSMP recipes. --- .../java/fr/moussax/bedrock/ui/menu/Menu.java | 6 +- .../bedrock/ui/sign/SignInputListener.java | 2 +- .../bedrock/ui/sign/SignInputMenu.java | 3 +- .../commands/impl/TestCommand.java | 22 +++- .../blightedSMP/content/ContentRegistrar.java | 9 +- .../content/items/BlightedItems.java | 8 +- .../content/items/BlightedTools.java | 3 +- .../blightedSMP/content/items/Bonemerang.java | 3 +- .../content/items/GlimmeringEye.java | 4 +- .../blightedSMP/content/items/Hyperion.java | 3 +- .../content/items/KnightsSword.java | 3 +- .../items/abilities/BonemerangAbility.java | 75 +++--------- .../items/abilities/KnightsSlamAbility.java | 24 ++-- .../items/abilities/VoidStepAbility.java | 31 ++--- .../items/abilities/WitherImpactAbility.java | 36 ++---- .../abilities/tools/AutosmeltAbility.java | 11 ++ .../items/abilities/tools/HammerAbility.java | 10 ++ .../items/abilities/tools/TimberAbility.java | 30 ++--- .../abilities/tools/VeinmineAbility.java | 11 ++ .../content/items/armors/FishingArmors.java | 110 +++++++++--------- .../content/items/blocks/BlightedForge.java | 2 +- .../items/blocks/BlightedWorkbench.java | 2 +- .../content/recipes/EndRecipes.java | 2 +- .../content/recipes/EquipmentRecipes.java | 10 +- .../content/recipes/FishingArmorsRecipes.java | 33 ++++-- .../content/recipes/ForgeRecipes.java | 4 +- .../content/recipes/MaterialRecipes.java | 12 +- .../recipes/NetherMaterialRecipes.java | 2 +- .../content/rituals/AncientRituals.java | 2 +- .../content/utils/ai/EndermanAI.java | 4 +- .../engine/entities/BlightedEntity.java | 20 ++-- 31 files changed, 237 insertions(+), 260 deletions(-) diff --git a/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java b/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java index 917341ad..2765c7a7 100644 --- a/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java +++ b/bedrock/src/main/java/fr/moussax/bedrock/ui/menu/Menu.java @@ -649,9 +649,9 @@ public void fillBorder(@NonNull MenuElementPreset preset) { */ public void fillPattern(String[] pattern, char symbol, @NonNull ItemStack item) { for (int row = 0; row < pattern.length && row < size / 9; row++) { - String replaced = pattern[row].replace(" ", ""); - for (int column = 0; column < replaced.length() && column < 9; column++) { - if (replaced.charAt(column) == symbol) { + String rowString = pattern[row]; + for (int column = 0; column < rowString.length() && column < 9; column++) { + if (rowString.charAt(column) == symbol) { setItem(getSlot(row, column), item); } } diff --git a/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputListener.java b/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputListener.java index 10cbcf6c..33b7aca8 100644 --- a/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputListener.java +++ b/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputListener.java @@ -58,7 +58,7 @@ public void inject(Player player) { public void channelRead(ChannelHandlerContext context, Object packet) throws Exception { if (packet instanceof ServerboundSignUpdatePacket signPacket) { if (SignInputManager.hasActiveSession(player.getUniqueId())) { - SignInputManager.handleSignUpdate(player, signPacket.getLines()); + SignInputManager.handleSignUpdate(player, signPacket.lines().toArray(String[]::new)); return; } } diff --git a/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputMenu.java b/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputMenu.java index f516c7de..4c1b53a0 100644 --- a/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputMenu.java +++ b/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputMenu.java @@ -3,6 +3,7 @@ import fr.moussax.bedrock.scheduling.PluginContext; import net.minecraft.core.BlockPos; import net.minecraft.network.protocol.game.ClientboundOpenSignEditorPacket; +import net.minecraft.world.level.block.entity.SignTextSlot; import net.minecraft.server.level.ServerPlayer; import org.bukkit.Bukkit; import org.bukkit.Location; @@ -63,7 +64,7 @@ public void open(@NonNull Player player) { if (!player.isOnline()) { return; } - nmsPlayer.connection.send(new ClientboundOpenSignEditorPacket(blockPosition, frontSide)); + nmsPlayer.connection.send(new ClientboundOpenSignEditorPacket(blockPosition, frontSide ? SignTextSlot.FRONT : SignTextSlot.BACK)); SignInputManager.register(player.getUniqueId(), this, blockPosition); }, 2L); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/TestCommand.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/TestCommand.java index a4fa96f8..8bf4b8c3 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/TestCommand.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/commands/impl/TestCommand.java @@ -1,16 +1,32 @@ package fr.moussax.blightedSMP.commands.impl; +import fr.moussax.bedrock.utils.ItemBuilder; import fr.moussax.blightedSMP.commands.AdminCommand; -import fr.moussax.bedrock.ui.toast.AdvancementToast; import org.bukkit.Material; import org.bukkit.command.Command; +import org.bukkit.enchantments.Enchantment; import org.bukkit.entity.Player; +import org.bukkit.inventory.ItemFlag; +import org.bukkit.inventory.ItemStack; public final class TestCommand extends AdminCommand { @Override protected boolean executeAdmin(Player player, Command command, String label, String[] args) { - AdvancementToast.task(player, "Command looped 50x for 2 ticks", Material.REPEATING_COMMAND_BLOCK); - AdvancementToast.challenge(player, "Call the Corrupted Champion", Material.SCULK_SHRIEKER); + + ItemStack item = new ItemBuilder(Material.COPPER_HELMET) + .setDisplayName("§fAngler Helmet") + .addEnchantment(Enchantment.UNBREAKING, 5) + .addItemFlag(ItemFlag.HIDE_ATTRIBUTES) + .addLore("", + " §8A simple garb from a simple ", + " §8craft. Though beneath the", + " §8surface, nothing is ever", + " §8quite so simple.", + "", "§f§lCOMMON" + ) + .toItemStack(); + + player.getInventory().addItem(item); return true; } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/ContentRegistrar.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/ContentRegistrar.java index 30706c9c..c7edd195 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/ContentRegistrar.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/ContentRegistrar.java @@ -21,11 +21,7 @@ import fr.moussax.blightedSMP.content.items.materials.EndMaterials; import fr.moussax.blightedSMP.content.items.materials.FishingMaterials; import fr.moussax.blightedSMP.content.items.materials.NetherMaterials; -import fr.moussax.blightedSMP.content.recipes.EndRecipes; -import fr.moussax.blightedSMP.content.recipes.EquipmentRecipes; -import fr.moussax.blightedSMP.content.recipes.ForgeRecipes; -import fr.moussax.blightedSMP.content.recipes.MaterialRecipes; -import fr.moussax.blightedSMP.content.recipes.NetherMaterialRecipes; +import fr.moussax.blightedSMP.content.recipes.*; import fr.moussax.blightedSMP.content.rituals.AncientRituals; import fr.moussax.blightedSMP.engine.entities.BlightedEntity; import fr.moussax.blightedSMP.engine.entities.rituals.AncientRitual; @@ -75,7 +71,8 @@ private ContentRegistrar() { new MaterialRecipes(), new NetherMaterialRecipes(), new EndRecipes(), - new EquipmentRecipes() + new EquipmentRecipes(), + new FishingArmorsRecipes() ); public static final List>> FORGE_MODULES = List.of( diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/BlightedItems.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/BlightedItems.java index f2fedf20..e3a3df46 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/BlightedItems.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/BlightedItems.java @@ -3,7 +3,6 @@ import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.items.ItemRarity; import fr.moussax.blightedSMP.engine.items.ItemType; -import fr.moussax.blightedSMP.engine.items.abilities.Ability; import java.util.function.Consumer; import fr.moussax.blightedSMP.engine.items.rules.ItemRule; @@ -82,7 +81,7 @@ public void register(Consumer registry) { "§5 abomination§7. Within its core lie §dGems ", "§7 sealed and waiting for a daring", "§7 hand to claim them.", - "§8 Gems: §d1✵", + "§8 Ges: §d1✵", "", "§d Right click to consume!", "", @@ -92,10 +91,7 @@ public void register(Consumer registry) { blightedGemstone.preventEquipping(); blightedGemstone.unstackable(); blightedGemstone.addRule(ItemRule.PREVENT_PLACEMENT); - blightedGemstone.addAbility( - Ability.rightClick("Consume Gems", new GemsItem.BlightedGemstoneAbility()), - false - ); + blightedGemstone.addAbility(new GemsItem.BlightedGemstoneAbility(), false); registry.accept(blightedBanner); registry.accept(blightedCodex); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/BlightedTools.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/BlightedTools.java index b86c384d..79914bcc 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/BlightedTools.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/BlightedTools.java @@ -4,7 +4,6 @@ import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.items.ItemRarity; import fr.moussax.blightedSMP.engine.items.ItemType; -import fr.moussax.blightedSMP.engine.items.abilities.Ability; import fr.moussax.blightedSMP.registry.RegistryModule; import org.bukkit.Material; @@ -35,7 +34,7 @@ public void register(Consumer registry) { BlightedItem demoPickaxe = new BlightedItem("DEMO_PICKAXE", ItemType.PICKAXE, ItemRarity.SPECIAL, Material.DIAMOND_PICKAXE); demoPickaxe.setDisplayName("Demo Pickaxe"); - demoPickaxe.addAbility(Ability.passive("Veinmine", new VeinmineAbility())); + demoPickaxe.addAbility(new VeinmineAbility()); demoPickaxe.addLore("§8Demonstration tool"); registry.accept(demoPickaxe); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/Bonemerang.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/Bonemerang.java index db7e8182..d6e9ace1 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/Bonemerang.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/Bonemerang.java @@ -4,7 +4,6 @@ import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.items.ItemRarity; import fr.moussax.blightedSMP.engine.items.ItemType; -import fr.moussax.blightedSMP.engine.items.abilities.Ability; import fr.moussax.blightedSMP.registry.RegistryModule; import java.util.function.Consumer; import org.bukkit.Material; @@ -24,7 +23,7 @@ public void register(Consumer registry) { "", ItemRarity.EPIC.getName() + " BOW" ); - bonemerang.addAbility(Ability.rightClick("Swing", new BonemerangAbility()), false); + bonemerang.addAbility(new BonemerangAbility(), false); bonemerang.addEnchantmentGlint(); bonemerang.unstackable(); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/GlimmeringEye.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/GlimmeringEye.java index 4f0be145..e5c772ee 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/GlimmeringEye.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/GlimmeringEye.java @@ -4,7 +4,6 @@ import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.items.ItemRarity; import fr.moussax.blightedSMP.engine.items.ItemType; -import fr.moussax.blightedSMP.engine.items.abilities.Ability; import fr.moussax.blightedSMP.registry.RegistryModule; import java.util.function.Consumer; import fr.moussax.blightedSMP.engine.items.rules.ItemRule; @@ -17,9 +16,8 @@ public void register(Consumer registry) { BlightedItem glimmeringEye = new BlightedItem("GLIMMERING_EYE", ItemType.UNCATEGORIZED, ItemRarity.RARE, Material.ENDER_EYE); glimmeringEye.setDisplayName("Glimmering Eye"); - Ability voidStep = Ability.rightClick("Voidstep", new VoidStepAbility()); glimmeringEye.addEnchantmentGlint(); - glimmeringEye.addAbility(voidStep); + glimmeringEye.addAbility(new VoidStepAbility()); glimmeringEye.addLore("", ItemRarity.RARE.getName()); glimmeringEye.addRule(ItemRule.PREVENT_PROJECTILE_LAUNCH); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/Hyperion.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/Hyperion.java index c56c0fb9..d1393924 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/Hyperion.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/Hyperion.java @@ -4,7 +4,6 @@ import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.items.ItemRarity; import fr.moussax.blightedSMP.engine.items.ItemType; -import fr.moussax.blightedSMP.engine.items.abilities.Ability; import fr.moussax.blightedSMP.registry.RegistryModule; import java.util.function.Consumer; import org.bukkit.Material; @@ -28,7 +27,7 @@ public void register(Consumer registry) { ); hyperion.setUnbreakable(true); hyperion.addItemFlag(ItemFlag.HIDE_UNBREAKABLE); - hyperion.addAbility(Ability.rightClick("Wither Impact", new WitherImpactAbility()), false); + hyperion.addAbility(new WitherImpactAbility(), false); registry.accept(hyperion); } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/KnightsSword.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/KnightsSword.java index 032423f1..03fe7fc9 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/KnightsSword.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/KnightsSword.java @@ -4,7 +4,6 @@ import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.items.ItemRarity; import fr.moussax.blightedSMP.engine.items.ItemType; -import fr.moussax.blightedSMP.engine.items.abilities.Ability; import fr.moussax.blightedSMP.registry.RegistryModule; import java.util.function.Consumer; import org.bukkit.Material; @@ -29,7 +28,7 @@ public void register(Consumer registry) { ItemRarity.LEGENDARY.getName() + " LONGSWORD" ); - knightSword.addAbility(Ability.rightClick("Knight's Slam", new KnightsSlamAbility()), false); + knightSword.addAbility(new KnightsSlamAbility(), false); knightSword.addAttributeModifier(Attribute.ATTACK_DAMAGE, 10, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.MAINHAND); knightSword.addAttributeModifier(Attribute.ATTACK_SPEED, 1.2, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.MAINHAND); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/BonemerangAbility.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/BonemerangAbility.java index 9014f5b7..cc13bfb9 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/BonemerangAbility.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/BonemerangAbility.java @@ -2,9 +2,8 @@ import fr.moussax.blightedSMP.BlightedSMP; import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; -import fr.moussax.blightedSMP.engine.player.BlightedPlayer; +import fr.moussax.blightedSMP.engine.items.abilities.AbilityType; import org.bukkit.Material; -import org.bukkit.NamespacedKey; import org.bukkit.Particle; import org.bukkit.Sound; import org.bukkit.entity.ArmorStand; @@ -13,20 +12,15 @@ import org.bukkit.entity.Player; import org.bukkit.event.player.PlayerInteractEvent; import org.bukkit.inventory.EquipmentSlot; +import org.bukkit.inventory.Inventory; import org.bukkit.inventory.ItemStack; -import org.bukkit.persistence.PersistentDataType; import org.bukkit.scheduler.BukkitRunnable; import org.bukkit.util.EulerAngle; import org.bukkit.util.Vector; import java.util.Map; -import java.util.UUID; -import java.util.concurrent.ConcurrentHashMap; public class BonemerangAbility implements AbilityManager { - private static final NamespacedKey UUID_KEY = new NamespacedKey(BlightedSMP.getInstance(), "bonemerang_uuid"); - private static final Map> cooldowns = new ConcurrentHashMap<>(); - private static final int OUTBOUND_TICKS = 13; private static final int RETURN_TICKS = 13; private static final double PROJECTILE_SPEED = 1.16; @@ -35,6 +29,16 @@ public class BonemerangAbility implements AbilityManager { private static final double SPAWN_HEIGHT_OFFSET = 1.1; private static final double ROTATION_SPEED = 35.0; + @Override + public String getName() { + return "Swing"; + } + + @Override + public AbilityType getType() { + return AbilityType.RIGHT_CLICK; + } + @Override public boolean triggerAbility(PlayerInteractEvent event) { if (event.getHand() != EquipmentSlot.HAND) { @@ -48,14 +52,6 @@ public boolean triggerAbility(PlayerInteractEvent event) { return false; } - String itemUuid = getOrAssignItemUuid(hand); - - if (isItemOnCooldown(player, itemUuid)) { - return false; - } - - setItemCooldown(player, itemUuid, getCooldownSeconds()); - ItemStack thrownCopy = hand.clone(); reduceStackInHand(player, hand); setThrownVisualInHand(player, thrownCopy); @@ -66,50 +62,7 @@ public boolean triggerAbility(PlayerInteractEvent event) { @Override public int getCooldownSeconds() { - return 0; - } - - @Override - public int getManaCost() { - return 0; - } - - @Override - public boolean canTrigger(BlightedPlayer player) { - return true; - } - - @Override - public void start(BlightedPlayer player) { - } - - @Override - public void stop(BlightedPlayer player) { - } - - private boolean isItemOnCooldown(Player player, String uuid) { - Map playerCooldowns = cooldowns.computeIfAbsent(player.getUniqueId(), k -> new ConcurrentHashMap<>()); - long currentTime = System.currentTimeMillis(); - return playerCooldowns.getOrDefault(uuid, 0L) > currentTime; - } - - private void setItemCooldown(Player player, String uuid, int seconds) { - cooldowns.computeIfAbsent(player.getUniqueId(), k -> new ConcurrentHashMap<>()) - .put(uuid, System.currentTimeMillis() + (seconds * 1000L)); - } - - private String getOrAssignItemUuid(ItemStack item) { - var meta = item.getItemMeta(); - if (meta == null) { - return "LEGACY"; - } - - var container = meta.getPersistentDataContainer(); - if (!container.has(UUID_KEY, PersistentDataType.STRING)) { - container.set(UUID_KEY, PersistentDataType.STRING, UUID.randomUUID().toString()); - item.setItemMeta(meta); - } - return container.get(UUID_KEY, PersistentDataType.STRING); + return 2; } private void reduceStackInHand(Player player, ItemStack hand) { @@ -248,7 +201,7 @@ private void returnItem(Player player, String expectedName, ItemStack original) } } - private boolean replaceNuggetWithOriginal(org.bukkit.inventory.Inventory inventory, ItemStack original) { + private boolean replaceNuggetWithOriginal(Inventory inventory, ItemStack original) { for (int i = 0; i < inventory.getSize(); i++) { ItemStack slot = inventory.getItem(i); if (isSameCustomNugget(slot, original)) { diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/KnightsSlamAbility.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/KnightsSlamAbility.java index 62eb5f79..db71731c 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/KnightsSlamAbility.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/KnightsSlamAbility.java @@ -2,6 +2,7 @@ import fr.moussax.blightedSMP.BlightedSMP; import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; +import fr.moussax.blightedSMP.engine.items.abilities.AbilityType; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import org.bukkit.Location; import org.bukkit.Material; @@ -20,32 +21,29 @@ public class KnightsSlamAbility implements AbilityManager { @Override - public boolean triggerAbility(PlayerInteractEvent event) { - new KnightSword(event.getPlayer().getTargetBlock(null, 6).getLocation(), BlightedPlayer.getBlightedPlayer(event.getPlayer())); - return true; - } - - @Override - public int getCooldownSeconds() { - return 30; + public String getName() { + return "Knight's Slam"; } @Override - public int getManaCost() { - return 20; + public AbilityType getType() { + return AbilityType.RIGHT_CLICK; } @Override - public boolean canTrigger(BlightedPlayer player) { + public boolean triggerAbility(PlayerInteractEvent event) { + new KnightSword(event.getPlayer().getTargetBlock(null, 6).getLocation(), BlightedPlayer.get(event.getPlayer())); return true; } @Override - public void start(BlightedPlayer player) { + public int getCooldownSeconds() { + return 30; } @Override - public void stop(BlightedPlayer player) { + public int getManaCost() { + return 20; } private static class KnightSword extends BukkitRunnable { diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/VoidStepAbility.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/VoidStepAbility.java index bb66389f..b3ce634b 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/VoidStepAbility.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/VoidStepAbility.java @@ -1,6 +1,7 @@ package fr.moussax.blightedSMP.content.items.abilities; import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; +import fr.moussax.blightedSMP.engine.items.abilities.AbilityType; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import fr.moussax.bedrock.text.Messenger; import org.bukkit.*; @@ -14,6 +15,16 @@ public class VoidStepAbility implements AbilityManager { private static final int MAX_DISTANCE = 40; + @Override + public String getName() { + return "Voidstep"; + } + + @Override + public AbilityType getType() { + return AbilityType.RIGHT_CLICK; + } + @Override public String[] getDescription() { return new String[]{ @@ -25,7 +36,7 @@ public String[] getDescription() { @Override public boolean triggerAbility(PlayerInteractEvent event) { - BlightedPlayer blightedPlayer = BlightedPlayer.getBlightedPlayer(event.getPlayer()); + BlightedPlayer blightedPlayer = BlightedPlayer.get(event.getPlayer()); Location targetLocation = getTargetedEyeLocation(blightedPlayer); if (targetLocation == null) { @@ -54,29 +65,11 @@ public boolean triggerAbility(PlayerInteractEvent event) { return true; } - @Override - public int getCooldownSeconds() { - return 0; - } - @Override public int getManaCost() { return 5; } - @Override - public boolean canTrigger(BlightedPlayer player) { - return true; - } - - @Override - public void start(BlightedPlayer player) { - } - - @Override - public void stop(BlightedPlayer player) { - } - private Location getTargetedEyeLocation(BlightedPlayer blightedPlayer) { var player = blightedPlayer.getPlayer(); var eyeLocation = player.getEyeLocation(); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/WitherImpactAbility.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/WitherImpactAbility.java index f2f4438f..e27c8877 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/WitherImpactAbility.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/WitherImpactAbility.java @@ -2,6 +2,7 @@ import fr.moussax.blightedSMP.BlightedSMP; import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; +import fr.moussax.blightedSMP.engine.items.abilities.AbilityType; import fr.moussax.blightedSMP.engine.items.registry.ItemRegistry; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import fr.moussax.bedrock.text.Formatter; @@ -35,6 +36,16 @@ public class WitherImpactAbility implements AbilityManager, private final double DAMAGE_RANGE = 5.0; private final long HEALING_COOLDOWN = 5000L; + @Override + public String getName() { + return "Wither Impact"; + } + + @Override + public AbilityType getType() { + return AbilityType.RIGHT_CLICK; + } + @Override public boolean triggerAbility(PlayerInteractEvent event) { if (event.getHand() != EquipmentSlot.HAND) { @@ -56,31 +67,8 @@ public boolean triggerAbility(PlayerInteractEvent event) { return true; } - @Override - public int getCooldownSeconds() { - return 0; - } - - @Override - public int getManaCost() { - return 0; - } - - @Override - public boolean canTrigger(BlightedPlayer player) { - return true; - } - - @Override - public void start(BlightedPlayer player) { - } - - @Override - public void stop(BlightedPlayer player) { - } - private boolean isHoldingHyperion(Player player) { - return player.getInventory().getItemInMainHand().equals(ItemRegistry.getItem("HYPERION").toItemStack()); + return player.getInventory().getItemInMainHand().equals(ItemRegistry.get("HYPERION").toItemStack()); } private void teleport(Player player) { diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/AutosmeltAbility.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/AutosmeltAbility.java index e8f3ff2e..3d76d0ea 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/AutosmeltAbility.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/AutosmeltAbility.java @@ -1,6 +1,7 @@ package fr.moussax.blightedSMP.content.items.abilities.tools; import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; +import fr.moussax.blightedSMP.engine.items.abilities.AbilityType; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import org.bukkit.Material; import org.bukkit.event.block.BlockDropItemEvent; @@ -10,6 +11,16 @@ public class AutosmeltAbility implements AbilityManager { + @Override + public String getName() { + return "Autosmelt"; + } + + @Override + public AbilityType getType() { + return AbilityType.PASSIVE; + } + private static final Map SMELTABLE = Map.ofEntries( Map.entry(Material.COBBLESTONE, Material.STONE), Map.entry(Material.STONE, Material.SMOOTH_STONE), diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/HammerAbility.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/HammerAbility.java index 3a04c932..1de03ef5 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/HammerAbility.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/HammerAbility.java @@ -1,10 +1,20 @@ package fr.moussax.blightedSMP.content.items.abilities.tools; import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; +import fr.moussax.blightedSMP.engine.items.abilities.AbilityType; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import org.bukkit.event.block.BlockBreakEvent; public class HammerAbility implements AbilityManager { + @Override + public String getName() { + return "Hammer"; + } + + @Override + public AbilityType getType() { + return AbilityType.PASSIVE; + } @Override public boolean triggerAbility(BlockBreakEvent event) { return false; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/TimberAbility.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/TimberAbility.java index 73ea02f5..5e24f8ff 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/TimberAbility.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/TimberAbility.java @@ -1,6 +1,7 @@ package fr.moussax.blightedSMP.content.items.abilities.tools; import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; +import fr.moussax.blightedSMP.engine.items.abilities.AbilityType; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import org.bukkit.Material; import org.bukkit.block.Block; @@ -10,6 +11,16 @@ public class TimberAbility implements AbilityManager { + @Override + public String getName() { + return "Timber"; + } + + @Override + public AbilityType getType() { + return AbilityType.PASSIVE; + } + private static final int MAX_LOGS = 32; private static final Set LOGS = Set.of( Material.OAK_LOG, Material.OAK_WOOD, @@ -99,23 +110,4 @@ public int getCooldownSeconds() { return 2; } - @Override - public int getManaCost() { - return 0; - } - - @Override - public boolean canTrigger(BlightedPlayer player) { - return true; - } - - @Override - public void start(BlightedPlayer player) { - - } - - @Override - public void stop(BlightedPlayer player) { - - } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/VeinmineAbility.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/VeinmineAbility.java index 41daebd9..971b21d7 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/VeinmineAbility.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/tools/VeinmineAbility.java @@ -1,6 +1,7 @@ package fr.moussax.blightedSMP.content.items.abilities.tools; import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; +import fr.moussax.blightedSMP.engine.items.abilities.AbilityType; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import org.bukkit.Material; import org.bukkit.block.Block; @@ -10,6 +11,16 @@ public class VeinmineAbility implements AbilityManager { + @Override + public String getName() { + return "Veinmine"; + } + + @Override + public AbilityType getType() { + return AbilityType.PASSIVE; + } + private static final int MAX_BLOCK = 64; private static final Set VEIN_BLOCKS = Set.of( Material.COAL_ORE, diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/armors/FishingArmors.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/armors/FishingArmors.java index a5fe3c38..ad53b54b 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/armors/FishingArmors.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/armors/FishingArmors.java @@ -6,9 +6,8 @@ import fr.moussax.blightedSMP.engine.items.ItemRarity; import fr.moussax.blightedSMP.engine.items.ItemType; import fr.moussax.blightedSMP.engine.items.abilities.FullSetBonus; -import fr.moussax.blightedSMP.registry.RegistryModule; -import java.util.function.Consumer; import fr.moussax.blightedSMP.engine.items.rules.ItemRule; +import fr.moussax.blightedSMP.registry.RegistryModule; import org.bukkit.Material; import org.bukkit.attribute.Attribute; import org.bukkit.attribute.AttributeModifier; @@ -18,12 +17,65 @@ import org.bukkit.inventory.meta.trim.TrimMaterial; import org.bukkit.inventory.meta.trim.TrimPattern; +import java.util.function.Consumer; + public final class FishingArmors implements RegistryModule> { @SuppressWarnings("UnstableApiUsage") @Override public void register(Consumer registry) { + String[] anglerArmorLore = new String[]{ + "", + " §8A simple garb from a simple ", + " §8craft. Though beneath the", + " §8surface, nothing is ever", + " §8quite so simple.", "", + ItemRarity.COMMON.getName() + }; + + BlightedItem anglerHelmet = new BlightedItem("ANGLER_HELMET", ItemType.HELMET, ItemRarity.COMMON, Material.COPPER_HELMET); + anglerHelmet.setDisplayName("Angler Helmet"); + anglerHelmet.addAttributeModifier(Attribute.ARMOR, 2.0, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.HEAD); + anglerHelmet.addAttributeModifier(Attribute.OXYGEN_BONUS, 0.5, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.HEAD); + anglerHelmet.addItemFlag(ItemFlag.HIDE_ATTRIBUTES); + anglerHelmet.addLore(anglerArmorLore); + anglerHelmet.setMaxDurability(121); + + BlightedItem anglerChestplate = new BlightedItem("ANGLER_CHESTPLATE", ItemType.CHESTPLATE, ItemRarity.COMMON, Material.LEATHER_CHESTPLATE); + anglerChestplate.setDisplayName("Angler Chestplate"); + anglerChestplate.addAttributeModifier(Attribute.ARMOR, 4.0, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.CHEST); + anglerChestplate.addAttributeModifier(Attribute.OXYGEN_BONUS, 0.5, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.CHEST); + anglerChestplate.addItemFlag(ItemFlag.HIDE_DYE, ItemFlag.HIDE_ATTRIBUTES); + anglerChestplate.addLore(anglerArmorLore); + anglerChestplate.setLeatherColor("#2B457A"); + anglerChestplate.setMaxDurability(176); + + BlightedItem anglerLeggings = new BlightedItem("ANGLER_LEGGINGS", ItemType.LEGGINGS, ItemRarity.COMMON, Material.LEATHER_LEGGINGS); + anglerLeggings.setDisplayName("Angler Leggings"); + anglerLeggings.addAttributeModifier(Attribute.ARMOR, 3.0, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.LEGS); + anglerLeggings.addAttributeModifier(Attribute.OXYGEN_BONUS, 0.5, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.LEGS); + anglerLeggings.addItemFlag(ItemFlag.HIDE_DYE, ItemFlag.HIDE_ATTRIBUTES); + anglerLeggings.addLore(anglerArmorLore); + anglerLeggings.setLeatherColor("#2B457A"); + anglerLeggings.setMaxDurability(165); + + BlightedItem anglerBoots = new BlightedItem("ANGLER_BOOTS", ItemType.BOOTS, ItemRarity.COMMON, Material.LEATHER_BOOTS); + anglerBoots.setDisplayName("Angler Boots"); + anglerBoots.addAttributeModifier(Attribute.ARMOR, 1.0, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.FEET); + anglerBoots.addAttributeModifier(Attribute.OXYGEN_BONUS, 0.5, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.FEET); + anglerBoots.addItemFlag(ItemFlag.HIDE_DYE, ItemFlag.HIDE_ATTRIBUTES); + anglerBoots.addLore(anglerArmorLore); + anglerBoots.setLeatherColor("#2B457A"); + + registry.accept(anglerHelmet); + registry.accept(anglerChestplate); + registry.accept(anglerLeggings); + registry.accept(anglerBoots); + + + + FullSetBonus emberWeaveSetBonus = new EmberWeaveSetBonus(); BlightedItem emberWeaveHelmet = new BlightedItem("EMBERWEAVE_HELMET", ItemType.HELMET, ItemRarity.RARE, Material.PLAYER_HEAD); @@ -118,56 +170,6 @@ public void register(Consumer registry) { ashfangBoots.setFullSetBonus(magmaWeaveSetBonus); ashfangBoots.addLore("", ItemRarity.EPIC.getName() + " BOOTS"); - String[] anglerLore = new String[]{ - "", - " §7Worn by those who cast lines", - " §7into the §9Deep Seas§7. A relic of", - " §7forgotten tradition, guiding", - " §7the path toward mastery." - }; - - BlightedItem anglerHelmet = new BlightedItem("ANGLER_HELMET", ItemType.HELMET, ItemRarity.UNCOMMON, Material.COPPER_HELMET); - anglerHelmet.setDisplayName("Angler Helmet"); - anglerHelmet.addLore(anglerLore); - anglerHelmet.addAttributeModifier(Attribute.ARMOR, 2.0, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.HEAD); - anglerHelmet.addAttributeModifier(Attribute.OXYGEN_BONUS, 0.5, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.HEAD); - anglerHelmet.addAttributeModifier(Attribute.LUCK, 0.25, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.HEAD); - anglerHelmet.setMaxDurability(121); - anglerHelmet.addLore("", ItemRarity.UNCOMMON.getName() + " HELMET"); - - BlightedItem anglerChestplate = new BlightedItem("ANGLER_CHESTPLATE", ItemType.CHESTPLATE, ItemRarity.UNCOMMON, Material.LEATHER_CHESTPLATE); - anglerChestplate.setDisplayName("Angler Chestplate"); - anglerChestplate.addLore(anglerLore); - anglerChestplate.addAttributeModifier(Attribute.ARMOR, 4.0, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.CHEST); - anglerChestplate.addAttributeModifier(Attribute.OXYGEN_BONUS, 0.5, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.CHEST); - anglerChestplate.addAttributeModifier(Attribute.LUCK, 0.25, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.CHEST); - anglerChestplate.addItemFlag(ItemFlag.HIDE_DYE); - anglerChestplate.setLeatherColor("#4B6D9E"); - anglerChestplate.setMaxDurability(176); - anglerChestplate.addLore("", ItemRarity.UNCOMMON.getName() + " CHESTPLATE"); - - BlightedItem anglerLeggings = new BlightedItem("ANGLER_LEGGINGS", ItemType.LEGGINGS, ItemRarity.UNCOMMON, Material.LEATHER_LEGGINGS); - anglerLeggings.setDisplayName("Angler Leggings"); - anglerLeggings.addLore(anglerLore); - anglerLeggings.addAttributeModifier(Attribute.ARMOR, 3.0, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.LEGS); - anglerLeggings.addAttributeModifier(Attribute.OXYGEN_BONUS, 0.5, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.LEGS); - anglerLeggings.addAttributeModifier(Attribute.LUCK, 0.25, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.LEGS); - anglerLeggings.addItemFlag(ItemFlag.HIDE_DYE); - anglerLeggings.setLeatherColor("#4B6D9E"); - anglerLeggings.setMaxDurability(165); - anglerLeggings.addLore("", ItemRarity.UNCOMMON.getName() + " LEGGINGS"); - - BlightedItem anglerBoots = new BlightedItem("ANGLER_BOOTS", ItemType.BOOTS, ItemRarity.UNCOMMON, Material.LEATHER_BOOTS); - anglerBoots.setDisplayName("Angler Boots"); - anglerBoots.addLore(anglerLore); - anglerBoots.addAttributeModifier(Attribute.ARMOR, 1.0, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.FEET); - anglerBoots.addAttributeModifier(Attribute.OXYGEN_BONUS, 0.5, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.FEET); - anglerBoots.addAttributeModifier(Attribute.LUCK, 0.25, AttributeModifier.Operation.ADD_NUMBER, EquipmentSlotGroup.FEET); - anglerBoots.addItemFlag(ItemFlag.HIDE_DYE); - anglerBoots.setLeatherColor("#4B6D9E"); - anglerBoots.setMaxDurability(143); - anglerBoots.addLore("", ItemRarity.UNCOMMON.getName() + " BOOTS"); - registry.accept(emberWeaveHelmet); registry.accept(emberWeaveChestplate); registry.accept(emberWeaveLeggins); @@ -176,9 +178,5 @@ public void register(Consumer registry) { registry.accept(ashfangChestplate); registry.accept(ashfangLeggins); registry.accept(ashfangBoots); - registry.accept(anglerHelmet); - registry.accept(anglerChestplate); - registry.accept(anglerLeggings); - registry.accept(anglerBoots); } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/blocks/BlightedForge.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/blocks/BlightedForge.java index 8c638006..97db4072 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/blocks/BlightedForge.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/blocks/BlightedForge.java @@ -12,7 +12,7 @@ public class BlightedForge extends BlightedBlock { public static BlightedForge instance; public BlightedForge() { - super(Material.BLAST_FURNACE, ItemRegistry.getItem("BLIGHTED_FORGE")); + super(Material.BLAST_FURNACE, ItemRegistry.get("BLIGHTED_FORGE")); } @Override diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/blocks/BlightedWorkbench.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/blocks/BlightedWorkbench.java index c3ed4d15..9c6f2389 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/blocks/BlightedWorkbench.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/blocks/BlightedWorkbench.java @@ -14,7 +14,7 @@ public class BlightedWorkbench extends BlightedBlock { public BlightedWorkbench() { - super(Material.ENCHANTING_TABLE, ItemRegistry.getItem("BLIGHTED_WORKBENCH")); + super(Material.ENCHANTING_TABLE, ItemRegistry.get("BLIGHTED_WORKBENCH")); } @Override diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/EndRecipes.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/EndRecipes.java index 6c0cdf95..c95da515 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/EndRecipes.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/EndRecipes.java @@ -30,7 +30,7 @@ public void register(Consumer registry) { BlightedRecipe glimmeringEyeRecipe = shapedRecipe("GLIMMERING_EYE", 1) .shape(" i ", "iji", " i ") - .bind('i', ItemRegistry.getItem("ENCHANTED_ENDER_PEARL"), 1) + .bind('i', ItemRegistry.get("ENCHANTED_ENDER_PEARL"), 1) .bind('j', Material.OPEN_EYEBLOSSOM, 1) .build(); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/EquipmentRecipes.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/EquipmentRecipes.java index 0ca20c90..74772219 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/EquipmentRecipes.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/EquipmentRecipes.java @@ -12,11 +12,11 @@ public final class EquipmentRecipes implements RegistryModule registry) { BlightedRecipe rocketBoots = shapedRecipe("ROCKET_BOOTS", 1) .shape("aba", "cdc", "e e") - .bind('a', Material.PHANTOM_MEMBRANE, 1) - .bind('b', Material.WIND_CHARGE, 1) - .bind('c', Material.SLIME_BLOCK, 1) - .bind('d', Material.COPPER_BOOTS, 1) - .bind('e', Material.RABBIT_FOOT, 1) + .bind('a', Material.PHANTOM_MEMBRANE) + .bind('b', Material.WIND_CHARGE) + .bind('c', Material.SLIME_BLOCK) + .bind('d', Material.COPPER_BOOTS) + .bind('e', Material.RABBIT_FOOT) .attributeSource(4) .build(); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/FishingArmorsRecipes.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/FishingArmorsRecipes.java index 885eaaff..dccdbf61 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/FishingArmorsRecipes.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/FishingArmorsRecipes.java @@ -2,21 +2,40 @@ import fr.moussax.blightedSMP.engine.items.recipes.crafting.BlightedRecipe; import fr.moussax.blightedSMP.registry.RegistryModule; +import org.bukkit.Material; import java.util.function.Consumer; import static fr.moussax.blightedSMP.engine.items.recipes.crafting.registry.RecipeRegistry.shapedRecipe; -public class AnglerArmorRecipe implements RegistryModule> { +public final class FishingArmorsRecipes implements RegistryModule> { @Override public void register(Consumer registry) { - BlightedRecipe anglerHelmet = shapedRecipe("ANGLER_HELMET") - - - - - + BlightedRecipe anglerHelmetRecipe = shapedRecipe("ANGLER_HELMET", 1) + .shape("aaa", "a a", " ") + .bind('a', Material.COD, 2) + .build(); + + BlightedRecipe anglerChestplateRecipe = shapedRecipe("ANGLER_CHESTPLATE", 1) + .shape("a a", "aaa", "aaa") + .bind('a', Material.COD, 2) + .build(); + + BlightedRecipe anglerLeggingsRecipe = shapedRecipe("ANGLER_LEGGINGS", 1) + .shape("aaa", "a a", "a a") + .bind('a', Material.COD, 2) + .build(); + + BlightedRecipe anglerBootsRecipe = shapedRecipe("ANGLER_BOOTS", 1) + .shape(" ", "a a", "a a") + .bind('a', Material.COD, 2) + .build(); + + registry.accept(anglerHelmetRecipe); + registry.accept(anglerChestplateRecipe); + registry.accept(anglerLeggingsRecipe); + registry.accept(anglerBootsRecipe); } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/ForgeRecipes.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/ForgeRecipes.java index ea2ca747..5e99998a 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/ForgeRecipes.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/ForgeRecipes.java @@ -13,8 +13,8 @@ public void register(Consumer registry) { var plasmaBucket = ForgeRecipe.Builder.of("PLASMA_BUCKET", 1) .fuelCost(10000) .ingredients( - new CraftingObject(ItemRegistry.getItem("MAGMA_BUCKET"), 1), - new CraftingObject(ItemRegistry.getItem("MAGMA_BUCKET"), 1), + new CraftingObject(ItemRegistry.get("MAGMA_BUCKET"), 1), + new CraftingObject(ItemRegistry.get("MAGMA_BUCKET"), 1), new CraftingObject(Material.NETHER_STAR, 1) ) .build(); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/MaterialRecipes.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/MaterialRecipes.java index 2434bfd9..255ccf5d 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/MaterialRecipes.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/MaterialRecipes.java @@ -30,7 +30,7 @@ public void register(Consumer registry) { BlightedRecipe enchantedIronBlockRecipe = shapedRecipe("ENCHANTED_IRON_BLOCK", 1) .shape(" e ", "eee", " e ") - .bind('e', ItemRegistry.getItem("ENCHANTED_IRON_INGOT"), 8) + .bind('e', ItemRegistry.get("ENCHANTED_IRON_INGOT"), 8) .build(); BlightedRecipe enchantedGoldIngotRecipe = shapedRecipe("ENCHANTED_GOLD_INGOT", 1) @@ -142,7 +142,7 @@ public void register(Consumer registry) { var enchantedLavaBucketRecipe = shapedRecipe("ENCHANTED_LAVA_BUCKET", 1) .shape("aaa", "bcb", " b ") - .bind('a', ItemRegistry.getItem("ENCHANTED_COAL"), 1) + .bind('a', ItemRegistry.get("ENCHANTED_COAL"), 1) .bind('b', Material.IRON_INGOT, 10) .bind('c', Material.LAVA_BUCKET, 1) .build(); @@ -150,8 +150,8 @@ public void register(Consumer registry) { var magmaBucketRecipe = shapedRecipe("MAGMA_BUCKET", 1) .shape("aaa", "bcb", " b ") .bind('a', Material.MAGMA_BLOCK, 64) - .bind('b', ItemRegistry.getItem("ENCHANTED_IRON_INGOT"), 4) - .bind('c', ItemRegistry.getItem("ENCHANTED_LAVA_BUCKET"), 1) + .bind('b', ItemRegistry.get("ENCHANTED_IRON_INGOT"), 4) + .bind('c', ItemRegistry.get("ENCHANTED_LAVA_BUCKET"), 1) .build(); var blightedCraftingTable = shapedRecipe("BLIGHTED_WORKBENCH", 1) @@ -166,9 +166,9 @@ public void register(Consumer registry) { .shape("aba", "cdc", "aea") .bind('a', Material.IRON_BLOCK, 1) .bind('b', Material.BLAST_FURNACE, 1) - .bind('c', ItemRegistry.getItem("ENCHANTED_COAL"), 2) + .bind('c', ItemRegistry.get("ENCHANTED_COAL"), 2) .bind('d', Material.LAVA_BUCKET, 1) - .bind('e', ItemRegistry.getItem("BLIGHTED_WORKBENCH"), 1) + .bind('e', ItemRegistry.get("BLIGHTED_WORKBENCH"), 1) .build(); BlightedRecipe magmaRodRecipe = shapedRecipe("MAGMA_ROD", 1) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/NetherMaterialRecipes.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/NetherMaterialRecipes.java index c90f668b..e7212971 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/NetherMaterialRecipes.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/recipes/NetherMaterialRecipes.java @@ -57,7 +57,7 @@ public void register(Consumer registry) { .bind('i', Material.NETHERRACK, 12) .build(); - registry.accept(enchantedGhastTearRecipe); + registry.accept(enchantedGhastTearRecipe); registry.accept(enchantedMagmaCreamRecipe); registry.accept(enchantedQuartzRecipe); registry.accept(enchantedBlazePowderRecipe); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/rituals/AncientRituals.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/rituals/AncientRituals.java index 5eab4228..970c47fd 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/rituals/AncientRituals.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/rituals/AncientRituals.java @@ -1,6 +1,6 @@ package fr.moussax.blightedSMP.content.rituals; -import fr.moussax.blightedSMP.content.entities.Illusioner; +import fr.moussax.blightedSMP.content.entities.powerful.Illusioner; import fr.moussax.blightedSMP.engine.entities.rituals.AncientRitual; import fr.moussax.blightedSMP.registry.RegistryModule; import java.util.function.Consumer; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/utils/ai/EndermanAI.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/utils/ai/EndermanAI.java index c38e4d1e..5ca2c53c 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/utils/ai/EndermanAI.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/utils/ai/EndermanAI.java @@ -4,7 +4,7 @@ import net.minecraft.world.entity.ai.goal.MeleeAttackGoal; import net.minecraft.world.entity.ai.goal.RandomStrollGoal; import net.minecraft.world.entity.ai.goal.target.NearestAttackableTargetGoal; -import net.minecraft.world.entity.monster.EnderMan; +import net.minecraft.world.entity.monster.Enderman; import net.minecraft.world.entity.player.Player; import org.bukkit.craftbukkit.entity.CraftMob; import org.bukkit.entity.LivingEntity; @@ -16,7 +16,7 @@ private EndermanAI() { public static void init(LivingEntity spawned) { if (!(spawned instanceof CraftMob craftMob)) return; - EnderMan nmsEnderman = (EnderMan) craftMob.getHandle(); + Enderman nmsEnderman = (Enderman) craftMob.getHandle(); nmsEnderman.goalSelector.removeAllGoals(goal -> true); nmsEnderman.targetSelector.removeAllGoals(goal -> true); diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java index bd771b66..3c5fcf1a 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/entities/BlightedEntity.java @@ -831,16 +831,16 @@ public void syncAttachments() { double zPrime = baseLocation.getZ() + (offset.getX() * sin + offset.getZ() * cos); double yPrime = baseLocation.getY() + offset.getY(); - Location currentLoc = attachedEntity.getLocation(); - float targetYaw = attachment.syncYaw() ? baseLocation.getYaw() : currentLoc.getYaw(); - float targetPitch = attachment.syncPitch() ? baseLocation.getPitch() : currentLoc.getPitch(); - - if (currentLoc.getWorld() == baseLocation.getWorld() - && Math.abs(currentLoc.getX() - xPrime) < 0.001 - && Math.abs(currentLoc.getY() - yPrime) < 0.001 - && Math.abs(currentLoc.getZ() - zPrime) < 0.001 - && Math.abs(currentLoc.getYaw() - targetYaw) < 0.1f - && Math.abs(currentLoc.getPitch() - targetPitch) < 0.1f) { + Location currentLocation = attachedEntity.getLocation(); + float targetYaw = attachment.syncYaw() ? baseLocation.getYaw() : currentLocation.getYaw(); + float targetPitch = attachment.syncPitch() ? baseLocation.getPitch() : currentLocation.getPitch(); + + if (currentLocation.getWorld() == baseLocation.getWorld() + && Math.abs(currentLocation.getX() - xPrime) < 0.001 + && Math.abs(currentLocation.getY() - yPrime) < 0.001 + && Math.abs(currentLocation.getZ() - zPrime) < 0.001 + && Math.abs(currentLocation.getYaw() - targetYaw) < 0.1f + && Math.abs(currentLocation.getPitch() - targetPitch) < 0.1f) { continue; } From 2b04dbeb56838b4f95dcd8267fee2a3b00b7cee5 Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 23:25:59 +0200 Subject: [PATCH 24/31] refactor(bedrock): add primitive custom model data overload and CommandSender message target - Add setCustomModelData(int) overload to ItemBuilder to avoid boxing. - Add send(CommandSender) overload to InteractiveMessage for non-player targets. --- .../bedrock/text/InteractiveMessage.java | 17 +++++++++++++++++ .../fr/moussax/bedrock/utils/ItemBuilder.java | 13 +++++++++++-- 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/bedrock/src/main/java/fr/moussax/bedrock/text/InteractiveMessage.java b/bedrock/src/main/java/fr/moussax/bedrock/text/InteractiveMessage.java index a5689d61..f733270a 100644 --- a/bedrock/src/main/java/fr/moussax/bedrock/text/InteractiveMessage.java +++ b/bedrock/src/main/java/fr/moussax/bedrock/text/InteractiveMessage.java @@ -6,6 +6,7 @@ import net.md_5.bungee.api.chat.HoverEvent; import net.md_5.bungee.api.chat.TextComponent; import net.md_5.bungee.api.chat.hover.content.Text; +import org.bukkit.command.CommandSender; import org.bukkit.entity.Player; import org.jspecify.annotations.NonNull; import org.jspecify.annotations.Nullable; @@ -120,6 +121,22 @@ public void send(@NonNull Player player) { player.spigot().sendMessage(root); } + /** + * Sends the message to a command sender. + * + *

If the sender is a {@link Player}, rich Bungee components with click/hover actions are delivered. + * Otherwise, plain text is sent.

+ * + * @param sender the recipient + */ + public void send(@NonNull CommandSender sender) { + if (sender instanceof Player player) { + send(player); + } else { + sender.sendMessage(root.toLegacyText()); + } + } + /** * Builds the message as Bungee chat components. * diff --git a/bedrock/src/main/java/fr/moussax/bedrock/utils/ItemBuilder.java b/bedrock/src/main/java/fr/moussax/bedrock/utils/ItemBuilder.java index 1b5c24f9..6444c9c7 100644 --- a/bedrock/src/main/java/fr/moussax/bedrock/utils/ItemBuilder.java +++ b/bedrock/src/main/java/fr/moussax/bedrock/utils/ItemBuilder.java @@ -435,10 +435,19 @@ public ItemBuilder setCustomModelData(@Nullable Integer data) { return this; } + return setCustomModelData(data.intValue()); + } + + /** + * Sets the item's custom model data. + * + * @param data the custom model data value + * @return this builder + */ + public ItemBuilder setCustomModelData(int data) { CustomModelDataComponent component = itemMeta.getCustomModelDataComponent(); - component.setFloats(List.of(data.floatValue())); + component.setFloats(List.of((float) data)); itemMeta.setCustomModelDataComponent(component); - return this; } From 1f57ce6ca9191ea048cbe5da86d964185692806f Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 23:26:00 +0200 Subject: [PATCH 25/31] refactor(mod): synchronize IP ban cache removal and ensure database shutdown safety - Synchronize IP_BAN removal in PunishmentManager active ban cache. - Log SQLite close exceptions in PluginDatabase without throwing during teardown. --- .../java/fr/moussax/blightedMod/database/PluginDatabase.java | 3 +-- .../blightedMod/moderator/punishments/PunishmentManager.java | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/database/PluginDatabase.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/database/PluginDatabase.java index 077edfc1..9174a1d1 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/database/PluginDatabase.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/database/PluginDatabase.java @@ -25,8 +25,7 @@ public void closeConnection() { connection.close(); } } catch (SQLException exception) { - Log.error("PluginDatabase", exception.getMessage()); - throw new RuntimeException("Unable to close the database connection", exception); + Log.error("PluginDatabase", "Failed to close database connection: " + exception.getMessage()); } } } diff --git a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentManager.java b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentManager.java index ad63c4b4..3703ea73 100644 --- a/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentManager.java +++ b/blighted-mod/src/main/java/fr/moussax/blightedMod/moderator/punishments/PunishmentManager.java @@ -119,7 +119,7 @@ public void removePunishment(UUID playerUuid, PunishmentData.PunishmentType type if (type == PunishmentData.PunishmentType.MUTE) { activeMutedPlayers.remove(playerUuid); - } else if (type == PunishmentData.PunishmentType.BAN) { + } else if (type == PunishmentData.PunishmentType.BAN || type == PunishmentData.PunishmentType.IP_BAN) { activeBannedPlayers.remove(playerUuid); } } catch (SQLException exception) { @@ -186,7 +186,7 @@ public PunishmentData getActivePunishment(UUID playerUuid, PunishmentData.Punish deactivatePunishment(punishment.id()); if (type == PunishmentData.PunishmentType.MUTE) { activeMutedPlayers.remove(playerUuid); - } else if (type == PunishmentData.PunishmentType.BAN) { + } else if (type == PunishmentData.PunishmentType.BAN || type == PunishmentData.PunishmentType.IP_BAN) { activeBannedPlayers.remove(playerUuid); } return null; From cdbabacb2f4a3d467a8734fb4511686c84d525f0 Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 23:30:46 +0200 Subject: [PATCH 26/31] refactor(smp): enforce null check in ShapelessRecipeBuilder and simplify block place listener - Add Objects.requireNonNull validation for result item in ShapelessRecipeBuilder. - Remove redundant hasItemMeta check before meta null check in BlightedBlockListener. --- .../blightedSMP/engine/items/blocks/BlightedBlockListener.java | 1 - .../items/recipes/crafting/builder/ShapelessRecipeBuilder.java | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java index 24a44d36..3c09b61f 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/blocks/BlightedBlockListener.java @@ -58,7 +58,6 @@ private String getBlockId(Block block) { @EventHandler public void onBlockPlace(BlockPlaceEvent event) { ItemStack item = event.getItemInHand(); - if (!item.hasItemMeta()) return; ItemMeta meta = item.getItemMeta(); if (meta == null) return; diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java index 6040856f..2a6ceba6 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/recipes/crafting/builder/ShapelessRecipeBuilder.java @@ -8,6 +8,7 @@ import java.util.ArrayList; import java.util.List; +import java.util.Objects; /** * Fluent builder for creating {@link BlightedShapelessRecipe} instances. @@ -24,7 +25,7 @@ public final class ShapelessRecipeBuilder { private CraftingObject attributeSource = null; private ShapelessRecipeBuilder(BlightedItem result, int amount) { - this.result = result; + this.result = Objects.requireNonNull(result, "result"); this.amount = amount; } From c99af48fec8b9ed73d19193f821973839f33883c Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 23:37:47 +0200 Subject: [PATCH 27/31] fix(sign): initialize SignBlockEntity tile entity editor state for Spigot 26.3 - Construct and transmit SignBlockEntity tile entity update packet with allowedPlayerEditor set. - Restore block state and tile entity state when completing sign input session in SignInputManager. --- .../bedrock/ui/sign/SignInputManager.java | 20 +++++++--- .../bedrock/ui/sign/SignInputMenu.java | 37 ++++++++++++++----- 2 files changed, 42 insertions(+), 15 deletions(-) diff --git a/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputManager.java b/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputManager.java index eff617bd..b75fd242 100644 --- a/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputManager.java +++ b/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputManager.java @@ -2,8 +2,10 @@ import fr.moussax.bedrock.scheduling.PluginContext; import net.minecraft.core.BlockPos; +import net.minecraft.network.protocol.Packet; import net.minecraft.network.protocol.game.ClientboundBlockUpdatePacket; import net.minecraft.server.level.ServerPlayer; +import net.minecraft.world.level.block.entity.BlockEntity; import net.minecraft.world.level.block.state.BlockState; import org.bukkit.Bukkit; import org.bukkit.craftbukkit.entity.CraftPlayer; @@ -29,7 +31,7 @@ private record Session(SignInputMenu menu, BlockPos position) { * Registers an active sign input session for a player. * * @param PlayerId player unique identifier - * @param menu sign input menu handling the session + * @param menu sign input menu handling the session * @param position temporary sign position */ static void register(UUID PlayerId, SignInputMenu menu, BlockPos position) { @@ -43,7 +45,7 @@ static void register(UUID PlayerId, SignInputMenu menu, BlockPos position) { * invoked.

* * @param player player who submitted the input - * @param lines submitted sign lines + * @param lines submitted sign lines */ public static void handleSignUpdate(Player player, String[] lines) { Session session = sessions.remove(player.getUniqueId()); @@ -54,11 +56,19 @@ public static void handleSignUpdate(Player player, String[] lines) { BlockState actualState = nmsPlayer.level().getBlockState(session.position); nmsPlayer.connection.send(new ClientboundBlockUpdatePacket(session.position, actualState)); + BlockEntity actualTile = nmsPlayer.level().getBlockEntity(session.position); + if (actualTile != null) { + Packet updatePacket = actualTile.getUpdatePacket(); + if (updatePacket != null) { + nmsPlayer.connection.send(updatePacket); + } + } + Bukkit.getScheduler().runTask(PluginContext.get(), () -> { - if (player.isOnline()) { - session.menu().handleComplete(player, lines); + if (player.isOnline()) { + session.menu().handleComplete(player, lines); + } } - } ); } diff --git a/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputMenu.java b/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputMenu.java index 4c1b53a0..e34e8129 100644 --- a/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputMenu.java +++ b/bedrock/src/main/java/fr/moussax/bedrock/ui/sign/SignInputMenu.java @@ -2,12 +2,18 @@ import fr.moussax.bedrock.scheduling.PluginContext; import net.minecraft.core.BlockPos; +import net.minecraft.network.chat.Component; +import net.minecraft.network.protocol.game.ClientboundBlockEntityDataPacket; +import net.minecraft.network.protocol.game.ClientboundBlockUpdatePacket; import net.minecraft.network.protocol.game.ClientboundOpenSignEditorPacket; -import net.minecraft.world.level.block.entity.SignTextSlot; import net.minecraft.server.level.ServerPlayer; +import net.minecraft.world.level.block.Blocks; +import net.minecraft.world.level.block.entity.SignBlockEntity; +import net.minecraft.world.level.block.entity.SignText; +import net.minecraft.world.level.block.entity.SignTextSlot; +import net.minecraft.world.level.block.state.BlockState; import org.bukkit.Bukkit; import org.bukkit.Location; -import org.bukkit.Material; import org.bukkit.craftbukkit.entity.CraftPlayer; import org.bukkit.entity.Player; import org.jspecify.annotations.NonNull; @@ -48,23 +54,34 @@ public SignInputMenu(String[] lines, Consumer onComplete, boole */ public void open(@NonNull Player player) { Location location = player.getLocation().clone(); - location.setY(location.getY() + 3); - player.sendBlockChange(location, Material.PALE_OAK_SIGN.createBlockData()); + location.setY(location.getY() + 1); + + BlockPos blockPosition = new BlockPos(location.getBlockX(), location.getBlockY(), location.getBlockZ()); + ServerPlayer nmsPlayer = ((CraftPlayer) player).getHandle(); - String[] safeLines = new String[]{"", "", "", ""}; + BlockState blockState = Blocks.OAK_SIGN.defaultBlockState(); + nmsPlayer.connection.send(new ClientboundBlockUpdatePacket(blockPosition, blockState)); + + SignBlockEntity signTile = new SignBlockEntity(blockPosition, blockState); + signTile.setAllowedPlayerEditor(player.getUniqueId()); + signTile.setWaxed(false); + + SignTextSlot slot = frontSide ? SignTextSlot.FRONT : SignTextSlot.BACK; + SignText.Mutable mutableText = SignText.EMPTY.asMutable(); for (int i = 0; i < Math.min(4, lines.length); i++) { - safeLines[i] = lines[i] != null ? lines[i] : ""; + String lineText = lines[i] != null ? lines[i] : ""; + mutableText.setLine(i, Component.literal(lineText)); } - player.sendSignChange(location, safeLines); + signTile.setText(mutableText.asImmutable(), slot); - BlockPos blockPosition = new BlockPos(location.getBlockX(), location.getBlockY(), location.getBlockZ()); - ServerPlayer nmsPlayer = ((CraftPlayer) player).getHandle(); + ClientboundBlockEntityDataPacket tilePacket = signTile.getUpdatePacket(); + nmsPlayer.connection.send(tilePacket); Bukkit.getScheduler().runTaskLater(PluginContext.get(), () -> { if (!player.isOnline()) { return; } - nmsPlayer.connection.send(new ClientboundOpenSignEditorPacket(blockPosition, frontSide ? SignTextSlot.FRONT : SignTextSlot.BACK)); + nmsPlayer.connection.send(new ClientboundOpenSignEditorPacket(blockPosition, slot)); SignInputManager.register(player.getUniqueId(), this, blockPosition); }, 2L); } From 4b924a77ddb9f26d7e4fddd1f7d038499f7d508d Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 23:51:16 +0200 Subject: [PATCH 28/31] fix(smp): enforce vanilla anvil caps, patch ability damage attribution, and fix Bonemerang duplication - Cap standard vanilla book merging at vanillaMax while allowing custom over-capped books up to level 10 in UnsafeAnvilListener. - Scale anvil repair XP cost dynamically for over-capped enchantment tiers. - Match Hyperion by BlightedItem ID and attribute damager Player in WitherImpactAbility and KnightsSlamAbility. - Accurately calculate and report total damage dealt in WitherImpactAbility. - Tag thrown Bonemerang placeholder nugget with PDC key to prevent item duplication bugs. --- .../items/abilities/BonemerangAbility.java | 51 +++++++++---------- .../items/abilities/KnightsSlamAbility.java | 2 +- .../items/abilities/WitherImpactAbility.java | 23 +++++---- .../items/listeners/UnsafeAnvilListener.java | 31 ++++++++--- 4 files changed, 61 insertions(+), 46 deletions(-) diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/BonemerangAbility.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/BonemerangAbility.java index cc13bfb9..e52f6b64 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/BonemerangAbility.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/BonemerangAbility.java @@ -4,6 +4,7 @@ import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; import fr.moussax.blightedSMP.engine.items.abilities.AbilityType; import org.bukkit.Material; +import org.bukkit.NamespacedKey; import org.bukkit.Particle; import org.bukkit.Sound; import org.bukkit.entity.ArmorStand; @@ -14,6 +15,7 @@ import org.bukkit.inventory.EquipmentSlot; import org.bukkit.inventory.Inventory; import org.bukkit.inventory.ItemStack; +import org.bukkit.persistence.PersistentDataType; import org.bukkit.scheduler.BukkitRunnable; import org.bukkit.util.EulerAngle; import org.bukkit.util.Vector; @@ -21,6 +23,8 @@ import java.util.Map; public class BonemerangAbility implements AbilityManager { + + private static final NamespacedKey THROWN_KEY = new NamespacedKey(BlightedSMP.getInstance(), "thrown_bonemerang"); private static final int OUTBOUND_TICKS = 13; private static final int RETURN_TICKS = 13; private static final double PROJECTILE_SPEED = 1.16; @@ -74,20 +78,21 @@ private void reduceStackInHand(Player player, ItemStack hand) { } private void setThrownVisualInHand(Player player, ItemStack from) { - ItemStack nugget = from.clone(); - nugget.setType(Material.IRON_NUGGET); - var meta = from.getItemMeta(); + ItemStack nugget = new ItemStack(Material.IRON_NUGGET); + var meta = nugget.getItemMeta(); if (meta != null) { - nugget.setItemMeta(meta.clone()); + meta.getPersistentDataContainer().set(THROWN_KEY, PersistentDataType.BYTE, (byte) 1); + meta.setDisplayName("§7Bonemerang (Thrown...)"); + nugget.setItemMeta(meta); } player.getInventory().setItemInMainHand(nugget); } private void launchProjectile(Player player, ItemStack toRestore) { ArmorStand projectile = player.getWorld().spawn( - player.getLocation().add(0, SPAWN_HEIGHT_OFFSET, 0), - ArmorStand.class, - this::configureArmorStand + player.getLocation().add(0, SPAWN_HEIGHT_OFFSET, 0), + ArmorStand.class, + this::configureArmorStand ); player.playSound(player.getLocation(), Sound.BLOCK_BONE_BLOCK_BREAK, 2.0f, 1.75f); @@ -153,17 +158,17 @@ private void configureArmorStand(ArmorStand stand) { private void updateProjectilePosition(ArmorStand projectile, Player player, Vector direction, boolean returning) { Vector movement = returning - ? player.getLocation().subtract(projectile.getLocation()).toVector().normalize().multiply(PROJECTILE_SPEED) - : direction.clone().multiply(PROJECTILE_SPEED); + ? player.getLocation().subtract(projectile.getLocation()).toVector().normalize().multiply(PROJECTILE_SPEED) + : direction.clone().multiply(PROJECTILE_SPEED); projectile.teleport(projectile.getLocation().add(movement)); } private void updateProjectileRotation(ArmorStand projectile, int tick) { projectile.setRightArmPose(new EulerAngle( - 0, - Math.toRadians(90 + (ROTATION_SPEED * tick)), - 0 + 0, + Math.toRadians(90 + (ROTATION_SPEED * tick)), + 0 )); } @@ -196,7 +201,7 @@ private void returnItem(Player player, String expectedName, ItemStack original) Map leftovers = inventory.addItem(original); if (!leftovers.isEmpty()) { leftovers.values().forEach(item -> - player.getWorld().dropItemNaturally(player.getLocation(), item) + player.getWorld().dropItemNaturally(player.getLocation(), item) ); } } @@ -204,22 +209,14 @@ private void returnItem(Player player, String expectedName, ItemStack original) private boolean replaceNuggetWithOriginal(Inventory inventory, ItemStack original) { for (int i = 0; i < inventory.getSize(); i++) { ItemStack slot = inventory.getItem(i); - if (isSameCustomNugget(slot, original)) { - inventory.setItem(i, original); - return true; + if (slot != null && slot.getType() == Material.IRON_NUGGET && slot.hasItemMeta()) { + var meta = slot.getItemMeta(); + if (meta != null && meta.getPersistentDataContainer().has(THROWN_KEY, PersistentDataType.BYTE)) { + inventory.setItem(i, original); + return true; + } } } return false; } - - private boolean isSameCustomNugget(ItemStack a, ItemStack b) { - if (a == null || b == null || a.getType() != Material.IRON_NUGGET) { - return false; - } - - var aMeta = a.getItemMeta(); - var bMeta = b.getItemMeta(); - - return aMeta != null && aMeta.equals(bMeta); - } } \ No newline at end of file diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/KnightsSlamAbility.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/KnightsSlamAbility.java index db71731c..4d3673ce 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/KnightsSlamAbility.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/KnightsSlamAbility.java @@ -61,7 +61,7 @@ private KnightSword(Location location, BlightedPlayer player) { for (Entity entity : entities) { LivingEntity livingEntity = (LivingEntity) entity; - livingEntity.damage(abilityDamage); + livingEntity.damage(abilityDamage, player.getPlayer()); enemies++; } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/WitherImpactAbility.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/WitherImpactAbility.java index e27c8877..f9aa3b0f 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/WitherImpactAbility.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/content/items/abilities/WitherImpactAbility.java @@ -1,9 +1,9 @@ package fr.moussax.blightedSMP.content.items.abilities; import fr.moussax.blightedSMP.BlightedSMP; +import fr.moussax.blightedSMP.engine.items.BlightedItem; import fr.moussax.blightedSMP.engine.items.abilities.AbilityManager; import fr.moussax.blightedSMP.engine.items.abilities.AbilityType; -import fr.moussax.blightedSMP.engine.items.registry.ItemRegistry; import fr.moussax.blightedSMP.engine.player.BlightedPlayer; import fr.moussax.bedrock.text.Formatter; import fr.moussax.bedrock.text.Messenger; @@ -53,12 +53,10 @@ public boolean triggerAbility(PlayerInteractEvent event) { } Player player = event.getPlayer(); - ItemStack item = player.getInventory().getItemInMainHand(); if (!isHoldingHyperion(player)) return false; teleport(player); - int entitiesDamaged = damageNearbyEntities(player); - notifyPlayerOfAbilityDamage(player, entitiesDamaged); + damageNearbyEntities(player); if (canUseHealingAbility(player)) { applyHealingEffect(player); @@ -68,7 +66,8 @@ public boolean triggerAbility(PlayerInteractEvent event) { } private boolean isHoldingHyperion(Player player) { - return player.getInventory().getItemInMainHand().equals(ItemRegistry.get("HYPERION").toItemStack()); + BlightedItem blightedItem = BlightedItem.fromItemStack(player.getInventory().getItemInMainHand()); + return blightedItem != null && "HYPERION".equals(blightedItem.getItemId()); } private void teleport(Player player) { @@ -90,22 +89,24 @@ private Location findTeleportDestination(Player player, Vector direction) { return location.clone().add(direction.clone().multiply(TELEPORT_DISTANCE)); } - private int damageNearbyEntities(Player origin) { + private double damageNearbyEntities(Player origin) { double damage = MIN_DAMAGE + (Math.random() * (MAX_DAMAGE - MIN_DAMAGE)); + double totalDamageDealt = 0.0; int entitiesDamaged = 0; for (Entity entity : origin.getNearbyEntities(DAMAGE_RANGE, DAMAGE_RANGE, DAMAGE_RANGE)) { - if (entity instanceof LivingEntity && !(entity instanceof Player)) { - ((LivingEntity) entity).damage(damage); + if (entity instanceof LivingEntity livingEntity && !(entity instanceof Player)) { + livingEntity.damage(damage, origin); + totalDamageDealt += damage; entitiesDamaged++; } } - return entitiesDamaged; + notifyPlayerOfAbilityDamage(origin, entitiesDamaged, totalDamageDealt); + return totalDamageDealt; } - private void notifyPlayerOfAbilityDamage(Player player, int entitiesDamaged) { + private void notifyPlayerOfAbilityDamage(Player player, int entitiesDamaged, double totalDamage) { if (entitiesDamaged > 0) { - double totalDamage = (double) entitiesDamaged * (15000.0D + Math.random() * 135000.0D); Messenger.inform(player, "Your implosion hit §d" + entitiesDamaged + " §7enem" + (entitiesDamaged > 1 ? "ies" : "y") + " for §d" + Formatter.formatDecimalWithCommas(totalDamage) + " §7damage."); } } diff --git a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/listeners/UnsafeAnvilListener.java b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/listeners/UnsafeAnvilListener.java index 746cc43d..269fbdeb 100644 --- a/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/listeners/UnsafeAnvilListener.java +++ b/blighted-smp/src/main/java/fr/moussax/blightedSMP/engine/items/listeners/UnsafeAnvilListener.java @@ -16,9 +16,11 @@ import java.util.Map; +@SuppressWarnings("UnstableApiUsage") public final class UnsafeAnvilListener implements Listener { private static final int ENCHANTMENT_HARD_CAP = 10; + private static final int OVERCAP_XP_COST_PER_TIER = 4; @EventHandler(priority = EventPriority.HIGH) public void onPrepareAnvil(PrepareAnvilEvent event) { @@ -38,11 +40,13 @@ public void onPrepareAnvil(PrepareAnvilEvent event) { if (resultMeta == null) return; boolean isResultBook = result.getType() == Material.ENCHANTED_BOOK; - Map currentEnchants = isResultBook && resultMeta instanceof EnchantmentStorageMeta storageMeta + Map currentEnchants = isResultBook + && resultMeta instanceof EnchantmentStorageMeta storageMeta ? storageMeta.getStoredEnchants() : resultMeta.getEnchants(); boolean changed = false; + int maxOvercapTier = 0; for (Map.Entry entry : bookMeta.getStoredEnchants().entrySet()) { Enchantment enchant = entry.getKey(); @@ -51,14 +55,15 @@ public void onPrepareAnvil(PrepareAnvilEvent event) { if (!enchant.canEnchantItem(result) && !isResultBook) continue; int currentLevel = currentEnchants.getOrDefault(enchant, 0); + int vanillaMax = enchant.getMaxLevel(); - int targetLevel = (currentLevel == bookLevel && currentLevel != enchant.getMaxLevel()) - ? currentLevel + 1 - : Math.max(currentLevel, bookLevel); - int finalLevel = Math.min(targetLevel, ENCHANTMENT_HARD_CAP); - + int finalLevel = getFinalLevel(bookLevel, vanillaMax, currentLevel); if (finalLevel <= currentLevel) continue; + if (finalLevel > vanillaMax) { + maxOvercapTier = Math.max(maxOvercapTier, finalLevel - vanillaMax); + } + if (isResultBook && resultMeta instanceof EnchantmentStorageMeta storageMeta) { storageMeta.addStoredEnchant(enchant, finalLevel, true); } else { @@ -83,7 +88,7 @@ public void onPrepareAnvil(PrepareAnvilEvent event) { int rightRepairCost = rightMeta instanceof Repairable repairable ? repairable.getRepairCost() : 0; resultRepairable.setRepairCost(leftRepairCost + rightRepairCost + 2); - int xpCost = Math.max(1, (leftRepairCost + rightRepairCost) + 2); + int xpCost = Math.max(1, (leftRepairCost + rightRepairCost) + 2 + (maxOvercapTier * OVERCAP_XP_COST_PER_TIER)); anvilView.setRepairCost(xpCost); } @@ -91,6 +96,18 @@ public void onPrepareAnvil(PrepareAnvilEvent event) { event.setResult(result); } + private static int getFinalLevel(int bookLevel, int vanillaMax, int currentLevel) { + int targetLevel; + if (bookLevel <= vanillaMax && currentLevel <= vanillaMax) { + // Vanilla combining logic capped at standard vanilla max level + targetLevel = (currentLevel == bookLevel) ? Math.min(currentLevel + 1, vanillaMax) : Math.max(currentLevel, bookLevel); + } else { + // Unsafe combining logic for custom over-capped book drops + targetLevel = (currentLevel == bookLevel) ? currentLevel + 1 : Math.max(currentLevel, bookLevel); + } + return Math.min(targetLevel, ENCHANTMENT_HARD_CAP); + } + private static boolean isCustomNonEquipment(ItemStack itemStack) { if (itemStack == null || itemStack.getType() == Material.AIR) return false; BlightedItem blightedItem = BlightedItem.fromItemStack(itemStack); From da8c98cca18121e0fb13a2d2141a883c30d5bf88 Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 23:58:30 +0200 Subject: [PATCH 29/31] chore: update api version to 26.3 in both plugins --- blighted-mod/src/main/resources/plugin.yml | 10 +++++----- blighted-smp/src/main/resources/plugin.yml | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/blighted-mod/src/main/resources/plugin.yml b/blighted-mod/src/main/resources/plugin.yml index ea659872..f2fc333e 100644 --- a/blighted-mod/src/main/resources/plugin.yml +++ b/blighted-mod/src/main/resources/plugin.yml @@ -3,7 +3,7 @@ version: '${version}' authors: [ MrInspection ] main: fr.moussax.blightedMod.BlightedMod -api-version: '26.2' +api-version: '26.3' load: STARTUP commands: @@ -15,7 +15,7 @@ commands: permission: blightedmod.moderator vanish: description: Toggle vanish mode. - aliases: [v] + aliases: [ v ] permission: blightedmod.moderator mute: description: Mute a player. @@ -54,7 +54,7 @@ commands: description: Report a player or message to online moderators. slowmode: description: Set or toggle chat slowmode delay in seconds. - aliases: [setslowmode] + aliases: [ setslowmode ] permission: blightedmod.moderator reports: description: View active player reports. @@ -73,8 +73,8 @@ commands: permission: blightedmod.moderator chat: description: Switch active chat channel (staff, all). - aliases: [c] + aliases: [ c ] msginspect: description: Toggle private message inspection (SocialSpy). - aliases: [spy, socialspy] + aliases: [ spy, socialspy ] permission: blightedmod.moderator \ No newline at end of file diff --git a/blighted-smp/src/main/resources/plugin.yml b/blighted-smp/src/main/resources/plugin.yml index b5c97c38..e1f6d579 100644 --- a/blighted-smp/src/main/resources/plugin.yml +++ b/blighted-smp/src/main/resources/plugin.yml @@ -3,7 +3,7 @@ version: '${version}' authors: [ MrInspection ] main: fr.moussax.blightedSMP.BlightedSMP -api-version: '26.2' +api-version: '26.3' load: STARTUP commands: From 4721961e06c5b4159ac93184f90b07463ca61f8a Mon Sep 17 00:00:00 2001 From: Moussa Date: Tue, 29 Sep 2026 23:58:40 +0200 Subject: [PATCH 30/31] ci: update java version --- .github/workflows/maven.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 8eaac953..8541251a 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -1,6 +1,6 @@ name: Maven Build -on: [pull_request] +on: [ pull_request ] permissions: contents: read @@ -17,10 +17,10 @@ jobs: - name: Checkout code uses: actions/checkout@v4 - - name: Set up JDK 25 + - name: Set up JDK 26 uses: actions/setup-java@v4 with: - java-version: '25' + java-version: '26' distribution: 'temurin' cache: 'maven' @@ -45,8 +45,8 @@ jobs: - name: Verify plugin.yml api-version matches target run: | - grep -q "api-version: '26.2'" src/main/resources/plugin.yml || { - echo "::error::plugin.yml api-version doesn't match Spigot target 26.2"; exit 1; } + grep -q "api-version: '26.3'" src/main/resources/plugin.yml || { + echo "::error::plugin.yml api-version doesn't match Spigot target 26.3"; exit 1; } - name: Build and Run Tests run: mvn -B package --file pom.xml From 9cfc8e2c3b268019a6f3f34108b597e76ce4248b Mon Sep 17 00:00:00 2001 From: Moussa Date: Wed, 30 Sep 2026 00:05:26 +0200 Subject: [PATCH 31/31] fix --- .github/workflows/maven.yml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 8541251a..0228ad0e 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -18,7 +18,7 @@ jobs: uses: actions/checkout@v4 - name: Set up JDK 26 - uses: actions/setup-java@v4 + uses: actions/setup-java@v5 with: java-version: '26' distribution: 'temurin' @@ -45,8 +45,16 @@ jobs: - name: Verify plugin.yml api-version matches target run: | - grep -q "api-version: '26.3'" src/main/resources/plugin.yml || { - echo "::error::plugin.yml api-version doesn't match Spigot target 26.3"; exit 1; } + found=0 + for file in $(find . -path "*/src/main/resources/plugin.yml"); do + found=1 + grep -q "api-version: '26.3'" "$file" || { + echo "::error::$file api-version doesn't match Spigot target 26.3"; exit 1; + } + done + if [ "$found" -eq 0 ]; then + echo "::error::No plugin.yml files found to verify"; exit 1; + fi - name: Build and Run Tests run: mvn -B package --file pom.xml @@ -63,5 +71,5 @@ jobs: uses: actions/upload-artifact@v4 with: name: BlightedMC-Plugin - path: target/*.jar + path: '**/target/blighted-*.jar' retention-days: 5 \ No newline at end of file