From 1472486f7a5af2c340d194b3ae6b4e7a2ddbe889 Mon Sep 17 00:00:00 2001 From: happpppymoon Date: Mon, 23 Mar 2026 15:58:41 +0900 Subject: [PATCH] fix : Remove unused -progress pipe:1 causing pipe deadlock - ffmpeg was given -progress pipe:1 which writes progress data to stdout - stdout was redirected but never read, filling the pipe buffer - Once the buffer filled, ffmpeg blocked on write and hung indefinitely - Output files had no moov atom written, resulting in unplayable files - Progress parsing already works via stderr legacy format (size=... time=...) - previously: `-n -progress pipe:1` with `RedirectStandardOutput = true` - now: `-n` with `RedirectStandardOutput = false` --- .../ConversionJobs/ConversionJob_FFMPEG.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Application/FileConverter/ConversionJobs/ConversionJob_FFMPEG.cs b/Application/FileConverter/ConversionJobs/ConversionJob_FFMPEG.cs index 79f81586..7d0d5083 100644 --- a/Application/FileConverter/ConversionJobs/ConversionJob_FFMPEG.cs +++ b/Application/FileConverter/ConversionJobs/ConversionJob_FFMPEG.cs @@ -77,9 +77,9 @@ protected override void Initialize() this.ffmpegProcessStartInfo = new ProcessStartInfo(ffmpegPath) { - CreateNoWindow = true, - UseShellExecute = false, - RedirectStandardOutput = true, + CreateNoWindow = true, + UseShellExecute = false, + RedirectStandardOutput = false, RedirectStandardError = true }; @@ -88,7 +88,7 @@ protected override void Initialize() protected virtual void FillFFMpegArgumentsList() { - const string baseArgs = "-n -progress pipe:1"; + const string baseArgs = "-n"; bool customCommandEnabled = this.ConversionPreset.GetSettingsValue(ConversionPreset.ConversionSettingKeys.EnableFFMPEGCustomCommand); if (customCommandEnabled) @@ -424,7 +424,7 @@ protected virtual void FillFFMpegArgumentsList() } } } - + protected override void Convert() { if (this.ConversionPreset == null)