Ceedling clobber removing project files not generated by Ceedling

[dmueller-tzmedical]

When running the command ceedling clobber in the base of my project I noticed it was deleting some *.bak files I use for other testing unrelated to ceedling and completely external to the file system used for my ceedling tests. I've included a sample output running clobber, which shows the command to rm -r device_files/firmware_testing/H3R_Settings/09_Server_Side_Requests/tmp/events.bak

ceedling clobber -v 4
Loaded project configuration from working directory.
 > Using: C:/workspace/some-project/project.yml
 > Working directory: C:/workspace/some-project
 > Set which Ceedling from config :project >> :which_ceedling => gem
 > Launching Ceedling from C:/tools/ruby34/lib/ruby/gems/3.4.0/gems/ceedling-1.0.1/

Application & Build Frameworks
   Ceedling => 1.0.1-fb1ce6c
      CMock => 2.6.0
      Unity => 2.6.1
 CException => 1.3.4

Validating configuration contains minimum required sections...

Base configuration handling...

Plugin Handling
---------------
Discovering all plugins...
Merging configuration from plugin module_generator...
Merging configuration from plugin report_tests_pretty_stdout...

Assembling Default Settings
---------------------------
Collecting default tool configurations...
Collecting CMock defaults...
Collecting Plugin YAML defaults...
Collecting Plugin Ruby hash defaults...
Populating project configuration with collected default values...

Completing Project Configuration
--------------------------------
Processing Unity configuration...
Processing CMock configuration...
Populating test runner generation settings...
Processing environment variables...
Processing path entries and expanding any string replacements...
Expanding any string replacements in :flags entries...
Expanding any string replacements in :defines entries...
Standardizing all paths...
Populating tool definition settings and expanding any string replacements...
Processing tool definition shortcuts...

Validating final project configuration...

Loading Plugins
---------------
Adding plugin gcov to Rake load list...
Adding plugin module_generator to Rake load list...
Instantiating plugin class Gcov...
Instantiating plugin class ModuleGenerator...
Instantiating plugin class ReportTestsRawOutputLog...
Instantiating plugin class ReportTestsPrettyStdout...
Instantiating plugin class ReportTestsLogFactory...
rm -r device_files/firmware_testing/H3R_Settings/09_Server_Side_Requests/tmp/events.bak
rm -r device_files/firmware_testing/H3R_Settings/09_Server_Side_Requests/tmp/wireless.bak

Clobbering all generated files...
(For large projects, this task may take a long time to complete)

rm -r build/artifacts/test
rm -r build/test/cache
rm -r build/test/dependencies
rm -r build/test/mocks
rm -r build/test/out
rm -r build/test/preprocess
rm -r build/test/preprocess/files
rm -r build/test/preprocess/includes
rm -r build/test/results
rm -r build/test/runners

Upon future searching it appears to be related to this line of code:

Please help me understand if I'm missing something here and this is expected. My expected behavior would be to not have ceedling clobber remove files outside of the build folder

[mkarlesky]

@dmueller-tzmedical Good find. That is some very old code in Ceedling. I believe the core problem is the assumptions in those globs for CLEAN. In its very earliest versions, Ceedling assumed it was always running from the root of a project and that project structure was quite simplistic. That's no longer the case. Cleaning definitely should be restricted to the build directory.