From ac87f458713b26b7ebd3391a93589698fa92b767 Mon Sep 17 00:00:00 2001 From: "Daniel V." Date: Thu, 13 Aug 2026 16:58:43 -0400 Subject: [PATCH 1/2] Update javadocs for withdraw and deposit. --- .../net/milkbowl/vault2/economy/Economy.java | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/main/java/net/milkbowl/vault2/economy/Economy.java b/src/main/java/net/milkbowl/vault2/economy/Economy.java index 29ee234..0a39ecb 100644 --- a/src/main/java/net/milkbowl/vault2/economy/Economy.java +++ b/src/main/java/net/milkbowl/vault2/economy/Economy.java @@ -924,6 +924,9 @@ default EconomyResponse canWithdraw(@NotNull final String pluginName, @NotNull f *
* Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. + *
+ * Note: Implementations should perform checks against {@link #canWithdraw(String, UUID, BigDecimal)} first where implemented. + * As implementations may or may not do checks in the withdraw method as a backup verification. *

* @param pluginName The name of the plugin that is calling the method. * @param accountID the UUID associated with the account to withdraw from. @@ -945,6 +948,9 @@ default EconomyResponse canWithdraw(@NotNull final String pluginName, @NotNull f * Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. *
+ * Note: Implementations should perform checks against {@link #canWithdraw(String, UUID, String, BigDecimal)} first where implemented. + * As implementations may or may not do checks in the withdraw method as a backup verification. + *
* If the provider does not support multiple worlds, the provider's default world will be used. *

* @param pluginName The name of the plugin that is calling the method. @@ -968,6 +974,9 @@ default EconomyResponse canWithdraw(@NotNull final String pluginName, @NotNull f * Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. *
+ * Note: Implementations should perform checks against {@link #canWithdraw(String, UUID, String, String, BigDecimal)} first where implemented. + * As implementations may or may not do checks in the withdraw method as a backup verification. + *
* If the provider does not support multiple worlds, the provider's default world will be used. *
* If the provider does not support multi-currency, the provider's default currency will be @@ -1084,6 +1093,9 @@ default EconomyResponse canDeposit(@NotNull final String pluginName, @NotNull fi *
* Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. + *
+ * Note: Implementations should perform checks against {@link #canDeposit(String, UUID, BigDecimal)} first where implemented. + * As implementations may or may not do checks in the deposit method as a backup verification. *

* @param pluginName The name of the plugin that is calling the method. * @param accountID the UUID associated with the account to deposit to. @@ -1105,6 +1117,9 @@ default EconomyResponse canDeposit(@NotNull final String pluginName, @NotNull fi * Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. *
+ * Note: Implementations should perform checks against {@link #canDeposit(String, UUID, String, BigDecimal)} first where implemented. + * As implementations may or may not do checks in the deposit method as a backup verification. + *
* If the provider does not support multiple worlds, the provider's default world will be used. *

* @param pluginName The name of the plugin that is calling the method. @@ -1128,6 +1143,9 @@ default EconomyResponse canDeposit(@NotNull final String pluginName, @NotNull fi * Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. *
+ * Note: Implementations should perform checks against {@link #canDeposit(String, UUID, String, String, BigDecimal)} first where implemented. + * As implementations may or may not do checks in the deposit method as a backup verification. + *
* If the provider does not support multiple worlds, the provider's default world will be used. *
* If the provider does not support multi-currency, the provider's default currency will be From 5435b58dcebe0002b76e4f8f74d99222e52ca34e Mon Sep 17 00:00:00 2001 From: "Daniel V." Date: Thu, 13 Aug 2026 17:00:59 -0400 Subject: [PATCH 2/2] Rename implementations -> callers --- .../net/milkbowl/vault2/economy/Economy.java | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/main/java/net/milkbowl/vault2/economy/Economy.java b/src/main/java/net/milkbowl/vault2/economy/Economy.java index 0a39ecb..0042146 100644 --- a/src/main/java/net/milkbowl/vault2/economy/Economy.java +++ b/src/main/java/net/milkbowl/vault2/economy/Economy.java @@ -925,8 +925,8 @@ default EconomyResponse canWithdraw(@NotNull final String pluginName, @NotNull f * Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. *
- * Note: Implementations should perform checks against {@link #canWithdraw(String, UUID, BigDecimal)} first where implemented. - * As implementations may or may not do checks in the withdraw method as a backup verification. + * Note: Callers should perform checks against {@link #canWithdraw(String, UUID, BigDecimal)} first where implemented. + * As callers may or may not do checks in the withdraw method as a backup verification. *

* @param pluginName The name of the plugin that is calling the method. * @param accountID the UUID associated with the account to withdraw from. @@ -948,8 +948,8 @@ default EconomyResponse canWithdraw(@NotNull final String pluginName, @NotNull f * Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. *
- * Note: Implementations should perform checks against {@link #canWithdraw(String, UUID, String, BigDecimal)} first where implemented. - * As implementations may or may not do checks in the withdraw method as a backup verification. + * Note: Callers should perform checks against {@link #canWithdraw(String, UUID, String, BigDecimal)} first where implemented. + * As callers may or may not do checks in the withdraw method as a backup verification. *
* If the provider does not support multiple worlds, the provider's default world will be used. *

@@ -974,8 +974,8 @@ default EconomyResponse canWithdraw(@NotNull final String pluginName, @NotNull f * Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. *
- * Note: Implementations should perform checks against {@link #canWithdraw(String, UUID, String, String, BigDecimal)} first where implemented. - * As implementations may or may not do checks in the withdraw method as a backup verification. + * Note: Callers should perform checks against {@link #canWithdraw(String, UUID, String, String, BigDecimal)} first where implemented. + * As callers may or may not do checks in the withdraw method as a backup verification. *
* If the provider does not support multiple worlds, the provider's default world will be used. *
@@ -1094,8 +1094,8 @@ default EconomyResponse canDeposit(@NotNull final String pluginName, @NotNull fi * Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. *
- * Note: Implementations should perform checks against {@link #canDeposit(String, UUID, BigDecimal)} first where implemented. - * As implementations may or may not do checks in the deposit method as a backup verification. + * Note: Callers should perform checks against {@link #canDeposit(String, UUID, BigDecimal)} first where implemented. + * As callers may or may not do checks in the deposit method as a backup verification. *

* @param pluginName The name of the plugin that is calling the method. * @param accountID the UUID associated with the account to deposit to. @@ -1117,8 +1117,8 @@ default EconomyResponse canDeposit(@NotNull final String pluginName, @NotNull fi * Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. *
- * Note: Implementations should perform checks against {@link #canDeposit(String, UUID, String, BigDecimal)} first where implemented. - * As implementations may or may not do checks in the deposit method as a backup verification. + * Note: Callers should perform checks against {@link #canDeposit(String, UUID, String, BigDecimal)} first where implemented. + * As callers may or may not do checks in the deposit method as a backup verification. *
* If the provider does not support multiple worlds, the provider's default world will be used. *

@@ -1143,8 +1143,8 @@ default EconomyResponse canDeposit(@NotNull final String pluginName, @NotNull fi * Note: {@code pluginName} should be used for logging/diagnostics only and MUST NOT affect * business logic. *
- * Note: Implementations should perform checks against {@link #canDeposit(String, UUID, String, String, BigDecimal)} first where implemented. - * As implementations may or may not do checks in the deposit method as a backup verification. + * Note: Callers should perform checks against {@link #canDeposit(String, UUID, String, String, BigDecimal)} first where implemented. + * As callers may or may not do checks in the deposit method as a backup verification. *
* If the provider does not support multiple worlds, the provider's default world will be used. *