From dab99e46bd071c7f5a4de4ffc3bec00ed98a0d82 Mon Sep 17 00:00:00 2001 From: TheDancingDeveloper Date: Mon, 10 Aug 2026 21:04:00 +0000 Subject: [PATCH] fix: remove invalid secrets-context if: condition from release workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `secrets` context isn't available in step-level `if:` conditionals per GitHub Actions' schema (confirmed with actionlint — plain YAML parsing doesn't catch this). This silently broke parsing of the entire release.yml/container-canary.yml files: every push/tag triggered a run with 0 jobs and a generic "workflow file issue" failure, blocking the v1.4.2 release from running at all. Since DOCKERHUB_TOKEN/DOCKERHUB_USERNAME are already required repo secrets for this step to do anything useful, just make the Docker Hub login unconditional, matching the existing repo.indexarr.net/ghcr.io login steps in the same jobs. Co-Authored-By: Claude Sonnet 5 --- .github/workflows/container-canary.yml | 1 - .github/workflows/release.yml | 1 - 2 files changed, 2 deletions(-) diff --git a/.github/workflows/container-canary.yml b/.github/workflows/container-canary.yml index c398bbb..bbdb621 100644 --- a/.github/workflows/container-canary.yml +++ b/.github/workflows/container-canary.yml @@ -33,7 +33,6 @@ jobs: username: ${{ github.actor }} password: ${{ secrets.GHCR_TOKEN }} - name: Authenticate to Docker Hub (higher pull rate limit for base images) - if: ${{ secrets.DOCKERHUB_TOKEN != '' }} uses: docker/login-action@v4 with: username: ${{ secrets.DOCKERHUB_USERNAME }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 96805b8..d737fc2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -48,7 +48,6 @@ jobs: username: ${{ github.actor }} password: ${{ secrets.GHCR_TOKEN }} - name: Authenticate to Docker Hub (higher pull rate limit for base images) - if: ${{ secrets.DOCKERHUB_TOKEN != '' }} uses: docker/login-action@v4 with: username: ${{ secrets.DOCKERHUB_USERNAME }}