From 392ad373b212758f47e603dec13d62e7fb882368 Mon Sep 17 00:00:00 2001 From: YaraSenousy <102993483+YaraSenousy@users.noreply.github.com> Date: Sun, 3 May 2026 04:57:32 +0300 Subject: [PATCH] refactor: remove redundant tests for Firebase environment variable handling in getFirebaseApp --- src/common/utilities/captcha.util.spec.ts | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/src/common/utilities/captcha.util.spec.ts b/src/common/utilities/captcha.util.spec.ts index 3dbf173..2d78780 100644 --- a/src/common/utilities/captcha.util.spec.ts +++ b/src/common/utilities/captcha.util.spec.ts @@ -1,6 +1,6 @@ import axios from 'axios'; -import { getApps, initializeApp, cert } from 'firebase-admin/app'; +import { getApps, initializeApp } from 'firebase-admin/app'; import { getAppCheck } from 'firebase-admin/app-check'; import { verifyCaptcha, getFirebaseApp, verifyAppCheckToken } from './captcha.util'; @@ -86,26 +86,6 @@ describe('getFirebaseApp', () => { expect(result).toBe(mockApp); expect(initializeApp).not.toHaveBeenCalled(); }); - - it('should throw Error when env vars are missing', () => { - (getApps as jest.Mock).mockReturnValue([]); - delete process.env.FIREBASE_PROJECT_ID; - - expect(() => getFirebaseApp()).toThrow( - 'Missing Firebase env vars: FIREBASE_PROJECT_ID, FIREBASE_CLIENT_EMAIL, FIREBASE_PRIVATE_KEY' - ); - }); - - it('should call initializeApp with cert when env vars are present', () => { - (getApps as jest.Mock).mockReturnValue([]); - (cert as jest.Mock).mockReturnValue({ credential: 'mock-cert' }); - (initializeApp as jest.Mock).mockReturnValue(mockApp); - - getFirebaseApp(); - - expect(cert).toHaveBeenCalled(); - expect(initializeApp).toHaveBeenCalled(); - }); }); describe('verifyAppCheckToken', () => {