Are the props passed to the component generated by withForm not reactivte?

[mistyharsh]

I have a very simple form using @tanstack/solid-form@1.28.3:

export const InstituteForm = withForm({
  defaultValues: {
    name: '',
  },
  props: {
    status: { type: 'idle' },
    isSubmitting: false,
  },
  render(props) {
    createEffect(() => {
      console.log('Props', props.status, props.isSubmitting);
    });
  },
});

And, it is used from another component:

export function CreateInstitute() {
  const [status, setStatus] = createSignal<StatusState>({ type: 'idle' });
  const [isSubmitting, setIsSubmitting] = createSignal(false);

  const form = useAppForm(() => ({
    defaultValues: {
      name: '',
    } as InstituteFormModel,
    onSubmit: async ({ value, formApi }) => {
      setIsSubmitting(true);
      setStatus({ type: 'idle' });

      // Rest of the code
    },
  }));

  return (
    <InstituteForm
      form={form}
      status={status()}
      isSubmitting={isSubmitting()}
    />
  );
}

The createEffect never fires when the signals values are updated. Is that expected? If yes, what's the ideal workaround/pattern?

[mistyharsh]

Just looked at the createFormHook.ts implementation. This is the withForm:

function withForm({
    render,
    props
  }) {
    return (innerProps) => render({
      ...props,
      ...innerProps
    });
  }

I guess it is a bug as it doesn't use mergeProps to merge the props and loosing reactivity.

[LeCarbonator]

Could you open an issue for this? This is likely a leftover since React was the first implementation of the function instead of solid.

[mistyharsh]

Done. Added issue #2054.