From fa075a038bcac449cdd2ad80ff844e8deeea51cd Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 12 Dec 2022 21:35:38 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- podium/storage/resources/util.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/podium/storage/resources/util.py b/podium/storage/resources/util.py index 7bbef9c5..1c75e69b 100644 --- a/podium/storage/resources/util.py +++ b/podium/storage/resources/util.py @@ -78,4 +78,23 @@ def extract_tar_file(archive_file, destination_dir, encoding="uft-8"): if not os.path.exists(archive_file): raise ValueError(f"Given archive file doesn't exist. Given {archive_file}.") with tarfile.open(name=archive_file, mode="r") as tar_ref: - tar_ref.extractall(path=destination_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar_ref, path=destination_dir)