Describe the bug
Opening the Save Query modal switches the Monaco editor theme to the UI theme. Because Monaco's theme registry is global, the change leaks into every other Monaco instance (the main console editor, cell editors, etc.) and persists after the modal is closed.
This only shows up if you have picked an editor theme in Settings → Appearance that differs from the UI theme. In that case the colors in the main editor visibly change the moment the modal opens and stay wrong until the editor is remounted (tab switch, app reload, ...).
The modal passes theme={currentTheme.id} to Monaco instead of resolving settings.editorTheme like SqlEditorWrapper does, and it never calls loadMonacoTheme in beforeMount, so the global monaco.editor.setTheme() call overwrites the previously active theme.
To Reproduce
- Open Settings → Appearance and set an editor theme different from the UI theme (e.g. UI: Default Dark, Editor: Monokai).
- Open the SQL editor — syntax colors follow the editor theme.
- Right-click a query → Save Query.
- Look at the SQL preview inside the modal and at the main editor behind it: both now use the UI theme colors. Closing the modal does not restore the editor theme.
OS Version
Linux (Arch, KDE) — reproducible on any platform
Tabularis Version
v0.11.0
Relevant Log Output
Describe the bug
Opening the Save Query modal switches the Monaco editor theme to the UI theme. Because Monaco's theme registry is global, the change leaks into every other Monaco instance (the main console editor, cell editors, etc.) and persists after the modal is closed.
This only shows up if you have picked an editor theme in Settings → Appearance that differs from the UI theme. In that case the colors in the main editor visibly change the moment the modal opens and stay wrong until the editor is remounted (tab switch, app reload, ...).
The modal passes
theme={currentTheme.id}to Monaco instead of resolvingsettings.editorThemelikeSqlEditorWrapperdoes, and it never callsloadMonacoThemeinbeforeMount, so the globalmonaco.editor.setTheme()call overwrites the previously active theme.To Reproduce
OS Version
Linux (Arch, KDE) — reproducible on any platform
Tabularis Version
v0.11.0
Relevant Log Output