perf(welcome): index connection tree to rebuild groups in linear time (#1743)

desperadoxhy · xuhengyu · datlechin · web-flow · commit dd34dbc8a7a8 · 2026-06-21T23:00:47.000+07:00
* perf(welcome): index connection tree to rebuild groups in linear time

* refactor(welcome): build the tree index once and drop dead aggregation state

---------

Co-authored-by: xuhengyu &lt;xuhengyu@aspirecn.com&gt;
Co-authored-by: Ngo Quoc Dat &lt;datlechin@gmail.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - The connection Export Options dialog keeps a steady size when you turn on Include Credentials, and saves through the standard macOS save dialog.
 - Data grid now serves the row count from its existing cache instead of recomputing it on every layout pass, reducing CPU churn while scrolling large result sets.
 - Typing in the sidebar table search stays responsive on databases with thousands of tables; filtering runs after a short pause instead of on every keystroke.
+- The welcome sidebar rebuilds its connection tree in linear time, so favoriting, moving, or regrouping connections stays responsive with many connections and nested groups.
 - Autocomplete ranks each fuzzy candidate once per keystroke instead of three times, keeping the suggestion list snappy on wide SELECT clauses with hundreds of columns.
 
 ### Fixed
diff --git a/TablePro/Models/Connection/ConnectionGroupTree.swift b/TablePro/Models/Connection/ConnectionGroupTree.swift
@@ -163,3 +163,237 @@ func connectionCount(in groupId: UUID, connections: [DatabaseConnection], groups
     }.count
     return directCount + descendantCount
 }
+
+// MARK: - Indexed Tree (O(G+C))
+
+struct GroupTreeIndices {
+    var connectionCountByGroup: [UUID: Int] = [:]
+    var depthByGroup: [UUID: Int] = [:]
+    var maxDescendantDepthByGroup: [UUID: Int] = [:]
+}
+
+private struct GroupTreeIndex {
+    let validGroupIds: Set<UUID>
+    let childrenByParentId: [UUID?: [ConnectionGroup]]
+    let connectionsByGroupId: [UUID: [DatabaseConnection]]
+}
+
+private func sortGroups(_ groups: [ConnectionGroup]) -> [ConnectionGroup] {
+    groups.sorted {
+        $0.sortOrder != $1.sortOrder
+            ? $0.sortOrder < $1.sortOrder
+            : $0.name.localizedStandardCompare($1.name) == .orderedAscending
+    }
+}
+
+private func sortConnections(_ connections: [DatabaseConnection]) -> [DatabaseConnection] {
+    connections.sorted {
+        $0.sortOrder != $1.sortOrder
+            ? $0.sortOrder < $1.sortOrder
+            : $0.name.localizedStandardCompare($1.name) == .orderedAscending
+    }
+}
+
+private func buildGroupTreeIndex(groups: [ConnectionGroup], connections: [DatabaseConnection]) -> GroupTreeIndex {
+    let validGroupIds = Set(groups.map(\.id))
+
+    var childrenByParentId: [UUID?: [ConnectionGroup]] = [:]
+    for group in groups {
+        let parentKey = group.parentId.flatMap { validGroupIds.contains($0) ? $0 : nil }
+        childrenByParentId[parentKey, default: []].append(group)
+    }
+    for key in childrenByParentId.keys {
+        if let levelGroups = childrenByParentId[key] {
+            childrenByParentId[key] = sortGroups(levelGroups)
+        }
+    }
+
+    var connectionsByGroupId: [UUID: [DatabaseConnection]] = [:]
+    for connection in connections {
+        guard let groupId = connection.groupId, validGroupIds.contains(groupId) else { continue }
+        connectionsByGroupId[groupId, default: []].append(connection)
+    }
+    for groupId in connectionsByGroupId.keys {
+        if let groupConnections = connectionsByGroupId[groupId] {
+            connectionsByGroupId[groupId] = sortConnections(groupConnections)
+        }
+    }
+
+    return GroupTreeIndex(
+        validGroupIds: validGroupIds,
+        childrenByParentId: childrenByParentId,
+        connectionsByGroupId: connectionsByGroupId
+    )
+}
+
+func buildGroupTreeIndexed(
+    groups: [ConnectionGroup],
+    connections: [DatabaseConnection],
+    maxDepth: Int = 3
+) -> [ConnectionGroupTreeNode] {
+    let index = buildGroupTreeIndex(groups: groups, connections: connections)
+    return buildGroupTreeIndexedLevel(
+        parentId: nil,
+        currentDepth: 0,
+        maxDepth: maxDepth,
+        index: index,
+        connections: connections
+    )
+}
+
+private func buildGroupTreeIndexedLevel(
+    parentId: UUID?,
+    currentDepth: Int,
+    maxDepth: Int,
+    index: GroupTreeIndex,
+    connections: [DatabaseConnection]
+) -> [ConnectionGroupTreeNode] {
+    var items: [ConnectionGroupTreeNode] = []
+    let levelGroups = index.childrenByParentId[parentId] ?? []
+
+    for group in levelGroups {
+        var children: [ConnectionGroupTreeNode] = []
+        if currentDepth < maxDepth {
+            children = buildGroupTreeIndexedLevel(
+                parentId: group.id,
+                currentDepth: currentDepth + 1,
+                maxDepth: maxDepth,
+                index: index,
+                connections: connections
+            )
+        }
+        for conn in index.connectionsByGroupId[group.id] ?? [] {
+            children.append(.connection(conn))
+        }
+        items.append(.group(group, children: children))
+    }
+
+    if parentId == nil {
+        let ungrouped = sortConnections(connections.filter { conn in
+            guard let groupId = conn.groupId else { return true }
+            return !index.validGroupIds.contains(groupId)
+        })
+        for conn in ungrouped {
+            items.append(.connection(conn))
+        }
+    }
+
+    return items
+}
+
+func buildGroupTreeWithIndices(
+    groups: [ConnectionGroup],
+    connections: [DatabaseConnection],
+    maxDepth: Int = 3
+) -> (tree: [ConnectionGroupTreeNode], indices: GroupTreeIndices) {
+    let index = buildGroupTreeIndex(groups: groups, connections: connections)
+    let tree = buildGroupTreeIndexedLevel(
+        parentId: nil,
+        currentDepth: 0,
+        maxDepth: maxDepth,
+        index: index,
+        connections: connections
+    )
+    return (tree, computeGroupTreeIndices(from: index, groups: groups, connections: connections))
+}
+
+func computeGroupTreeIndices(groups: [ConnectionGroup], connections: [DatabaseConnection]) -> GroupTreeIndices {
+    computeGroupTreeIndices(
+        from: buildGroupTreeIndex(groups: groups, connections: connections),
+        groups: groups,
+        connections: connections
+    )
+}
+
+private func computeGroupTreeIndices(
+    from index: GroupTreeIndex,
+    groups: [ConnectionGroup],
+    connections: [DatabaseConnection]
+) -> GroupTreeIndices {
+    var result = GroupTreeIndices()
+
+    var depthByGroup: [UUID: Int] = [:]
+    var visitedDepth: Set<UUID> = []
+    var queue: [(UUID, Int)] = []
+    let roots = index.childrenByParentId[nil] ?? []
+    for root in roots where !visitedDepth.contains(root.id) {
+        visitedDepth.insert(root.id)
+        depthByGroup[root.id] = 1
+        queue.append((root.id, 1))
+    }
+    var queueIndex = 0
+    while queueIndex < queue.count {
+        let (currentId, currentDepth) = queue[queueIndex]
+        queueIndex += 1
+        let children = index.childrenByParentId[currentId] ?? []
+        for child in children where !visitedDepth.contains(child.id) {
+            visitedDepth.insert(child.id)
+            depthByGroup[child.id] = currentDepth + 1
+            queue.append((child.id, currentDepth + 1))
+        }
+    }
+
+    var maxDepthByGroup: [UUID: Int] = [:]
+    var connectionCountByGroup: [UUID: Int] = [:]
+    for root in roots {
+        _ = aggregateSubtree(
+            groupId: root.id,
+            visited: [],
+            index: index,
+            maxDepthByGroup: &maxDepthByGroup,
+            connectionCountByGroup: &connectionCountByGroup
+        )
+    }
+
+    for group in groups {
+        result.depthByGroup[group.id] = depthByGroup[group.id]
+            ?? depthOf(groupId: group.id, groups: groups)
+        result.maxDescendantDepthByGroup[group.id] = maxDepthByGroup[group.id]
+            ?? maxDescendantDepth(groupId: group.id, groups: groups)
+        result.connectionCountByGroup[group.id] = connectionCountByGroup[group.id]
+            ?? connectionCount(in: group.id, connections: connections, groups: groups)
+    }
+
+    return result
+}
+
+private struct SubtreeAggregate {
+    var maxDescendantDepth: Int
+    var connectionCount: Int
+}
+
+private func aggregateSubtree(
+    groupId: UUID,
+    visited: Set<UUID>,
+    index: GroupTreeIndex,
+    maxDepthByGroup: inout [UUID: Int],
+    connectionCountByGroup: inout [UUID: Int]
+) -> SubtreeAggregate {
+    var nextVisited = visited
+    nextVisited.insert(groupId)
+
+    let children = index.childrenByParentId[groupId] ?? []
+    var maxChildDescendantDepth = 0
+    var subtreeCount = index.connectionsByGroupId[groupId]?.count ?? 0
+
+    for child in children where !visited.contains(child.id) {
+        let childAggregate = aggregateSubtree(
+            groupId: child.id,
+            visited: nextVisited,
+            index: index,
+            maxDepthByGroup: &maxDepthByGroup,
+            connectionCountByGroup: &connectionCountByGroup
+        )
+        maxChildDescendantDepth = max(maxChildDescendantDepth, childAggregate.maxDescendantDepth)
+        subtreeCount += childAggregate.connectionCount
+    }
+
+    let maxDescendantDepthValue = children.isEmpty ? 0 : 1 + maxChildDescendantDepth
+    let result = SubtreeAggregate(
+        maxDescendantDepth: maxDescendantDepthValue,
+        connectionCount: subtreeCount
+    )
+    maxDepthByGroup[groupId] = result.maxDescendantDepth
+    connectionCountByGroup[groupId] = result.connectionCount
+    return result
+}
diff --git a/TablePro/ViewModels/WelcomeViewModel.swift b/TablePro/ViewModels/WelcomeViewModel.swift
@@ -108,7 +108,7 @@ final class WelcomeViewModel {
             .filter(\.isFavorite)
             .sorted { $0.name.localizedStandardCompare($1.name) == .orderedAscending }
 
-        let tree = buildGroupTree(groups: groups, connections: connections, parentId: nil)
+        let (tree, indices) = buildGroupTreeWithIndices(groups: groups, connections: connections)
         let baseItems = searchText.isEmpty ? tree : filterGroupTree(tree, searchText: searchText)
         if searchText.isEmpty, !favoriteConnections.isEmpty {
             treeItems = baseItems.filter { node in
@@ -119,17 +119,9 @@ final class WelcomeViewModel {
             treeItems = baseItems
         }
 
-        var counts: [UUID: Int] = [:]
-        var depths: [UUID: Int] = [:]
-        var descendantDepths: [UUID: Int] = [:]
-        for group in groups {
-            counts[group.id] = connectionCount(in: group.id, connections: connections, groups: groups)
-            depths[group.id] = depthOf(groupId: group.id, groups: groups)
-            descendantDepths[group.id] = maxDescendantDepth(groupId: group.id, groups: groups)
-        }
-        connectionCountByGroup = counts
-        depthByGroup = depths
-        maxDescendantDepthByGroup = descendantDepths
+        connectionCountByGroup = indices.connectionCountByGroup
+        depthByGroup = indices.depthByGroup
+        maxDescendantDepthByGroup = indices.maxDescendantDepthByGroup
     }
 
     private func scheduleRebuildTree(oldValue: String) {
diff --git a/TableProTests/Models/ConnectionGroupTreeTests.swift b/TableProTests/Models/ConnectionGroupTreeTests.swift
