refactor(datagrid): remove dead TableRowsController that bypassed row-count cache

Author: datlechin

TablePro/Views/Results/DataGridCoordinator.swift

@@ -109,7 +109,6 @@ final class TableViewCoordinator: NSObject, NSTableViewDelegate, NSTableViewData
     let cellFactory = DataGridCellFactory()
     let cellRegistry: DataGridCellRegistry
     let columnPool = DataGridColumnPool()
-    let tableRowsController = TableRowsController()
     let selectionController = GridSelectionController()
     var overlayEditor: CellOverlayEditor?
     var overlayViewer: CellOverlayViewer?
@@ -234,7 +233,6 @@ final class TableViewCoordinator: NSObject, NSTableViewDelegate, NSTableViewData
             }
             tableView.reloadData()
         }
-        tableRowsController.detach()
         delegate = nil
         activeFKPreviewPopover?.close()
         clearFKPreviewState()

TablePro/Views/Results/DataGridView.swift

@@ -109,7 +109,6 @@ struct DataGridView: NSViewRepresentable {
         context.coordinator.tableView = tableView
         installSelectionOverlay(tableView: tableView, coordinator: context.coordinator)
         context.coordinator.attachScrollObservers(scrollView: scrollView)
-        context.coordinator.tableRowsController.attach(tableView)
         context.coordinator.tableRowsProvider = tableRowsProvider
         context.coordinator.tableRowsMutator = tableRowsMutator
         context.coordinator.paginationOffsetProvider = paginationOffsetProvider
@@ -426,7 +425,6 @@ struct DataGridView: NSViewRepresentable {
         coordinator.persistColumnLayoutToStorage()
         coordinator.settingsCancellable = nil
         coordinator.themeCancellable = nil
-        coordinator.tableRowsController.detach()
     }
 
     func makeCoordinator() -> TableViewCoordinator {

TablePro/Views/Results/Extensions/DataGridView+CellCommit.swift

@@ -26,14 +26,10 @@ extension TableViewCoordinator {
             in: tableView,
             schema: identitySchema
         ) else { return }
-        if case .cellChanged = delta {
-            tableRowsController.apply(.cellChanged(row: row, column: tableColumnIndex))
-        } else {
-            tableView.reloadData(
-                forRowIndexes: IndexSet(integer: row),
-                columnIndexes: IndexSet(integer: tableColumnIndex)
-            )
-        }
+        tableView.reloadData(
+            forRowIndexes: IndexSet(integer: row),
+            columnIndexes: IndexSet(integer: tableColumnIndex)
+        )
     }
 
     @discardableResult

TablePro/Views/Results/TableRowsController.swift

@@ -3,6 +3,7 @@
 //  TableProTests
 //
 
+import AppKit
 import SwiftUI
 import TableProPluginKit
 import Testing
@@ -88,6 +89,34 @@ struct TableViewCoordinatorRowCountCacheTests {
         #expect(coordinator.cachedRowCount == coordinator.tableRowsProvider().count)
     }
 
+    @Test("numberOfRows serves cachedRowCount when unsorted")
+    func numberOfRowsServesCacheWhenUnsorted() {
+        let rows: ContiguousArray<Row> = [
+            Row(id: .existing(0), values: [.text("a")]),
+            Row(id: .existing(1), values: [.text("b")]),
+        ]
+        let coordinator = makeCoordinator(rows: rows)
+        let tableView = NSTableView()
+
+        #expect(coordinator.numberOfRows(in: tableView) == 2)
+        #expect(coordinator.numberOfRows(in: tableView) == coordinator.tableRowsProvider().count)
+    }
+
+    @Test("numberOfRows serves sortedIDs count when sorted")
+    func numberOfRowsServesSortedIDsCountWhenSorted() {
+        let rows: ContiguousArray<Row> = [
+            Row(id: .existing(0), values: [.text("a")]),
+            Row(id: .existing(1), values: [.text("b")]),
+            Row(id: .existing(2), values: [.text("c")]),
+        ]
+        let coordinator = makeCoordinator(rows: rows)
+        let tableView = NSTableView()
+        coordinator.sortedIDs = [.existing(2), .existing(0)]
+        coordinator.updateCache()
+
+        #expect(coordinator.numberOfRows(in: tableView) == 2)
+    }
+
     @Test("sortedIDs count takes precedence over cachedRowCount fallback")
     func sortedIDsCountPrecedesCache() {
         let rows: ContiguousArray<Row> = [