From 419dbd38be181f48103d6a6b4efc017318d1006d Mon Sep 17 00:00:00 2001 From: Ayrat Hudaygulov Date: Tue, 15 Sep 2026 21:32:12 +0100 Subject: [PATCH] docs: stop citing deleted GetVahterStats; note V41 rename / V50 drop of legacy vahter tables DB.fs:866 GetVahterStats was deleted in #362; the project agent kept re-citing it. Also updates the FROZEN legacy-table wording to reflect the V41 rename and the V50 drop (issue #330 step 4). Co-Authored-By: Claude Fable 5.1 --- .github/AGENT-FLOWS-REDESIGN.md | 11 +++++------ .github/bots.yml | 5 ++--- .github/prompts/project.md | 5 ++--- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/.github/AGENT-FLOWS-REDESIGN.md b/.github/AGENT-FLOWS-REDESIGN.md index c3f1a647..8116a8ae 100644 --- a/.github/AGENT-FLOWS-REDESIGN.md +++ b/.github/AGENT-FLOWS-REDESIGN.md @@ -121,9 +121,9 @@ agent — which, per §1.1, does not exist. (group by `SourceContext` + message prefix). - Vahter's legacy tables (`message`, `user`, `banned`, `banned_by_bot`, `callback`, `vahter_actions`, `llm_triage`) froze at **2026-04-02** during the event-sourcing cutover - (Flyway V23). Any agent querying them gets four-month-stale data that looks live. - `DB.fs:866 GetVahterStats` is dead code; `DB.fs:896 GetVahterActionStats` reading `event` - is the live path. + (Flyway V23), were renamed to `deprecated_*` by V41 (2026-08-12, #362), and are being + dropped by V50 (#494). Query `event` / `snapshot_message` / `snapshot_user` only — + `GetVahterActionStats` reading `event` is the live path. - Nothing said in the vahters' private moderator channel (`ADMIN_CHANNEL_ID = -1001170325774`) is persisted. `Bot.fs:1533-1550` — recognized `/vahter` commands are dispatched without `InsertMessage`; free-form discussion falls through the @@ -202,9 +202,8 @@ bots: traffic_class: high # drives baseline windows + alert sensitivity query_set: vahter # -> scripts/queries/vahter/*.sql notes: | - Legacy tables (message, user, banned, banned_by_bot, callback, vahter_actions, - llm_triage) FROZEN at 2026-04-02 (event-sourcing cutover, Flyway V23). - Query `event` / `snapshot_message` / `snapshot_user` only. + Legacy tables renamed to deprecated_* by V41 (2026-08-12, #362); dropped by + V50 (#494). Query `event` / `snapshot_message` / `snapshot_user` only. coupon: display_name: CouponHubBot argocd_app: coupon-bot diff --git a/.github/bots.yml b/.github/bots.yml index cf8aff8a..11c5f5d2 100644 --- a/.github/bots.yml +++ b/.github/bots.yml @@ -38,9 +38,8 @@ bots: query_set: vahter # -> scripts/queries/vahter/*.sql community_hashes: [] notes: | - Legacy tables (message, user, banned, banned_by_bot, callback, vahter_actions, - llm_triage) FROZEN at 2026-04-02 (event-sourcing cutover, Flyway V23). - Query `event` / `snapshot_message` / `snapshot_user` only. + Legacy tables renamed to deprecated_* by V41 (2026-08-12, #362); dropped by + V50 (#494). Query `event` / `snapshot_message` / `snapshot_user` only. coupon: display_name: CouponHubBot diff --git a/.github/prompts/project.md b/.github/prompts/project.md index de60c49b..8e4866b5 100644 --- a/.github/prompts/project.md +++ b/.github/prompts/project.md @@ -108,9 +108,8 @@ perform these checks and say in your summary which you ran and what you saw: bot lists that omit a bot in `.github/bots.yml`. 3. Config drift: `bot_setting` keys referenced in code but absent from docs, or documented but unreferenced; workflow inputs/secrets declared but never consumed. -4. Dead code: functions or files with no remaining callers (a recent event-sourcing cutover in - VahterBanBot left known examples — `DB.fs:866 GetVahterStats` is dead; the live path is - `GetVahterActionStats`). +4. Dead code: functions or files with no remaining callers — confirm with a repo-wide grep for + callers before filing; a symbol that only appears in its own definition is dead. "I found nothing" without naming what you looked at is not a clean day — it is an unverified claim, and it is exactly how this role silently became a no-op before.