"There are still applied mods" warning even when no mods were applied

[isatsam]

Version: 0.0.9
Steps to reproduce:

1. Initialise P2ML (in my case, this was over a fresh Steam install).
2. Add some mods to Mods/ directory
3. Check some mod(s) in the list in P2ML manually or via "Enable all" button. Observe "Current mod list has not been applied yet. Patch to apply the changes" warning (red message)
4. Without applying any changes, uncheck the mods and observe the "There are still applied mods. Restore defaults to recover backups" warning

As far as I understand, there shouldn't be any applied mods unless user clicks "Patch" at least once... If the message is correct, it could probably use a little rephrasing, but I can't tell what is it supposed to mean right now.

[SurDno]

It displays this because currently it just checks that the mod list has changed since last patching, not whether the current mod list as the same as the last patched one. So any changes that are reverted still count as changes.

Easiest way to fix the particular issue you described would probably be to alter the text from “There are still applied mods” to “There may still be applied mods” to make the message more clear.

However, there is a similar issue achieved by enabling and disabling a mod in your mod list, which will cause a message that the current mod list has not been applied to appear.

The ideal solution would be serialising the last patched mod list through json in SettingsSaver and comparing last patched list the current one instead of relying on IsPatched Boolean that is reset after every change. That functionality is in the plans at some point.