Skip to content

x.self_in_case_choices translation is very wrong #286

@BryceStevenWilley

Description

@BryceStevenWilley

Relevant bit of code:

person_word = word(x.maybe_user_partips[0].name.familiar())
else:
person_word = word('one of them')
if logged_in_user_is_admin:
x.self_in_case_choices = [
['is_filing', word(f'I am filing for { person_word }')]
]

Issues:

  • it's translating the name of the user (shouldn't do that)
  • it's translating the words "one of them", and then putting that translation into the full sentence of "No, but I am ...". Will result in wrong translation
  • it's putting the name of the user into the full sentence and calling word: that certainly won't be translatable
  • english word choice is not easily overridable by the implementing interview

Should change it around to make the word choices there template, or something similarly simple, that can be overwritten.

Metadata

Metadata

Labels

bugSomething isn't workingenhancementNew feature or request

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions