From 72dd8e1d63ed66c646ba127e13dd88a18c23f4e5 Mon Sep 17 00:00:00 2001 From: "vivi-the-going-merry[bot]" <308115520+vivi-the-going-merry[bot]@users.noreply.github.com> Date: Tue, 17 Nov 2026 10:26:07 -0700 Subject: [PATCH 1/3] Add failing test: subscriber owner deleting own listing image Co-Authored-By: Claude Sonnet 5.5 --- .../Listing/ListingMediaAuthorizationTest.php | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tests/wpunit/Listing/ListingMediaAuthorizationTest.php b/tests/wpunit/Listing/ListingMediaAuthorizationTest.php index 4414a3fef..1508626f1 100644 --- a/tests/wpunit/Listing/ListingMediaAuthorizationTest.php +++ b/tests/wpunit/Listing/ListingMediaAuthorizationTest.php @@ -106,6 +106,21 @@ public function testReparentedForeignImageCannotBeDeletedAfterUpgrade() { $this->assertSame( $listing_id, (int) wp_get_post_parent_id( $image_id ) ); } + /** + * @since 6.4.30 + */ + public function testSubscriberOwnerCanDeleteOwnListingImage() { + $subscriber_id = $this->get_or_create_user( 'subscriber', 'media-subscriber@example.com' ); + $listing_id = $this->create_listing( $subscriber_id ); + $image_id = $this->create_image_attachment( $subscriber_id, $listing_id ); + + wp_set_current_user( $subscriber_id ); + $response = $this->dispatch_image_delete( $listing_id, $image_id ); + + $this->assertTrue( $response['success'] ); + $this->assertNull( get_post( $image_id ) ); + } + /** * @since 6.4.28 */ From 5990ca7974e7f5e0c927da8b8fdf5f7351ee101b Mon Sep 17 00:00:00 2001 From: "vivi-the-going-merry[bot]" <308115520+vivi-the-going-merry[bot]@users.noreply.github.com> Date: Tue, 17 Nov 2026 10:26:19 -0700 Subject: [PATCH 2/3] Use x.x since tag Co-Authored-By: Claude Sonnet 5.5 --- tests/wpunit/Listing/ListingMediaAuthorizationTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/wpunit/Listing/ListingMediaAuthorizationTest.php b/tests/wpunit/Listing/ListingMediaAuthorizationTest.php index 1508626f1..37e211607 100644 --- a/tests/wpunit/Listing/ListingMediaAuthorizationTest.php +++ b/tests/wpunit/Listing/ListingMediaAuthorizationTest.php @@ -107,7 +107,7 @@ public function testReparentedForeignImageCannotBeDeletedAfterUpgrade() { } /** - * @since 6.4.30 + * @since x.x */ public function testSubscriberOwnerCanDeleteOwnListingImage() { $subscriber_id = $this->get_or_create_user( 'subscriber', 'media-subscriber@example.com' ); From ba89690374a5d69fbab32737d6475038f41ea3ad Mon Sep 17 00:00:00 2001 From: "vivi-the-going-merry[bot]" <308115520+vivi-the-going-merry[bot]@users.noreply.github.com> Date: Tue, 17 Nov 2026 10:29:37 -0700 Subject: [PATCH 3/3] Let listing owners delete images they uploaded Co-Authored-By: Claude Sonnet 5.5 --- includes/class-wpbdp.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/includes/class-wpbdp.php b/includes/class-wpbdp.php index 2ec26965d..306f237a2 100644 --- a/includes/class-wpbdp.php +++ b/includes/class-wpbdp.php @@ -696,8 +696,9 @@ private function can_edit_listing_images( $listing_id ) { /** * Whether the current request may permanently remove a listing image. * - * Authenticated users need attachment-level delete rights. Guests already - * proved listing access via submit token or access key. + * Authenticated users need attachment-level delete rights or must have + * uploaded the image themselves (Subscribers lack `delete_posts`). + * Guests already proved listing access via submit token or access key. * * @since 6.4.28 * @@ -715,7 +716,7 @@ private function can_delete_listing_image( $image_id, $listing_id ) { return true; } - return current_user_can( 'delete_post', $image_id ); + return current_user_can( 'delete_post', $image_id ) || (int) get_post_field( 'post_author', $image_id ) === get_current_user_id(); } public function ajax_listing_media_image() {