-
Notifications
You must be signed in to change notification settings - Fork 6
Add an ESLint config and run lint in CI #25
Copy link
Copy link
Open
Labels
GRANTFOX OSSGrantFox open-source campaign taskGrantFox open-source campaign taskMAYBE REWARDEDMay be rewarded under the GrantFox campaignMay be rewarded under the GrantFox campaignOFFICIAL CAMPAIGNOfficial GrantFox campaign issueOfficial GrantFox campaign issuearea:toolingtoolingtoolingpriority:mediumMedium priorityMedium prioritystack:expressstack:expressstack:expressstack:nodejsNode.jsNode.jsstack:typescriptTypeScriptTypeScripttype:enhancementImprovement to existing functionalityImprovement to existing functionality
Metadata
Metadata
Assignees
Labels
GRANTFOX OSSGrantFox open-source campaign taskGrantFox open-source campaign taskMAYBE REWARDEDMay be rewarded under the GrantFox campaignMay be rewarded under the GrantFox campaignOFFICIAL CAMPAIGNOfficial GrantFox campaign issueOfficial GrantFox campaign issuearea:toolingtoolingtoolingpriority:mediumMedium priorityMedium prioritystack:expressstack:expressstack:expressstack:nodejsNode.jsNode.jsstack:typescriptTypeScriptTypeScripttype:enhancementImprovement to existing functionalityImprovement to existing functionality
Type
Fields
Give feedbackNo fields configured for Feature.
Implement an ESLint config and enforce it in CI
Description
package.jsondefines"lint": "eslint src --ext .ts"and depends oneslint@^9, but there is no ESLint config file in the repo, sonpm run lintcannot run with a working ruleset, and.github/workflows/ci.ymlnever invokes lint. This issue adds a flat-config ESLint setup with TypeScript support and gates CI on it.Requirements and context
StableRoute-Org/Stableroute-backendonly.eslint.config.js(create file) using ESLint 9 flat config withtypescript-eslint, targetingsrc/**/*.ts.@typescript-eslint/parserandtypescript-eslint(or@typescript-eslint/eslint-plugin) to devDependencies.no-floating-promisesonce type-aware linting is configured) and fix or// eslint-disablejustified violations.Lintstep to.github/workflows/ci.ymlrunningnpm run lint.Suggested execution
git checkout -b enhancement/tooling-25-eslint-configeslint.config.js; updatepackage.jsonand.github/workflows/ci.yml.npm teststill passes.README.md.anyand floating promises.Test and commit
npm run lint,npm run build, andnpm test— all must pass clean.src/.npm run lintoutput in the PR.Example commit message
chore(tooling): add ESLint flat config and enforce lint in CIGuidelines
Community & contribution rewards