Zombie Piglins can have items enchanted when transferring to/from the Resource World

[DaMarine]

Which servers are you seeing the bug on?

Survival, Resource

Describe the bug

Zombie Piglins appear to have items they're holding become randomly enchanted when transferring the Piglins to/from the Resource World.

Steps to reproduce

Step 1. In The Nether of the Resource World, give a normal Baby Piglin an item to hold
Step 2. Transport it to the Overworld and have it zombify
Step 3. Transport it to the Main World and the item its holding might get enchanted

Additional info

Full scope of this bug may not be fully realised as of yet, requires further investigation and testing.

Provided evidence of bug:

Checklist

• I have checked the Slabserver-Bugs repo to make sure this is not reported, or marked as "Won't Fix".

[DaMarine]

Just realised why this is happening...

server.spawnEntity() spawns a new entity in a way that allows for randomly generated default equipment, as per standard vanilla behaviour. The Zombified Piglin is almost certainly spawning with an enchanted golden sword, but mergeCompound(cont) is merging the transferred mob's inventory on top of it - replacing the item, but keeping the enchant.

Should be a simple fix... PR incoming