From ca906e5dd6378edd19f9409a6d57b563b370de85 Mon Sep 17 00:00:00 2001 From: MortenFriisSiteImprove Date: Wed, 16 Sep 2026 07:57:04 +0200 Subject: [PATCH] Correct the live image alternative issue label --- docs/live-testing.md | 2 +- tests/browser/result-navigation.spec.js | 4 ++-- tests/live/accessibility-rule.mjs | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/live-testing.md b/docs/live-testing.md index e5c4910..d5548fa 100644 --- a/docs/live-testing.md +++ b/docs/live-testing.md @@ -2,7 +2,7 @@ The manual **Live Siteimprove smoke test** workflow builds and tests a candidate, installs those exact bytes into a fresh disposable CMS, then opens the real overlay. Live tests run only on the newer CMS profile. It does not replace the overlay, manufacture report data or invoke its command queue from the test. -The first smoke test checks existing API entitlement, authenticates through the direct-login popup, opens the panel and requires an authenticated successful report response for the exact mapped public URL. The selectors and response contract follow the AEM/WordPress test approach; they still need confirmation with the first live account run. A second live scenario scans a persisted synthetic draft with a missing image alternative, saves a correction as a new draft revision, and scans again. Both checks must carry their distinct run markers, enter the running state, and return to the recheck control with the active-check indicator cleared. Live run 35017790911 passed the report and draft-handoff smoke checks. The suite now also requires the documented WCAG 1.1.1 Level A check, SIA-R2 (Image without a text alternative), before the fix and its absence in the visible accessibility results after the fix. These new result assertions still require live validation; they fail instead of skipping when the result cannot be found. +The first smoke test checks existing API entitlement, authenticates through the direct-login popup, opens the panel and requires an authenticated successful report response for the exact mapped public URL. The selectors and response contract follow the AEM/WordPress test approach; they still need confirmation with the first live account run. A second live scenario scans a persisted synthetic draft with a missing image alternative, saves a correction as a new draft revision, and scans again. Both checks must carry their distinct run markers, enter the running state, and return to the recheck control with the active-check indicator cleared. Live run 35017790911 passed the report and draft-handoff smoke checks. The suite now also requires the WCAG 1.1.1 Level A check, SIA-R2 (Image missing a text alternative), before the fix and its absence in the visible accessibility results after the fix. These new result assertions still require live validation; they fail instead of skipping when the result cannot be found. ## Configure before enabling diff --git a/tests/browser/result-navigation.spec.js b/tests/browser/result-navigation.spec.js index 0d63feb..f4d460e 100644 --- a/tests/browser/result-navigation.spec.js +++ b/tests/browser/result-navigation.spec.js @@ -2,11 +2,11 @@ const { test, expect } = require('@playwright/test'); async function fixture(page, expanded, issue) { await page.setContent(` -
${issue ? '

Image without a text alternative

' : '

No accessibility issues

'}
+
${issue ? '

Image missing a text alternative

' : '

No accessibility issues

'}
`); } -test('opens collapsed accessibility results to expose the documented issue', async ({ page }) => { +test('opens collapsed accessibility results to expose the image alternative issue', async ({ page }) => { const { openAccessibilityResults, resultViewState } = await import('../live/result-view.mjs'); await fixture(page, false, true); await openAccessibilityResults(page); diff --git a/tests/live/accessibility-rule.mjs b/tests/live/accessibility-rule.mjs index 5ff7e55..b9a2524 100644 --- a/tests/live/accessibility-rule.mjs +++ b/tests/live/accessibility-rule.mjs @@ -1,4 +1,4 @@ -// Official check name and mapping: +// Rule mapping (the UI label was confirmed separately): // https://help.siteimprove.com/support/solutions/articles/80000448514 // https://help.siteimprove.com/support/solutions/articles/80000448497 export const imageAlternativeRule = Object.freeze({ @@ -6,5 +6,5 @@ export const imageAlternativeRule = Object.freeze({ apiId: 2, criterion: '1.1.1', level: 'A', - label: 'Image without a text alternative', + label: 'Image missing a text alternative', });