SelectRecipientDataCommand SelectRecipientDataResult#columns is empty

[rkovarik]

Caused by a69e261.
When using com.thoughtworks.xstream.annotations.XStreamImplicit on com.silverpop.api.client.result.SelectRecipientDataResult#columns the result contains list of columns with one column and its name and value are null.

[larrychu-acoustic]

The root of the problem with this code is that ApiClient and ApiSession are entangled such that responsibilities are blurred. ApiClient.executeCommand() will validate the session and re-authenticate if necessary. I'd like to change this.

ApiSession.close() should not call the #executeCommand method. I'd like to see a class extracted from ApiClient perhaps named CommandSender which will contain most of the logic from ApiClient. ApiClient should be left only the responsibility of validating and re-authenticating the session. CommandSender should then have a method, sendCommand as follows.

    ApiResult sendCommand(ApiCommand command, String url, Map requestHeaders) 
                                                    throws ApiResultException

This would also require that ApiClientFactory be changed to be a factory of CommandSenders rather than ApiClients.

A CommandSenderFactory would need to be introduced to replace the XmlApiClientFactory in the XmlApiSession constructors.

Are you interested in taking this on?